From: Arnd Bergmann <arnd@arndb.de>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: Gabriele Paoloni <gabriele.paoloni@huawei.com>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Rob Herring <robh@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Jingoo Han <jingoohan1@gmail.com>,
Pratyush Anand <pratyush.anand@gmail.com>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>
Subject: Re: [PATCH v3 1/6] PCI: designware: remove wrong io_base assignment
Date: Mon, 23 Nov 2015 17:40:56 +0100 [thread overview]
Message-ID: <6899049.45pKpnsxmL@wuerfel> (raw)
In-Reply-To: <56533D93.5000604@linaro.org>
On Monday 23 November 2015 18:23:47 Stanimir Varbanov wrote:
> >>
> >> Fixes: 0021d22b73d6 ("PCI: designware: Use of_pci_get_host_bridge_resources()
> >> to parse DT")
> >> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
>
> I think the bug is introduced in:
>
> cbce7900598c ("PCI: designware: Make driver arch-agnostic")
>
> cause the io_base is correctly calculated in 0021d22b73d6, do you agree?
I think cbce7900598c just slightly changes the io_base value, but
it's still referring to a bus address, not a cpu address, both before
and after the patch.
0021d22b73d6 hower seems to remove the correct 'pp->io_base = range.cpu_addr;'
and replaces it with 'pp->io_base = pp->io->start;', so it's now in
the wrong address space.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/6] PCI: designware: remove wrong io_base assignment
Date: Mon, 23 Nov 2015 17:40:56 +0100 [thread overview]
Message-ID: <6899049.45pKpnsxmL@wuerfel> (raw)
In-Reply-To: <56533D93.5000604@linaro.org>
On Monday 23 November 2015 18:23:47 Stanimir Varbanov wrote:
> >>
> >> Fixes: 0021d22b73d6 ("PCI: designware: Use of_pci_get_host_bridge_resources()
> >> to parse DT")
> >> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
>
> I think the bug is introduced in:
>
> cbce7900598c ("PCI: designware: Make driver arch-agnostic")
>
> cause the io_base is correctly calculated in 0021d22b73d6, do you agree?
I think cbce7900598c just slightly changes the io_base value, but
it's still referring to a bus address, not a cpu address, both before
and after the patch.
0021d22b73d6 hower seems to remove the correct 'pp->io_base = range.cpu_addr;'
and replaces it with 'pp->io_base = pp->io->start;', so it's now in
the wrong address space.
Arnd
next prev parent reply other threads:[~2015-11-23 16:41 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 9:28 [PATCH v3 0/6] Qualcomm PCIe driver and designware fixes Stanimir Varbanov
2015-11-23 9:28 ` Stanimir Varbanov
2015-11-23 9:28 ` Stanimir Varbanov
2015-11-23 9:28 ` [PATCH v3 1/6] PCI: designware: remove wrong io_base assignment Stanimir Varbanov
2015-11-23 9:28 ` Stanimir Varbanov
[not found] ` <44d133d5ebd4f7b9e8b817aa8bae12f690e70000.1448270813.git.stanimir.varbanov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-11-23 9:59 ` Arnd Bergmann
2015-11-23 9:59 ` Arnd Bergmann
2015-11-23 9:59 ` Arnd Bergmann
2015-11-23 10:27 ` Gabriele Paoloni
2015-11-23 10:27 ` Gabriele Paoloni
2015-11-23 16:23 ` Stanimir Varbanov
2015-11-23 16:23 ` Stanimir Varbanov
2015-11-23 16:40 ` Arnd Bergmann [this message]
2015-11-23 16:40 ` Arnd Bergmann
2015-11-24 9:25 ` Stanimir Varbanov
2015-11-24 9:25 ` Stanimir Varbanov
2015-11-23 9:28 ` [PATCH v3 2/6] PCI: designware: add memory barrier after enabling region Stanimir Varbanov
2015-11-23 9:28 ` Stanimir Varbanov
2015-11-23 11:27 ` Russell King - ARM Linux
2015-11-23 11:27 ` Russell King - ARM Linux
2015-11-23 16:05 ` Stanimir Varbanov
2015-11-23 16:05 ` Stanimir Varbanov
2015-11-23 9:29 ` [PATCH v3 3/6] DT: PCI: qcom: Document PCIe devicetree bindings Stanimir Varbanov
2015-11-23 9:29 ` Stanimir Varbanov
2015-11-23 9:29 ` Stanimir Varbanov
2015-11-23 18:13 ` Bjorn Andersson
2015-11-23 18:13 ` Bjorn Andersson
2015-11-24 9:17 ` Stanimir Varbanov
2015-11-24 9:17 ` Stanimir Varbanov
2015-11-23 23:17 ` Rob Herring
2015-11-23 23:17 ` Rob Herring
2015-11-24 9:22 ` Stanimir Varbanov
2015-11-24 9:22 ` Stanimir Varbanov
2015-11-24 9:22 ` Stanimir Varbanov
2015-11-23 9:29 ` [PATCH v3 4/6] PCI: qcom: Add Qualcomm PCIe controller driver Stanimir Varbanov
2015-11-23 9:29 ` Stanimir Varbanov
2015-11-23 9:29 ` Stanimir Varbanov
2015-11-23 11:02 ` kbuild test robot
2015-11-23 11:02 ` kbuild test robot
2015-11-23 11:02 ` kbuild test robot
2015-11-23 9:29 ` [PATCH v3 5/6] ARM: dts: apq8064: add pcie devicetree node Stanimir Varbanov
2015-11-23 9:29 ` Stanimir Varbanov
2015-11-23 9:29 ` Stanimir Varbanov
2015-11-23 9:29 ` [PATCH v3 6/6] ARM: dts: ifc6410: enable pcie dt node for this board Stanimir Varbanov
2015-11-23 9:29 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6899049.45pKpnsxmL@wuerfel \
--to=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=gabriele.paoloni@huawei.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jingoohan1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=pratyush.anand@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.