From: Christian Marangi <ansuelsmth@gmail.com>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 1/2] test: led: Add missing ';'
Date: Mon, 29 Sep 2025 12:14:09 +0200 [thread overview]
Message-ID: <68da5bf4.c80a0220.2f77f4.4c19@mx.google.com> (raw)
In-Reply-To: <20250925205026.3561694-1-trini@konsulko.com>
On Thu, Sep 25, 2025 at 02:50:25PM -0600, Tom Rini wrote:
> Some tests here had not been compile tested before submission and were
> missing a ';' on the end of declaring struct udevice *dev. Add it.
>
> Fixes: 9046279d92bb ("test: dm: Add tests for LED boot and activity")
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> Cc: Christian Marangi <ansuelsmth@gmail.com>
> ---
Sorry Tom for not catching this, I hoped the CI enabled these config.
Does the CI for these test use the SANDBOX defconfig?
Just to prevent similar error in the future.
> test/dm/led.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/test/dm/led.c b/test/dm/led.c
> index 36652c2833a9..f41a2fb73fc0 100644
> --- a/test/dm/led.c
> +++ b/test/dm/led.c
> @@ -162,7 +162,7 @@ DM_TEST(dm_test_led_blink, UTF_SCAN_PDATA | UTF_SCAN_FDT);
> #ifdef CONFIG_LED_BOOT
> static int dm_test_led_boot(struct unit_test_state *uts)
> {
> - struct udevice *dev
> + struct udevice *dev;
>
> /* options/u-boot/boot-led is set to phandle to "sandbox:green" */
> ut_assertok(led_get_by_label("sandbox:green", &dev));
> @@ -180,7 +180,7 @@ DM_TEST(dm_test_led_boot, UTF_SCAN_PDATA | UTF_SCAN_FDT);
> #ifndef CONFIG_LED_BLINK
> static int dm_test_led_boot_blink(struct unit_test_state *uts)
> {
> - struct udevice *dev
> + struct udevice *dev;
>
> /* options/u-boot/boot-led is set to phandle to "sandbox:green" */
> ut_assertok(led_get_by_label("sandbox:green", &dev));
> @@ -200,7 +200,7 @@ DM_TEST(dm_test_led_boot_blink, UTF_SCAN_PDATA | UTF_SCAN_FDT);
> #ifdef CONFIG_LED_ACTIVITY
> static int dm_test_led_activity(struct unit_test_state *uts)
> {
> - struct udevice *dev
> + struct udevice *dev;
>
> /* options/u-boot/activity-led is set to phandle to "sandbox:red" */
> ut_assertok(led_get_by_label("sandbox:red", &dev));
> @@ -218,7 +218,7 @@ DM_TEST(dm_test_led_activity, UTF_SCAN_PDATA | UTF_SCAN_FDT);
> #ifndef CONFIG_LED_BLINK
> static int dm_test_led_activityt_blink(struct unit_test_state *uts)
> {
> - struct udevice *dev
> + struct udevice *dev;
>
> /* options/u-boot/activity-led is set to phandle to "sandbox:red" */
> ut_assertok(led_get_by_label("sandbox:red", &dev));
> --
> 2.43.0
>
--
Ansuel
next prev parent reply other threads:[~2025-09-29 10:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 20:50 [PATCH 1/2] test: led: Add missing ';' Tom Rini
2025-09-25 20:50 ` [PATCH 2/2] test: syslog: Add missing include of <env.h> Tom Rini
2025-09-29 10:14 ` Christian Marangi [this message]
2025-09-29 14:03 ` [PATCH 1/2] test: led: Add missing ';' Tom Rini
2025-09-30 20:22 ` Christian Marangi
2025-10-09 14:18 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68da5bf4.c80a0220.2f77f4.4c19@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.