All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Marangi <ansuelsmth@gmail.com>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 1/2] test: led: Add missing ';'
Date: Tue, 30 Sep 2025 22:22:20 +0200	[thread overview]
Message-ID: <68dc3c07.050a0220.90794.3860@mx.google.com> (raw)
In-Reply-To: <20250929140341.GB6093@bill-the-cat>

On Mon, Sep 29, 2025 at 08:03:41AM -0600, Tom Rini wrote:
> On Mon, Sep 29, 2025 at 12:14:09PM +0200, Christian Marangi wrote:
> > On Thu, Sep 25, 2025 at 02:50:25PM -0600, Tom Rini wrote:
> > > Some tests here had not been compile tested before submission and were
> > > missing a ';' on the end of declaring struct udevice *dev. Add it.
> > > 
> > > Fixes: 9046279d92bb ("test: dm: Add tests for LED boot and activity")
> > > Signed-off-by: Tom Rini <trini@konsulko.com>
> > > ---
> > > Cc: Christian Marangi <ansuelsmth@gmail.com>
> > > ---
> > 
> > Sorry Tom for not catching this, I hoped the CI enabled these config.
> > 
> > Does the CI for these test use the SANDBOX defconfig?
> > 
> > Just to prevent similar error in the future.
> 
> The issue is that the new options weren't enabled on sandbox as well.
> 

Yes sorry if I wasn't clear. I was honestly confused on where the config
were taken for CI and I assumed they were all enabled by default.

Thanks for confirming that the config for CI needs to be enabled in the
sandbox defconfig.

And again sorry for this embarassing error!

-- 
	Ansuel

  reply	other threads:[~2025-09-30 20:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-25 20:50 [PATCH 1/2] test: led: Add missing ';' Tom Rini
2025-09-25 20:50 ` [PATCH 2/2] test: syslog: Add missing include of <env.h> Tom Rini
2025-09-29 10:14 ` [PATCH 1/2] test: led: Add missing ';' Christian Marangi
2025-09-29 14:03   ` Tom Rini
2025-09-30 20:22     ` Christian Marangi [this message]
2025-10-09 14:18 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68dc3c07.050a0220.90794.3860@mx.google.com \
    --to=ansuelsmth@gmail.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.