* [PATCH 1/2] test: led: Add missing ';'
@ 2025-09-25 20:50 Tom Rini
2025-09-25 20:50 ` [PATCH 2/2] test: syslog: Add missing include of <env.h> Tom Rini
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Tom Rini @ 2025-09-25 20:50 UTC (permalink / raw)
To: u-boot; +Cc: Christian Marangi
Some tests here had not been compile tested before submission and were
missing a ';' on the end of declaring struct udevice *dev. Add it.
Fixes: 9046279d92bb ("test: dm: Add tests for LED boot and activity")
Signed-off-by: Tom Rini <trini@konsulko.com>
---
Cc: Christian Marangi <ansuelsmth@gmail.com>
---
test/dm/led.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/test/dm/led.c b/test/dm/led.c
index 36652c2833a9..f41a2fb73fc0 100644
--- a/test/dm/led.c
+++ b/test/dm/led.c
@@ -162,7 +162,7 @@ DM_TEST(dm_test_led_blink, UTF_SCAN_PDATA | UTF_SCAN_FDT);
#ifdef CONFIG_LED_BOOT
static int dm_test_led_boot(struct unit_test_state *uts)
{
- struct udevice *dev
+ struct udevice *dev;
/* options/u-boot/boot-led is set to phandle to "sandbox:green" */
ut_assertok(led_get_by_label("sandbox:green", &dev));
@@ -180,7 +180,7 @@ DM_TEST(dm_test_led_boot, UTF_SCAN_PDATA | UTF_SCAN_FDT);
#ifndef CONFIG_LED_BLINK
static int dm_test_led_boot_blink(struct unit_test_state *uts)
{
- struct udevice *dev
+ struct udevice *dev;
/* options/u-boot/boot-led is set to phandle to "sandbox:green" */
ut_assertok(led_get_by_label("sandbox:green", &dev));
@@ -200,7 +200,7 @@ DM_TEST(dm_test_led_boot_blink, UTF_SCAN_PDATA | UTF_SCAN_FDT);
#ifdef CONFIG_LED_ACTIVITY
static int dm_test_led_activity(struct unit_test_state *uts)
{
- struct udevice *dev
+ struct udevice *dev;
/* options/u-boot/activity-led is set to phandle to "sandbox:red" */
ut_assertok(led_get_by_label("sandbox:red", &dev));
@@ -218,7 +218,7 @@ DM_TEST(dm_test_led_activity, UTF_SCAN_PDATA | UTF_SCAN_FDT);
#ifndef CONFIG_LED_BLINK
static int dm_test_led_activityt_blink(struct unit_test_state *uts)
{
- struct udevice *dev
+ struct udevice *dev;
/* options/u-boot/activity-led is set to phandle to "sandbox:red" */
ut_assertok(led_get_by_label("sandbox:red", &dev));
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] test: syslog: Add missing include of <env.h>
2025-09-25 20:50 [PATCH 1/2] test: led: Add missing ';' Tom Rini
@ 2025-09-25 20:50 ` Tom Rini
2025-09-29 10:14 ` [PATCH 1/2] test: led: Add missing ';' Christian Marangi
2025-10-09 14:18 ` Tom Rini
2 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2025-09-25 20:50 UTC (permalink / raw)
To: u-boot
These files was making environment calls without including <env.h> and so
relying on an indirect inclusion from elsewhere. Add the missing include
directly.
Signed-off-by: Tom Rini <trini@konsulko.com>
---
test/log/syslog_test.c | 1 +
test/log/syslog_test_ndebug.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/test/log/syslog_test.c b/test/log/syslog_test.c
index 98b914365804..b6c0631aaf67 100644
--- a/test/log/syslog_test.c
+++ b/test/log/syslog_test.c
@@ -10,6 +10,7 @@
/* Override CONFIG_LOG_MAX_LEVEL */
#define LOG_DEBUG
+#include <env.h>
#include <asm/global_data.h>
#include <dm/device.h>
#include <hexdump.h>
diff --git a/test/log/syslog_test_ndebug.c b/test/log/syslog_test_ndebug.c
index dfd0217c1e4f..a02d207ac0b9 100644
--- a/test/log/syslog_test_ndebug.c
+++ b/test/log/syslog_test_ndebug.c
@@ -7,6 +7,7 @@
* Invoke the test with: ./u-boot -d arch/sandbox/dts/test.dtb
*/
+#include <env.h>
#include <asm/global_data.h>
#include <dm/device.h>
#include <hexdump.h>
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] test: led: Add missing ';'
2025-09-25 20:50 [PATCH 1/2] test: led: Add missing ';' Tom Rini
2025-09-25 20:50 ` [PATCH 2/2] test: syslog: Add missing include of <env.h> Tom Rini
@ 2025-09-29 10:14 ` Christian Marangi
2025-09-29 14:03 ` Tom Rini
2025-10-09 14:18 ` Tom Rini
2 siblings, 1 reply; 6+ messages in thread
From: Christian Marangi @ 2025-09-29 10:14 UTC (permalink / raw)
To: Tom Rini; +Cc: u-boot
On Thu, Sep 25, 2025 at 02:50:25PM -0600, Tom Rini wrote:
> Some tests here had not been compile tested before submission and were
> missing a ';' on the end of declaring struct udevice *dev. Add it.
>
> Fixes: 9046279d92bb ("test: dm: Add tests for LED boot and activity")
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> Cc: Christian Marangi <ansuelsmth@gmail.com>
> ---
Sorry Tom for not catching this, I hoped the CI enabled these config.
Does the CI for these test use the SANDBOX defconfig?
Just to prevent similar error in the future.
> test/dm/led.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/test/dm/led.c b/test/dm/led.c
> index 36652c2833a9..f41a2fb73fc0 100644
> --- a/test/dm/led.c
> +++ b/test/dm/led.c
> @@ -162,7 +162,7 @@ DM_TEST(dm_test_led_blink, UTF_SCAN_PDATA | UTF_SCAN_FDT);
> #ifdef CONFIG_LED_BOOT
> static int dm_test_led_boot(struct unit_test_state *uts)
> {
> - struct udevice *dev
> + struct udevice *dev;
>
> /* options/u-boot/boot-led is set to phandle to "sandbox:green" */
> ut_assertok(led_get_by_label("sandbox:green", &dev));
> @@ -180,7 +180,7 @@ DM_TEST(dm_test_led_boot, UTF_SCAN_PDATA | UTF_SCAN_FDT);
> #ifndef CONFIG_LED_BLINK
> static int dm_test_led_boot_blink(struct unit_test_state *uts)
> {
> - struct udevice *dev
> + struct udevice *dev;
>
> /* options/u-boot/boot-led is set to phandle to "sandbox:green" */
> ut_assertok(led_get_by_label("sandbox:green", &dev));
> @@ -200,7 +200,7 @@ DM_TEST(dm_test_led_boot_blink, UTF_SCAN_PDATA | UTF_SCAN_FDT);
> #ifdef CONFIG_LED_ACTIVITY
> static int dm_test_led_activity(struct unit_test_state *uts)
> {
> - struct udevice *dev
> + struct udevice *dev;
>
> /* options/u-boot/activity-led is set to phandle to "sandbox:red" */
> ut_assertok(led_get_by_label("sandbox:red", &dev));
> @@ -218,7 +218,7 @@ DM_TEST(dm_test_led_activity, UTF_SCAN_PDATA | UTF_SCAN_FDT);
> #ifndef CONFIG_LED_BLINK
> static int dm_test_led_activityt_blink(struct unit_test_state *uts)
> {
> - struct udevice *dev
> + struct udevice *dev;
>
> /* options/u-boot/activity-led is set to phandle to "sandbox:red" */
> ut_assertok(led_get_by_label("sandbox:red", &dev));
> --
> 2.43.0
>
--
Ansuel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] test: led: Add missing ';'
2025-09-29 10:14 ` [PATCH 1/2] test: led: Add missing ';' Christian Marangi
@ 2025-09-29 14:03 ` Tom Rini
2025-09-30 20:22 ` Christian Marangi
0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2025-09-29 14:03 UTC (permalink / raw)
To: Christian Marangi; +Cc: u-boot
[-- Attachment #1: Type: text/plain, Size: 751 bytes --]
On Mon, Sep 29, 2025 at 12:14:09PM +0200, Christian Marangi wrote:
> On Thu, Sep 25, 2025 at 02:50:25PM -0600, Tom Rini wrote:
> > Some tests here had not been compile tested before submission and were
> > missing a ';' on the end of declaring struct udevice *dev. Add it.
> >
> > Fixes: 9046279d92bb ("test: dm: Add tests for LED boot and activity")
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> > ---
> > Cc: Christian Marangi <ansuelsmth@gmail.com>
> > ---
>
> Sorry Tom for not catching this, I hoped the CI enabled these config.
>
> Does the CI for these test use the SANDBOX defconfig?
>
> Just to prevent similar error in the future.
The issue is that the new options weren't enabled on sandbox as well.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] test: led: Add missing ';'
2025-09-29 14:03 ` Tom Rini
@ 2025-09-30 20:22 ` Christian Marangi
0 siblings, 0 replies; 6+ messages in thread
From: Christian Marangi @ 2025-09-30 20:22 UTC (permalink / raw)
To: Tom Rini; +Cc: u-boot
On Mon, Sep 29, 2025 at 08:03:41AM -0600, Tom Rini wrote:
> On Mon, Sep 29, 2025 at 12:14:09PM +0200, Christian Marangi wrote:
> > On Thu, Sep 25, 2025 at 02:50:25PM -0600, Tom Rini wrote:
> > > Some tests here had not been compile tested before submission and were
> > > missing a ';' on the end of declaring struct udevice *dev. Add it.
> > >
> > > Fixes: 9046279d92bb ("test: dm: Add tests for LED boot and activity")
> > > Signed-off-by: Tom Rini <trini@konsulko.com>
> > > ---
> > > Cc: Christian Marangi <ansuelsmth@gmail.com>
> > > ---
> >
> > Sorry Tom for not catching this, I hoped the CI enabled these config.
> >
> > Does the CI for these test use the SANDBOX defconfig?
> >
> > Just to prevent similar error in the future.
>
> The issue is that the new options weren't enabled on sandbox as well.
>
Yes sorry if I wasn't clear. I was honestly confused on where the config
were taken for CI and I assumed they were all enabled by default.
Thanks for confirming that the config for CI needs to be enabled in the
sandbox defconfig.
And again sorry for this embarassing error!
--
Ansuel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] test: led: Add missing ';'
2025-09-25 20:50 [PATCH 1/2] test: led: Add missing ';' Tom Rini
2025-09-25 20:50 ` [PATCH 2/2] test: syslog: Add missing include of <env.h> Tom Rini
2025-09-29 10:14 ` [PATCH 1/2] test: led: Add missing ';' Christian Marangi
@ 2025-10-09 14:18 ` Tom Rini
2 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2025-10-09 14:18 UTC (permalink / raw)
To: u-boot, Tom Rini; +Cc: Christian Marangi
On Thu, 25 Sep 2025 14:50:25 -0600, Tom Rini wrote:
> Some tests here had not been compile tested before submission and were
> missing a ';' on the end of declaring struct udevice *dev. Add it.
>
>
Applied to u-boot/master, thanks!
[1/2] test: led: Add missing ';'
commit: 9b937cdaa3a701d106de73ef846d2edd5c818593
[2/2] test: syslog: Add missing include of <env.h>
commit: f293019b6b9ca369190c620e0232227d950d2187
--
Tom
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-10-09 14:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-25 20:50 [PATCH 1/2] test: led: Add missing ';' Tom Rini
2025-09-25 20:50 ` [PATCH 2/2] test: syslog: Add missing include of <env.h> Tom Rini
2025-09-29 10:14 ` [PATCH 1/2] test: led: Add missing ';' Christian Marangi
2025-09-29 14:03 ` Tom Rini
2025-09-30 20:22 ` Christian Marangi
2025-10-09 14:18 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.