All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Kever Yang <kever.yang@rock-chips.com>, FUKAUMI Naoki <naoki@radxa.com>
Cc: robh@kernel.org, conor+dt@kernel.org, liujianfeng1994@gmail.com,
	jonas@kwiboo.se, cfsworks@gmail.com, dmt.yashin@gmail.com,
	jbx6244@gmail.com, sebastian.reichel@collabora.com,
	tim@feathertop.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	marcin.juszkiewicz@linaro.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	michael.riesch@wolfvision.net, macromorgan@hotmail.com,
	krzk+dt@kernel.org, jing@jing.rocks, dsimic@manjaro.org
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Radxa E52C
Date: Sun, 05 Jan 2025 14:29:06 +0100	[thread overview]
Message-ID: <6900956.G0QQBjFxQf@phil> (raw)
In-Reply-To: <E280EE989942CA2A+4252fa87-049d-4b73-ac28-537f29c09660@radxa.com>

Hey,

Am Freitag, 3. Januar 2025, 07:45:58 CET schrieb FUKAUMI Naoki:
> Hi Kever,
> 
> What do you think about the introduction of the "rockchip,rk3582" 
> compatibility string?

I'm not Kever, but I do like the way you did this :-) .

I.e. the rk3582 _is_ a rk3588 with those cores disabled.

So going the way you did allows us to not introduce too much
overhead while still already having the rk3582 naming in there
if it becomes necessary later on.


Heiko


> --
> FUKAUMI Naoki
> Radxa Computer (Shenzhen) Co., Ltd.
> 
> On 12/26/24 11:46, FUKAUMI Naoki wrote:
> > Add devicetree binding for the Radxa E52C.
> > 
> > Radxa E52C is a compact network computer based on the Rockchip RK3582
> > SoC.
> > 
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> > ---
> > Changes in v3:
> > - Collect A-b tag
> > Changes in v2:
> > - Add "rockchip,rk3588s"
> > ---
> >   Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
> >   1 file changed, 6 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > index 753199a12923..2152d170524a 100644
> > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > @@ -812,6 +812,12 @@ properties:
> >             - const: radxa,e20c
> >             - const: rockchip,rk3528
> >   
> > +      - description: Radxa E52C
> > +        items:
> > +          - const: radxa,e52c
> > +          - const: rockchip,rk3582
> > +          - const: rockchip,rk3588s
> > +
> >         - description: Radxa Rock
> >           items:
> >             - const: radxa,rock
> 
> 





_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Kever Yang <kever.yang@rock-chips.com>, FUKAUMI Naoki <naoki@radxa.com>
Cc: robh@kernel.org, conor+dt@kernel.org, liujianfeng1994@gmail.com,
	jonas@kwiboo.se, cfsworks@gmail.com, dmt.yashin@gmail.com,
	jbx6244@gmail.com, sebastian.reichel@collabora.com,
	tim@feathertop.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	marcin.juszkiewicz@linaro.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	michael.riesch@wolfvision.net, macromorgan@hotmail.com,
	krzk+dt@kernel.org, jing@jing.rocks, dsimic@manjaro.org
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Radxa E52C
Date: Sun, 05 Jan 2025 14:29:06 +0100	[thread overview]
Message-ID: <6900956.G0QQBjFxQf@phil> (raw)
In-Reply-To: <E280EE989942CA2A+4252fa87-049d-4b73-ac28-537f29c09660@radxa.com>

Hey,

Am Freitag, 3. Januar 2025, 07:45:58 CET schrieb FUKAUMI Naoki:
> Hi Kever,
> 
> What do you think about the introduction of the "rockchip,rk3582" 
> compatibility string?

I'm not Kever, but I do like the way you did this :-) .

I.e. the rk3582 _is_ a rk3588 with those cores disabled.

So going the way you did allows us to not introduce too much
overhead while still already having the rk3582 naming in there
if it becomes necessary later on.


Heiko


> --
> FUKAUMI Naoki
> Radxa Computer (Shenzhen) Co., Ltd.
> 
> On 12/26/24 11:46, FUKAUMI Naoki wrote:
> > Add devicetree binding for the Radxa E52C.
> > 
> > Radxa E52C is a compact network computer based on the Rockchip RK3582
> > SoC.
> > 
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> > ---
> > Changes in v3:
> > - Collect A-b tag
> > Changes in v2:
> > - Add "rockchip,rk3588s"
> > ---
> >   Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
> >   1 file changed, 6 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > index 753199a12923..2152d170524a 100644
> > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > @@ -812,6 +812,12 @@ properties:
> >             - const: radxa,e20c
> >             - const: rockchip,rk3528
> >   
> > +      - description: Radxa E52C
> > +        items:
> > +          - const: radxa,e52c
> > +          - const: rockchip,rk3582
> > +          - const: rockchip,rk3588s
> > +
> >         - description: Radxa Rock
> >           items:
> >             - const: radxa,rock
> 
> 





  reply	other threads:[~2025-01-05 13:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-26  2:46 [PATCH v3 0/2] rockchip: Add support for RK3582 FUKAUMI Naoki
2024-12-26  2:46 ` FUKAUMI Naoki
2024-12-26  2:46 ` [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Radxa E52C FUKAUMI Naoki
2024-12-26  2:46   ` FUKAUMI Naoki
2025-01-03  6:45   ` FUKAUMI Naoki
2025-01-03  6:45     ` FUKAUMI Naoki
2025-01-05 13:29     ` Heiko Stuebner [this message]
2025-01-05 13:29       ` Heiko Stuebner
2025-01-05 15:35       ` Dragan Simic
2025-01-05 15:35         ` Dragan Simic
2024-12-26  2:46 ` [PATCH v3 2/2] arm64: dts: " FUKAUMI Naoki
2024-12-26  2:46   ` FUKAUMI Naoki
2024-12-27 15:18 ` [PATCH v3 0/2] rockchip: Add support for RK3582 Rob Herring (Arm)
2024-12-27 15:18   ` Rob Herring (Arm)
2025-01-08 12:02 ` Heiko Stuebner
2025-01-08 12:02   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6900956.G0QQBjFxQf@phil \
    --to=heiko@sntech.de \
    --cc=cfsworks@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmt.yashin@gmail.com \
    --cc=dsimic@manjaro.org \
    --cc=jbx6244@gmail.com \
    --cc=jing@jing.rocks \
    --cc=jonas@kwiboo.se \
    --cc=kever.yang@rock-chips.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=liujianfeng1994@gmail.com \
    --cc=macromorgan@hotmail.com \
    --cc=marcin.juszkiewicz@linaro.org \
    --cc=michael.riesch@wolfvision.net \
    --cc=naoki@radxa.com \
    --cc=robh@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=tim@feathertop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.