[PATCH BlueZ] shared/bap: fix keeping PAC caps <-> metadata correspondence

[PATCH BlueZ] shared/bap: fix keeping PAC caps <-> metadata correspondence

[Pauli Virtanen]

In PACS, Metadata is associated with a specific PAC.  bap_pac_merge()
mixes up metadatas from different PACs if some PAC has no metadata.

Fix caps<->metadata correspondence by explicitly storing 0-length entry,
instead of skipping it altogether, if metadata (or caps) is missing.
---
 src/shared/bap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/shared/bap.c b/src/shared/bap.c
index 427d18627..a18f393f7 100644
--- a/src/shared/bap.c
+++ b/src/shared/bap.c
@@ -3840,11 +3840,11 @@ static void *ltv_merge(struct iovec *data, struct iovec *cont)
 	if (!data)
 		return NULL;
 
+	util_iov_append(data, &delimiter, sizeof(delimiter));
+
 	if (!cont || !cont->iov_len || !cont->iov_base)
 		return data->iov_base;
 
-	util_iov_append(data, &delimiter, sizeof(delimiter));
-
 	return util_iov_append(data, cont->iov_base, cont->iov_len);
 }
 
-- 
2.51.1

RE: [BlueZ] shared/bap: fix keeping PAC caps <-> metadata correspondence

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1865 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1021294

---Test result---

Test Summary:
CheckPatch                    PENDING   0.25 seconds
GitLint                       PENDING   0.26 seconds
BuildEll                      PASS      20.71 seconds
BluezMake                     PASS      2728.59 seconds
MakeCheck                     PASS      20.24 seconds
MakeDistcheck                 PASS      188.88 seconds
CheckValgrind                 PASS      240.71 seconds
CheckSmatch                   WARNING   312.80 seconds
bluezmakeextell               PASS      130.57 seconds
IncrementalBuild              PENDING   0.23 seconds
ScanBuild                     PASS      932.36 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
src/shared/bap.c:317:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:317:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:317:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structures
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ] shared/bap: fix keeping PAC caps <-> metadata correspondence

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Sun,  9 Nov 2025 14:32:26 +0200 you wrote:
> In PACS, Metadata is associated with a specific PAC.  bap_pac_merge()
> mixes up metadatas from different PACs if some PAC has no metadata.
> 
> Fix caps<->metadata correspondence by explicitly storing 0-length entry,
> instead of skipping it altogether, if metadata (or caps) is missing.
> ---
>  src/shared/bap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
  - [BlueZ] shared/bap: fix keeping PAC caps <-> metadata correspondence
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=a7b0f2355bb5

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html