All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: monaco-evk: Enable Bluetooth support
@ 2025-11-13 13:05 Wei Deng
  2025-11-13 13:30 ` bluez.test.bot
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Wei Deng @ 2025-11-13 13:05 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, linux-bluetooth,
	cheng.jiang, quic_jiaymao, quic_chezhou, quic_shuaz

There's a WCN6855 WiFi/Bluetooth module on an M.2 card. To make
Bluetooth work, we need to define the necessary device tree nodes,
including UART configuration and power supplies.

Since there is no standard M.2 binding in the device tree at present,
the PMU is described using dedicated PMU nodes to represent the
internal regulators required by the module.

The module provides a 3.3V supply, which originates from the
main board’s 12V rail. To represent this power hierarchy in the device
tree, add a fixed 12V regulator node as the DC-IN source and link it
to the 3.3V regulator node.

Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/monaco-evk.dts | 99 +++++++++++++++++++++++++
 1 file changed, 99 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
index bb35893da73d..a8d1dd04fcd3 100644
--- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
+++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
@@ -20,6 +20,7 @@ aliases {
 		ethernet0 = &ethernet0;
 		i2c1 = &i2c1;
 		serial0 = &uart7;
+		serial1 = &uart2;
 	};
 
 	chosen {
@@ -76,6 +77,86 @@ platform {
 			};
 		};
 	};
+
+	vreg_dcin_12v: regulator-dcin-12v {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_DCIN_12V";
+		regulator-min-microvolt = <12000000>;
+		regulator-max-microvolt = <12000000>;
+
+		regulator-boot-on;
+		regulator-always-on;
+	};
+
+	vreg_wcn_3p3: regulator-wcn-3p3 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_WCN_3P3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		vin-supply = <&vreg_dcin_12v>;
+
+		regulator-boot-on;
+	};
+
+	wcn6855-pmu {
+		compatible = "qcom,wcn6855-pmu";
+
+		vddio-supply = <&vreg_wcn_3p3>;
+		vddaon-supply = <&vreg_wcn_3p3>;
+		vddpmu-supply = <&vreg_wcn_3p3>;
+		vddpmumx-supply = <&vreg_wcn_3p3>;
+		vddpmucx-supply = <&vreg_wcn_3p3>;
+		vddrfa0p95-supply = <&vreg_wcn_3p3>;
+		vddrfa1p3-supply = <&vreg_wcn_3p3>;
+		vddrfa1p9-supply = <&vreg_wcn_3p3>;
+		vddpcielp3-supply = <&vreg_wcn_3p3>;
+		vddpcielp9-supply = <&vreg_wcn_3p3>;
+
+		regulators {
+			vreg_pmu_rfa_cmn: ldo0 {
+				regulator-name = "vreg_pmu_rfa_cmn";
+			};
+
+			vreg_pmu_aon_0p59: ldo1 {
+				regulator-name = "vreg_pmu_aon_0p59";
+			};
+
+			vreg_pmu_wlcx_0p8: ldo2 {
+				regulator-name = "vreg_pmu_wlcx_0p8";
+			};
+
+			vreg_pmu_wlmx_0p85: ldo3 {
+				regulator-name = "vreg_pmu_wlmx_0p85";
+			};
+
+			vreg_pmu_btcmx_0p85: ldo4 {
+				regulator-name = "vreg_pmu_btcmx_0p85";
+			};
+
+			vreg_pmu_rfa_0p8: ldo5 {
+				regulator-name = "vreg_pmu_rfa_0p8";
+			};
+
+			vreg_pmu_rfa_1p2: ldo6 {
+				regulator-name = "vreg_pmu_rfa_1p2";
+			};
+
+			vreg_pmu_rfa_1p8: ldo7 {
+				regulator-name = "vreg_pmu_rfa_1p8";
+			};
+
+			vreg_pmu_pcie_0p9: ldo8 {
+				regulator-name = "vreg_pmu_pcie_0p9";
+			};
+
+			vreg_pmu_pcie_1p8: ldo9 {
+				regulator-name = "vreg_pmu_pcie_1p8";
+			};
+		};
+	};
 };
 
 &apps_rsc {
@@ -466,6 +547,24 @@ qup_i2c15_default: qup-i2c15-state {
 	};
 };
 
+&uart2 {
+	status = "okay";
+
+	bluetooth: bluetooth {
+		compatible = "qcom,wcn6855-bt";
+		max-speed = <3200000>;
+
+		vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
+		vddaon-supply = <&vreg_pmu_aon_0p59>;
+		vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
+		vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
+		vddbtcmx-supply = <&vreg_pmu_btcmx_0p85>;
+		vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
+		vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
+		vddrfa1p8-supply = <&vreg_pmu_rfa_1p8>;
+	};
+};
+
 &uart7 {
 	status = "okay";
 };
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* RE: arm64: dts: qcom: monaco-evk: Enable Bluetooth support
  2025-11-13 13:05 [PATCH] arm64: dts: qcom: monaco-evk: Enable Bluetooth support Wei Deng
@ 2025-11-13 13:30 ` bluez.test.bot
  2025-11-13 20:15 ` [PATCH] " Dmitry Baryshkov
  2025-11-14 15:58 ` Rob Herring (Arm)
  2 siblings, 0 replies; 9+ messages in thread
From: bluez.test.bot @ 2025-11-13 13:30 UTC (permalink / raw)
  To: linux-bluetooth, wei.deng

[-- Attachment #1: Type: text/plain, Size: 2463 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1022969

---Test result---

Test Summary:
CheckPatch                    PENDING   0.40 seconds
GitLint                       PENDING   0.34 seconds
SubjectPrefix                 FAIL      0.41 seconds
BuildKernel                   PASS      24.84 seconds
CheckAllWarning               PASS      27.03 seconds
CheckSparse                   PASS      30.80 seconds
BuildKernel32                 PASS      24.49 seconds
TestRunnerSetup               PASS      490.00 seconds
TestRunner_l2cap-tester       PASS      25.12 seconds
TestRunner_iso-tester         PASS      55.64 seconds
TestRunner_bnep-tester        PASS      6.07 seconds
TestRunner_mgmt-tester        FAIL      117.91 seconds
TestRunner_rfcomm-tester      PASS      9.07 seconds
TestRunner_sco-tester         PASS      14.07 seconds
TestRunner_ioctl-tester       PASS      9.67 seconds
TestRunner_mesh-tester        FAIL      11.50 seconds
TestRunner_smp-tester         PASS      8.38 seconds
TestRunner_userchan-tester    PASS      6.39 seconds
IncrementalBuild              PENDING   0.82 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 492, Passed: 487 (99.0%), Failed: 1, Not Run: 4

Failed Test Cases
Read Exp Feature - Success                           Failed       0.104 seconds
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Timed out    2.094 seconds
Mesh - Send cancel - 2                               Timed out    1.997 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] arm64: dts: qcom: monaco-evk: Enable Bluetooth support
  2025-11-13 13:05 [PATCH] arm64: dts: qcom: monaco-evk: Enable Bluetooth support Wei Deng
  2025-11-13 13:30 ` bluez.test.bot
@ 2025-11-13 20:15 ` Dmitry Baryshkov
  2025-11-14 15:58 ` Rob Herring (Arm)
  2 siblings, 0 replies; 9+ messages in thread
From: Dmitry Baryshkov @ 2025-11-13 20:15 UTC (permalink / raw)
  To: Wei Deng
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
	linux-bluetooth, cheng.jiang, quic_jiaymao, quic_chezhou,
	quic_shuaz

On Thu, Nov 13, 2025 at 06:35:19PM +0530, Wei Deng wrote:
> There's a WCN6855 WiFi/Bluetooth module on an M.2 card. To make
> Bluetooth work, we need to define the necessary device tree nodes,
> including UART configuration and power supplies.
> 
> Since there is no standard M.2 binding in the device tree at present,
> the PMU is described using dedicated PMU nodes to represent the
> internal regulators required by the module.
> 
> The module provides a 3.3V supply, which originates from the
> main board’s 12V rail. To represent this power hierarchy in the device
> tree, add a fixed 12V regulator node as the DC-IN source and link it
> to the 3.3V regulator node.
> 
> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/monaco-evk.dts | 99 +++++++++++++++++++++++++
>  1 file changed, 99 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] arm64: dts: qcom: monaco-evk: Enable Bluetooth support
  2025-11-13 13:05 [PATCH] arm64: dts: qcom: monaco-evk: Enable Bluetooth support Wei Deng
  2025-11-13 13:30 ` bluez.test.bot
  2025-11-13 20:15 ` [PATCH] " Dmitry Baryshkov
@ 2025-11-14 15:58 ` Rob Herring (Arm)
  2025-11-14 16:18   ` Rob Herring
  2 siblings, 1 reply; 9+ messages in thread
From: Rob Herring (Arm) @ 2025-11-14 15:58 UTC (permalink / raw)
  To: Wei Deng
  Cc: Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, quic_jiaymao,
	Konrad Dybcio, linux-kernel, linux-bluetooth, cheng.jiang,
	devicetree, Bjorn Andersson, quic_shuaz, quic_chezhou


On Thu, 13 Nov 2025 18:35:19 +0530, Wei Deng wrote:
> There's a WCN6855 WiFi/Bluetooth module on an M.2 card. To make
> Bluetooth work, we need to define the necessary device tree nodes,
> including UART configuration and power supplies.
> 
> Since there is no standard M.2 binding in the device tree at present,
> the PMU is described using dedicated PMU nodes to represent the
> internal regulators required by the module.
> 
> The module provides a 3.3V supply, which originates from the
> main board’s 12V rail. To represent this power hierarchy in the device
> tree, add a fixed 12V regulator node as the DC-IN source and link it
> to the 3.3V regulator node.
> 
> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/monaco-evk.dts | 99 +++++++++++++++++++++++++
>  1 file changed, 99 insertions(+)
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/next-20251112 (exact match)
 Base: tags/next-20251112 (use --merge-base to override)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20251113130519.2647081-1-wei.deng@oss.qualcomm.com:

arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcielp3-supply', 'vddpcielp9-supply' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcie1p3-supply' is a required property
	from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcie1p9-supply' is a required property
	from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml






^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] arm64: dts: qcom: monaco-evk: Enable Bluetooth support
  2025-11-14 15:58 ` Rob Herring (Arm)
@ 2025-11-14 16:18   ` Rob Herring
  2025-11-18  7:07     ` Wei Deng
  0 siblings, 1 reply; 9+ messages in thread
From: Rob Herring @ 2025-11-14 16:18 UTC (permalink / raw)
  To: Wei Deng
  Cc: Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, quic_jiaymao,
	Konrad Dybcio, linux-kernel, linux-bluetooth, cheng.jiang,
	devicetree, Bjorn Andersson, quic_shuaz, quic_chezhou

On Fri, Nov 14, 2025 at 10:06 AM Rob Herring (Arm) <robh@kernel.org> wrote:
>
>
> On Thu, 13 Nov 2025 18:35:19 +0530, Wei Deng wrote:
> > There's a WCN6855 WiFi/Bluetooth module on an M.2 card. To make
> > Bluetooth work, we need to define the necessary device tree nodes,
> > including UART configuration and power supplies.
> >
> > Since there is no standard M.2 binding in the device tree at present,
> > the PMU is described using dedicated PMU nodes to represent the
> > internal regulators required by the module.
> >
> > The module provides a 3.3V supply, which originates from the
> > main board’s 12V rail. To represent this power hierarchy in the device
> > tree, add a fixed 12V regulator node as the DC-IN source and link it
> > to the 3.3V regulator node.
> >
> > Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
> > ---
> >  arch/arm64/boot/dts/qcom/monaco-evk.dts | 99 +++++++++++++++++++++++++
> >  1 file changed, 99 insertions(+)
> >
>
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
>   pip3 install dtschema --upgrade
>
>
> This patch series was applied (using b4) to base:
>  Base: attempting to guess base-commit...
>  Base: tags/next-20251112 (exact match)
>  Base: tags/next-20251112 (use --merge-base to override)
>
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
>
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20251113130519.2647081-1-wei.deng@oss.qualcomm.com:
>
> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcielp3-supply', 'vddpcielp9-supply' do not match any of the regexes: '^pinctrl-[0-9]+$'
>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcie1p3-supply' is a required property
>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcie1p9-supply' is a required property
>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml

This is the 3rd report of your typos. Is there some reason you are
ignoring the reports?

Rob

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] arm64: dts: qcom: monaco-evk: Enable Bluetooth support
  2025-11-14 16:18   ` Rob Herring
@ 2025-11-18  7:07     ` Wei Deng
  2025-11-18  7:19       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 9+ messages in thread
From: Wei Deng @ 2025-11-18  7:07 UTC (permalink / raw)
  To: Rob Herring
  Cc: Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, quic_jiaymao,
	Konrad Dybcio, linux-kernel, linux-bluetooth, cheng.jiang,
	devicetree, Bjorn Andersson, quic_shuaz, quic_chezhou

Hi Rob,

Thanks for your comments.

On 11/15/2025 12:18 AM, Rob Herring wrote:
> On Fri, Nov 14, 2025 at 10:06 AM Rob Herring (Arm) <robh@kernel.org> wrote:
>>
>>
>> On Thu, 13 Nov 2025 18:35:19 +0530, Wei Deng wrote:
>>> There's a WCN6855 WiFi/Bluetooth module on an M.2 card. To make
>>> Bluetooth work, we need to define the necessary device tree nodes,
>>> including UART configuration and power supplies.
>>>
>>> Since there is no standard M.2 binding in the device tree at present,
>>> the PMU is described using dedicated PMU nodes to represent the
>>> internal regulators required by the module.
>>>
>>> The module provides a 3.3V supply, which originates from the
>>> main board’s 12V rail. To represent this power hierarchy in the device
>>> tree, add a fixed 12V regulator node as the DC-IN source and link it
>>> to the 3.3V regulator node.
>>>
>>> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
>>> ---
>>>  arch/arm64/boot/dts/qcom/monaco-evk.dts | 99 +++++++++++++++++++++++++
>>>  1 file changed, 99 insertions(+)
>>>
>>
>>
>> My bot found new DTB warnings on the .dts files added or changed in this
>> series.
>>
>> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
>> are fixed by another series. Ultimately, it is up to the platform
>> maintainer whether these warnings are acceptable or not. No need to reply
>> unless the platform maintainer has comments.
>>
>> If you already ran DT checks and didn't see these error(s), then
>> make sure dt-schema is up to date:
>>
>>   pip3 install dtschema --upgrade
>>
>>
>> This patch series was applied (using b4) to base:
>>  Base: attempting to guess base-commit...
>>  Base: tags/next-20251112 (exact match)
>>  Base: tags/next-20251112 (use --merge-base to override)
>>
>> If this is not the correct base, please add 'base-commit' tag
>> (or use b4 which does this automatically)
>>
>> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20251113130519.2647081-1-wei.deng@oss.qualcomm.com:
>>
>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcielp3-supply', 'vddpcielp9-supply' do not match any of the regexes: '^pinctrl-[0-9]+$'
>>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcie1p3-supply' is a required property
>>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcie1p9-supply' is a required property
>>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
> 
> This is the 3rd report of your typos. Is there some reason you are
> ignoring the reports?
> 

Sorry for the delayed response. These warnings are worth addressing 
and will be resolved in the next patch.

> Rob

-- 
Best Regards,
Wei Deng


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] arm64: dts: qcom: monaco-evk: Enable Bluetooth support
  2025-11-18  7:07     ` Wei Deng
@ 2025-11-18  7:19       ` Krzysztof Kozlowski
  2025-11-18 13:24         ` Wei Deng
  0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-18  7:19 UTC (permalink / raw)
  To: Wei Deng, Rob Herring
  Cc: Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, quic_jiaymao,
	Konrad Dybcio, linux-kernel, linux-bluetooth, cheng.jiang,
	devicetree, Bjorn Andersson, quic_shuaz, quic_chezhou

On 18/11/2025 08:07, Wei Deng wrote:
> Hi Rob,
> 
> Thanks for your comments.
> 
> On 11/15/2025 12:18 AM, Rob Herring wrote:
>> On Fri, Nov 14, 2025 at 10:06 AM Rob Herring (Arm) <robh@kernel.org> wrote:
>>>
>>>
>>> On Thu, 13 Nov 2025 18:35:19 +0530, Wei Deng wrote:
>>>> There's a WCN6855 WiFi/Bluetooth module on an M.2 card. To make
>>>> Bluetooth work, we need to define the necessary device tree nodes,
>>>> including UART configuration and power supplies.
>>>>
>>>> Since there is no standard M.2 binding in the device tree at present,
>>>> the PMU is described using dedicated PMU nodes to represent the
>>>> internal regulators required by the module.
>>>>
>>>> The module provides a 3.3V supply, which originates from the
>>>> main board’s 12V rail. To represent this power hierarchy in the device
>>>> tree, add a fixed 12V regulator node as the DC-IN source and link it
>>>> to the 3.3V regulator node.
>>>>
>>>> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
>>>> ---
>>>>  arch/arm64/boot/dts/qcom/monaco-evk.dts | 99 +++++++++++++++++++++++++
>>>>  1 file changed, 99 insertions(+)
>>>>
>>>
>>>
>>> My bot found new DTB warnings on the .dts files added or changed in this
>>> series.
>>>
>>> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
>>> are fixed by another series. Ultimately, it is up to the platform
>>> maintainer whether these warnings are acceptable or not. No need to reply
>>> unless the platform maintainer has comments.
>>>
>>> If you already ran DT checks and didn't see these error(s), then
>>> make sure dt-schema is up to date:
>>>
>>>   pip3 install dtschema --upgrade
>>>
>>>
>>> This patch series was applied (using b4) to base:
>>>  Base: attempting to guess base-commit...
>>>  Base: tags/next-20251112 (exact match)
>>>  Base: tags/next-20251112 (use --merge-base to override)
>>>
>>> If this is not the correct base, please add 'base-commit' tag
>>> (or use b4 which does this automatically)
>>>
>>> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20251113130519.2647081-1-wei.deng@oss.qualcomm.com:
>>>
>>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcielp3-supply', 'vddpcielp9-supply' do not match any of the regexes: '^pinctrl-[0-9]+$'
>>>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
>>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcie1p3-supply' is a required property
>>>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
>>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcie1p9-supply' is a required property
>>>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
>>
>> This is the 3rd report of your typos. Is there some reason you are
>> ignoring the reports?
>>
> 
> Sorry for the delayed response. These warnings are worth addressing 
> and will be resolved in the next patch.
>


Three of your patchsets have bugs easily pointed out by tools, so please
answer - are you ignoring the reports? Are you doing any tests before
sending?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] arm64: dts: qcom: monaco-evk: Enable Bluetooth support
  2025-11-18  7:19       ` Krzysztof Kozlowski
@ 2025-11-18 13:24         ` Wei Deng
  2025-11-18 14:12           ` Krzysztof Kozlowski
  0 siblings, 1 reply; 9+ messages in thread
From: Wei Deng @ 2025-11-18 13:24 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Rob Herring
  Cc: Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, quic_jiaymao,
	Konrad Dybcio, linux-kernel, linux-bluetooth, cheng.jiang,
	devicetree, Bjorn Andersson, quic_shuaz, quic_chezhou

Hi Krzysztof,

Thanks for your comments.

On 11/18/2025 3:19 PM, Krzysztof Kozlowski wrote:
> On 18/11/2025 08:07, Wei Deng wrote:
>> Hi Rob,
>>
>> Thanks for your comments.
>>
>> On 11/15/2025 12:18 AM, Rob Herring wrote:
>>> On Fri, Nov 14, 2025 at 10:06 AM Rob Herring (Arm) <robh@kernel.org> wrote:
>>>>
>>>>
>>>> On Thu, 13 Nov 2025 18:35:19 +0530, Wei Deng wrote:
>>>>> There's a WCN6855 WiFi/Bluetooth module on an M.2 card. To make
>>>>> Bluetooth work, we need to define the necessary device tree nodes,
>>>>> including UART configuration and power supplies.
>>>>>
>>>>> Since there is no standard M.2 binding in the device tree at present,
>>>>> the PMU is described using dedicated PMU nodes to represent the
>>>>> internal regulators required by the module.
>>>>>
>>>>> The module provides a 3.3V supply, which originates from the
>>>>> main board’s 12V rail. To represent this power hierarchy in the device
>>>>> tree, add a fixed 12V regulator node as the DC-IN source and link it
>>>>> to the 3.3V regulator node.
>>>>>
>>>>> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
>>>>> ---
>>>>>  arch/arm64/boot/dts/qcom/monaco-evk.dts | 99 +++++++++++++++++++++++++
>>>>>  1 file changed, 99 insertions(+)
>>>>>
>>>>
>>>>
>>>> My bot found new DTB warnings on the .dts files added or changed in this
>>>> series.
>>>>
>>>> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
>>>> are fixed by another series. Ultimately, it is up to the platform
>>>> maintainer whether these warnings are acceptable or not. No need to reply
>>>> unless the platform maintainer has comments.
>>>>
>>>> If you already ran DT checks and didn't see these error(s), then
>>>> make sure dt-schema is up to date:
>>>>
>>>>   pip3 install dtschema --upgrade
>>>>
>>>>
>>>> This patch series was applied (using b4) to base:
>>>>  Base: attempting to guess base-commit...
>>>>  Base: tags/next-20251112 (exact match)
>>>>  Base: tags/next-20251112 (use --merge-base to override)
>>>>
>>>> If this is not the correct base, please add 'base-commit' tag
>>>> (or use b4 which does this automatically)
>>>>
>>>> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20251113130519.2647081-1-wei.deng@oss.qualcomm.com:
>>>>
>>>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcielp3-supply', 'vddpcielp9-supply' do not match any of the regexes: '^pinctrl-[0-9]+$'
>>>>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
>>>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcie1p3-supply' is a required property
>>>>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
>>>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcie1p9-supply' is a required property
>>>>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
>>>
>>> This is the 3rd report of your typos. Is there some reason you are
>>> ignoring the reports?
>>>
>>
>> Sorry for the delayed response. These warnings are worth addressing 
>> and will be resolved in the next patch.
>>
> 
> 
> Three of your patchsets have bugs easily pointed out by tools, so please
> answer - are you ignoring the reports? Are you doing any tests before
> sending?
> 

Testing was completed on the local hardware platform with successful 
compilation and normal functionality, so the tests in this section 
were omitted. Prior to the next submission, a dt-binding constraint 
check will be performed.

> Best regards,
> Krzysztof

-- 
Best Regards,
Wei Deng


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] arm64: dts: qcom: monaco-evk: Enable Bluetooth support
  2025-11-18 13:24         ` Wei Deng
@ 2025-11-18 14:12           ` Krzysztof Kozlowski
  0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-18 14:12 UTC (permalink / raw)
  To: Wei Deng, Rob Herring
  Cc: Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, quic_jiaymao,
	Konrad Dybcio, linux-kernel, linux-bluetooth, cheng.jiang,
	devicetree, Bjorn Andersson, quic_shuaz, quic_chezhou

On 18/11/2025 14:24, Wei Deng wrote:
> Hi Krzysztof,
> 
> Thanks for your comments.
> 
> On 11/18/2025 3:19 PM, Krzysztof Kozlowski wrote:
>> On 18/11/2025 08:07, Wei Deng wrote:
>>> Hi Rob,
>>>
>>> Thanks for your comments.
>>>
>>> On 11/15/2025 12:18 AM, Rob Herring wrote:
>>>> On Fri, Nov 14, 2025 at 10:06 AM Rob Herring (Arm) <robh@kernel.org> wrote:
>>>>>
>>>>>
>>>>> On Thu, 13 Nov 2025 18:35:19 +0530, Wei Deng wrote:
>>>>>> There's a WCN6855 WiFi/Bluetooth module on an M.2 card. To make
>>>>>> Bluetooth work, we need to define the necessary device tree nodes,
>>>>>> including UART configuration and power supplies.
>>>>>>
>>>>>> Since there is no standard M.2 binding in the device tree at present,
>>>>>> the PMU is described using dedicated PMU nodes to represent the
>>>>>> internal regulators required by the module.
>>>>>>
>>>>>> The module provides a 3.3V supply, which originates from the
>>>>>> main board’s 12V rail. To represent this power hierarchy in the device
>>>>>> tree, add a fixed 12V regulator node as the DC-IN source and link it
>>>>>> to the 3.3V regulator node.
>>>>>>
>>>>>> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
>>>>>> ---
>>>>>>  arch/arm64/boot/dts/qcom/monaco-evk.dts | 99 +++++++++++++++++++++++++
>>>>>>  1 file changed, 99 insertions(+)
>>>>>>
>>>>>
>>>>>
>>>>> My bot found new DTB warnings on the .dts files added or changed in this
>>>>> series.
>>>>>
>>>>> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
>>>>> are fixed by another series. Ultimately, it is up to the platform
>>>>> maintainer whether these warnings are acceptable or not. No need to reply
>>>>> unless the platform maintainer has comments.
>>>>>
>>>>> If you already ran DT checks and didn't see these error(s), then
>>>>> make sure dt-schema is up to date:
>>>>>
>>>>>   pip3 install dtschema --upgrade
>>>>>
>>>>>
>>>>> This patch series was applied (using b4) to base:
>>>>>  Base: attempting to guess base-commit...
>>>>>  Base: tags/next-20251112 (exact match)
>>>>>  Base: tags/next-20251112 (use --merge-base to override)
>>>>>
>>>>> If this is not the correct base, please add 'base-commit' tag
>>>>> (or use b4 which does this automatically)
>>>>>
>>>>> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20251113130519.2647081-1-wei.deng@oss.qualcomm.com:
>>>>>
>>>>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcielp3-supply', 'vddpcielp9-supply' do not match any of the regexes: '^pinctrl-[0-9]+$'
>>>>>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
>>>>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcie1p3-supply' is a required property
>>>>>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
>>>>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcie1p9-supply' is a required property
>>>>>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
>>>>
>>>> This is the 3rd report of your typos. Is there some reason you are
>>>> ignoring the reports?
>>>>
>>>
>>> Sorry for the delayed response. These warnings are worth addressing 
>>> and will be resolved in the next patch.
>>>
>>
>>
>> Three of your patchsets have bugs easily pointed out by tools, so please
>> answer - are you ignoring the reports? Are you doing any tests before
>> sending?
>>
> 
> Testing was completed on the local hardware platform with successful 
> compilation and normal functionality, so the tests in this section 

Which is not enough.

Did you read kernel writing-schema guide? Or any other guide like your
own internal guideline which asks you explicitly for other tests?


> were omitted. Prior to the next submission, a dt-binding constraint 
> check will be performed.

You need to read internal guideline go/upstream before you post next
patches.

How many other tests you did not run?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2025-11-18 14:12 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-13 13:05 [PATCH] arm64: dts: qcom: monaco-evk: Enable Bluetooth support Wei Deng
2025-11-13 13:30 ` bluez.test.bot
2025-11-13 20:15 ` [PATCH] " Dmitry Baryshkov
2025-11-14 15:58 ` Rob Herring (Arm)
2025-11-14 16:18   ` Rob Herring
2025-11-18  7:07     ` Wei Deng
2025-11-18  7:19       ` Krzysztof Kozlowski
2025-11-18 13:24         ` Wei Deng
2025-11-18 14:12           ` Krzysztof Kozlowski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.