Re: Re: [PATCH v2 5/5] ARM: EXYNOS4: Add platform data for EXYNOS4 FIMD and LTE480WV platform-lcd

Re: Re: [PATCH v2 5/5] ARM: EXYNOS4: Add platform data for EXYNOS4 FIMD and LTE480WV platform-lcd

[JinGoo Han]

Hi, Tushar Behera.

> -----Original Message-----
> From: linux-samsung-soc-owner@vger.kernel.org [mailto:linux-samsung-soc-
> owner@vger.kernel.org] On Behalf Of Tushar Behera
> Sent: Tuesday, June 21, 2011 12:47 PM
> To: Jingoo Han
> Cc: Kukjin Kim; Paul Mundt; linux-samsung-soc@vger.kernel.org; Jonghun Han;
> Anand Kumar N; Thomas Abraham; Sylwester Nawrocki; Marek Szyprowski;
> Kyungmin Park; Inki Dae; ARM Linux; Ben Dooks
> Subject: Re: [PATCH v2 5/5] ARM: EXYNOS4: Add platform data for EXYNOS4
> FIMD and LTE480WV platform-lcd
> 
> Hi,
> 
> On Friday 17 June 2011 06:32 PM, Jingoo Han wrote:
> > From: Jonghun Han<jonghun.han@samsung.com>
> >
> > This patch adds support EXYNOS4 FIMD0 and LTE480WV LCD pannel.
> >
> > Signed-off-by: Jonghun Han<jonghun.han@samsung.com>
> > Signed-off-by: Jingoo Han<jg1.han@samsung.com>
> > ---
> >   arch/arm/mach-exynos4/mach-smdkc210.c |   74
> +++++++++++++++++++++++++++++++++
> >   arch/arm/mach-exynos4/mach-smdkv310.c |   74
> +++++++++++++++++++++++++++++++++
> >   2 files changed, 148 insertions(+), 0 deletions(-)
> >
> 
> There are variants of SMDKV310 boards that don't use LTE480WV LCD panel.
> Won't it be better to provide an option of selecting the LCD panel
> through config file and adding the panel code accordingly?
>
> Also, the panel code can be consolidated at a single location and used
> in appropriate machine files.
> 
Do you have a patch about that?
If you make a patch about your suggestion, please submit it.

Re: [PATCH v2 5/5] ARM: EXYNOS4: Add platform data for EXYNOS4 FIMD and LTE480WV platform-lcd

[Tushar Behera]

Hi Jingoo Han,
On Tuesday 21 June 2011 09:38 AM, JinGoo Han wrote:
> Hi, Tushar Behera.
> 
>> -----Original Message-----
>> From: linux-samsung-soc-owner@vger.kernel.org [mailto:linux-samsung-soc-
>> owner@vger.kernel.org] On Behalf Of Tushar Behera
>> Sent: Tuesday, June 21, 2011 12:47 PM
>> To: Jingoo Han
>> Cc: Kukjin Kim; Paul Mundt; linux-samsung-soc@vger.kernel.org; Jonghun Han;
>> Anand Kumar N; Thomas Abraham; Sylwester Nawrocki; Marek Szyprowski;
>> Kyungmin Park; Inki Dae; ARM Linux; Ben Dooks
>> Subject: Re: [PATCH v2 5/5] ARM: EXYNOS4: Add platform data for EXYNOS4
>> FIMD and LTE480WV platform-lcd
>>
>> Hi,
>>
>> On Friday 17 June 2011 06:32 PM, Jingoo Han wrote:
>>> From: Jonghun Han<jonghun.han@samsung.com>
>>>
>>> This patch adds support EXYNOS4 FIMD0 and LTE480WV LCD pannel.
>>>
>>> Signed-off-by: Jonghun Han<jonghun.han@samsung.com>
>>> Signed-off-by: Jingoo Han<jg1.han@samsung.com>
>>> ---
>>>    arch/arm/mach-exynos4/mach-smdkc210.c |   74
>> +++++++++++++++++++++++++++++++++
>>>    arch/arm/mach-exynos4/mach-smdkv310.c |   74
>> +++++++++++++++++++++++++++++++++
>>>    2 files changed, 148 insertions(+), 0 deletions(-)
>>>
>>
>> There are variants of SMDKV310 boards that don't use LTE480WV LCD panel.
>> Won't it be better to provide an option of selecting the LCD panel
>> through config file and adding the panel code accordingly?
>>
>> Also, the panel code can be consolidated at a single location and used
>> in appropriate machine files.
>>
> Do you have a patch about that?
As of now, I don't have any patch for this.
> If you make a patch about your suggestion, please submit it.
I don't have a SMDKV310 with LTE480WV LCD panel, so I might still not be
able to test that patch.

-- 
Tushar Behera