From: David Lechner <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
To: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Kevin Hilman <khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
"Axel Haslam" <ahaslam-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
"Alexandre Bailon"
<abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
"Bartosz Gołaszewski"
<bgolaszewski-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH 2/3] pinctrl: New driver for TI DA8XX/OMAP-L138/AM18XX pinconf
Date: Wed, 23 Nov 2016 10:21:41 -0600 [thread overview]
Message-ID: <6936ebc0-bb27-d741-3504-e2fbb231b87c@lechnology.com> (raw)
In-Reply-To: <88b3d16b-6e5b-ea75-d770-35d9adc6c677-l0cyMroinI0@public.gmane.org>
On 11/23/2016 05:04 AM, Sekhar Nori wrote:
> On Wednesday 23 November 2016 08:59 AM, David Lechner wrote:
>> This adds a new driver for pinconf on TI DA8XX/OMAP-L138/AM18XX. These
>
> s/DA8XX/DA850/
>
>> SoCs have a separate controller for controlling pullup/pulldown groups.
>>
>> Signed-off-by: David Lechner <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
>
>> +static const char *da850_pupd_get_get_group_name(struct pinctrl_dev *pctldev,
>> + unsigned int selector)
>> +{
>> + return da850_pupd_group_names[selector];
>> +}
>> +
>> +static int da850_pupd_get_get_group_pins(struct pinctrl_dev *pctldev,
>> + unsigned int selector,
>> + const unsigned int **pins,
>> + unsigned int *num_pins)
>> +{
>> + *num_pins = 0;
>> +
>> + return 0;
>> +}
>
> usage of get_get_ in the function names above is odd.
Will fix (copy/paste error)
>
> Thanks,
> Sekhar
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: david@lechnology.com (David Lechner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] pinctrl: New driver for TI DA8XX/OMAP-L138/AM18XX pinconf
Date: Wed, 23 Nov 2016 10:21:41 -0600 [thread overview]
Message-ID: <6936ebc0-bb27-d741-3504-e2fbb231b87c@lechnology.com> (raw)
In-Reply-To: <88b3d16b-6e5b-ea75-d770-35d9adc6c677@ti.com>
On 11/23/2016 05:04 AM, Sekhar Nori wrote:
> On Wednesday 23 November 2016 08:59 AM, David Lechner wrote:
>> This adds a new driver for pinconf on TI DA8XX/OMAP-L138/AM18XX. These
>
> s/DA8XX/DA850/
>
>> SoCs have a separate controller for controlling pullup/pulldown groups.
>>
>> Signed-off-by: David Lechner <david@lechnology.com>
>
>> +static const char *da850_pupd_get_get_group_name(struct pinctrl_dev *pctldev,
>> + unsigned int selector)
>> +{
>> + return da850_pupd_group_names[selector];
>> +}
>> +
>> +static int da850_pupd_get_get_group_pins(struct pinctrl_dev *pctldev,
>> + unsigned int selector,
>> + const unsigned int **pins,
>> + unsigned int *num_pins)
>> +{
>> + *num_pins = 0;
>> +
>> + return 0;
>> +}
>
> usage of get_get_ in the function names above is odd.
Will fix (copy/paste error)
>
> Thanks,
> Sekhar
>
WARNING: multiple messages have this Message-ID (diff)
From: David Lechner <david@lechnology.com>
To: Sekhar Nori <nsekhar@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kevin Hilman <khilman@kernel.org>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Axel Haslam" <ahaslam@baylibre.com>,
"Alexandre Bailon" <abailon@baylibre.com>,
"Bartosz Gołaszewski" <bgolaszewski@baylibre.com>
Subject: Re: [PATCH 2/3] pinctrl: New driver for TI DA8XX/OMAP-L138/AM18XX pinconf
Date: Wed, 23 Nov 2016 10:21:41 -0600 [thread overview]
Message-ID: <6936ebc0-bb27-d741-3504-e2fbb231b87c@lechnology.com> (raw)
In-Reply-To: <88b3d16b-6e5b-ea75-d770-35d9adc6c677@ti.com>
On 11/23/2016 05:04 AM, Sekhar Nori wrote:
> On Wednesday 23 November 2016 08:59 AM, David Lechner wrote:
>> This adds a new driver for pinconf on TI DA8XX/OMAP-L138/AM18XX. These
>
> s/DA8XX/DA850/
>
>> SoCs have a separate controller for controlling pullup/pulldown groups.
>>
>> Signed-off-by: David Lechner <david@lechnology.com>
>
>> +static const char *da850_pupd_get_get_group_name(struct pinctrl_dev *pctldev,
>> + unsigned int selector)
>> +{
>> + return da850_pupd_group_names[selector];
>> +}
>> +
>> +static int da850_pupd_get_get_group_pins(struct pinctrl_dev *pctldev,
>> + unsigned int selector,
>> + const unsigned int **pins,
>> + unsigned int *num_pins)
>> +{
>> + *num_pins = 0;
>> +
>> + return 0;
>> +}
>
> usage of get_get_ in the function names above is odd.
Will fix (copy/paste error)
>
> Thanks,
> Sekhar
>
next prev parent reply other threads:[~2016-11-23 16:21 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 3:29 [PATCH 0/3] TI DA850/OMAP-L138/AM18x pinconf David Lechner
2016-11-23 3:29 ` David Lechner
2016-11-23 3:29 ` [PATCH 1/3] devicetree: bindings: pinctrl: Add binding for ti,da850-pupd David Lechner
2016-11-23 3:29 ` [PATCH 1/3] devicetree: bindings: pinctrl: Add binding for ti, da850-pupd David Lechner
2016-11-23 11:01 ` [PATCH 1/3] devicetree: bindings: pinctrl: Add binding for ti,da850-pupd Sekhar Nori
2016-11-23 11:01 ` Sekhar Nori
2016-11-24 14:04 ` Linus Walleij
2016-11-24 14:04 ` [PATCH 1/3] devicetree: bindings: pinctrl: Add binding for ti, da850-pupd Linus Walleij
2016-11-28 21:54 ` [PATCH 1/3] devicetree: bindings: pinctrl: Add binding for ti,da850-pupd Rob Herring
2016-11-28 21:54 ` Rob Herring
2016-11-23 3:29 ` [PATCH 2/3] pinctrl: New driver for TI DA8XX/OMAP-L138/AM18XX pinconf David Lechner
2016-11-23 3:29 ` David Lechner
[not found] ` <1479871767-20160-3-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2016-11-23 11:04 ` Sekhar Nori
2016-11-23 11:04 ` Sekhar Nori
2016-11-23 11:04 ` Sekhar Nori
[not found] ` <88b3d16b-6e5b-ea75-d770-35d9adc6c677-l0cyMroinI0@public.gmane.org>
2016-11-23 16:21 ` David Lechner [this message]
2016-11-23 16:21 ` David Lechner
2016-11-23 16:21 ` David Lechner
2016-11-24 14:05 ` Linus Walleij
2016-11-24 14:05 ` Linus Walleij
2016-11-24 14:05 ` Linus Walleij
2016-11-23 3:29 ` [PATCH 3/3] ARM: dts: da850: Add node for pullup/pulldown pinconf David Lechner
2016-11-23 3:29 ` David Lechner
[not found] ` <1479871767-20160-4-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2016-11-23 11:12 ` Sekhar Nori
2016-11-23 11:12 ` Sekhar Nori
2016-11-23 11:12 ` Sekhar Nori
2016-11-23 16:24 ` David Lechner
2016-11-23 16:24 ` David Lechner
2016-11-23 16:24 ` David Lechner
2016-11-23 22:33 ` Kevin Hilman
2016-11-23 22:33 ` Kevin Hilman
2016-11-24 5:54 ` Sekhar Nori
2016-11-24 5:54 ` Sekhar Nori
2016-11-23 11:17 ` [PATCH 0/3] TI DA850/OMAP-L138/AM18x pinconf Sekhar Nori
2016-11-23 11:17 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6936ebc0-bb27-d741-3504-e2fbb231b87c@lechnology.com \
--to=david-nq/r/kbu++upp/zk7jdf2g@public.gmane.org \
--cc=abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=ahaslam-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=bgolaszewski-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=nsekhar-l0cyMroinI0@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.