[syzbot] [btrfs?] kernel BUG in btrfs_create_qgroup

[syzbot] [btrfs?] kernel BUG in btrfs_create_qgroup

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit:    d358e5254674 Merge tag 'for-6.19/dm-changes' of git://git...
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=11dc161a580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=de48dccdf203ea90
dashboard link: https://syzkaller.appspot.com/bug?extid=803e4cb8245b52928347
compiler:       Debian clang version 20.1.8 (++20250708063551+0c9f909b7976-1~exp1~20250708183702.136), Debian LLD 20.1.8
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=14eef992580000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=102541b4580000

Downloadable assets:
disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/d900f083ada3/non_bootable_disk-d358e525.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/3fa1d04c1a85/vmlinux-d358e525.xz
kernel image: https://storage.googleapis.com/syzbot-assets/a9b253146e36/bzImage-d358e525.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/29e87432b229/mount_0.gz
  fsck result: OK (log: https://syzkaller.appspot.com/x/fsck.log?x=10eef992580000)

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+803e4cb8245b52928347@syzkaller.appspotmail.com

R13: 00007f6d45de5fa0 R14: 00007f6d45de5fa0 R15: 0000000000000003
 </TASK>
assertion failed: prealloc == NULL :: 0, in fs/btrfs/qgroup.c:1690
------------[ cut here ]------------
kernel BUG at fs/btrfs/qgroup.c:1690!
Oops: invalid opcode: 0000 [#1] SMP KASAN NOPTI
CPU: 0 UID: 0 PID: 5518 Comm: syz.0.17 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
RIP: 0010:btrfs_create_qgroup+0x52b/0x530 fs/btrfs/qgroup.c:1690
Code: 24 08 e8 08 f4 6f 07 48 c7 c7 e0 49 d1 8b 48 c7 c6 40 4a d1 8b 31 d2 48 c7 c1 60 46 d1 8b 41 b8 9a 06 00 00 e8 e6 33 39 fd 90 <0f> 0b 0f 1f 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 f3
RSP: 0018:ffffc900029af540 EFLAGS: 00010246
RAX: 0000000000000042 RBX: 00000000fffffff4 RCX: 4c7ff4269176e000
RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000
RBP: 0000000000000100 R08: ffffc900029af267 R09: 1ffff92000535e4c
R10: dffffc0000000000 R11: fffff52000535e4d R12: dffffc0000000000
R13: 1ffff110001f1b1c R14: ffff888000f8d8e0 R15: ffff888038ab4800
FS:  000055557c30d500(0000) GS:ffff88808d22f000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fb800c6e6c8 CR3: 000000001fd86000 CR4: 0000000000352ef0
Call Trace:
 <TASK>
 create_pending_snapshot+0x86c/0x3230 fs/btrfs/transaction.c:1748
 create_pending_snapshots+0x17c/0x1c0 fs/btrfs/transaction.c:1940
 btrfs_commit_transaction+0xf78/0x3b10 fs/btrfs/transaction.c:2430
 create_snapshot fs/btrfs/ioctl.c:779 [inline]
 btrfs_mksubvol+0xc75/0x12c0 fs/btrfs/ioctl.c:926
 btrfs_mksnapshot+0xab/0xf0 fs/btrfs/ioctl.c:968
 __btrfs_ioctl_snap_create+0x520/0x730 fs/btrfs/ioctl.c:1232
 btrfs_ioctl_snap_create+0x131/0x180 fs/btrfs/ioctl.c:1259
 btrfs_ioctl+0x447/0xd00 fs/btrfs/ioctl.c:-1
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:597 [inline]
 __se_sys_ioctl+0xfc/0x170 fs/ioctl.c:583
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xfa/0xf80 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f6d45b8f7c9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc63bd07b8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f6d45de5fa0 RCX: 00007f6d45b8f7c9
RDX: 0000200000001600 RSI: 0000000050009401 RDI: 0000000000000003
RBP: 00007ffc63bd0810 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000002
R13: 00007f6d45de5fa0 R14: 00007f6d45de5fa0 R15: 0000000000000003
 </TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:btrfs_create_qgroup+0x52b/0x530 fs/btrfs/qgroup.c:1690
Code: 24 08 e8 08 f4 6f 07 48 c7 c7 e0 49 d1 8b 48 c7 c6 40 4a d1 8b 31 d2 48 c7 c1 60 46 d1 8b 41 b8 9a 06 00 00 e8 e6 33 39 fd 90 <0f> 0b 0f 1f 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 f3
RSP: 0018:ffffc900029af540 EFLAGS: 00010246
RAX: 0000000000000042 RBX: 00000000fffffff4 RCX: 4c7ff4269176e000
RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000
RBP: 0000000000000100 R08: ffffc900029af267 R09: 1ffff92000535e4c
R10: dffffc0000000000 R11: fffff52000535e4d R12: dffffc0000000000
R13: 1ffff110001f1b1c R14: ffff888000f8d8e0 R15: ffff888038ab4800
FS:  000055557c30d500(0000) GS:ffff88808d22f000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000557ea737e138 CR3: 000000001fd86000 CR4: 0000000000352ef0


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

Re: [syzbot] [btrfs?] kernel BUG in btrfs_create_qgroup

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
WARNING in btrfs_space_info_update_bytes_may_use

BTRFS info (device loop0 state EA): last unmount of filesystem 395ef67a-297e-477c-816d-cd80a5b93e5d
------------[ cut here ]------------
WARNING: fs/btrfs/space-info.h:257 at btrfs_space_info_update_bytes_may_use+0x318/0x600 fs/btrfs/space-info.h:257, CPU#0: syz-executor/5765
Modules linked in:
CPU: 0 UID: 0 PID: 5765 Comm: syz-executor Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
RIP: 0010:btrfs_space_info_update_bytes_may_use+0x318/0x600 fs/btrfs/space-info.h:257
Code: 00 00 74 08 4c 89 ff e8 06 ae 32 fe 4d 8b 27 4c 89 e7 48 8b 6c 24 18 48 89 ee e8 d3 d3 ca fd 49 39 ec 73 1c e8 69 d1 ca fd 90 <0f> 0b 90 31 db 43 80 7c 35 00 00 0f 85 48 ff ff ff e9 4b ff ff ff
RSP: 0018:ffffc9000268f9d0 EFLAGS: 00010293
RAX: ffffffff83f6eee7 RBX: ffffffffffea1000 RCX: ffff888000c18000
RDX: 0000000000000000 RSI: 000000000015f000 RDI: 000000000015e000
RBP: 000000000015f000 R08: ffffffff8fa21877 R09: 1ffffffff1f4430e
R10: dffffc0000000000 R11: fffffbfff1f4430f R12: 000000000015e000
R13: 1ffff110022dc410 R14: dffffc0000000000 R15: ffff8880116e2080
FS:  0000555564980500(0000) GS:ffff88808d22f000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055556499b5c8 CR3: 0000000023114000 CR4: 0000000000352ef0
Call Trace:
 <TASK>
 btrfs_space_info_free_bytes_may_use fs/btrfs/space-info.h:294 [inline]
 block_rsv_release_bytes fs/btrfs/block-rsv.c:153 [inline]
 btrfs_block_rsv_release+0x462/0x570 fs/btrfs/block-rsv.c:290
 btrfs_release_global_block_rsv+0x33/0x270 fs/btrfs/block-rsv.c:455
 btrfs_free_block_groups+0xcbf/0xfd0 fs/btrfs/block-group.c:4579
 close_ctree+0x7bc/0x1380 fs/btrfs/disk-io.c:4410
 generic_shutdown_super+0x135/0x2c0 fs/super.c:643
 kill_anon_super+0x3b/0x70 fs/super.c:1289
 btrfs_kill_super+0x41/0x50 fs/btrfs/super.c:2129
 deactivate_locked_super+0xbc/0x130 fs/super.c:474
 cleanup_mnt+0x425/0x4c0 fs/namespace.c:1318
 task_work_run+0x1d4/0x260 kernel/task_work.c:233
 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline]
 __exit_to_user_mode_loop kernel/entry/common.c:44 [inline]
 exit_to_user_mode_loop+0xff/0x4f0 kernel/entry/common.c:75
 __exit_to_user_mode_prepare include/linux/irq-entry-common.h:226 [inline]
 syscall_exit_to_user_mode_prepare include/linux/irq-entry-common.h:256 [inline]
 syscall_exit_to_user_mode_work include/linux/entry-common.h:159 [inline]
 syscall_exit_to_user_mode include/linux/entry-common.h:194 [inline]
 do_syscall_64+0x2e3/0xf80 arch/x86/entry/syscall_64.c:100
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f1756990af7
Code: a8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 0f 1f 44 00 00 31 f6 e9 09 00 00 00 66 0f 1f 84 00 00 00 00 00 b8 a6 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 01 c3 48 c7 c2 a8 ff ff ff f7 d8 64 89 02 b8
RSP: 002b:00007ffc9d03bb88 EFLAGS: 00000246 ORIG_RAX: 00000000000000a6
RAX: 0000000000000000 RBX: 00007f1756a13d7d RCX: 00007f1756990af7
RDX: 0000000000000000 RSI: 0000000000000009 RDI: 00007ffc9d03bc40
RBP: 00007ffc9d03bc40 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000ffffffff R11: 0000000000000246 R12: 00007ffc9d03ccd0
R13: 00007f1756a13d7d R14: 00000000000277e0 R15: 00007ffc9d03cd10
 </TASK>


Tested on:

commit:         d358e525 Merge tag 'for-6.19/dm-changes' of git://git...
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=13299592580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=de48dccdf203ea90
dashboard link: https://syzkaller.appspot.com/bug?extid=803e4cb8245b52928347
compiler:       Debian clang version 20.1.8 (++20250708063551+0c9f909b7976-1~exp1~20250708183702.136), Debian LLD 20.1.8
patch:          https://syzkaller.appspot.com/x/patch.diff?x=10e4561a580000