From: Martin Doucha <mdoucha@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>,
linuxtestproject.agent@gmail.com
Cc: ltp@lists.linux.it
Subject: Re: [LTP] struct tst_fs: Add flag for checking filesystem mount support in kernel
Date: Tue, 18 Aug 2026 11:21:16 +0200 [thread overview]
Message-ID: <693d37db-950b-43d6-814d-ebfea26cfd51@suse.cz> (raw)
In-Reply-To: <6a840f0f.eb04e794.373edf.fbff@mx.google.com>
On 8/18/26 09:51, Andrea Cervesato wrote:
>> Could safe_mount() and SAFE_MOUNT2() gain kernel-doc comments that describe
>> the new check_support argument and the resulting TCONF behavior? These are
>> modified public APIs in include/ and lib/.
>
> This is actually correct, rather than adding only docs in the struct,
> it would be good to add the doc also in the function documentation.
SAFE_MOUNT2() is only used in lib/tst_test.c and LTP tests should
probably not use it at all. We have no documentation for other SAFE_*()
functions because they're sufficiently described by the relevant
manpage. The two extra parameters in SAFE_MOUNT2() should be clear enough.
--
Martin Doucha mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-08-18 9:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 12:49 [LTP] [PATCH 0/3] Add optional kernel support checks for filesystem features Martin Doucha
2026-08-14 12:49 ` [LTP] [PATCH 1/3] struct tst_fs: Add flag for checking filesystem mount support in kernel Martin Doucha
2026-08-14 13:05 ` [LTP] " linuxtestproject.agent
2026-08-18 7:51 ` Andrea Cervesato via ltp
2026-08-18 9:21 ` Martin Doucha [this message]
2026-08-18 9:35 ` [LTP] [PATCH 1/3] " Andrea Cervesato via ltp
2026-08-20 15:41 ` Petr Vorel
2026-08-14 12:49 ` [LTP] [PATCH 2/3] refluxfs: Check kernel reflink support before mount Martin Doucha
2026-08-18 9:35 ` Andrea Cervesato via ltp
2026-08-14 12:49 ` [LTP] [PATCH 3/3] file_attr02: Simplify device mounting Martin Doucha
2026-08-18 9:35 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=693d37db-950b-43d6-814d-ebfea26cfd51@suse.cz \
--to=mdoucha@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.