From: Tomasz Figa <t.figa@samsung.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
Kukjin Kim <kgene.kim@samsung.com>,
kwangwoo.lee@gmail.com, Peter Korsgaard <jacmet@sunsite.dk>,
augulis.darius@gmail.com, mcuelenaere@gmail.com,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Rob Herring <robherring2@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Thomas Abraham <thomas.abraham@linaro.org>
Subject: Re: [PATCH 2/2] pinctrl: samsung: Fix link error with CONFIG_PINCTRL_EXYNOS disabled
Date: Tue, 23 Apr 2013 14:09:46 +0200 [thread overview]
Message-ID: <6940961.67Lk2axxPL@amdc1227> (raw)
In-Reply-To: <CACRpkdbJj9Newk+sCTvJzxA4V2cmJ3hzuQELv7t1wFMhd_Y8+Q@mail.gmail.com>
Hi Linus,
On Tuesday 23 of April 2013 14:03:12 Linus Walleij wrote:
> On Wed, Apr 17, 2013 at 12:24 AM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> > Commit f67faf487 added driver data for Exynos5250, which is available
> > only if CONFIG_PINCTRL_EXYNOS is enabled. However probably due to merge
> > error, the reference to this driver data structure was located outside
> > of relevant ifdef and compiled unconditionally, leading to link error
> > with CONFIG_PINCTRL_EXYNOS.
> >
> > This patch fixes mentioned link error by moving driver data entry under
> > ifdef CONFIG_PINCTRL_EXYNOS.
> >
> > Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com>
>
> This does not apply to my "devel" branch in the pinctrl tree.
>
> Could you rebase it on that branch?
>
> Or is the error not even in my tree?
This one got sent incorrectly due to my mistake. Please try the correct
version:
[PATCH RESEND 2/2] pinctrl: samsung: Fix link error with CONFIG_PINCTRL_EXYNOS
disabled
Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Kernel and System Framework
WARNING: multiple messages have this Message-ID (diff)
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] pinctrl: samsung: Fix link error with CONFIG_PINCTRL_EXYNOS disabled
Date: Tue, 23 Apr 2013 14:09:46 +0200 [thread overview]
Message-ID: <6940961.67Lk2axxPL@amdc1227> (raw)
In-Reply-To: <CACRpkdbJj9Newk+sCTvJzxA4V2cmJ3hzuQELv7t1wFMhd_Y8+Q@mail.gmail.com>
Hi Linus,
On Tuesday 23 of April 2013 14:03:12 Linus Walleij wrote:
> On Wed, Apr 17, 2013 at 12:24 AM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> > Commit f67faf487 added driver data for Exynos5250, which is available
> > only if CONFIG_PINCTRL_EXYNOS is enabled. However probably due to merge
> > error, the reference to this driver data structure was located outside
> > of relevant ifdef and compiled unconditionally, leading to link error
> > with CONFIG_PINCTRL_EXYNOS.
> >
> > This patch fixes mentioned link error by moving driver data entry under
> > ifdef CONFIG_PINCTRL_EXYNOS.
> >
> > Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com>
>
> This does not apply to my "devel" branch in the pinctrl tree.
>
> Could you rebase it on that branch?
>
> Or is the error not even in my tree?
This one got sent incorrectly due to my mistake. Please try the correct
version:
[PATCH RESEND 2/2] pinctrl: samsung: Fix link error with CONFIG_PINCTRL_EXYNOS
disabled
Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Kernel and System Framework
next prev parent reply other threads:[~2013-04-23 12:09 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 21:14 [PATCH v5 0/6] Initial Device Tree support for S3C64xx Tomasz Figa
2013-04-15 21:14 ` Tomasz Figa
2013-04-15 21:14 ` [PATCH v5 1/6] ARM: common: vic: Parse interrupt and resume masks from device tree Tomasz Figa
2013-04-15 21:14 ` Tomasz Figa
2013-04-15 21:14 ` [PATCH v5 2/6] ARM: s3c64xx: Skip legacy EINT setup if pinctrl-s3c64xx driver is present Tomasz Figa
2013-04-15 21:14 ` Tomasz Figa
2013-04-16 16:26 ` Mark Brown
2013-04-16 16:26 ` Mark Brown
2013-04-16 22:31 ` Tomasz Figa
2013-04-16 22:31 ` Tomasz Figa
2013-04-16 22:43 ` [PATCH v6 " Tomasz Figa
2013-04-16 22:43 ` Tomasz Figa
2013-04-15 21:14 ` [PATCH v5 3/6] gpio: samsung: Skip legacy GPIO registration if pinctrl-s3c64xx " Tomasz Figa
2013-04-15 21:14 ` Tomasz Figa
2013-04-16 16:27 ` Mark Brown
2013-04-16 16:27 ` Mark Brown
2013-04-16 22:35 ` Tomasz Figa
2013-04-16 22:35 ` Tomasz Figa
2013-04-17 13:06 ` Mark Brown
2013-04-17 13:06 ` Mark Brown
2013-04-23 14:33 ` Kukjin Kim
2013-04-23 14:33 ` Kukjin Kim
2013-04-15 21:14 ` [PATCH v5 4/6] ARM: s3c64xx: Add board file for boot using Device Tree Tomasz Figa
2013-04-15 21:14 ` Tomasz Figa
2013-04-15 21:14 ` [PATCH v5 5/6] ARM: dts: Add basic dts include files for Samsung S3C64xx SoCs Tomasz Figa
2013-04-15 21:14 ` Tomasz Figa
2013-04-16 13:09 ` Rob Herring
2013-04-16 13:09 ` Rob Herring
2013-04-16 13:19 ` Tomasz Figa
2013-04-16 13:19 ` Tomasz Figa
2013-04-17 17:46 ` Rob Herring
2013-04-17 17:46 ` Rob Herring
2013-04-23 14:29 ` Kukjin Kim
2013-04-23 14:29 ` Kukjin Kim
2013-04-23 14:44 ` Tomasz Figa
2013-04-23 14:44 ` Tomasz Figa
2013-04-23 14:48 ` Kukjin Kim
2013-04-23 14:48 ` Kukjin Kim
2013-04-15 21:14 ` [PATCH v5 6/6] ARM: dts: Add dts file for S3C6410-based Mini6410 board Tomasz Figa
2013-04-15 21:14 ` Tomasz Figa
2013-04-16 16:33 ` [PATCH v5 0/6] Initial Device Tree support for S3C64xx Mark Brown
2013-04-16 16:33 ` Mark Brown
2013-04-16 22:23 ` [PATCH 1/2] pinctrl: s3c64xx: Fix build error caused by undefined chained_irq_enter Tomasz Figa
2013-04-16 22:23 ` Tomasz Figa
2013-04-16 22:24 ` [PATCH 2/2] pinctrl: samsung: Fix link error with CONFIG_PINCTRL_EXYNOS disabled Tomasz Figa
2013-04-16 22:24 ` Tomasz Figa
2013-04-23 12:03 ` Linus Walleij
2013-04-23 12:03 ` Linus Walleij
2013-04-23 12:09 ` Tomasz Figa [this message]
2013-04-23 12:09 ` Tomasz Figa
2013-04-24 14:27 ` Linus Walleij
2013-04-24 14:27 ` Linus Walleij
2013-04-24 14:47 ` Tomasz Figa
2013-04-24 14:47 ` Tomasz Figa
2013-04-25 13:26 ` Linus Walleij
2013-04-25 13:26 ` Linus Walleij
2013-04-16 22:29 ` [PATCH RESEND " Tomasz Figa
2013-04-16 22:29 ` Tomasz Figa
2013-04-23 12:00 ` [PATCH 1/2] pinctrl: s3c64xx: Fix build error caused by undefined chained_irq_enter Linus Walleij
2013-04-23 12:00 ` Linus Walleij
2013-04-17 13:08 ` [PATCH v5 0/6] Initial Device Tree support for S3C64xx Mark Brown
2013-04-17 13:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6940961.67Lk2axxPL@amdc1227 \
--to=t.figa@samsung.com \
--cc=augulis.darius@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=jacmet@sunsite.dk \
--cc=kgene.kim@samsung.com \
--cc=kwangwoo.lee@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mcuelenaere@gmail.com \
--cc=robherring2@gmail.com \
--cc=thomas.abraham@linaro.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.