[PATCH] drm/tests: Add a missing Kconfig select

[PATCH] drm/tests: Add a missing Kconfig select

[Thomas Hellström]

Fix the following warning:

WARNING: unmet direct dependencies detected for DRM_DISPLAY_HDMI_STATE_HELPER
  Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && DRM_DISPLAY_HELPER [=y] && DRM_DISPLAY_HDMI_HELPER [=n]
  Selected by [y]:
  - DRM_KUNIT_TEST [=y] && HAS_IOMEM [=y] && DRM [=y] && KUNIT [=y] && MMU [=y]

Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Fixes: 54cb39e2293b ("drm/connector: hdmi: Create an HDMI sub-state")
Cc: Maxime Ripard <mripard@kernel.org>
Cc: dri-devel@lists.freedesktop.org
---
 drivers/gpu/drm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 9703429de6b9..47592b6fc868 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -79,6 +79,7 @@ config DRM_KUNIT_TEST
 	depends on DRM && KUNIT && MMU
 	select DRM_BUDDY
 	select DRM_DISPLAY_DP_HELPER
+	select DRM_DISPLAY_HDMI_HELPER
 	select DRM_DISPLAY_HDMI_STATE_HELPER
 	select DRM_DISPLAY_HELPER
 	select DRM_EXEC
-- 
2.44.0

Re: drm/tests: Add a missing Kconfig select

[Sui Jingfeng]

Hi,

On 5/29/24 17:19, Thomas Hellström wrote:
> Fix the following warning:
> 
> WARNING: unmet direct dependencies detected for DRM_DISPLAY_HDMI_STATE_HELPER
>    Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && DRM_DISPLAY_HELPER [=y] && DRM_DISPLAY_HDMI_HELPER [=n]
>    Selected by [y]:
>    - DRM_KUNIT_TEST [=y] && HAS_IOMEM [=y] && DRM [=y] && KUNIT [=y] && MMU [=y]
> 
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Fixes: 54cb39e2293b ("drm/connector: hdmi: Create an HDMI sub-state")
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: dri-devel@lists.freedesktop.org

Acked-by: Sui Jingfeng <sui.jingfeng@linux.dev>

Re: [PATCH] drm/tests: Add a missing Kconfig select

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

Hi,

Thanks for sending that patch

On Wed, May 29, 2024 at 11:19:55AM GMT, Thomas Hellström wrote:
> Fix the following warning:
> 
> WARNING: unmet direct dependencies detected for DRM_DISPLAY_HDMI_STATE_HELPER
>   Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && DRM_DISPLAY_HELPER [=y] && DRM_DISPLAY_HDMI_HELPER [=n]
>   Selected by [y]:
>   - DRM_KUNIT_TEST [=y] && HAS_IOMEM [=y] && DRM [=y] && KUNIT [=y] && MMU [=y]
> 
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Fixes: 54cb39e2293b ("drm/connector: hdmi: Create an HDMI sub-state")
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: dri-devel@lists.freedesktop.org

I already sent a fix for that one, and just merged it:
https://lore.kernel.org/r/20240529080013.2325748-1-mripard@kernel.org

Let me know if it doesn't fix it for you

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]

Re: [PATCH] drm/tests: Add a missing Kconfig select

[Thomas Hellström]

On Wed, 2024-05-29 at 11:40 +0200, Maxime Ripard wrote:
> Hi,
> 
> Thanks for sending that patch
> 
> On Wed, May 29, 2024 at 11:19:55AM GMT, Thomas Hellström wrote:
> > Fix the following warning:
> > 
> > WARNING: unmet direct dependencies detected for
> > DRM_DISPLAY_HDMI_STATE_HELPER
> >   Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && DRM_DISPLAY_HELPER
> > [=y] && DRM_DISPLAY_HDMI_HELPER [=n]
> >   Selected by [y]:
> >   - DRM_KUNIT_TEST [=y] && HAS_IOMEM [=y] && DRM [=y] && KUNIT [=y]
> > && MMU [=y]
> > 
> > Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> > Fixes: 54cb39e2293b ("drm/connector: hdmi: Create an HDMI sub-
> > state")
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: dri-devel@lists.freedesktop.org
> 
> I already sent a fix for that one, and just merged it:
> https://lore.kernel.org/r/20240529080013.2325748-1-mripard@kernel.org
> 
> Let me know if it doesn't fix it for you
> 
> Maxime

Ah, great. It blocked the xe CI but this should hopefully fix it.

Thanks,
Thomas