From: Wei Xu <xuwei5@hisilicon.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: hisilicon: poplar: Correct PCIe reset GPIO polarity
Date: Sat, 21 Mar 2026 14:51:20 +0800 [thread overview]
Message-ID: <69BE3FE8.9080109@hisilicon.com> (raw)
In-Reply-To: <20260227071958.1350024-1-shawnguo@kernel.org>
Hi Shawn,
On 2026/2/27 15:19, Shawn Guo wrote:
> The PCIe reset GPIO on Poplar is actually active low. The active high
> worked before because kernel driver didn't respect the setting from DT.
> This is changed since commit 1d26a55fbeb9 ("PCI: histb: Switch to using
> gpiod API"), and thus PCIe on Poplar got brken since then.
>
> Fix the problem by correcting the polarity.
>
> Fixes: 32fa01761bd9 ("arm64: dts: hi3798cv200: enable PCIe support for poplar board")
> Cc: stable@vger.kernel.org
> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> ---
> arch/arm64/boot/dts/hisilicon/hi3798cv200-poplar.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3798cv200-poplar.dts b/arch/arm64/boot/dts/hisilicon/hi3798cv200-poplar.dts
> index 7d370dac4c85..579d55daa7d0 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3798cv200-poplar.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi3798cv200-poplar.dts
> @@ -179,7 +179,7 @@ &ohci {
> };
>
> &pcie {
> - reset-gpios = <&gpio4 4 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio4 4 GPIO_ACTIVE_LOW>;
> vpcie-supply = <®_pcie>;
> status = "okay";
> };
>
Applied to the HiSilicon arm64 dt tree.
Thanks!
Best Regards,
Wei
prev parent reply other threads:[~2026-03-21 6:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 7:19 [PATCH] arm64: dts: hisilicon: poplar: Correct PCIe reset GPIO polarity Shawn Guo
2026-03-21 6:51 ` Wei Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69BE3FE8.9080109@hisilicon.com \
--to=xuwei5@hisilicon.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.