* [PATCH] arm64: dts: hisilicon: poplar: Correct PCIe reset GPIO polarity
@ 2026-02-27 7:19 Shawn Guo
2026-03-21 6:51 ` Wei Xu
0 siblings, 1 reply; 2+ messages in thread
From: Shawn Guo @ 2026-02-27 7:19 UTC (permalink / raw)
To: Wei Xu; +Cc: linux-arm-kernel, devicetree, linux-kernel, Shawn Guo, stable
The PCIe reset GPIO on Poplar is actually active low. The active high
worked before because kernel driver didn't respect the setting from DT.
This is changed since commit 1d26a55fbeb9 ("PCI: histb: Switch to using
gpiod API"), and thus PCIe on Poplar got brken since then.
Fix the problem by correcting the polarity.
Fixes: 32fa01761bd9 ("arm64: dts: hi3798cv200: enable PCIe support for poplar board")
Cc: stable@vger.kernel.org
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
---
arch/arm64/boot/dts/hisilicon/hi3798cv200-poplar.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3798cv200-poplar.dts b/arch/arm64/boot/dts/hisilicon/hi3798cv200-poplar.dts
index 7d370dac4c85..579d55daa7d0 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3798cv200-poplar.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi3798cv200-poplar.dts
@@ -179,7 +179,7 @@ &ohci {
};
&pcie {
- reset-gpios = <&gpio4 4 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&gpio4 4 GPIO_ACTIVE_LOW>;
vpcie-supply = <®_pcie>;
status = "okay";
};
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] arm64: dts: hisilicon: poplar: Correct PCIe reset GPIO polarity
2026-02-27 7:19 [PATCH] arm64: dts: hisilicon: poplar: Correct PCIe reset GPIO polarity Shawn Guo
@ 2026-03-21 6:51 ` Wei Xu
0 siblings, 0 replies; 2+ messages in thread
From: Wei Xu @ 2026-03-21 6:51 UTC (permalink / raw)
To: Shawn Guo; +Cc: linux-arm-kernel, devicetree, linux-kernel, stable
Hi Shawn,
On 2026/2/27 15:19, Shawn Guo wrote:
> The PCIe reset GPIO on Poplar is actually active low. The active high
> worked before because kernel driver didn't respect the setting from DT.
> This is changed since commit 1d26a55fbeb9 ("PCI: histb: Switch to using
> gpiod API"), and thus PCIe on Poplar got brken since then.
>
> Fix the problem by correcting the polarity.
>
> Fixes: 32fa01761bd9 ("arm64: dts: hi3798cv200: enable PCIe support for poplar board")
> Cc: stable@vger.kernel.org
> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> ---
> arch/arm64/boot/dts/hisilicon/hi3798cv200-poplar.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3798cv200-poplar.dts b/arch/arm64/boot/dts/hisilicon/hi3798cv200-poplar.dts
> index 7d370dac4c85..579d55daa7d0 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3798cv200-poplar.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi3798cv200-poplar.dts
> @@ -179,7 +179,7 @@ &ohci {
> };
>
> &pcie {
> - reset-gpios = <&gpio4 4 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio4 4 GPIO_ACTIVE_LOW>;
> vpcie-supply = <®_pcie>;
> status = "okay";
> };
>
Applied to the HiSilicon arm64 dt tree.
Thanks!
Best Regards,
Wei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-21 6:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-27 7:19 [PATCH] arm64: dts: hisilicon: poplar: Correct PCIe reset GPIO polarity Shawn Guo
2026-03-21 6:51 ` Wei Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.