* Forwarded: [PATCH] usb: core: fix memory leak in usb_new_device() error path
2026-04-25 2:12 [syzbot] [usb?] memory leak in hub_event (4) syzbot
@ 2026-04-25 6:36 ` syzbot
2026-04-25 7:52 ` Forwarded: [PATCH] ALSA: caiaq: fix usb_dev refcount leak on probe failure syzbot
` (7 subsequent siblings)
8 siblings, 0 replies; 29+ messages in thread
From: syzbot @ 2026-04-25 6:36 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: [PATCH] usb: core: fix memory leak in usb_new_device() error path
Author: kartikey406@gmail.com
#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
When usb_new_device() fails, it jumps to the 'fail' label which calls
pm_runtime_disable() but never balances the earlier
pm_runtime_get_noresume() call made at the top of the function.
This leaves the PM runtime usage count elevated, preventing
usb_put_dev() in hub_port_connect() from dropping the refcount to zero.
As a result, usb_release_dev() never fires and usb_destroy_configuration()
is never called, leaking all memory allocated during enumeration:
- struct usb_device (2048 bytes) via usb_alloc_dev()
- raw config descriptor (1024 bytes) via usb_get_configuration()
- config metadata ( 8 bytes) via usb_get_configuration()
- interface descriptor ( 64 bytes) via usb_parse_configuration()
- struct device_private ( 256 bytes) via device_private_init()
Fix this by adding pm_runtime_put_noidle() on the fail path to balance
the pm_runtime_get_noresume() at the top of the function.
pm_runtime_put_noidle() is correct here rather than pm_runtime_put()
because we are in a teardown path and must not trigger autosuspend
scheduling.
Reported-by: syzbot+2afd7e71155c7e241560@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=2afd7e71155c7e241560
Signed-off-by: Deepanshu kartikey <kartikey406@gmail.com>
---
drivers/usb/core/hub.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 24960ba9caa9..148fadfbc30b 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -2733,6 +2733,7 @@ int usb_new_device(struct usb_device *udev)
usb_set_device_state(udev, USB_STATE_NOTATTACHED);
pm_runtime_disable(&udev->dev);
pm_runtime_set_suspended(&udev->dev);
+ pm_runtime_put_noidle(&udev->dev);
return err;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Forwarded: [PATCH] ALSA: caiaq: fix usb_dev refcount leak on probe failure
2026-04-25 2:12 [syzbot] [usb?] memory leak in hub_event (4) syzbot
2026-04-25 6:36 ` Forwarded: [PATCH] usb: core: fix memory leak in usb_new_device() error path syzbot
@ 2026-04-25 7:52 ` syzbot
2026-04-25 8:58 ` Forwarded: [PATCH] usb: core: hub: fix memory leak in hub_port_connect syzbot
` (6 subsequent siblings)
8 siblings, 0 replies; 29+ messages in thread
From: syzbot @ 2026-04-25 7:52 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: [PATCH] ALSA: caiaq: fix usb_dev refcount leak on probe failure
Author: kartikey406@gmail.com
#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
create_card() takes a reference on the USB device with usb_get_dev()
and stores the matching usb_put_dev() in card_free(), which is
installed as the snd_card's ->private_free destructor.
However, ->private_free is only assigned near the end of init_card(),
after several failure points (usb_set_interface(), EP type checks,
usb_submit_urb(), the EP1_CMD_GET_DEVICE_INFO exchange, and its
timeout). When any of those fail, init_card() returns an error to
snd_probe(), which calls snd_card_free(card). Because ->private_free
is still NULL, card_free() never runs, the usb_get_dev() reference
is not dropped, and the struct usb_device leaks along with its
descriptor allocations and device_private.
syzbot reproduces this with a malformed UAC3 device whose only valid
altsetting is 0; init_card()'s usb_set_interface(usb_dev, 0, 1) call
fails with -EIO and triggers the leak.
Move the ->private_free assignment into create_card(), immediately
after usb_get_dev(), so that every error path reaching snd_card_free()
balances the reference. card_free()'s callees (snd_usb_caiaq_input_free,
free_urbs, kfree) already tolerate the partially-initialized state
because the chip private area is zero-initialized by snd_card_new().
Reported-by: syzbot+2afd7e71155c7e241560@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=2afd7e71155c7e241560
Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>
---
sound/usb/caiaq/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/usb/caiaq/device.c b/sound/usb/caiaq/device.c
index 51177ebfb8c6..f084a0f782ad 100644
--- a/sound/usb/caiaq/device.c
+++ b/sound/usb/caiaq/device.c
@@ -411,6 +411,7 @@ static int create_card(struct usb_device *usb_dev,
cdev = caiaqdev(card);
cdev->chip.dev = usb_get_dev(usb_dev);
+ card->private_free = card_free;
cdev->chip.card = card;
cdev->chip.usb_id = USB_ID(le16_to_cpu(usb_dev->descriptor.idVendor),
le16_to_cpu(usb_dev->descriptor.idProduct));
@@ -500,7 +501,6 @@ static int init_card(struct snd_usb_caiaqdev *cdev)
cdev->vendor_name, cdev->product_name, usbpath);
setup_card(cdev);
- card->private_free = card_free;
return 0;
err_kill_urb:
--
2.43.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Forwarded: [PATCH] usb: core: hub: fix memory leak in hub_port_connect
2026-04-25 2:12 [syzbot] [usb?] memory leak in hub_event (4) syzbot
2026-04-25 6:36 ` Forwarded: [PATCH] usb: core: fix memory leak in usb_new_device() error path syzbot
2026-04-25 7:52 ` Forwarded: [PATCH] ALSA: caiaq: fix usb_dev refcount leak on probe failure syzbot
@ 2026-04-25 8:58 ` syzbot
2026-04-25 9:36 ` syzbot
` (5 subsequent siblings)
8 siblings, 0 replies; 29+ messages in thread
From: syzbot @ 2026-04-25 8:58 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: [PATCH] usb: core: hub: fix memory leak in hub_port_connect
Author: souradiptodas6@gmail.com
#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 24960ba9caa9..2924ce770066 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -5405,6 +5405,7 @@ static void hub_port_connect(struct usb_hub *hub, int
port1, u16 portstatus,
if (hcd->usb_phy && !hdev->parent)
usb_phy_notify_disconnect(hcd->usb_phy,
udev->speed);
usb_disconnect(&port_dev->child);
+ udev = NULL;
}
/* We can forget about a "removed" device when there's a physical
@@ -5582,6 +5583,7 @@ static void hub_port_connect(struct usb_hub *hub, int
port1, u16 portstatus,
goto loop_disable;
status = hub_power_remaining(hub);
+ udev = NULL;
if (status)
dev_dbg(hub->intfdev, "%dmA power budget left\n",
status);
@@ -5624,6 +5626,8 @@ static void hub_port_connect(struct usb_hub *hub, int
port1, u16 portstatus,
if (status != -ENOTCONN && status != -ENODEV)
hcd->driver->relinquish_port(hcd, port1);
}
+ if (udev)
+ usb_put_dev(udev);
}
/* Handle physical or logical connection change events.
^ permalink raw reply related [flat|nested] 29+ messages in thread* Forwarded: [PATCH] usb: core: hub: fix memory leak in hub_port_connect
2026-04-25 2:12 [syzbot] [usb?] memory leak in hub_event (4) syzbot
` (2 preceding siblings ...)
2026-04-25 8:58 ` Forwarded: [PATCH] usb: core: hub: fix memory leak in hub_port_connect syzbot
@ 2026-04-25 9:36 ` syzbot
2026-04-25 12:54 ` Forwarded: [PATCH] ALSA: caiaq: fix usb_dev refcount leak on probe failure syzbot
` (4 subsequent siblings)
8 siblings, 0 replies; 29+ messages in thread
From: syzbot @ 2026-04-25 9:36 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: [PATCH] usb: core: hub: fix memory leak in hub_port_connect
Author: souradiptodas6@gmail.com
#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
---
drivers/usb/core/hub.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 24960ba9caa9..2924ce770066 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -5405,6 +5405,7 @@ static void hub_port_connect(struct usb_hub *hub, int port1, u16 portstatus,
if (hcd->usb_phy && !hdev->parent)
usb_phy_notify_disconnect(hcd->usb_phy, udev->speed);
usb_disconnect(&port_dev->child);
+ udev = NULL;
}
/* We can forget about a "removed" device when there's a physical
@@ -5582,6 +5583,7 @@ static void hub_port_connect(struct usb_hub *hub, int port1, u16 portstatus,
goto loop_disable;
status = hub_power_remaining(hub);
+ udev = NULL;
if (status)
dev_dbg(hub->intfdev, "%dmA power budget left\n", status);
@@ -5624,6 +5626,8 @@ static void hub_port_connect(struct usb_hub *hub, int port1, u16 portstatus,
if (status != -ENOTCONN && status != -ENODEV)
hcd->driver->relinquish_port(hcd, port1);
}
+ if (udev)
+ usb_put_dev(udev);
}
/* Handle physical or logical connection change events.
--
2.52.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Forwarded: [PATCH] ALSA: caiaq: fix usb_dev refcount leak on probe failure
2026-04-25 2:12 [syzbot] [usb?] memory leak in hub_event (4) syzbot
` (3 preceding siblings ...)
2026-04-25 9:36 ` syzbot
@ 2026-04-25 12:54 ` syzbot
2026-04-25 14:43 ` syzbot
` (3 subsequent siblings)
8 siblings, 0 replies; 29+ messages in thread
From: syzbot @ 2026-04-25 12:54 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: [PATCH] ALSA: caiaq: fix usb_dev refcount leak on probe failure
Author: kartikey406@gmail.com
#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
create_card() takes a reference on the USB device with usb_get_dev()
and stores the matching usb_put_dev() in card_free(), which is
installed as the snd_card's ->private_free destructor.
However, ->private_free is only assigned near the end of init_card(),
after several failure points (usb_set_interface(), EP type checks,
usb_submit_urb(), the EP1_CMD_GET_DEVICE_INFO exchange, and its
timeout). When any of those fail, init_card() returns an error to
snd_probe(), which calls snd_card_free(card). Because ->private_free
is still NULL, card_free() never runs, the usb_get_dev() reference
is not dropped, and the struct usb_device leaks along with its
descriptor allocations and device_private.
syzbot reproduces this with a malformed UAC3 device whose only valid
altsetting is 0; init_card()'s usb_set_interface(usb_dev, 0, 1) call
fails with -EIO and triggers the leak.
Move the ->private_free assignment into create_card(), immediately
after usb_get_dev(), so that every error path reaching snd_card_free()
balances the reference. card_free()'s callees (snd_usb_caiaq_input_free,
free_urbs, kfree) already tolerate the partially-initialized state
because the chip private area is zero-initialized by snd_card_new().
Reported-by: syzbot+2afd7e71155c7e241560@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=2afd7e71155c7e241560
Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>
---
sound/usb/caiaq/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/usb/caiaq/device.c b/sound/usb/caiaq/device.c
index 51177ebfb8c6..f084a0f782ad 100644
--- a/sound/usb/caiaq/device.c
+++ b/sound/usb/caiaq/device.c
@@ -411,6 +411,7 @@ static int create_card(struct usb_device *usb_dev,
cdev = caiaqdev(card);
cdev->chip.dev = usb_get_dev(usb_dev);
+ card->private_free = card_free;
cdev->chip.card = card;
cdev->chip.usb_id = USB_ID(le16_to_cpu(usb_dev->descriptor.idVendor),
le16_to_cpu(usb_dev->descriptor.idProduct));
@@ -500,7 +501,6 @@ static int init_card(struct snd_usb_caiaqdev *cdev)
cdev->vendor_name, cdev->product_name, usbpath);
setup_card(cdev);
- card->private_free = card_free;
return 0;
err_kill_urb:
--
2.43.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Forwarded: [PATCH] ALSA: caiaq: fix usb_dev refcount leak on probe failure
2026-04-25 2:12 [syzbot] [usb?] memory leak in hub_event (4) syzbot
` (4 preceding siblings ...)
2026-04-25 12:54 ` Forwarded: [PATCH] ALSA: caiaq: fix usb_dev refcount leak on probe failure syzbot
@ 2026-04-25 14:43 ` syzbot
2026-04-26 2:33 ` Hillf Danton
2026-04-27 11:40 ` [syzbot] [usb?] memory leak in hub_event (4) Oliver Neukum
` (2 subsequent siblings)
8 siblings, 1 reply; 29+ messages in thread
From: syzbot @ 2026-04-25 14:43 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: [PATCH] ALSA: caiaq: fix usb_dev refcount leak on probe failure
Author: kartikey406@gmail.com
#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
create_card() takes a reference on the USB device with usb_get_dev()
and stores the matching usb_put_dev() in card_free(), which is
installed as the snd_card's ->private_free destructor.
However, ->private_free is only assigned near the end of init_card(),
after several failure points (usb_set_interface(), EP type checks,
usb_submit_urb(), the EP1_CMD_GET_DEVICE_INFO exchange, and its
timeout). When any of those fail, init_card() returns an error to
snd_probe(), which calls snd_card_free(card). Because ->private_free
is still NULL, card_free() never runs, the usb_get_dev() reference
is not dropped, and the struct usb_device leaks along with its
descriptor allocations and device_private.
syzbot reproduces this with a malformed UAC3 device whose only valid
altsetting is 0; init_card()'s usb_set_interface(usb_dev, 0, 1) call
fails with -EIO and triggers the leak.
Move the ->private_free assignment into create_card(), immediately
after usb_get_dev(), so that every error path reaching snd_card_free()
balances the reference. card_free()'s callees (snd_usb_caiaq_input_free,
free_urbs, kfree) already tolerate the partially-initialized state
because the chip private area is zero-initialized by snd_card_new().
Reported-by: syzbot+2afd7e71155c7e241560@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=2afd7e71155c7e241560
Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>
---
sound/usb/caiaq/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/usb/caiaq/device.c b/sound/usb/caiaq/device.c
index 8af0c04041ee..ad9f744b496b 100644
--- a/sound/usb/caiaq/device.c
+++ b/sound/usb/caiaq/device.c
@@ -423,6 +423,7 @@ static int create_card(struct usb_device *usb_dev,
cdev = caiaqdev(card);
cdev->chip.dev = usb_get_dev(usb_dev);
+ card->private_free = card_free;
cdev->chip.card = card;
cdev->chip.usb_id = USB_ID(le16_to_cpu(usb_dev->descriptor.idVendor),
le16_to_cpu(usb_dev->descriptor.idProduct));
@@ -511,7 +512,6 @@ static int init_card(struct snd_usb_caiaqdev *cdev)
scnprintf(card->longname, sizeof(card->longname), "%s %s (%s)",
cdev->vendor_name, cdev->product_name, usbpath);
- card->private_free = card_free;
err = setup_card(cdev);
if (err < 0)
return err;
--
2.43.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: Forwarded: [PATCH] ALSA: caiaq: fix usb_dev refcount leak on probe failure
2026-04-25 14:43 ` syzbot
@ 2026-04-26 2:33 ` Hillf Danton
0 siblings, 0 replies; 29+ messages in thread
From: Hillf Danton @ 2026-04-26 2:33 UTC (permalink / raw)
To: Deepanshu Kartikey; +Cc: syzbot, linux-kernel, syzkaller-bugs
> Date: Sat, 25 Apr 2026 07:43:17 -0700
> For archival purposes, forwarding an incoming command email to
> linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
>
> ***
>
> Subject: [PATCH] ALSA: caiaq: fix usb_dev refcount leak on probe failure
> Author: kartikey406@gmail.com
>
Deepanshu, can you please correctly fill your Cc list as required to
avoid this forwarded message which is a waste of net bandwidth?
> #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>
>
>
> create_card() takes a reference on the USB device with usb_get_dev()
> and stores the matching usb_put_dev() in card_free(), which is
> installed as the snd_card's ->private_free destructor.
>
> However, ->private_free is only assigned near the end of init_card(),
> after several failure points (usb_set_interface(), EP type checks,
> usb_submit_urb(), the EP1_CMD_GET_DEVICE_INFO exchange, and its
> timeout). When any of those fail, init_card() returns an error to
> snd_probe(), which calls snd_card_free(card). Because ->private_free
> is still NULL, card_free() never runs, the usb_get_dev() reference
> is not dropped, and the struct usb_device leaks along with its
> descriptor allocations and device_private.
>
> syzbot reproduces this with a malformed UAC3 device whose only valid
> altsetting is 0; init_card()'s usb_set_interface(usb_dev, 0, 1) call
> fails with -EIO and triggers the leak.
>
> Move the ->private_free assignment into create_card(), immediately
> after usb_get_dev(), so that every error path reaching snd_card_free()
> balances the reference. card_free()'s callees (snd_usb_caiaq_input_free,
> free_urbs, kfree) already tolerate the partially-initialized state
> because the chip private area is zero-initialized by snd_card_new().
>
> Reported-by: syzbot+2afd7e71155c7e241560@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=2afd7e71155c7e241560
> Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>
> ---
> sound/usb/caiaq/device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/usb/caiaq/device.c b/sound/usb/caiaq/device.c
> index 8af0c04041ee..ad9f744b496b 100644
> --- a/sound/usb/caiaq/device.c
> +++ b/sound/usb/caiaq/device.c
> @@ -423,6 +423,7 @@ static int create_card(struct usb_device *usb_dev,
>
> cdev = caiaqdev(card);
> cdev->chip.dev = usb_get_dev(usb_dev);
> + card->private_free = card_free;
> cdev->chip.card = card;
> cdev->chip.usb_id = USB_ID(le16_to_cpu(usb_dev->descriptor.idVendor),
> le16_to_cpu(usb_dev->descriptor.idProduct));
> @@ -511,7 +512,6 @@ static int init_card(struct snd_usb_caiaqdev *cdev)
> scnprintf(card->longname, sizeof(card->longname), "%s %s (%s)",
> cdev->vendor_name, cdev->product_name, usbpath);
>
> - card->private_free = card_free;
> err = setup_card(cdev);
> if (err < 0)
> return err;
> --
> 2.43.0
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [syzbot] [usb?] memory leak in hub_event (4)
2026-04-25 2:12 [syzbot] [usb?] memory leak in hub_event (4) syzbot
` (5 preceding siblings ...)
2026-04-25 14:43 ` syzbot
@ 2026-04-27 11:40 ` Oliver Neukum
2026-04-27 12:37 ` syzbot
2026-04-27 14:19 ` Alan Stern
2026-04-29 10:42 ` [PATCH] usb: core: hcd: fix possible deadlock in rh control transfers Oliver Neukum
2026-04-29 10:45 ` [PATCH] sound: usb: caiaq: fix reference leak in probe error Oliver Neukum
8 siblings, 2 replies; 29+ messages in thread
From: Oliver Neukum @ 2026-04-27 11:40 UTC (permalink / raw)
To: syzbot, gregkh, linux-kernel, linux-usb, syzkaller-bugs
[-- Attachment #1: Type: text/plain, Size: 81 bytes --]
On 25.04.26 04:12, syzbot wrote:
#syz test: git://repo/address.git dd6c438c3e64
[-- Attachment #2: 0001-usb-core-fix-memory-of-error-case-in-usb_get_configu.patch --]
[-- Type: text/x-patch, Size: 1527 bytes --]
From 001175f4d2e1c2ceac98b4af2521fc4d0253d0c8 Mon Sep 17 00:00:00 2001
From: Oliver Neukum <oneukum@suse.com>
Date: Mon, 27 Apr 2026 13:35:38 +0200
Subject: [PATCH] usb: core: fix memory of error case in usb_get_configuration
Prior allocations need to be reversed if subsequent
allocations fail.
Fixes: dd2057e544dc9 ("USB: core: drop OOM message")
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Reported-by: syzbot+2afd7e71155c7e241560@syzkaller.appspotmail.com
---
drivers/usb/core/config.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
index 417140b012bb..67475ff81641 100644
--- a/drivers/usb/core/config.c
+++ b/drivers/usb/core/config.c
@@ -944,11 +944,11 @@ int usb_get_configuration(struct usb_device *dev)
length = ncfg * sizeof(char *);
dev->rawdescriptors = kzalloc(length, GFP_KERNEL);
if (!dev->rawdescriptors)
- return -ENOMEM;
+ goto bailout2;
desc = kmalloc(USB_DT_CONFIG_SIZE, GFP_KERNEL);
if (!desc)
- return -ENOMEM;
+ goto bailout;
for (cfgno = 0; cfgno < ncfg; cfgno++) {
/* We grab just the first descriptor so we know how long
@@ -1012,6 +1012,15 @@ int usb_get_configuration(struct usb_device *dev)
dev->descriptor.bNumConfigurations = cfgno;
return result;
+
+bailout:
+ kfree(dev->rawdescriptors);
+ dev->rawdescriptors = NULL;
+bailout2:
+ kfree(dev->config);
+ dev->config = NULL;
+
+ return -ENOMEM;
}
void usb_release_bos_descriptor(struct usb_device *dev)
--
2.54.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: [syzbot] [usb?] memory leak in hub_event (4)
2026-04-27 11:40 ` [syzbot] [usb?] memory leak in hub_event (4) Oliver Neukum
@ 2026-04-27 12:37 ` syzbot
2026-04-27 14:19 ` Alan Stern
1 sibling, 0 replies; 29+ messages in thread
From: syzbot @ 2026-04-27 12:37 UTC (permalink / raw)
To: gregkh, linux-kernel, linux-usb, oneukum, syzkaller-bugs
Hello,
syzbot tried to test the proposed patch but the build/boot failed:
failed to checkout kernel repo git://repo/address.git on commit dd6c438c3e64: failed to run ["git" "fetch" "--force" "--tags" "b7cf8f2fbfc36c709a08e0b9c77990e491473738"]: exit status 128
Tested on:
commit: [unknown
git tree: git://repo/address.git dd6c438c3e64
kernel config: https://syzkaller.appspot.com/x/.config?x=ac5083db84233db3
dashboard link: https://syzkaller.appspot.com/bug?extid=2afd7e71155c7e241560
compiler:
patch: https://syzkaller.appspot.com/x/patch.diff?x=1575b236580000
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [syzbot] [usb?] memory leak in hub_event (4)
2026-04-27 11:40 ` [syzbot] [usb?] memory leak in hub_event (4) Oliver Neukum
2026-04-27 12:37 ` syzbot
@ 2026-04-27 14:19 ` Alan Stern
2026-04-28 11:33 ` Oliver Neukum
1 sibling, 1 reply; 29+ messages in thread
From: Alan Stern @ 2026-04-27 14:19 UTC (permalink / raw)
To: Oliver Neukum; +Cc: syzbot, gregkh, linux-kernel, linux-usb, syzkaller-bugs
On Mon, Apr 27, 2026 at 01:40:02PM +0200, Oliver Neukum wrote:
> On 25.04.26 04:12, syzbot wrote:
>
> #syz test: git://repo/address.git dd6c438c3e64
> From 001175f4d2e1c2ceac98b4af2521fc4d0253d0c8 Mon Sep 17 00:00:00 2001
> From: Oliver Neukum <oneukum@suse.com>
> Date: Mon, 27 Apr 2026 13:35:38 +0200
> Subject: [PATCH] usb: core: fix memory of error case in usb_get_configuration
>
> Prior allocations need to be reversed if subsequent
> allocations fail.
>
> Fixes: dd2057e544dc9 ("USB: core: drop OOM message")
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> Reported-by: syzbot+2afd7e71155c7e241560@syzkaller.appspotmail.com
> ---
> drivers/usb/core/config.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
> index 417140b012bb..67475ff81641 100644
> --- a/drivers/usb/core/config.c
> +++ b/drivers/usb/core/config.c
> @@ -944,11 +944,11 @@ int usb_get_configuration(struct usb_device *dev)
> length = ncfg * sizeof(char *);
> dev->rawdescriptors = kzalloc(length, GFP_KERNEL);
> if (!dev->rawdescriptors)
> - return -ENOMEM;
> + goto bailout2;
>
> desc = kmalloc(USB_DT_CONFIG_SIZE, GFP_KERNEL);
> if (!desc)
> - return -ENOMEM;
> + goto bailout;
>
> for (cfgno = 0; cfgno < ncfg; cfgno++) {
> /* We grab just the first descriptor so we know how long
> @@ -1012,6 +1012,15 @@ int usb_get_configuration(struct usb_device *dev)
> dev->descriptor.bNumConfigurations = cfgno;
>
> return result;
> +
> +bailout:
> + kfree(dev->rawdescriptors);
> + dev->rawdescriptors = NULL;
> +bailout2:
> + kfree(dev->config);
> + dev->config = NULL;
> +
> + return -ENOMEM;
> }
This is not needed. dev->rawdescriptors and dev->config are deallocated
in usb_destroy_configuration(), which gets called when the usb_device
structure is released.
The memory leak must have a different cause.
Alan Stern
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [syzbot] [usb?] memory leak in hub_event (4)
2026-04-27 14:19 ` Alan Stern
@ 2026-04-28 11:33 ` Oliver Neukum
2026-04-28 15:12 ` Alan Stern
0 siblings, 1 reply; 29+ messages in thread
From: Oliver Neukum @ 2026-04-28 11:33 UTC (permalink / raw)
To: Alan Stern; +Cc: syzbot, gregkh, linux-kernel, linux-usb, syzkaller-bugs
On 27.04.26 16:19, Alan Stern wrote:
> This is not needed. dev->rawdescriptors and dev->config are deallocated
> in usb_destroy_configuration(), which gets called when the usb_device
> structure is released.
>
> The memory leak must have a different cause.
You are correct. Yet I can see no way for usb_destroy_configuration()
to not run. Hence we must be overlooking something.
Regards
Oliver
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [syzbot] [usb?] memory leak in hub_event (4)
2026-04-28 11:33 ` Oliver Neukum
@ 2026-04-28 15:12 ` Alan Stern
0 siblings, 0 replies; 29+ messages in thread
From: Alan Stern @ 2026-04-28 15:12 UTC (permalink / raw)
To: Oliver Neukum; +Cc: syzbot, gregkh, linux-kernel, linux-usb, syzkaller-bugs
On Tue, Apr 28, 2026 at 01:33:20PM +0200, Oliver Neukum wrote:
>
>
> On 27.04.26 16:19, Alan Stern wrote:
> > This is not needed. dev->rawdescriptors and dev->config are deallocated
> > in usb_destroy_configuration(), which gets called when the usb_device
> > structure is released.
> >
> > The memory leak must have a different cause.
>
> You are correct. Yet I can see no way for usb_destroy_configuration()
> to not run. Hence we must be overlooking something.
Maybe the usb_device structures are not being released at all. For
instance, the snd_usb_audio or snd_usb_caiaq driver may forget to drop a
reference in an error pathway.
It seems odd that the bug report says there are 5 suspected memory leaks
right after 5 devices have disconnected, yet the tracebacks are for
different size allocations, implying that they all refer to the same
device (i.e., not the same allocation for each of the 5 devices). But
it could just be a coincidence.
Alan Stern
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH] usb: core: hcd: fix possible deadlock in rh control transfers
2026-04-25 2:12 [syzbot] [usb?] memory leak in hub_event (4) syzbot
` (6 preceding siblings ...)
2026-04-27 11:40 ` [syzbot] [usb?] memory leak in hub_event (4) Oliver Neukum
@ 2026-04-29 10:42 ` Oliver Neukum
2026-04-29 19:04 ` Alan Stern
2026-04-29 10:45 ` [PATCH] sound: usb: caiaq: fix reference leak in probe error Oliver Neukum
8 siblings, 1 reply; 29+ messages in thread
From: Oliver Neukum @ 2026-04-29 10:42 UTC (permalink / raw)
To: syzbot+2afd7e71155c7e241560; +Cc: linux-usb, tiwai, Oliver Neukum
From within the SCSI error handler memory allocations must not
trigger IO. Handling errors in UAS and the storage driver may
involve resetting a device. The thread doing the reset itself
relies on VM magic. However, that is insufficient, as resetting
a device involves resuming it. Resumption as well as resetting
involves conrol transfers to the parent of the device to be reset.
That may be a root hub. Hence usbcore must heed the flags passed
to usb_submit_urb() processing control transfers to root hubs.
The problem exist since the storage driver has been merged.
Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
drivers/usb/core/hcd.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 89221f1ce769..29c74ed40526 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -448,7 +448,8 @@ rh_string(int id, struct usb_hcd const *hcd, u8 *data, unsigned len)
/* Root hub control transfers execute synchronously */
-static int rh_call_control (struct usb_hcd *hcd, struct urb *urb)
+static int rh_call_control(struct usb_hcd *hcd,
+ struct urb *urb, gfp_t mem_flags)
{
struct usb_ctrlrequest *cmd;
u16 typeReq, wValue, wIndex, wLength;
@@ -483,8 +484,8 @@ static int rh_call_control (struct usb_hcd *hcd, struct urb *urb)
* tbuf should be at least as big as the
* USB hub descriptor.
*/
- tbuf_size = max_t(u16, sizeof(struct usb_hub_descriptor), wLength);
- tbuf = kzalloc(tbuf_size, GFP_KERNEL);
+ tbuf_size = max_t(u16, sizeof(struct usb_hub_descriptor), wLength);
+ tbuf = kzalloc(tbuf_size, mem_flags);
if (!tbuf) {
status = -ENOMEM;
goto err_alloc;
@@ -809,12 +810,13 @@ static int rh_queue_status (struct usb_hcd *hcd, struct urb *urb)
return retval;
}
-static int rh_urb_enqueue (struct usb_hcd *hcd, struct urb *urb)
+static int rh_urb_enqueue(struct usb_hcd *hcd,
+ struct urb *urb, gfp_t mem_flags)
{
if (usb_endpoint_xfer_int(&urb->ep->desc))
return rh_queue_status (hcd, urb);
if (usb_endpoint_xfer_control(&urb->ep->desc))
- return rh_call_control (hcd, urb);
+ return rh_call_control(hcd, urb, mem_flags);
return -EINVAL;
}
@@ -1535,7 +1537,7 @@ int usb_hcd_submit_urb (struct urb *urb, gfp_t mem_flags)
*/
if (is_root_hub(urb->dev)) {
- status = rh_urb_enqueue(hcd, urb);
+ status = rh_urb_enqueue(hcd, urb, mem_flags);
} else {
status = map_urb_for_dma(hcd, urb, mem_flags);
if (likely(status == 0)) {
--
2.54.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: [PATCH] usb: core: hcd: fix possible deadlock in rh control transfers
2026-04-29 10:42 ` [PATCH] usb: core: hcd: fix possible deadlock in rh control transfers Oliver Neukum
@ 2026-04-29 19:04 ` Alan Stern
2026-04-29 19:13 ` Oliver Neukum
0 siblings, 1 reply; 29+ messages in thread
From: Alan Stern @ 2026-04-29 19:04 UTC (permalink / raw)
To: Oliver Neukum; +Cc: syzbot+2afd7e71155c7e241560, linux-usb, tiwai
On Wed, Apr 29, 2026 at 12:42:06PM +0200, Oliver Neukum wrote:
> From within the SCSI error handler memory allocations must not
> trigger IO. Handling errors in UAS and the storage driver may
> involve resetting a device. The thread doing the reset itself
> relies on VM magic. However, that is insufficient, as resetting
> a device involves resuming it. Resumption as well as resetting
> involves conrol transfers to the parent of the device to be reset.
> That may be a root hub. Hence usbcore must heed the flags passed
> to usb_submit_urb() processing control transfers to root hubs.
The SCSI core prevents devices from suspending while they are in use.
If the error handler wants to do a reset (or if a USB transfer fails and
the driver does a reset to recover), the device won't be in runtime
suspend at the time, and so neither will its root hub.
Besides, even if a resume was necessary, wouldn't the same VM magic that
works for the reset thread also work for the resume? After all, they
will be the same thread; the usb_autoresume_device() call in
usb_reset_device() is synchronous and it is called after
memalloc_noio_save().
Alan Stern
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] usb: core: hcd: fix possible deadlock in rh control transfers
2026-04-29 19:04 ` Alan Stern
@ 2026-04-29 19:13 ` Oliver Neukum
2026-04-29 19:18 ` Alan Stern
0 siblings, 1 reply; 29+ messages in thread
From: Oliver Neukum @ 2026-04-29 19:13 UTC (permalink / raw)
To: Alan Stern, Oliver Neukum; +Cc: linux-usb, tiwai
On 29.04.26 21:04, Alan Stern wrote:
> Besides, even if a resume was necessary, wouldn't the same VM magic that
> works for the reset thread also work for the resume? After all, they
They need not be the same thread. That is the point. usb_reset_device()
does a resume. However, it is possible for this to race with another thread
doing a resume or a suspend. In that case it will block and wait for
another thread. Hence we essentially get priority inversion more or
less.
Regards
Oliver
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] usb: core: hcd: fix possible deadlock in rh control transfers
2026-04-29 19:13 ` Oliver Neukum
@ 2026-04-29 19:18 ` Alan Stern
0 siblings, 0 replies; 29+ messages in thread
From: Alan Stern @ 2026-04-29 19:18 UTC (permalink / raw)
To: Oliver Neukum; +Cc: linux-usb, tiwai
On Wed, Apr 29, 2026 at 09:13:59PM +0200, Oliver Neukum wrote:
> On 29.04.26 21:04, Alan Stern wrote:
>
> > Besides, even if a resume was necessary, wouldn't the same VM magic that
> > works for the reset thread also work for the resume? After all, they
>
> They need not be the same thread. That is the point. usb_reset_device()
> does a resume. However, it is possible for this to race with another thread
> doing a resume or a suspend. In that case it will block and wait for
> another thread. Hence we essentially get priority inversion more or
> less.
Okay, I see. Good point. You should include this in the patch
description.
Alan Stern
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH] sound: usb: caiaq: fix reference leak in probe error
2026-04-25 2:12 [syzbot] [usb?] memory leak in hub_event (4) syzbot
` (7 preceding siblings ...)
2026-04-29 10:42 ` [PATCH] usb: core: hcd: fix possible deadlock in rh control transfers Oliver Neukum
@ 2026-04-29 10:45 ` Oliver Neukum
2026-04-29 10:53 ` Takashi Iwai
` (3 more replies)
8 siblings, 4 replies; 29+ messages in thread
From: Oliver Neukum @ 2026-04-29 10:45 UTC (permalink / raw)
To: syzbot+2afd7e71155c7e241560; +Cc: linux-usb, tiwai, Oliver Neukum
If probing a device fails early a reference to a device
is leaked.
Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
sound/usb/caiaq/device.c | 21 +++++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/sound/usb/caiaq/device.c b/sound/usb/caiaq/device.c
index 8af0c04041ee..1a9ddbdc2cd1 100644
--- a/sound/usb/caiaq/device.c
+++ b/sound/usb/caiaq/device.c
@@ -442,7 +442,8 @@ static int init_card(struct snd_usb_caiaqdev *cdev)
if (usb_set_interface(usb_dev, 0, 1) != 0) {
dev_err(dev, "can't set alt interface.\n");
- return -EIO;
+ err = -EIO;
+ goto dev_err_put;
}
usb_init_urb(&cdev->ep1_in_urb);
@@ -462,14 +463,18 @@ static int init_card(struct snd_usb_caiaqdev *cdev)
if (usb_urb_ep_type_check(&cdev->ep1_in_urb) ||
usb_urb_ep_type_check(&cdev->midi_out_urb)) {
dev_err(dev, "invalid EPs\n");
- return -EINVAL;
+ err = -EINVAL;
+ goto dev_err_put;
}
init_waitqueue_head(&cdev->ep1_wait_queue);
init_waitqueue_head(&cdev->prepare_wait_queue);
- if (usb_submit_urb(&cdev->ep1_in_urb, GFP_KERNEL) != 0)
- return -EIO;
+ if (usb_submit_urb(&cdev->ep1_in_urb, GFP_KERNEL) != 0) {
+ err = -EIO;
+ goto dev_err_put;
+ }
+
err = snd_usb_caiaq_send_command(cdev, EP1_CMD_GET_DEVICE_INFO, NULL, 0);
if (err)
@@ -520,6 +525,14 @@ static int init_card(struct snd_usb_caiaqdev *cdev)
err_kill_urb:
usb_kill_urb(&cdev->ep1_in_urb);
+
+ /*
+ * private_free has not been set.
+ * Undoing the usb_get_dev() from
+ * create_card()
+ */
+ err_dev_put:
+ usb_put_dev(usb_dev);
return err;
}
--
2.54.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: [PATCH] sound: usb: caiaq: fix reference leak in probe error
2026-04-29 10:45 ` [PATCH] sound: usb: caiaq: fix reference leak in probe error Oliver Neukum
@ 2026-04-29 10:53 ` Takashi Iwai
2026-04-29 11:05 ` Oliver Neukum
2026-04-29 19:42 ` kernel test robot
` (2 subsequent siblings)
3 siblings, 1 reply; 29+ messages in thread
From: Takashi Iwai @ 2026-04-29 10:53 UTC (permalink / raw)
To: Oliver Neukum; +Cc: syzbot+2afd7e71155c7e241560, linux-usb, tiwai
On Wed, 29 Apr 2026 12:45:24 +0200,
Oliver Neukum wrote:
>
> If probing a device fails early a reference to a device
> is leaked.
>
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
Thanks, but I believe it's been already fixed in my tree for 7.1-rc2:
7a5f1cd22d47f8ca4b760b6334378ae42c1bd24b
ALSA: caiaq: fix usb_dev refcount leak on probe failure
Also, there are a couple of fixes for caiaq queued for 7.1-rc2, too.
Takashi
> ---
> sound/usb/caiaq/device.c | 21 +++++++++++++++++----
> 1 file changed, 17 insertions(+), 4 deletions(-)
>
> diff --git a/sound/usb/caiaq/device.c b/sound/usb/caiaq/device.c
> index 8af0c04041ee..1a9ddbdc2cd1 100644
> --- a/sound/usb/caiaq/device.c
> +++ b/sound/usb/caiaq/device.c
> @@ -442,7 +442,8 @@ static int init_card(struct snd_usb_caiaqdev *cdev)
>
> if (usb_set_interface(usb_dev, 0, 1) != 0) {
> dev_err(dev, "can't set alt interface.\n");
> - return -EIO;
> + err = -EIO;
> + goto dev_err_put;
> }
>
> usb_init_urb(&cdev->ep1_in_urb);
> @@ -462,14 +463,18 @@ static int init_card(struct snd_usb_caiaqdev *cdev)
> if (usb_urb_ep_type_check(&cdev->ep1_in_urb) ||
> usb_urb_ep_type_check(&cdev->midi_out_urb)) {
> dev_err(dev, "invalid EPs\n");
> - return -EINVAL;
> + err = -EINVAL;
> + goto dev_err_put;
> }
>
> init_waitqueue_head(&cdev->ep1_wait_queue);
> init_waitqueue_head(&cdev->prepare_wait_queue);
>
> - if (usb_submit_urb(&cdev->ep1_in_urb, GFP_KERNEL) != 0)
> - return -EIO;
> + if (usb_submit_urb(&cdev->ep1_in_urb, GFP_KERNEL) != 0) {
> + err = -EIO;
> + goto dev_err_put;
> + }
> +
>
> err = snd_usb_caiaq_send_command(cdev, EP1_CMD_GET_DEVICE_INFO, NULL, 0);
> if (err)
> @@ -520,6 +525,14 @@ static int init_card(struct snd_usb_caiaqdev *cdev)
>
> err_kill_urb:
> usb_kill_urb(&cdev->ep1_in_urb);
> +
> + /*
> + * private_free has not been set.
> + * Undoing the usb_get_dev() from
> + * create_card()
> + */
> + err_dev_put:
> + usb_put_dev(usb_dev);
> return err;
> }
>
> --
> 2.54.0
>
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH] sound: usb: caiaq: fix reference leak in probe error
2026-04-29 10:53 ` Takashi Iwai
@ 2026-04-29 11:05 ` Oliver Neukum
0 siblings, 0 replies; 29+ messages in thread
From: Oliver Neukum @ 2026-04-29 11:05 UTC (permalink / raw)
To: Takashi Iwai, Oliver Neukum; +Cc: syzbot+2afd7e71155c7e241560, linux-usb, tiwai
On 29.04.26 12:53, Takashi Iwai wrote:
> On Wed, 29 Apr 2026 12:45:24 +0200,
> Oliver Neukum wrote:
>>
>> If probing a device fails early a reference to a device
>> is leaked.
>>
>> Signed-off-by: Oliver Neukum <oneukum@suse.com>
>
> Thanks, but I believe it's been already fixed in my tree for 7.1-rc2:
> 7a5f1cd22d47f8ca4b760b6334378ae42c1bd24b
> ALSA: caiaq: fix usb_dev refcount leak on probe failure
>
> Also, there are a couple of fixes for caiaq queued for 7.1-rc2, too.
Very good. Such things happen.
Regards
Oliver
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] sound: usb: caiaq: fix reference leak in probe error
2026-04-29 10:45 ` [PATCH] sound: usb: caiaq: fix reference leak in probe error Oliver Neukum
2026-04-29 10:53 ` Takashi Iwai
@ 2026-04-29 19:42 ` kernel test robot
2026-04-30 5:33 ` kernel test robot
2026-04-30 11:02 ` kernel test robot
3 siblings, 0 replies; 29+ messages in thread
From: kernel test robot @ 2026-04-29 19:42 UTC (permalink / raw)
To: Oliver Neukum, syzbot+2afd7e71155c7e241560
Cc: oe-kbuild-all, linux-usb, tiwai, Oliver Neukum
Hi Oliver,
kernel test robot noticed the following build errors:
[auto build test ERROR on tiwai-sound/for-next]
[also build test ERROR on tiwai-sound/for-linus usb/usb-testing usb/usb-next usb/usb-linus westeri-thunderbolt/next peter-chen-usb/for-usb-next linus/master v7.1-rc1 next-20260429]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Oliver-Neukum/sound-usb-caiaq-fix-reference-leak-in-probe-error/20260429-205539
base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
patch link: https://lore.kernel.org/r/20260429104527.19927-1-oneukum%40suse.com
patch subject: [PATCH] sound: usb: caiaq: fix reference leak in probe error
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20260429/202604292126.d4xbRC4p-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260429/202604292126.d4xbRC4p-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604292126.d4xbRC4p-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
sound/usb/caiaq/device.c: In function 'init_card':
>> sound/usb/caiaq/device.c:534:2: warning: label 'err_dev_put' defined but not used [-Wunused-label]
534 | err_dev_put:
| ^~~~~~~~~~~
>> sound/usb/caiaq/device.c:475:17: error: label 'dev_err_put' used but not defined
475 | goto dev_err_put;
| ^~~~
vim +/dev_err_put +475 sound/usb/caiaq/device.c
434
435 static int init_card(struct snd_usb_caiaqdev *cdev)
436 {
437 char *c, usbpath[32];
438 struct usb_device *usb_dev = cdev->chip.dev;
439 struct snd_card *card = cdev->chip.card;
440 struct device *dev = caiaqdev_to_dev(cdev);
441 int err, len;
442
443 if (usb_set_interface(usb_dev, 0, 1) != 0) {
444 dev_err(dev, "can't set alt interface.\n");
445 err = -EIO;
446 goto dev_err_put;
447 }
448
449 usb_init_urb(&cdev->ep1_in_urb);
450 usb_init_urb(&cdev->midi_out_urb);
451
452 usb_fill_bulk_urb(&cdev->ep1_in_urb, usb_dev,
453 usb_rcvbulkpipe(usb_dev, 0x1),
454 cdev->ep1_in_buf, EP1_BUFSIZE,
455 usb_ep1_command_reply_dispatch, cdev);
456
457 usb_fill_bulk_urb(&cdev->midi_out_urb, usb_dev,
458 usb_sndbulkpipe(usb_dev, 0x1),
459 cdev->midi_out_buf, EP1_BUFSIZE,
460 snd_usb_caiaq_midi_output_done, cdev);
461
462 /* sanity checks of EPs before actually submitting */
463 if (usb_urb_ep_type_check(&cdev->ep1_in_urb) ||
464 usb_urb_ep_type_check(&cdev->midi_out_urb)) {
465 dev_err(dev, "invalid EPs\n");
466 err = -EINVAL;
467 goto dev_err_put;
468 }
469
470 init_waitqueue_head(&cdev->ep1_wait_queue);
471 init_waitqueue_head(&cdev->prepare_wait_queue);
472
473 if (usb_submit_urb(&cdev->ep1_in_urb, GFP_KERNEL) != 0) {
474 err = -EIO;
> 475 goto dev_err_put;
476 }
477
478
479 err = snd_usb_caiaq_send_command(cdev, EP1_CMD_GET_DEVICE_INFO, NULL, 0);
480 if (err)
481 goto err_kill_urb;
482
483 if (!wait_event_timeout(cdev->ep1_wait_queue, cdev->spec_received, HZ)) {
484 err = -ENODEV;
485 goto err_kill_urb;
486 }
487
488 usb_string(usb_dev, usb_dev->descriptor.iManufacturer,
489 cdev->vendor_name, CAIAQ_USB_STR_LEN);
490
491 usb_string(usb_dev, usb_dev->descriptor.iProduct,
492 cdev->product_name, CAIAQ_USB_STR_LEN);
493
494 strscpy(card->driver, MODNAME, sizeof(card->driver));
495 strscpy(card->shortname, cdev->product_name, sizeof(card->shortname));
496 strscpy(card->mixername, cdev->product_name, sizeof(card->mixername));
497
498 /* if the id was not passed as module option, fill it with a shortened
499 * version of the product string which does not contain any
500 * whitespaces */
501
502 if (*card->id == '\0') {
503 char id[sizeof(card->id)];
504
505 memset(id, 0, sizeof(id));
506
507 for (c = card->shortname, len = 0;
508 *c && len < sizeof(card->id) - 1; c++)
509 if (*c != ' ')
510 id[len++] = *c;
511
512 snd_card_set_id(card, id);
513 }
514
515 usb_make_path(usb_dev, usbpath, sizeof(usbpath));
516 scnprintf(card->longname, sizeof(card->longname), "%s %s (%s)",
517 cdev->vendor_name, cdev->product_name, usbpath);
518
519 card->private_free = card_free;
520 err = setup_card(cdev);
521 if (err < 0)
522 return err;
523
524 return 0;
525
526 err_kill_urb:
527 usb_kill_urb(&cdev->ep1_in_urb);
528
529 /*
530 * private_free has not been set.
531 * Undoing the usb_get_dev() from
532 * create_card()
533 */
> 534 err_dev_put:
535 usb_put_dev(usb_dev);
536 return err;
537 }
538
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH] sound: usb: caiaq: fix reference leak in probe error
2026-04-29 10:45 ` [PATCH] sound: usb: caiaq: fix reference leak in probe error Oliver Neukum
2026-04-29 10:53 ` Takashi Iwai
2026-04-29 19:42 ` kernel test robot
@ 2026-04-30 5:33 ` kernel test robot
2026-04-30 11:02 ` kernel test robot
3 siblings, 0 replies; 29+ messages in thread
From: kernel test robot @ 2026-04-30 5:33 UTC (permalink / raw)
To: Oliver Neukum, syzbot+2afd7e71155c7e241560
Cc: oe-kbuild-all, linux-usb, tiwai, Oliver Neukum
Hi Oliver,
kernel test robot noticed the following build errors:
[auto build test ERROR on tiwai-sound/for-next]
[also build test ERROR on tiwai-sound/for-linus usb/usb-testing usb/usb-next usb/usb-linus westeri-thunderbolt/next peter-chen-usb/for-usb-next linus/master v7.1-rc1 next-20260429]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Oliver-Neukum/sound-usb-caiaq-fix-reference-leak-in-probe-error/20260429-205539
base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
patch link: https://lore.kernel.org/r/20260429104527.19927-1-oneukum%40suse.com
patch subject: [PATCH] sound: usb: caiaq: fix reference leak in probe error
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20260430/202604301315.U4YJaZc3-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260430/202604301315.U4YJaZc3-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604301315.U4YJaZc3-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
sound/usb/caiaq/device.c: In function 'init_card':
>> sound/usb/caiaq/device.c:534:2: warning: label 'err_dev_put' defined but not used [-Wunused-label]
534 | err_dev_put:
| ^~~~~~~~~~~
>> sound/usb/caiaq/device.c:475:17: error: label 'dev_err_put' used but not defined
475 | goto dev_err_put;
| ^~~~
vim +/dev_err_put +475 sound/usb/caiaq/device.c
434
435 static int init_card(struct snd_usb_caiaqdev *cdev)
436 {
437 char *c, usbpath[32];
438 struct usb_device *usb_dev = cdev->chip.dev;
439 struct snd_card *card = cdev->chip.card;
440 struct device *dev = caiaqdev_to_dev(cdev);
441 int err, len;
442
443 if (usb_set_interface(usb_dev, 0, 1) != 0) {
444 dev_err(dev, "can't set alt interface.\n");
445 err = -EIO;
446 goto dev_err_put;
447 }
448
449 usb_init_urb(&cdev->ep1_in_urb);
450 usb_init_urb(&cdev->midi_out_urb);
451
452 usb_fill_bulk_urb(&cdev->ep1_in_urb, usb_dev,
453 usb_rcvbulkpipe(usb_dev, 0x1),
454 cdev->ep1_in_buf, EP1_BUFSIZE,
455 usb_ep1_command_reply_dispatch, cdev);
456
457 usb_fill_bulk_urb(&cdev->midi_out_urb, usb_dev,
458 usb_sndbulkpipe(usb_dev, 0x1),
459 cdev->midi_out_buf, EP1_BUFSIZE,
460 snd_usb_caiaq_midi_output_done, cdev);
461
462 /* sanity checks of EPs before actually submitting */
463 if (usb_urb_ep_type_check(&cdev->ep1_in_urb) ||
464 usb_urb_ep_type_check(&cdev->midi_out_urb)) {
465 dev_err(dev, "invalid EPs\n");
466 err = -EINVAL;
467 goto dev_err_put;
468 }
469
470 init_waitqueue_head(&cdev->ep1_wait_queue);
471 init_waitqueue_head(&cdev->prepare_wait_queue);
472
473 if (usb_submit_urb(&cdev->ep1_in_urb, GFP_KERNEL) != 0) {
474 err = -EIO;
> 475 goto dev_err_put;
476 }
477
478
479 err = snd_usb_caiaq_send_command(cdev, EP1_CMD_GET_DEVICE_INFO, NULL, 0);
480 if (err)
481 goto err_kill_urb;
482
483 if (!wait_event_timeout(cdev->ep1_wait_queue, cdev->spec_received, HZ)) {
484 err = -ENODEV;
485 goto err_kill_urb;
486 }
487
488 usb_string(usb_dev, usb_dev->descriptor.iManufacturer,
489 cdev->vendor_name, CAIAQ_USB_STR_LEN);
490
491 usb_string(usb_dev, usb_dev->descriptor.iProduct,
492 cdev->product_name, CAIAQ_USB_STR_LEN);
493
494 strscpy(card->driver, MODNAME, sizeof(card->driver));
495 strscpy(card->shortname, cdev->product_name, sizeof(card->shortname));
496 strscpy(card->mixername, cdev->product_name, sizeof(card->mixername));
497
498 /* if the id was not passed as module option, fill it with a shortened
499 * version of the product string which does not contain any
500 * whitespaces */
501
502 if (*card->id == '\0') {
503 char id[sizeof(card->id)];
504
505 memset(id, 0, sizeof(id));
506
507 for (c = card->shortname, len = 0;
508 *c && len < sizeof(card->id) - 1; c++)
509 if (*c != ' ')
510 id[len++] = *c;
511
512 snd_card_set_id(card, id);
513 }
514
515 usb_make_path(usb_dev, usbpath, sizeof(usbpath));
516 scnprintf(card->longname, sizeof(card->longname), "%s %s (%s)",
517 cdev->vendor_name, cdev->product_name, usbpath);
518
519 card->private_free = card_free;
520 err = setup_card(cdev);
521 if (err < 0)
522 return err;
523
524 return 0;
525
526 err_kill_urb:
527 usb_kill_urb(&cdev->ep1_in_urb);
528
529 /*
530 * private_free has not been set.
531 * Undoing the usb_get_dev() from
532 * create_card()
533 */
> 534 err_dev_put:
535 usb_put_dev(usb_dev);
536 return err;
537 }
538
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH] sound: usb: caiaq: fix reference leak in probe error
2026-04-29 10:45 ` [PATCH] sound: usb: caiaq: fix reference leak in probe error Oliver Neukum
` (2 preceding siblings ...)
2026-04-30 5:33 ` kernel test robot
@ 2026-04-30 11:02 ` kernel test robot
3 siblings, 0 replies; 29+ messages in thread
From: kernel test robot @ 2026-04-30 11:02 UTC (permalink / raw)
To: Oliver Neukum, syzbot+2afd7e71155c7e241560
Cc: llvm, oe-kbuild-all, linux-usb, tiwai, Oliver Neukum
Hi Oliver,
kernel test robot noticed the following build errors:
[auto build test ERROR on tiwai-sound/for-next]
[also build test ERROR on tiwai-sound/for-linus usb/usb-testing usb/usb-next usb/usb-linus westeri-thunderbolt/next peter-chen-usb/for-usb-next linus/master v7.1-rc1 next-20260429]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Oliver-Neukum/sound-usb-caiaq-fix-reference-leak-in-probe-error/20260429-205539
base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
patch link: https://lore.kernel.org/r/20260429104527.19927-1-oneukum%40suse.com
patch subject: [PATCH] sound: usb: caiaq: fix reference leak in probe error
config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20260430/202604301817.kEsyTIz2-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
rustc: rustc 1.88.0 (6b00bc388 2025-06-23)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260430/202604301817.kEsyTIz2-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604301817.kEsyTIz2-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
>> sound/usb/caiaq/device.c:446:8: error: use of undeclared label 'dev_err_put'
446 | goto dev_err_put;
| ^
>> sound/usb/caiaq/device.c:534:2: warning: unused label 'err_dev_put' [-Wunused-label]
534 | err_dev_put:
| ^~~~~~~~~~~~
1 warning and 1 error generated.
vim +/dev_err_put +446 sound/usb/caiaq/device.c
434
435 static int init_card(struct snd_usb_caiaqdev *cdev)
436 {
437 char *c, usbpath[32];
438 struct usb_device *usb_dev = cdev->chip.dev;
439 struct snd_card *card = cdev->chip.card;
440 struct device *dev = caiaqdev_to_dev(cdev);
441 int err, len;
442
443 if (usb_set_interface(usb_dev, 0, 1) != 0) {
444 dev_err(dev, "can't set alt interface.\n");
445 err = -EIO;
> 446 goto dev_err_put;
447 }
448
449 usb_init_urb(&cdev->ep1_in_urb);
450 usb_init_urb(&cdev->midi_out_urb);
451
452 usb_fill_bulk_urb(&cdev->ep1_in_urb, usb_dev,
453 usb_rcvbulkpipe(usb_dev, 0x1),
454 cdev->ep1_in_buf, EP1_BUFSIZE,
455 usb_ep1_command_reply_dispatch, cdev);
456
457 usb_fill_bulk_urb(&cdev->midi_out_urb, usb_dev,
458 usb_sndbulkpipe(usb_dev, 0x1),
459 cdev->midi_out_buf, EP1_BUFSIZE,
460 snd_usb_caiaq_midi_output_done, cdev);
461
462 /* sanity checks of EPs before actually submitting */
463 if (usb_urb_ep_type_check(&cdev->ep1_in_urb) ||
464 usb_urb_ep_type_check(&cdev->midi_out_urb)) {
465 dev_err(dev, "invalid EPs\n");
466 err = -EINVAL;
467 goto dev_err_put;
468 }
469
470 init_waitqueue_head(&cdev->ep1_wait_queue);
471 init_waitqueue_head(&cdev->prepare_wait_queue);
472
473 if (usb_submit_urb(&cdev->ep1_in_urb, GFP_KERNEL) != 0) {
474 err = -EIO;
475 goto dev_err_put;
476 }
477
478
479 err = snd_usb_caiaq_send_command(cdev, EP1_CMD_GET_DEVICE_INFO, NULL, 0);
480 if (err)
481 goto err_kill_urb;
482
483 if (!wait_event_timeout(cdev->ep1_wait_queue, cdev->spec_received, HZ)) {
484 err = -ENODEV;
485 goto err_kill_urb;
486 }
487
488 usb_string(usb_dev, usb_dev->descriptor.iManufacturer,
489 cdev->vendor_name, CAIAQ_USB_STR_LEN);
490
491 usb_string(usb_dev, usb_dev->descriptor.iProduct,
492 cdev->product_name, CAIAQ_USB_STR_LEN);
493
494 strscpy(card->driver, MODNAME, sizeof(card->driver));
495 strscpy(card->shortname, cdev->product_name, sizeof(card->shortname));
496 strscpy(card->mixername, cdev->product_name, sizeof(card->mixername));
497
498 /* if the id was not passed as module option, fill it with a shortened
499 * version of the product string which does not contain any
500 * whitespaces */
501
502 if (*card->id == '\0') {
503 char id[sizeof(card->id)];
504
505 memset(id, 0, sizeof(id));
506
507 for (c = card->shortname, len = 0;
508 *c && len < sizeof(card->id) - 1; c++)
509 if (*c != ' ')
510 id[len++] = *c;
511
512 snd_card_set_id(card, id);
513 }
514
515 usb_make_path(usb_dev, usbpath, sizeof(usbpath));
516 scnprintf(card->longname, sizeof(card->longname), "%s %s (%s)",
517 cdev->vendor_name, cdev->product_name, usbpath);
518
519 card->private_free = card_free;
520 err = setup_card(cdev);
521 if (err < 0)
522 return err;
523
524 return 0;
525
526 err_kill_urb:
527 usb_kill_urb(&cdev->ep1_in_urb);
528
529 /*
530 * private_free has not been set.
531 * Undoing the usb_get_dev() from
532 * create_card()
533 */
> 534 err_dev_put:
535 usb_put_dev(usb_dev);
536 return err;
537 }
538
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 29+ messages in thread