From: Alexander Graf <agraf@suse.de>
To: Scott Wood <scottwood@freescale.com>
Cc: Bharat Bhushan <Bharat.Bhushan@freescale.com>,
"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] powerpc/kvm/booke: Fix build break due to stack frame size warning
Date: Tue, 10 Dec 2013 02:05:02 +0000 [thread overview]
Message-ID: <6CE89604-76E9-4875-89C7-2A6C11CD6326@suse.de> (raw)
In-Reply-To: <1386623900.10013.46.camel@snotra.buserror.net>
On 09.12.2013, at 22:18, Scott Wood <scottwood@freescale.com> wrote:
> On Mon, 2013-11-25 at 04:26 -0600, Bharat Bhushan wrote:
>>
>>> -----Original Message-----
>>> From: Wood Scott-B07421
>>> Sent: Saturday, November 23, 2013 3:22 AM
>>> To: Alexander Graf
>>> Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; Wood Scott-B07421; Bhushan
>>> Bharat-R65777
>>> Subject: [PATCH] powerpc/kvm/booke: Fix build break due to stack frame size
>>> warning
>>>
>>> Commit ce11e48b7fdd256ec68b932a89b397a790566031 ("KVM: PPC: E500: Add
>>> userspace debug stub support") added "struct thread_struct" to the
>>> stack of kvmppc_vcpu_run(). thread_struct is 1152 bytes on my build,
>>> compared to 48 bytes for the recently-introduced "struct debug_reg".
>>> Use the latter instead.
>>>
>>> This fixes the following error:
>>>
>>> cc1: warnings being treated as errors
>>> arch/powerpc/kvm/booke.c: In function 'kvmppc_vcpu_run':
>>> arch/powerpc/kvm/booke.c:760:1: error: the frame size of 1424 bytes is larger
>>> than 1024 bytes
>>> make[2]: *** [arch/powerpc/kvm/booke.o] Error 1
>>> make[1]: *** [arch/powerpc/kvm] Error 2
>>> make[1]: *** Waiting for unfinished jobs....
>>>
>>> Signed-off-by: Scott Wood <scottwood@freescale.com>
>>> Cc: Bharat Bhushan <r65777@freescale.com>
>>> ---
>>> Build tested only. Bharat, please test.
>>
>> Tested with qemu debug stub; It works fine
>>
>> -Bharat
>
> Alex, are you going to take this through your tree?
Sure. Do you want this for 3.13 or 3.14? Since I don't see the breakage with my compilers I'd queue it for 3.14, but whatever works for you works for me.
Also Bharat, could you please make that a real "Tested-by" line?
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Scott Wood <scottwood@freescale.com>
Cc: Bharat Bhushan <Bharat.Bhushan@freescale.com>,
"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] powerpc/kvm/booke: Fix build break due to stack frame size warning
Date: Tue, 10 Dec 2013 03:05:02 +0100 [thread overview]
Message-ID: <6CE89604-76E9-4875-89C7-2A6C11CD6326@suse.de> (raw)
In-Reply-To: <1386623900.10013.46.camel@snotra.buserror.net>
On 09.12.2013, at 22:18, Scott Wood <scottwood@freescale.com> wrote:
> On Mon, 2013-11-25 at 04:26 -0600, Bharat Bhushan wrote:
>>
>>> -----Original Message-----
>>> From: Wood Scott-B07421
>>> Sent: Saturday, November 23, 2013 3:22 AM
>>> To: Alexander Graf
>>> Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; Wood Scott-B07421; Bhushan
>>> Bharat-R65777
>>> Subject: [PATCH] powerpc/kvm/booke: Fix build break due to stack frame size
>>> warning
>>>
>>> Commit ce11e48b7fdd256ec68b932a89b397a790566031 ("KVM: PPC: E500: Add
>>> userspace debug stub support") added "struct thread_struct" to the
>>> stack of kvmppc_vcpu_run(). thread_struct is 1152 bytes on my build,
>>> compared to 48 bytes for the recently-introduced "struct debug_reg".
>>> Use the latter instead.
>>>
>>> This fixes the following error:
>>>
>>> cc1: warnings being treated as errors
>>> arch/powerpc/kvm/booke.c: In function 'kvmppc_vcpu_run':
>>> arch/powerpc/kvm/booke.c:760:1: error: the frame size of 1424 bytes is larger
>>> than 1024 bytes
>>> make[2]: *** [arch/powerpc/kvm/booke.o] Error 1
>>> make[1]: *** [arch/powerpc/kvm] Error 2
>>> make[1]: *** Waiting for unfinished jobs....
>>>
>>> Signed-off-by: Scott Wood <scottwood@freescale.com>
>>> Cc: Bharat Bhushan <r65777@freescale.com>
>>> ---
>>> Build tested only. Bharat, please test.
>>
>> Tested with qemu debug stub; It works fine
>>
>> -Bharat
>
> Alex, are you going to take this through your tree?
Sure. Do you want this for 3.13 or 3.14? Since I don't see the breakage with my compilers I'd queue it for 3.14, but whatever works for you works for me.
Also Bharat, could you please make that a real "Tested-by" line?
Alex
next prev parent reply other threads:[~2013-12-10 2:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 21:52 [PATCH] powerpc/kvm/booke: Fix build break due to stack frame size warning Scott Wood
2013-11-22 21:52 ` Scott Wood
2013-11-25 10:26 ` Bharat Bhushan
2013-12-09 21:18 ` Scott Wood
2013-12-09 21:18 ` Scott Wood
2013-12-10 2:05 ` Alexander Graf [this message]
2013-12-10 2:05 ` Alexander Graf
2013-12-10 23:11 ` Scott Wood
2013-12-10 23:11 ` Scott Wood
2013-12-10 23:16 ` Alexander Graf
2013-12-10 23:16 ` Alexander Graf
2013-12-10 23:16 ` Alexander Graf
2013-12-10 23:16 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6CE89604-76E9-4875-89C7-2A6C11CD6326@suse.de \
--to=agraf@suse.de \
--cc=Bharat.Bhushan@freescale.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.