All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: kraghava@qti.qualcomm.com, meta-virtualization@lists.yoctoproject.org
Cc: vkraleti@qti.qualcomm.com, anujmitt@qti.qualcomm.com,
	sbanerje@qti.qualcomm.com
Subject: Re: [PATCH v2 0/2] Add crosvm recipe to meta-virtualization
Date: Fri, 19 Jun 2026 20:42:33 -0700 (PDT)	[thread overview]
Message-ID: <6a360c29.883ba7c5.96128.ac08@mx.google.com> (raw)
In-Reply-To: <20260613060743.3120135-1-kraghava@qti.qualcomm.com>

Thanks for the v2! Most of my v4 feedback is addressed — gitsm dropped in
favour of explicit clones, PV/PKGV cleaned up, SUMMARY expanded, README +
test instructions added, and the qemux86-64 nested-KVM path gives me
something I can actually reproduce here. Appreciated.

But for a v3, make sure to summarize the changes from the previous
version. I had to look up the old comments and that gets a bit tedious
when doing a lot of reviews.

Per-patch comments are on the individual messages. The main one is on
1/2 — a one-character SRC_URI change that lets the whole
do_filter_minijail_cargo_config task go away. 2/2 just has a typo and
a small nit.

With those addressed, and a reply on the three v4 items I still don't
see resolved (BBCLASSEXTEND, wayland, crate-licence variation — replies
on-list are fine for the latter two, no need to be code changes), I
think we're close to a mergeable v3.

Bruce


      parent reply	other threads:[~2026-06-20  3:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-13  6:07 [PATCH v2 0/2] Add crosvm recipe to meta-virtualization Keerthivasan Raghavan
2026-06-13  6:07 ` [PATCH v2 1/2] crosvm: add recipe for ChromeOS Virtual Machine Monitor (VMM) Keerthivasan Raghavan
2026-06-20  3:42   ` Bruce Ashfield
2026-06-13  6:07 ` [PATCH v2 2/2] crosvm-image-minimal: add a reference image for crosvm demo Keerthivasan Raghavan
2026-06-20  3:42   ` Bruce Ashfield
2026-06-20  3:42 ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a360c29.883ba7c5.96128.ac08@mx.google.com \
    --to=bruce.ashfield@gmail.com \
    --cc=anujmitt@qti.qualcomm.com \
    --cc=kraghava@qti.qualcomm.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    --cc=sbanerje@qti.qualcomm.com \
    --cc=vkraleti@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.