From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: kraghava@qti.qualcomm.com, meta-virtualization@lists.yoctoproject.org
Cc: vkraleti@qti.qualcomm.com, anujmitt@qti.qualcomm.com,
sbanerje@qti.qualcomm.com
Subject: Re: [PATCH v2 2/2] crosvm-image-minimal: add a reference image for crosvm demo
Date: Fri, 19 Jun 2026 20:42:37 -0700 (PDT) [thread overview]
Message-ID: <6a360c2d.dfaa6ae2.184890.bc53@mx.google.com> (raw)
In-Reply-To: <20260613060743.3120135-3-kraghava@qti.qualcomm.com>
Mostly looks good. The "host kernel is the guest kernel" pattern is
honest for a demo, the dependency wiring (do_rootfs[depends] on guest
image + kernel deploy) is correct, and bundle_crosvm_guest is
defensive (readlink -f, install -m 0644, bbfatal on missing inputs).
README is concrete and reproducible.
Two minor things:
- SUMMARY typo: "demo its uage." → "demo its usage."
- KVM_MODULES:aarch64 = "" is identical to the unconditional
KVM_MODULES = "" default. Either drop the override, or keep it
only if you want the explicit per-arch line as documentation
of the "kvm is built-in on arm64" fact.
Bruce
next prev parent reply other threads:[~2026-06-20 3:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-13 6:07 [PATCH v2 0/2] Add crosvm recipe to meta-virtualization Keerthivasan Raghavan
2026-06-13 6:07 ` [PATCH v2 1/2] crosvm: add recipe for ChromeOS Virtual Machine Monitor (VMM) Keerthivasan Raghavan
2026-06-20 3:42 ` Bruce Ashfield
2026-06-13 6:07 ` [PATCH v2 2/2] crosvm-image-minimal: add a reference image for crosvm demo Keerthivasan Raghavan
2026-06-20 3:42 ` Bruce Ashfield [this message]
2026-06-20 3:42 ` [PATCH v2 0/2] Add crosvm recipe to meta-virtualization Bruce Ashfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a360c2d.dfaa6ae2.184890.bc53@mx.google.com \
--to=bruce.ashfield@gmail.com \
--cc=anujmitt@qti.qualcomm.com \
--cc=kraghava@qti.qualcomm.com \
--cc=meta-virtualization@lists.yoctoproject.org \
--cc=sbanerje@qti.qualcomm.com \
--cc=vkraleti@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.