[LTP] [PATCH] set_mempolicy05: require CONFIG_NUMA

[LTP] [PATCH] set_mempolicy05: require CONFIG_NUMA

[Avinesh Kumar via ltp]

On kernels without CONFIG_NUMA=y set_mempolicy() returns ENOSYS,
which the test misreports as TFAIL.

set_mempolicy05.c:105: TFAIL: set_mempolicy should fail with EFAULT or EINVAL, instead returned 38

Add .needs_kconfigs with CONFIG_NUMA=y

Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>
---
 testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c
index 65061bf3d..6c91beebc 100644
--- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c
+++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c
@@ -115,6 +115,10 @@ static struct tst_test test = {
 		"ppc",
 		NULL
 	},
+	.needs_kconfigs = (const char *const[]){
+		"CONFIG_NUMA=y",
+		NULL
+	},
 	.tags = (const struct tst_tag[]) {
 		{"linux-git", "cf01fb9985e8"},
 		{"CVE", "CVE-2017-7616"},
-- 
2.54.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] set_mempolicy05: require CONFIG_NUMA

[linuxtestproject.agent]

Hi Avinesh,

On 23 Jun 2026, Avinesh Kumar wrote:
> set_mempolicy05: require CONFIG_NUMA

Verdict - Reviewed

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] set_mempolicy05: require CONFIG_NUMA

[Andrea Cervesato via ltp]

Hi Avinesh,

the patch looks good to me, but it's probably not enough. we will
need to implement the same concept for all set_mempolicy() tests,
since it's NUMA specific. We just missed this for all this time
apparently. Did you see the same errors for them as well?

Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] set_mempolicy05: require CONFIG_NUMA

[Avinesh Kumar via ltp]

Hi Andrea,


On 6/24/26 10:14 AM, Andrea Cervesato via ltp wrote:
> Hi Avinesh,
> 
> the patch looks good to me, but it's probably not enough. we will
> need to implement the same concept for all set_mempolicy() tests,
> since it's NUMA specific. We just missed this for all this time
> apparently. Did you see the same errors for them as well?

Thanks for the review. Remaining set_mempolicy tests are checking for 
minimum two NUMA nodes and hence reports

tse_numa.c:200: TINFO: Found 1 NUMA memory nodes
tse_numa.c:141: TINFO: File '/sys/devices/system/node/node0/meminfo' 
does not exist! NUMA not enabled?
get_mempolicy02.c:60: TCONF: test requires at least one NUMA memory node

even on systems without CONFIG_NUMA=y.

But I also think that we should add
CONFIG_NUMA=y check in all these tests. Please confirm, I will send 
revised version.


Regards,
Avinesh

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] set_mempolicy05: require CONFIG_NUMA

[Andrea Cervesato via ltp]

> But I also think that we should add
> CONFIG_NUMA=y check in all these tests. Please confirm, I will send 
> revised version.

Yes please, let's fix them all already.

Thanks,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp