From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: sashiko-reviews@lists.linux.dev
Cc: conor+dt@kernel.org, dri-devel@lists.freedesktop.org,
vkoul@kernel.org, robh@kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, neil.armstrong@linaro.org,
olteanv@gmail.com
Subject: Re: [PATCH RFC/DO NOT MERGE 08/12] drm/msm/hdmi: Add support for PM OPP table
Date: Mon, 7 Sep 2026 15:03:46 +0200 [thread overview]
Message-ID: <6a485a80-cf23-40ba-b385-fd35cf0e9888@oss.qualcomm.com> (raw)
In-Reply-To: <20260828141602.211751F000E9@smtp.kernel.org>
On 28/08/2026 16:16, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [High] Unconditional call to `devm_pm_opp_set_clkname()` causes probe failure on platforms without the optional "extp" clock.
Ack
> - [Medium] Memory and reference leak of `hdmi->next_bridge` on error paths in probe due to bypassed cleanup.
> --
Ack
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: sashiko-reviews@lists.linux.dev
Cc: conor+dt@kernel.org, dri-devel@lists.freedesktop.org,
vkoul@kernel.org, robh@kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, neil.armstrong@linaro.org,
olteanv@gmail.com
Subject: Re: [PATCH RFC/DO NOT MERGE 08/12] drm/msm/hdmi: Add support for PM OPP table
Date: Mon, 7 Sep 2026 15:03:46 +0200 [thread overview]
Message-ID: <6a485a80-cf23-40ba-b385-fd35cf0e9888@oss.qualcomm.com> (raw)
In-Reply-To: <20260828141602.211751F000E9@smtp.kernel.org>
On 28/08/2026 16:16, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [High] Unconditional call to `devm_pm_opp_set_clkname()` causes probe failure on platforms without the optional "extp" clock.
Ack
> - [Medium] Memory and reference leak of `hdmi->next_bridge` on error paths in probe due to bypassed cleanup.
> --
Ack
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-07 13:03 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 14:04 [PATCH RFC/DO NOT MERGE 00/12] drm/msm/hdmi: Add Eliza HDMI and HDMI PHY Krzysztof Kozlowski
2026-08-28 14:04 ` Krzysztof Kozlowski
2026-08-28 14:04 ` [PATCH RFC/DO NOT MERGE 01/12] drm/msm/hdmi_bridge: Drop redundant initialization in msm_hdmi_bridge_init() Krzysztof Kozlowski
2026-08-28 14:04 ` Krzysztof Kozlowski
2026-08-31 16:27 ` Konrad Dybcio
2026-08-31 16:27 ` Konrad Dybcio
2026-08-28 14:05 ` [PATCH RFC/DO NOT MERGE 02/12] drm/msm: Properly handle msm_ioremap() without name Krzysztof Kozlowski
2026-08-28 14:05 ` Krzysztof Kozlowski
2026-08-31 16:27 ` Konrad Dybcio
2026-08-31 16:27 ` Konrad Dybcio
2026-08-28 14:05 ` [PATCH RFC/DO NOT MERGE 03/12] drm/msm/dsi: Fix indentation of if block in dsi_mgr_bridge_mode_valid() Krzysztof Kozlowski
2026-08-28 14:05 ` Krzysztof Kozlowski
2026-08-31 16:28 ` Konrad Dybcio
2026-08-31 16:28 ` Konrad Dybcio
2026-08-28 14:05 ` [PATCH RFC/DO NOT MERGE 04/12] dt-bindings: display/msm: hdmi: Correct name of disallowed supplies Krzysztof Kozlowski
2026-08-28 14:05 ` Krzysztof Kozlowski
2026-08-31 16:37 ` Konrad Dybcio
2026-08-31 16:37 ` Konrad Dybcio
2026-08-28 14:05 ` [PATCH RFC/DO NOT MERGE 05/12] dt-bindings: display/msm: hdmi: Add Eliza HDMI TX Krzysztof Kozlowski
2026-08-28 14:05 ` Krzysztof Kozlowski
2026-08-28 14:12 ` sashiko-bot
2026-08-28 14:12 ` sashiko-bot
2026-08-31 13:53 ` Krzysztof Kozlowski
2026-08-31 13:53 ` Krzysztof Kozlowski
2026-08-28 14:05 ` [PATCH RFC/DO NOT MERGE 06/12] dt-bindings: display/msm: eliza-hdmi-phy: Add Eliza HDMI PHY Krzysztof Kozlowski
2026-08-28 14:05 ` Krzysztof Kozlowski
2026-08-28 14:10 ` sashiko-bot
2026-08-28 14:10 ` sashiko-bot
2026-08-31 14:13 ` Krzysztof Kozlowski
2026-08-31 14:13 ` Krzysztof Kozlowski
2026-08-28 14:05 ` [PATCH RFC/DO NOT MERGE 07/12] drm/msm/hdmi: Split PHY init from power up Krzysztof Kozlowski
2026-08-28 14:05 ` Krzysztof Kozlowski
2026-08-28 14:22 ` sashiko-bot
2026-08-28 14:22 ` sashiko-bot
2026-09-07 12:34 ` Krzysztof Kozlowski
2026-09-07 12:34 ` Krzysztof Kozlowski
2026-08-31 16:40 ` Konrad Dybcio
2026-08-31 16:40 ` Konrad Dybcio
2026-09-01 5:57 ` Krzysztof Kozlowski
2026-09-01 5:57 ` Krzysztof Kozlowski
2026-08-28 14:05 ` [PATCH RFC/DO NOT MERGE 08/12] drm/msm/hdmi: Add support for PM OPP table Krzysztof Kozlowski
2026-08-28 14:05 ` Krzysztof Kozlowski
2026-08-28 14:16 ` sashiko-bot
2026-08-28 14:16 ` sashiko-bot
2026-09-07 13:03 ` Krzysztof Kozlowski [this message]
2026-09-07 13:03 ` Krzysztof Kozlowski
2026-08-31 16:43 ` Konrad Dybcio
2026-08-31 16:43 ` Konrad Dybcio
2026-09-01 5:58 ` Krzysztof Kozlowski
2026-09-01 5:58 ` Krzysztof Kozlowski
2026-08-28 14:05 ` [PATCH RFC/DO NOT MERGE 09/12] drm/msm/hdmi: Add HDMI for Eliza SoC Krzysztof Kozlowski
2026-08-28 14:05 ` Krzysztof Kozlowski
2026-08-28 14:22 ` sashiko-bot
2026-08-28 14:22 ` sashiko-bot
2026-09-07 13:09 ` Krzysztof Kozlowski
2026-09-07 13:09 ` Krzysztof Kozlowski
2026-08-31 16:45 ` Konrad Dybcio
2026-08-31 16:45 ` Konrad Dybcio
2026-09-01 6:00 ` Krzysztof Kozlowski
2026-09-01 6:00 ` Krzysztof Kozlowski
2026-08-28 14:05 ` [PATCH RFC/DO NOT MERGE 10/12] drm/msm/hdmi_phy_eliza: Add support for Synopsys-based HDMI phy on Eliza Krzysztof Kozlowski
2026-08-28 14:05 ` Krzysztof Kozlowski
2026-08-28 14:19 ` sashiko-bot
2026-08-28 14:19 ` sashiko-bot
2026-09-08 13:19 ` Krzysztof Kozlowski
2026-09-08 13:19 ` Krzysztof Kozlowski
2026-08-28 14:05 ` [PATCH RFC/DO NOT MERGE 11/12] arm64: dts: qcom: eliza: Add HDMI display with HDMI PHY Krzysztof Kozlowski
2026-08-28 14:05 ` Krzysztof Kozlowski
2026-08-28 14:05 ` [PATCH RFC/DO NOT MERGE 12/12] arm64: dts: qcom: eliza-evk: Add native HDMI Krzysztof Kozlowski
2026-08-28 14:05 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a485a80-cf23-40ba-b385-fd35cf0e9888@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.