[LTP] [PATCH] checkpatch: relax parenthesis style checks

[LTP] [PATCH] checkpatch: relax parenthesis style checks

[Andrea Cervesato]

From: Andrea Cervesato <andrea.cervesato@suse.com>

The PARENTHESIS_ALIGNMENT and OPEN_ENDED_LINE strict checks flag common
LTP formatting that is otherwise accepted, so disable them.

Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
 .checkpatch.conf | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.checkpatch.conf b/.checkpatch.conf
index a7b6219adac5fff663c99a4cafaafb7c609233a6..0b22f7811cc891e91c62565edb0663df1e0f2622 100644
--- a/.checkpatch.conf
+++ b/.checkpatch.conf
@@ -17,3 +17,6 @@
 
 # ENOSYS is used in test error macros
 --ignore ENOSYS
+
+# LTP does not enforce open parenthesis alignment nor forbid a trailing '('
+--ignore PARENTHESIS_ALIGNMENT,OPEN_ENDED_LINE

---
base-commit: 7ca5dc366a558f3666223e6abe579edd90bafd38
change-id: 20260714-checkpatch_remove_rules-e942ef47a23d

Best regards,
-- 
Andrea Cervesato <andrea.cervesato@suse.com>


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] checkpatch: relax parenthesis style checks

[Cyril Hrubis]

Hi!
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] checkpatch: relax parenthesis style checks

[linuxtestproject.agent]

Hi Andrea,

On Tue, Jul 14 2026, Andrea Cervesato wrote:
> checkpatch: relax parenthesis style checks

Verdict - Reviewed

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] checkpatch: relax parenthesis style checks

[Andrea Cervesato via ltp]

Merged, Thanks!

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] checkpatch: relax parenthesis style checks

[Petr Vorel]

Hi Andrea, Cyril,

I found both rules useful (more readable and more consistent code). Can we put
it back? Over the years you will recognise on the code of single test that it
was written/modified by several people with a different styles. And that makes
it less readable.

* PARENTHESIS_ALIGNMENT check enforces space behind 'while' or 'if'.
i.e. instead of:
	while(tst_fzsync_run_b(&fzsync_pair)) {
have:
	while (tst_fzsync_run_b(&fzsync_pair)) {

cve-2014-0196.c mixes 'while()' and 'while ()'. Is it that hard to be
consistent on it?

* OPEN_ENDED_LINE asks for not ending line with '(' or '['.
i.e. instead of this:
	ruleset_fd = TST_EXP_FD_SILENT(
								   tst_syscall(__NR_landlock_create_ruleset, ruleset_attr,
						   sizeof(struct tst_landlock_ruleset_attr_abi1), 0));
have this:
	ruleset_fd = TST_EXP_FD_SILENT(tst_syscall(__NR_landlock_create_ruleset, ruleset_attr,
						   sizeof(struct tst_landlock_ruleset_attr_abi1), 0));

It's just my personal preference but I agree with the author of the rule that
enforced style is more readable.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp