[LTP] [PATCH 1/1] setsockopt10: Fix running with more iterations

[LTP] [PATCH 1/1] setsockopt10: Fix running with more iterations

[Petr Vorel]

Do proper cleanup SAFE_CLOSE(tcp1_sk) before return to fix test when
running with more iterations:

    # ./setsockopt10  -i1022
    ...
    setsockopt10.c:165: TPASS: parent: tls disallows disconnect: EOPNOTSUPP (95)
    setsockopt10.c:116: TINFO: child: connect for tcp2 connection
    setsockopt10.c:120: TINFO: child: could not connect to tcp1: ECONNREFUSED (111)
    setsockopt10.c:134: TBROK: socket(2, 1, 0) failed: EMFILE (24)

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 testcases/kernel/syscalls/setsockopt/setsockopt10.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/testcases/kernel/syscalls/setsockopt/setsockopt10.c b/testcases/kernel/syscalls/setsockopt/setsockopt10.c
index 76c977d2eb..b12f7bf166 100644
--- a/testcases/kernel/syscalls/setsockopt/setsockopt10.c
+++ b/testcases/kernel/syscalls/setsockopt/setsockopt10.c
@@ -167,6 +167,7 @@ static void run(void)
 			tst_res(TFAIL | TTERRNO, "parent: unexpected errno from connect");
 		TST_CHECKPOINT_WAKE(2);
 		tst_reap_children();
+		SAFE_CLOSE(tcp1_sk);
 		return;
 	}
 
@@ -183,6 +184,7 @@ static void run(void)
 
 		TST_CHECKPOINT_WAKE(2);
 		tst_reap_children();
+		SAFE_CLOSE(tcp1_sk);
 		return;
 	}
 
-- 
2.55.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] setsockopt10: Fix running with more iterations

[linuxtestproject.agent]

Hi Petr,

On Mon, Jul 20 23:36:10 2026 +0200, Petr Vorel wrote:
> setsockopt10: Fix running with more iterations

Verdict - Reviewed

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] setsockopt10: Fix running with more iterations

[Andrea Cervesato via ltp]

Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] setsockopt10: Fix running with more iterations

[Andrea Cervesato via ltp]

Merged, Thanks!

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp