[PATCH BlueZ bluez] bap: fixed the return value of GIOFunc

[PATCH BlueZ bluez] bap: fixed the return value of GIOFunc

[Yang Li via B4 Relay]

From: Yang Li <yang.li@amlogic.com>

The GIOFunc should return FALSE if the event source should be removed.

Fixes: 322c39a64 (bap: Start BIG sync after receiving BIGInfo)

Signed-off-by: Yang Li <yang.li@amlogic.com>
---
 profiles/audio/bap.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c
index 473e4cfc2..ff8f58a12 100644
--- a/profiles/audio/bap.c
+++ b/profiles/audio/bap.c
@@ -3683,7 +3683,6 @@ static gboolean iso_do_big_sync(GIOChannel *io, GIOCondition cond,
 			BT_IO_OPT_INVALID)) {
 		error("bt_io_set: %s", err->message);
 		g_error_free(err);
-		return FALSE;
 	}
 
 	if (!bt_io_bcast_accept(io,
@@ -3694,10 +3693,9 @@ static gboolean iso_do_big_sync(GIOChannel *io, GIOCondition cond,
 			iso_bc_addr.bc_bis, BT_IO_OPT_INVALID)) {
 		error("bt_io_bcast_accept: %s", err->message);
 		g_error_free(err);
-		return FALSE;
 	}
 
-	return TRUE;
+	return FALSE;
 }
 
 static void long_pa_sync_confirm_cb(GIOChannel *io, void *user_data)

---
base-commit: 729f96089cf66831d911385623ca932e0c245913
change-id: 20260729-fix_iofunc-e62cecc52b8e

Best regards,
-- 
Yang Li <yang.li@amlogic.com>

[PATCH BlueZ bluez] bap: fixed the return value of GIOFunc

[Yang Li]

The GIOFunc should return FALSE if the event source should be removed.

Fixes: 322c39a64 (bap: Start BIG sync after receiving BIGInfo)

Signed-off-by: Yang Li <yang.li@amlogic.com>
---
 profiles/audio/bap.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c
index 473e4cfc2..ff8f58a12 100644
--- a/profiles/audio/bap.c
+++ b/profiles/audio/bap.c
@@ -3683,7 +3683,6 @@ static gboolean iso_do_big_sync(GIOChannel *io, GIOCondition cond,
 			BT_IO_OPT_INVALID)) {
 		error("bt_io_set: %s", err->message);
 		g_error_free(err);
-		return FALSE;
 	}
 
 	if (!bt_io_bcast_accept(io,
@@ -3694,10 +3693,9 @@ static gboolean iso_do_big_sync(GIOChannel *io, GIOCondition cond,
 			iso_bc_addr.bc_bis, BT_IO_OPT_INVALID)) {
 		error("bt_io_bcast_accept: %s", err->message);
 		g_error_free(err);
-		return FALSE;
 	}
 
-	return TRUE;
+	return FALSE;
 }
 
 static void long_pa_sync_confirm_cb(GIOChannel *io, void *user_data)

---
base-commit: 729f96089cf66831d911385623ca932e0c245913
change-id: 20260729-fix_iofunc-e62cecc52b8e

Best regards,
-- 
Yang Li <yang.li@amlogic.com>

RE: [BlueZ,bluez] bap: fixed the return value of GIOFunc

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1996 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1136288

---Test result---

Test Summary:
CheckPatch                    FAIL      0.28 seconds
GitLint                       PASS      0.20 seconds
BuildEll                      PASS      20.39 seconds
BluezMake                     PASS      555.77 seconds
MakeCheck                     PASS      3.19 seconds
MakeDistcheck                 PASS      159.43 seconds
CheckValgrind                 PASS      159.91 seconds
CheckSmatch                   PASS      312.43 seconds
bluezmakeextell               PASS      103.33 seconds
IncrementalBuild              PASS      563.46 seconds
ScanBuild                     PASS      984.05 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,bluez] bap: fixed the return value of GIOFunc
WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: 322c39a64323 ("bap: Start BIG sync after receiving BIGInfo")'
#77: 
Fixes: 322c39a64 (bap: Start BIG sync after receiving BIGInfo)

/github/workspace/src/patch/14717048.patch total: 0 errors, 1 warnings, 18 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/patch/14717048.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.




https://github.com/bluez/bluez/pull/2357

---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ bluez] bap: fixed the return value of GIOFunc

[Bastien Nocera]

On Wed, 2026-07-29 at 09:47 +0800, Yang Li via B4 Relay wrote:
> From: Yang Li <yang.li@amlogic.com>
> 
> The GIOFunc should return FALSE if the event source should be
> removed.
> 
> Fixes: 322c39a64 (bap: Start BIG sync after receiving BIGInfo)
> 
> Signed-off-by: Yang Li <yang.li@amlogic.com>

Looks good, thanks.

Although I would have still preferred G_SOURCE_REMOVE which makes it
clearer what it does.

> ---
>  profiles/audio/bap.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c
> index 473e4cfc2..ff8f58a12 100644
> --- a/profiles/audio/bap.c
> +++ b/profiles/audio/bap.c
> @@ -3683,7 +3683,6 @@ static gboolean iso_do_big_sync(GIOChannel *io,
> GIOCondition cond,
>  			BT_IO_OPT_INVALID)) {
>  		error("bt_io_set: %s", err->message);
>  		g_error_free(err);
> -		return FALSE;
>  	}
>  
>  	if (!bt_io_bcast_accept(io,
> @@ -3694,10 +3693,9 @@ static gboolean iso_do_big_sync(GIOChannel
> *io, GIOCondition cond,
>  			iso_bc_addr.bc_bis, BT_IO_OPT_INVALID)) {
>  		error("bt_io_bcast_accept: %s", err->message);
>  		g_error_free(err);
> -		return FALSE;
>  	}
>  
> -	return TRUE;
> +	return FALSE;
>  }
>  
>  static void long_pa_sync_confirm_cb(GIOChannel *io, void *user_data)
> 
> ---
> base-commit: 729f96089cf66831d911385623ca932e0c245913
> change-id: 20260729-fix_iofunc-e62cecc52b8e
> 
> Best regards,