From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: linuxtestproject.agent@gmail.com
Cc: Xuewen Wang <wangxuewen@kylinos.cn>, ltp@lists.linux.it
Subject: Re: [LTP] memcg/functional: fix memcg_failcnt intermittent timeout by disabling swap
Date: Mon, 03 Aug 2026 13:38:37 +0000 [thread overview]
Message-ID: <6a7099dd.c69142e7.53fee.7114@mx.google.com> (raw)
In-Reply-To: <20260731024600.3976-1-linuxtestproject.agent@gmail.com>
Hi Xuewen,
> > memcg/functional: fix memcg_failcnt intermittent timeout by disabling swap
>
> > + swapoff -a 2>/dev/null
> > +
> > start_memcg_process $2 -s ${MEMORY_TO_ALLOCATE}
>
> The 2>/dev/null here hides errors from the very command that implements
> the fix. If swapoff fails, or the command is not present, swap stays
> enabled and the intermittent timeout this patch targets can recur, now
> without any diagnostic to explain it.
>
> memcg_limit_in_bytes.sh, cited as the model for this change, runs
> swapoff -a and swapon -a without redirecting stderr. Would dropping the
> redirect (at least on swapoff) be preferable, so a failure to disable
> swap remains visible?
This is correct. If swapoff fails, we can't understand why.
Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-08-03 13:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 1:49 [LTP] [PATCH] memcg/functional: fix memcg_failcnt intermittent timeout by disabling swap Xuewen Wang
2026-07-31 2:46 ` [LTP] " linuxtestproject.agent
2026-08-03 13:38 ` Andrea Cervesato via ltp [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-08-05 6:40 [LTP] [PATCH v2] " Xuewen Wang
2026-08-05 7:40 ` [LTP] " linuxtestproject.agent
2026-08-07 1:44 [LTP] [PATCH v3] " Xuewen Wang
2026-08-07 2:51 ` [LTP] " linuxtestproject.agent
2026-08-07 3:52 ` Li Wang
2026-08-07 5:34 ` Andrea Cervesato via ltp
2026-08-07 6:20 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a7099dd.c69142e7.53fee.7114@mx.google.com \
--to=ltp@lists.linux.it \
--cc=andrea.cervesato@suse.com \
--cc=linuxtestproject.agent@gmail.com \
--cc=wangxuewen@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.