All of lore.kernel.org
 help / color / mirror / Atom feed
* Forwarded: Re: [syzbot ci] Re: net/smc: fix clcsock and lgr/lnk races in smc_diag dump path
       [not found] <81003c25-0d13-4fe7-b7b2-2c676f043899@linux.ibm.com>
@ 2026-08-12  6:35 ` syzbot
  2026-08-12  6:36   ` syzbot ci
  0 siblings, 1 reply; 5+ messages in thread
From: syzbot @ 2026-08-12  6:35 UTC (permalink / raw)
  To: syzbot; +Cc: syzbot, mjambigi

For archival purposes, forwarding an incoming command email to
syzbot@lists.linux.dev.

***

Subject: Re: [syzbot ci] Re: net/smc: fix clcsock and lgr/lnk races in smc_diag dump path
Author: mjambigi@linux.ibm.com

#syz test

v4: Moves mutex_init(&clcsock_release_lock) before sk->sk_prot->hash(sk)
in smc_sk_init() to fix the uninitialized mutex warning you reported.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Forwarded: Re: [syzbot ci] Re: net/smc: fix clcsock and lgr/lnk races in smc_diag dump path
  2026-08-12  6:35 ` syzbot
@ 2026-08-12  6:36   ` syzbot ci
  0 siblings, 0 replies; 5+ messages in thread
From: syzbot ci @ 2026-08-12  6:36 UTC (permalink / raw)
  To: syzbot; +Cc: mjambigi, syzbot

> For archival purposes, forwarding an incoming command email to
> syzbot@lists.linux.dev.
>
> ***
>
> Subject: Re: [syzbot ci] Re: net/smc: fix clcsock and lgr/lnk races in smc_diag dump path
> Author: mjambigi@linux.ibm.com
>
> #syz test

Please attach the patch to act upon.

>
> v4: Moves mutex_init(&clcsock_release_lock) before sk->sk_prot->hash(sk)
> in smc_sk_init() to fix the uninitialized mutex warning you reported.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Forwarded: Re: [syzbot ci] Re: net/smc: fix clcsock and lgr/lnk races in smc_diag dump path
       [not found] <3fed64ca-e62e-448f-ba4c-7cd1f0543899@linux.ibm.com>
@ 2026-08-12 12:32 ` syzbot
  2026-08-12 12:34   ` syzbot ci
  0 siblings, 1 reply; 5+ messages in thread
From: syzbot @ 2026-08-12 12:32 UTC (permalink / raw)
  To: syzbot; +Cc: syzbot, mjambigi

For archival purposes, forwarding an incoming command email to
syzbot@lists.linux.dev.

***

Subject: Re: [syzbot ci] Re: net/smc: fix clcsock and lgr/lnk races in smc_diag dump path
Author: mjambigi@linux.ibm.com

#syz test:
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

v4: Move hash(sk) to the end of smc_sk_init() so the socket is published
only after it is fully constructed.

diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
index 00403175b740..5e7560417ec7 100644
--- a/net/smc/af_smc.c
+++ b/net/smc/af_smc.c
@@ -409,13 +409,13 @@ void smc_sk_init(struct net *net, struct sock *sk,
int protocol)
 				      "sk_lock-AF_SMC", &smc_key);
 	spin_lock_init(&smc->accept_q_lock);
 	spin_lock_init(&smc->conn.send_lock);
-	sk->sk_prot->hash(sk);
 	mutex_init(&smc->clcsock_release_lock);
 	smc_init_saved_callbacks(smc);
 	smc->limit_smc_hs = net->smc.limit_smc_hs;
 	smc->use_fallback = false; /* assume rdma capability first */
 	smc->fallback_rsn = 0;
 	smc_close_init(smc);
+	sk->sk_prot->hash(sk);
 }

 static struct sock *smc_sock_alloc(struct net *net, struct socket *sock,

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: Forwarded: Re: [syzbot ci] Re: net/smc: fix clcsock and lgr/lnk races in smc_diag dump path
  2026-08-12 12:32 ` Forwarded: Re: [syzbot ci] Re: net/smc: fix clcsock and lgr/lnk races in smc_diag dump path syzbot
@ 2026-08-12 12:34   ` syzbot ci
  0 siblings, 0 replies; 5+ messages in thread
From: syzbot ci @ 2026-08-12 12:34 UTC (permalink / raw)
  To: syzbot; +Cc: mjambigi, syzbot

> For archival purposes, forwarding an incoming command email to
> syzbot@lists.linux.dev.
>
> ***
>
> Subject: Re: [syzbot ci] Re: net/smc: fix clcsock and lgr/lnk races in smc_diag dump path
> Author: mjambigi@linux.ibm.com
>
> #syz test:

syzbot-ci does not support `#syz test` with arguments.

> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>
> v4: Move hash(sk) to the end of smc_sk_init() so the socket is published
> only after it is fully constructed.
>
> diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
> index 00403175b740..5e7560417ec7 100644
> --- a/net/smc/af_smc.c
> +++ b/net/smc/af_smc.c
> @@ -409,13 +409,13 @@ void smc_sk_init(struct net *net, struct sock *sk,
> int protocol)
>  				      "sk_lock-AF_SMC", &smc_key);
>  	spin_lock_init(&smc->accept_q_lock);
>  	spin_lock_init(&smc->conn.send_lock);
> -	sk->sk_prot->hash(sk);
>  	mutex_init(&smc->clcsock_release_lock);
>  	smc_init_saved_callbacks(smc);
>  	smc->limit_smc_hs = net->smc.limit_smc_hs;
>  	smc->use_fallback = false; /* assume rdma capability first */
>  	smc->fallback_rsn = 0;
>  	smc_close_init(smc);
> +	sk->sk_prot->hash(sk);
>  }
>
>  static struct sock *smc_sock_alloc(struct net *net, struct socket *sock,

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Forwarded: Re: [syzbot ci] Re: net/smc: fix clcsock and lgr/lnk races in smc_diag dump path
       [not found] <df7a4fe7-d9be-4a5d-942b-5ca3c1fb1031@linux.ibm.com>
@ 2026-08-12 12:38 ` syzbot
  0 siblings, 0 replies; 5+ messages in thread
From: syzbot @ 2026-08-12 12:38 UTC (permalink / raw)
  To: syzbot; +Cc: syzbot, mjambigi

For archival purposes, forwarding an incoming command email to
syzbot@lists.linux.dev.

***

Subject: Re: [syzbot ci] Re: net/smc: fix clcsock and lgr/lnk races in smc_diag dump path
Author: mjambigi@linux.ibm.com

#syz test

v4: Move hash(sk) to the end of smc_sk_init() so the socket is published only after it is fully constructed.

diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
index 00403175b740..5e7560417ec7 100644
--- a/net/smc/af_smc.c
+++ b/net/smc/af_smc.c
@@ -409,13 +409,13 @@ void smc_sk_init(struct net *net, struct sock *sk, int protocol)
 				      "sk_lock-AF_SMC", &smc_key);
 	spin_lock_init(&smc->accept_q_lock);
 	spin_lock_init(&smc->conn.send_lock);
-	sk->sk_prot->hash(sk);
 	mutex_init(&smc->clcsock_release_lock);
 	smc_init_saved_callbacks(smc);
 	smc->limit_smc_hs = net->smc.limit_smc_hs;
 	smc->use_fallback = false; /* assume rdma capability first */
 	smc->fallback_rsn = 0;
 	smc_close_init(smc);
+	sk->sk_prot->hash(sk);
 }

 static struct sock *smc_sock_alloc(struct net *net, struct socket *sock,

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-08-12 12:38 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <3fed64ca-e62e-448f-ba4c-7cd1f0543899@linux.ibm.com>
2026-08-12 12:32 ` Forwarded: Re: [syzbot ci] Re: net/smc: fix clcsock and lgr/lnk races in smc_diag dump path syzbot
2026-08-12 12:34   ` syzbot ci
     [not found] <df7a4fe7-d9be-4a5d-942b-5ca3c1fb1031@linux.ibm.com>
2026-08-12 12:38 ` syzbot
     [not found] <81003c25-0d13-4fe7-b7b2-2c676f043899@linux.ibm.com>
2026-08-12  6:35 ` syzbot
2026-08-12  6:36   ` syzbot ci

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.