[PATCH] Bluetooth: btmtk: improve error logs of MT79xx WMT operations

[PATCH] Bluetooth: btmtk: improve error logs of MT79xx WMT operations

[Jiajia Liu]

There are some identical error logs, making it difficult to distinguish
which step has the error. Improve them based on BTMTK_WMT_FUNC_CTRL and
BTMTK_WMT_PATCH_DWNLD calls and comments.

Signed-off-by: Jiajia Liu <liujiajia@kylinos.cn>
---
 drivers/bluetooth/btmtk.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c
index 02a96342e964..bbd0ac41fdb7 100644
--- a/drivers/bluetooth/btmtk.c
+++ b/drivers/bluetooth/btmtk.c
@@ -198,7 +198,7 @@ int btmtk_setup_firmware_79xx(struct hci_dev *hdev, const char *fwname,
 
 				err = wmt_cmd_sync(hdev, &wmt_params);
 				if (err < 0) {
-					bt_dev_err(hdev, "Failed to send wmt patch dwnld (%d)",
+					bt_dev_err(hdev, "Failed to get wmt patch status (%d)",
 						   err);
 					goto err_release_fw;
 				}
@@ -251,7 +251,7 @@ int btmtk_setup_firmware_79xx(struct hci_dev *hdev, const char *fwname,
 					err = -EIO;
 					goto err_release_fw;
 				} else if (err < 0) {
-					bt_dev_err(hdev, "Failed to send wmt patch dwnld (%d)",
+					bt_dev_err(hdev, "Failed to send wmt patch data (%d)",
 						   err);
 					goto err_release_fw;
 				}
@@ -1424,7 +1424,7 @@ int btmtk_usb_setup(struct hci_dev *hdev)
 
 		err = btmtk_usb_hci_wmt_sync(hdev, &wmt_params);
 		if (err < 0) {
-			bt_dev_err(hdev, "Failed to send wmt func ctrl (%d)", err);
+			bt_dev_err(hdev, "Failed to enable protocol (%d)", err);
 			return err;
 		}
 
@@ -1550,7 +1550,7 @@ int btmtk_usb_shutdown(struct hci_dev *hdev)
 
 	err = btmtk_usb_hci_wmt_sync(hdev, &wmt_params);
 	if (err < 0) {
-		bt_dev_err(hdev, "Failed to send wmt func ctrl (%d)", err);
+		bt_dev_err(hdev, "Failed to disable device (%d)", err);
 		usb_autopm_put_interface(data->intf);
 		return err;
 	}
-- 
2.55.0

RE: Bluetooth: btmtk: improve error logs of MT79xx WMT operations

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1145096

---Test result---

Test Summary:
CheckPatch                    PASS      2.83 seconds
VerifyFixes                   PASS      0.17 seconds
VerifySignedoff               PASS      0.13 seconds
GitLint                       PASS      0.24 seconds
SubjectPrefix                 PASS      0.08 seconds
BuildKernel                   PASS      27.87 seconds
CheckAllWarning               PASS      30.41 seconds
CheckSparse                   PASS      29.24 seconds
BuildKernel32                 PASS      27.25 seconds
CheckKernelLLVM               SKIP      0.00 seconds
TestRunnerSetup               PASS      507.95 seconds
IncrementalBuild              PASS      26.10 seconds

Details
##############################
Test: CheckKernelLLVM - SKIP
Desc: Build kernel with LLVM + context analysis
Output:
Clang not found


https://github.com/bluez/bluetooth-next/pull/575

---
Regards,
Linux Bluetooth