All of lore.kernel.org
 help / color / mirror / Atom feed
* [BlueZ] attrib: Fix smatch "non-ANSI function declaration" warning
@ 2026-08-14  9:27 Bastien Nocera
  2026-08-14 10:57 ` bluez.test.bot
  2026-08-14 17:20 ` patchwork-bot+bluetooth
  0 siblings, 2 replies; 3+ messages in thread
From: Bastien Nocera @ 2026-08-14  9:27 UTC (permalink / raw)
  To: linux-bluetooth

attrib/interactive.c:175:27: warning: non-ANSI function declaration of function 'disconnect_io'
---
 attrib/interactive.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/attrib/interactive.c b/attrib/interactive.c
index 07d6cafc57ba..0291fa876533 100644
--- a/attrib/interactive.c
+++ b/attrib/interactive.c
@@ -172,7 +172,7 @@ static void connect_cb(GIOChannel *io, GError *err, gpointer user_data)
 	rl_printf("Connection successful\n");
 }
 
-static void disconnect_io()
+static void disconnect_io(void)
 {
 	if (conn_state == STATE_DISCONNECTED)
 		return;
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [BlueZ] attrib: Fix smatch "non-ANSI function declaration" warning
  2026-08-14  9:27 [BlueZ] attrib: Fix smatch "non-ANSI function declaration" warning Bastien Nocera
@ 2026-08-14 10:57 ` bluez.test.bot
  2026-08-14 17:20 ` patchwork-bot+bluetooth
  1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2026-08-14 10:57 UTC (permalink / raw)
  To: linux-bluetooth, hadess

[-- Attachment #1: Type: text/plain, Size: 2484 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1145981

---Test result---

Test Summary:
CheckPatch                    FAIL      0.36 seconds
GitLint                       FAIL      0.24 seconds
BuildEll                      PASS      17.38 seconds
BluezMake                     PASS      483.22 seconds
MakeCheck                     PASS      0.81 seconds
MakeDistcheck                 PASS      124.51 seconds
CheckValgrind                 PASS      115.91 seconds
CheckSmatch                   WARNING   230.51 seconds
bluezmakeextell               PASS      75.66 seconds
IncrementalBuild              PASS      461.57 seconds
ScanBuild                     PASS      706.53 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ] attrib: Fix smatch "non-ANSI function declaration" warning
WARNING:EMAIL_SUBJECT: A patch subject line should describe the change not the tool that found it
#34: 
Subject: [BlueZ] attrib: Fix smatch "non-ANSI function declaration" warning

/github/workspace/src/patch/14750038.patch total: 0 errors, 1 warnings, 8 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/patch/14750038.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ] attrib: Fix smatch "non-ANSI function declaration" warning

3: B1 Line exceeds max length (95>80): "attrib/interactive.c:175:27: warning: non-ANSI function declaration of function 'disconnect_io'"
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
attrib/interactive.c: note: in included file (through /usr/include/readline/readline.h):attrib/interactive.c:300:23: warning: Variable length array is used.


https://github.com/bluez/bluez/pull/2399

---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [BlueZ] attrib: Fix smatch "non-ANSI function declaration" warning
  2026-08-14  9:27 [BlueZ] attrib: Fix smatch "non-ANSI function declaration" warning Bastien Nocera
  2026-08-14 10:57 ` bluez.test.bot
@ 2026-08-14 17:20 ` patchwork-bot+bluetooth
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+bluetooth @ 2026-08-14 17:20 UTC (permalink / raw)
  To: Bastien Nocera; +Cc: linux-bluetooth

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri, 14 Aug 2026 11:27:41 +0200 you wrote:
> attrib/interactive.c:175:27: warning: non-ANSI function declaration of function 'disconnect_io'
> ---
>  attrib/interactive.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [BlueZ] attrib: Fix smatch "non-ANSI function declaration" warning
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=a01be7144cd8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-08-14 17:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-14  9:27 [BlueZ] attrib: Fix smatch "non-ANSI function declaration" warning Bastien Nocera
2026-08-14 10:57 ` bluez.test.bot
2026-08-14 17:20 ` patchwork-bot+bluetooth

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.