[PATCH BlueZ] media: fix wrong argument to lp_get_uid() in avrcp-player

[PATCH BlueZ] media: fix wrong argument to lp_get_uid() in avrcp-player

[Pauli Virtanen]

In track_changed(), lp_get_uid() is passed struct local_player although
player_link is expected, which is ASAN crash.  It takes void * since
it's avrcp_player_cb callback function, so wasn't caught by compiler.

Pass the right object. Fixes AddressSanitizer: heap-buffer-overflow
---
 profiles/audio/avrcp-player.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/profiles/audio/avrcp-player.c b/profiles/audio/avrcp-player.c
index d335e7ef6..43db0dc45 100644
--- a/profiles/audio/avrcp-player.c
+++ b/profiles/audio/avrcp-player.c
@@ -198,7 +198,7 @@ static void track_position(uint32_t old, uint32_t position, void *user_data)
 static void track_changed(void *user_data)
 {
 	struct player_link *p = user_data;
-	uint64_t uid = lp_get_uid(p->lp);
+	uint64_t uid = lp_get_uid(p);
 
 	avrcp_player_event(p->avrcp, AVRCP_EVENT_TRACK_CHANGED, &uid);
 	avrcp_player_event(p->avrcp, AVRCP_EVENT_TRACK_REACHED_START, NULL);
-- 
2.55.0

RE: [BlueZ] media: fix wrong argument to lp_get_uid() in avrcp-player

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 987 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1146603

---Test result---

Test Summary:
CheckPatch                    PASS      0.41 seconds
GitLint                       PASS      0.47 seconds
BuildEll                      PASS      20.50 seconds
BluezMake                     PASS      575.14 seconds
MakeCheck                     PASS      3.80 seconds
MakeDistcheck                 PASS      157.59 seconds
CheckValgrind                 PASS      154.82 seconds
CheckSmatch                   PASS      307.51 seconds
bluezmakeextell               PASS      97.74 seconds
IncrementalBuild              PASS      586.80 seconds
ScanBuild                     PASS      894.53 seconds



https://github.com/bluez/bluez/pull/2405

---
Regards,
Linux Bluetooth