* [LTP] [PATCH] setsockopt08: make check fixes
@ 2026-08-28 10:01 Avinesh Kumar via ltp
2026-08-28 11:15 ` Andrea Cervesato via ltp
2026-08-28 11:16 ` Andrea Cervesato via ltp
0 siblings, 2 replies; 3+ messages in thread
From: Avinesh Kumar via ltp @ 2026-08-28 10:01 UTC (permalink / raw)
To: ltp
From: Avinesh Kumar <avinesh.kumar@suse.com>
- correct misspelled 'layed'
- remove space after a cast
- make setup() and run() static
Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>
---
testcases/kernel/syscalls/setsockopt/setsockopt08.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/testcases/kernel/syscalls/setsockopt/setsockopt08.c b/testcases/kernel/syscalls/setsockopt/setsockopt08.c
index 3d1838f6ed73..c0be2f02489d 100644
--- a/testcases/kernel/syscalls/setsockopt/setsockopt08.c
+++ b/testcases/kernel/syscalls/setsockopt/setsockopt08.c
@@ -68,7 +68,7 @@
*
* That is, the padding gets inserted unconditionally during the transformation,
* independent of the actual values of ->u.user.match_size or
- * ->u.user.target_size and the result ends up getting layed out with proper
+ * ->u.user.target_size and the result ends up getting laid out with proper
* alignment only if said values match the expectations.
*
* That's not a problem in itself, but this unconditional insertion of padding
@@ -99,7 +99,7 @@
static void *buffer;
-void setup(void)
+static void setup(void)
{
if (!tst_is_compat_mode())
tst_res(TINFO, "The vulnerability was only present in 32-bit compat mode");
@@ -107,7 +107,7 @@ void setup(void)
tst_setup_netns();
}
-void run(void)
+static void run(void)
{
const char *const res_fmt_str =
"setsockopt(%d, IPPROTO_IP, IPT_SO_SET_REPLACE, %p, 1)";
@@ -118,7 +118,7 @@ void run(void)
const size_t tgt_size = 32;
const size_t match_size = 1024 - 64 - 112 - 4 - tgt_size - 4;
struct xt_entry_target *xt_entry_tgt =
- ((struct xt_entry_target *) (&ipt_entry->elems[0] + match_size));
+ ((struct xt_entry_target *)(&ipt_entry->elems[0] + match_size));
int fd = SAFE_SOCKET(AF_INET, SOCK_DGRAM, 0);
int result;
--
2.55.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH] setsockopt08: make check fixes
2026-08-28 10:01 [LTP] [PATCH] setsockopt08: make check fixes Avinesh Kumar via ltp
@ 2026-08-28 11:15 ` Andrea Cervesato via ltp
2026-08-28 11:16 ` Andrea Cervesato via ltp
1 sibling, 0 replies; 3+ messages in thread
From: Andrea Cervesato via ltp @ 2026-08-28 11:15 UTC (permalink / raw)
To: Avinesh Kumar; +Cc: ltp
Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH] setsockopt08: make check fixes
2026-08-28 10:01 [LTP] [PATCH] setsockopt08: make check fixes Avinesh Kumar via ltp
2026-08-28 11:15 ` Andrea Cervesato via ltp
@ 2026-08-28 11:16 ` Andrea Cervesato via ltp
1 sibling, 0 replies; 3+ messages in thread
From: Andrea Cervesato via ltp @ 2026-08-28 11:16 UTC (permalink / raw)
To: Avinesh Kumar; +Cc: ltp
Merged, Thanks!
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-28 11:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-28 10:01 [LTP] [PATCH] setsockopt08: make check fixes Avinesh Kumar via ltp
2026-08-28 11:15 ` Andrea Cervesato via ltp
2026-08-28 11:16 ` Andrea Cervesato via ltp
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.