Re: [syzbot] [block?] general protection fault in blk_mq_quiesce_queue

[syzbot <syzbot+fefa0af09f7891b1800e@syzkaller.appspotmail.com>]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
WARNING in nvme_reset_ctrl_sync

------------[ cut here ]------------
!list_empty(&work->entry)
WARNING: kernel/workqueue.c:2432 at __queue_work+0xee4/0x1370 kernel/workqueue.c:2432, CPU#0: syz.3.20/6407
Modules linked in:
CPU: 0 UID: 0 PID: 6407 Comm: syz.3.20 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014
RIP: 0010:__queue_work+0xee4/0x1370 kernel/workqueue.c:2432
Code: 44 89 f6 e8 9e 35 3b 00 45 84 f6 0f 85 f7 f1 ff ff e9 54 7f 51 ff e8 7b 3b 3b 00 90 0f 0b 90 e9 7c f4 ff ff e8 6d 3b 3b 00 90 <0f> 0b 90 e9 95 f5 ff ff e8 5f 3b 3b 00 4c 89 e2 48 b8 00 00 00 00
RSP: 0018:ffffc90003f57af8 EFLAGS: 00010093
RAX: 0000000000000000 RBX: ffff888029078800 RCX: 0000000000000001
RDX: ffff8880290a0000 RSI: ffffffff81d000c3 RDI: ffff8880290a0000
RBP: ffff88804c6c8b10 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000000000001 R11: 0000000000000000 R12: ffff88804c6c8b18
R13: 1ffff920007eaf69 R14: ffff8880280cd000 R15: dffffc0000000000
FS:  0000000000000000(0000) GS:ffff888096967000(0063) knlGS:00000000f6804b40
CS:  0010 DS: 002b ES: 002b CR0: 0000000080050033
CR2: 00007f04c5506e9c CR3: 000000004e47d000 CR4: 0000000000352ef0
Call Trace:
 <TASK>
 queue_work_on+0x180/0x1e0 kernel/workqueue.c:2501
 queue_work include/linux/workqueue.h:700 [inline]
 nvme_reset_ctrl drivers/nvme/host/core.c:226 [inline]
 nvme_reset_ctrl_sync+0x51/0xe0 drivers/nvme/host/core.c:236
 nvme_sysfs_reset+0x35/0x80 drivers/nvme/host/sysfs.c:21
 dev_attr_store+0x58/0x80 drivers/base/core.c:2509
 sysfs_kf_write+0xf2/0x150 fs/sysfs/file.c:145
 kernfs_fop_write_iter+0x3e0/0x5f0 fs/kernfs/file.c:345
 new_sync_write fs/read_write.c:595 [inline]
 vfs_write+0x6af/0x1050 fs/read_write.c:687
 ksys_write+0x12a/0x250 fs/read_write.c:739
 do_syscall_32_irqs_on arch/x86/entry/syscall_32.c:79 [inline]
 __do_fast_syscall_32+0x13a/0x8b0 arch/x86/entry/syscall_32.c:291
 do_fast_syscall_32+0x32/0x70 arch/x86/entry/syscall_32.c:316
 entry_SYSENTER_compat_after_hwframe+0x84/0x8e
RIP: 0023:0xf702efec
Code: Unable to access opcode bytes at 0xf702efc2.
RSP: 002b:00000000f680450c EFLAGS: 00000292 ORIG_RAX: 0000000000000004
RAX: ffffffffffffffda RBX: 0000000000000004 RCX: 0000000080000480
RDX: 0000000000000001 RSI: 0000000000000000 RDI: 0000000000000000
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000292 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
 </TASK>


Tested on:

commit:         940de590 Merge tag 'hardening-v7.3-rc2' of git://git.k..
git tree:       git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
console output: https://syzkaller.appspot.com/x/log.txt?x=16cecb49580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=85bc5cc2fc7394d9
dashboard link: https://syzkaller.appspot.com/bug?extid=fefa0af09f7891b1800e
compiler:       gcc (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44
userspace arch: i386
patch:          https://syzkaller.appspot.com/x/patch.diff?x=14cca125580000