[PATCH 1/4] Bluetooth: btmtksdio: Fix runtime PM leak in btmtksdio_reset()

[PATCH 1/4] Bluetooth: btmtksdio: Fix runtime PM leak in btmtksdio_reset()

[Wentao Liang]

btmtksdio_reset() takes a runtime PM reference with
pm_runtime_get_sync(bdev->dev), which leaves the device's usage
count incremented even when it fails.  However, when the reset has
already been started (BTMTKSDIO_HW_RESET_ACTIVE is found set by
test_and_set_bit()), the function returns early without dropping
that reference, leaking it on every concurrent reset request.

Add a pm_runtime_put_noidle() on the early-exit path to keep the
usage count balanced.

Fixes: 8fafe702253d ("Bluetooth: mt7921s: support bluetooth reset mechanism")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
 drivers/bluetooth/btmtksdio.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
index 5b0fab7b89b5..243215a81fa7 100644
--- a/drivers/bluetooth/btmtksdio.c
+++ b/drivers/bluetooth/btmtksdio.c
@@ -1280,8 +1280,10 @@ static void btmtksdio_reset(struct hci_dev *hdev)
 
 	pm_runtime_get_sync(bdev->dev);
 
-	if (test_and_set_bit(BTMTKSDIO_HW_RESET_ACTIVE, &bdev->tx_state))
+	if (test_and_set_bit(BTMTKSDIO_HW_RESET_ACTIVE, &bdev->tx_state)) {
+		pm_runtime_put_noidle(bdev->dev);
 		return;
+	}
 
 	sdio_claim_host(bdev->func);
 
-- 
2.34.1

RE: [1/4] Bluetooth: btmtksdio: Fix runtime PM leak in btmtksdio_reset()

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1165045/

---Test result---

Test Summary:
CheckPatch                    PASS      1.31 seconds
VerifyFixes                   PASS      0.11 seconds
VerifySignedoff               PASS      0.17 seconds
GitLint                       PASS      0.60 seconds
SubjectPrefix                 PASS      0.20 seconds
BuildKernel                   PASS      28.31 seconds
CheckAllWarning               PASS      32.38 seconds
CheckSparse                   PASS      35.52 seconds
BuildKernel32                 PASS      29.13 seconds
CheckKernelLLVM               PASS      33.74 seconds
TestRunnerSetup               PASS      730.24 seconds
IncrementalBuild              PASS      28.47 seconds



https://github.com/bluez/bluetooth-next/pull/768

---
Regards,
Linux Bluetooth