[PATCH v2 0/5] Handheld gaming PC panel orientation quirks

[PATCH v2 0/5] Handheld gaming PC panel orientation quirks

[John Edwards]

Hello.

I am submitting a small number of patches to add panel rotation quirks for
a few handheld gaming PCs.  These patches were created by the SteamFork
team and are in daily use by us and/or members of our community.

The following devices are covered by these patches:
1: AYANEO 2S
2: AYANEO Flip DS, AYANEO Flip KB
3: AYANEO Slide, Antec Core HS
4: GPD Win 2 (with correct DMI strings)
5: OneXPlayer Mini (Intel)

Thank you for your consideration and for taking the time to review these
patches.

John Edwards

v2:
- Minor rewording of commit messages
- Include Tested-by tag for Paco Avelar in AYANEO Flip DS/KB patch
- Add OneXPlayer Mini (Intel) patch

v1:
https://lore.kernel.org/dri-devel/20250116155049.39647-2-uejji@uejji.net/

Andrew Wyatt (5):
  drm: panel-orientation-quirks: Add support for AYANEO 2S
  drm: panel-orientation-quirks: Add quirks for AYA NEO Flip DS and KB
  drm: panel-orientation-quirks: Add quirk for AYA NEO Slide
  drm: panel-orientation-quirks: Add new quirk for GPD Win 2
  drm: panel-orientation-quirks: Add quirk for OneXPlayer Mini (Intel)

 .../gpu/drm/drm_panel_orientation_quirks.c    | 40 ++++++++++++++++++-
 1 file changed, 38 insertions(+), 2 deletions(-)

-- 
2.43.0

[PATCH v2 1/5] drm: panel-orientation-quirks: Add support for AYANEO 2S

[John Edwards]

From: Andrew Wyatt <fewtarius@steamfork.org>

AYANEO 2S uses the same panel and orientation as the AYANEO 2.

Update the AYANEO 2 DMI match to also match AYANEO 2S.

Signed-off-by: Andrew Wyatt <fewtarius@steamfork.org>
Signed-off-by: John Edwards <uejji@uejji.net>
Tested-by: John Edwards <uejji@uejji.net>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 4a73821b8..f9c975338 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -184,10 +184,10 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T103HAF"),
 		},
 		.driver_data = (void *)&lcd800x1280_rightside_up,
-	}, {	/* AYA NEO AYANEO 2 */
+	}, {	/* AYA NEO AYANEO 2/2S */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
-		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AYANEO 2"),
+		  DMI_MATCH(DMI_PRODUCT_NAME, "AYANEO 2"),
 		},
 		.driver_data = (void *)&lcd1200x1920_rightside_up,
 	}, {	/* AYA NEO 2021 */
-- 
2.43.0

[PATCH v2 2/5] drm: panel-orientation-quirks: Add quirks for AYA NEO Flip DS and KB

[John Edwards]

From: Andrew Wyatt <fewtarius@steamfork.org>

The AYA NEO Flip DS and KB both use a 1080x1920 portrait LCD panel.  The
Flip DS additionally uses a 640x960 portrait LCD panel as a second display.

Add DMI matches to correctly rotate these panels.

Signed-off-by: Andrew Wyatt <fewtarius@steamfork.org>
Co-developed-by: John Edwards <uejji@uejji.net>
Signed-off-by: John Edwards <uejji@uejji.net>
Tested-by: Paco Avelar <pacoavelar@hotmail.com>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index f9c975338..c5acf2628 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -93,6 +93,12 @@ static const struct drm_dmi_panel_orientation_data onegx1_pro = {
 	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
 };
 
+static const struct drm_dmi_panel_orientation_data lcd640x960_leftside_up = {
+	.width = 640,
+	.height = 960,
+	.orientation = DRM_MODE_PANEL_ORIENTATION_LEFT_UP,
+};
+
 static const struct drm_dmi_panel_orientation_data lcd720x1280_rightside_up = {
 	.width = 720,
 	.height = 1280,
@@ -202,6 +208,18 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_MATCH(DMI_PRODUCT_NAME, "AIR"),
 		},
 		.driver_data = (void *)&lcd1080x1920_leftside_up,
+	}, {    /* AYA NEO Flip DS Bottom Screen */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "FLIP DS"),
+	},
+		.driver_data = (void *)&lcd640x960_leftside_up,
+	}, {    /* AYA NEO Flip KB/DS Top Screen */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
+		  DMI_MATCH(DMI_PRODUCT_NAME, "FLIP"),
+	},
+		.driver_data = (void *)&lcd1080x1920_leftside_up,
 	}, {	/* AYA NEO Founder */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYA NEO"),
-- 
2.43.0

[PATCH v2 3/5] drm: panel-orientation-quirks: Add quirk for AYA NEO Slide

[John Edwards]

From: Andrew Wyatt <fewtarius@steamfork.org>

The AYANEO Slide uses a 1080x1920 portrait LCD panel.  This is the same
panel used on the AYANEO Air Plus, but the DMI data is too different to
match both with one entry.

Add a DMI match to correctly rotate the panel on the AYANEO Slide.

This also covers the Antec Core HS, which is a rebranded AYANEO Slide with
the exact same hardware and DMI strings.

Signed-off-by: Andrew Wyatt <fewtarius@steamfork.org>
Signed-off-by: John Edwards <uejji@uejji.net>
Tested-by: John Edwards <uejji@uejji.net>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index c5acf2628..9e6708cd1 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -244,6 +244,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_MATCH(DMI_BOARD_NAME, "KUN"),
 		},
 		.driver_data = (void *)&lcd1600x2560_rightside_up,
+	}, {	/* AYA NEO SLIDE */
+		 .matches = {
+		   DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
+		   DMI_MATCH(DMI_PRODUCT_NAME, "SLIDE"),
+	},
+		.driver_data = (void *)&lcd1080x1920_leftside_up,
 	}, {    /* AYN Loki Max */
 		.matches = {
 			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ayn"),
-- 
2.43.0

[PATCH v2 4/5] drm: panel-orientation-quirks: Add new quirk for GPD Win 2

[John Edwards]

From: Andrew Wyatt <fewtarius@steamfork.org>

Some GPD Win 2 units shipped with the correct DMI strings.

Add a DMI match to correctly rotate the panel on these units.

Signed-off-by: Andrew Wyatt <fewtarius@steamfork.org>
Signed-off-by: John Edwards <uejji@uejji.net>
Tested-by: Paco Avelar <pacoavelar@hotmail.com>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 9e6708cd1..e6148cc31 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -339,6 +339,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
 		},
 		.driver_data = (void *)&gpd_win2,
+	}, {	/* GPD Win 2 (correct DMI strings) */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "GPD"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "WIN2")
+		},
+		.driver_data = (void *)&lcd720x1280_rightside_up,
 	}, {	/* GPD Win 3 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "GPD"),
-- 
2.43.0

[PATCH v2 5/5] drm: panel-orientation-quirks: Add quirk for OneXPlayer Mini (Intel) From: Andrew Wyatt <fewtarius@steamfork.org>

[John Edwards]

The Intel model of the OneXPlayer Mini uses a 1200x1920 portrait LCD panel.
The DMI strings are the same as the OneXPlayer, which already has a DMI
quirk, but the panel is different.

Add a DMI match to correctly rotate this panel.

Signed-off-by: Andrew Wyatt <fewtarius@steamfork.org>
Co-developed-by: John Edwards <uejji@uejji.net>
Signed-off-by: John Edwards <uejji@uejji.net>
Tested-by: João Pedro Kurtz <joexkurtz@gmail.com>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index e6148cc31..88aa57c15 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -129,6 +129,12 @@ static const struct drm_dmi_panel_orientation_data lcd1080x1920_rightside_up = {
 	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
 };
 
+static const struct drm_dmi_panel_orientation_data lcd1200x1920_leftside_up = {
+	.width = 1200,
+	.height = 1920,
+	.orientation = DRM_MODE_PANEL_ORIENTATION_LEFT_UP,
+};
+
 static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = {
 	.width = 1200,
 	.height = 1920,
@@ -473,6 +479,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONE XPLAYER"),
 		},
 		.driver_data = (void *)&lcd1600x2560_leftside_up,
+	}, {	/* OneXPlayer Mini (Intel) */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK TECHNOLOGY CO., LTD."),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONE XPLAYER"),
+		},
+		.driver_data = (void *)&lcd1200x1920_leftside_up,
 	}, {	/* OrangePi Neo */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),
-- 
2.43.0

[PATCH v2 5/5] drm: panel-orientation-quirks: Add quirk for OneXPlayer Mini (Intel)

[John Edwards]

From: Andrew Wyatt <fewtarius@steamfork.org>

The Intel model of the OneXPlayer Mini uses a 1200x1920 portrait LCD panel.
The DMI strings are the same as the OneXPlayer, which already has a DMI
quirk, but the panel is different.

Add a DMI match to correctly rotate this panel.

Signed-off-by: Andrew Wyatt <fewtarius@steamfork.org>
Co-developed-by: John Edwards <uejji@uejji.net>
Signed-off-by: John Edwards <uejji@uejji.net>
Tested-by: João Pedro Kurtz <joexkurtz@gmail.com>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index e6148cc31..88aa57c15 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -129,6 +129,12 @@ static const struct drm_dmi_panel_orientation_data lcd1080x1920_rightside_up = {
 	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
 };
 
+static const struct drm_dmi_panel_orientation_data lcd1200x1920_leftside_up = {
+	.width = 1200,
+	.height = 1920,
+	.orientation = DRM_MODE_PANEL_ORIENTATION_LEFT_UP,
+};
+
 static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = {
 	.width = 1200,
 	.height = 1920,
@@ -473,6 +479,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONE XPLAYER"),
 		},
 		.driver_data = (void *)&lcd1600x2560_leftside_up,
+	}, {	/* OneXPlayer Mini (Intel) */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK TECHNOLOGY CO., LTD."),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONE XPLAYER"),
+		},
+		.driver_data = (void *)&lcd1200x1920_leftside_up,
 	}, {	/* OrangePi Neo */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),
-- 
2.43.0

Re: [PATCH v2 5/5] drm: panel-orientation-quirks: Add quirk for OneXPlayer Mini (Intel) From: Andrew Wyatt <fewtarius@steamfork.org>

[John Edwards]

My deepest apologies.  There was a serious formatting error in this email
that was discovered too late.  I have resubmitted this.

John Edwards


On Fri, Jan 24, 2025 at 2:49 PM John Edwards <uejji@uejji.net> wrote:
>
> The Intel model of the OneXPlayer Mini uses a 1200x1920 portrait LCD panel.
> The DMI strings are the same as the OneXPlayer, which already has a DMI
> quirk, but the panel is different.
>
> Add a DMI match to correctly rotate this panel.
>
> Signed-off-by: Andrew Wyatt <fewtarius@steamfork.org>
> Co-developed-by: John Edwards <uejji@uejji.net>
> Signed-off-by: John Edwards <uejji@uejji.net>
> Tested-by: João Pedro Kurtz <joexkurtz@gmail.com>
> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index e6148cc31..88aa57c15 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -129,6 +129,12 @@ static const struct drm_dmi_panel_orientation_data lcd1080x1920_rightside_up = {
>         .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
>  };
>
> +static const struct drm_dmi_panel_orientation_data lcd1200x1920_leftside_up = {
> +       .width = 1200,
> +       .height = 1920,
> +       .orientation = DRM_MODE_PANEL_ORIENTATION_LEFT_UP,
> +};
> +
>  static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = {
>         .width = 1200,
>         .height = 1920,
> @@ -473,6 +479,12 @@ static const struct dmi_system_id orientation_data[] = {
>                   DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONE XPLAYER"),
>                 },
>                 .driver_data = (void *)&lcd1600x2560_leftside_up,
> +       }, {    /* OneXPlayer Mini (Intel) */
> +               .matches = {
> +                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK TECHNOLOGY CO., LTD."),
> +                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONE XPLAYER"),
> +               },
> +               .driver_data = (void *)&lcd1200x1920_leftside_up,
>         }, {    /* OrangePi Neo */
>                 .matches = {
>                   DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),
> --
> 2.43.0
>

Re: [PATCH v2 0/5] Handheld gaming PC panel orientation quirks

[Thomas Zimmermann]

Hi

Am 24.01.25 um 21:46 schrieb John Edwards:
> Hello.
>
> I am submitting a small number of patches to add panel rotation quirks for
> a few handheld gaming PCs.  These patches were created by the SteamFork
> team and are in daily use by us and/or members of our community.
>
> The following devices are covered by these patches:
> 1: AYANEO 2S
> 2: AYANEO Flip DS, AYANEO Flip KB
> 3: AYANEO Slide, Antec Core HS
> 4: GPD Win 2 (with correct DMI strings)
> 5: OneXPlayer Mini (Intel)
>
> Thank you for your consideration and for taking the time to review these
> patches.

Did you ever receive any response to this series? If not, then

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

for the series. Let me know if you need assistance for getting the patch 
files merged.

Best regards
Thomas

>
> John Edwards
>
> v2:
> - Minor rewording of commit messages
> - Include Tested-by tag for Paco Avelar in AYANEO Flip DS/KB patch
> - Add OneXPlayer Mini (Intel) patch
>
> v1:
> https://lore.kernel.org/dri-devel/20250116155049.39647-2-uejji@uejji.net/
>
> Andrew Wyatt (5):
>    drm: panel-orientation-quirks: Add support for AYANEO 2S
>    drm: panel-orientation-quirks: Add quirks for AYA NEO Flip DS and KB
>    drm: panel-orientation-quirks: Add quirk for AYA NEO Slide
>    drm: panel-orientation-quirks: Add new quirk for GPD Win 2
>    drm: panel-orientation-quirks: Add quirk for OneXPlayer Mini (Intel)
>
>   .../gpu/drm/drm_panel_orientation_quirks.c    | 40 ++++++++++++++++++-
>   1 file changed, 38 insertions(+), 2 deletions(-)
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Re: [PATCH v2 2/5] drm: panel-orientation-quirks: Add quirks for AYA NEO Flip DS and KB

[Hans de Goede]

Hi,

Thank you for your patches and sorry for being slow to respond.

On 24-Jan-25 9:46 PM, John Edwards wrote:
> From: Andrew Wyatt <fewtarius@steamfork.org>
> 
> The AYA NEO Flip DS and KB both use a 1080x1920 portrait LCD panel.  The
> Flip DS additionally uses a 640x960 portrait LCD panel as a second display.
> 
> Add DMI matches to correctly rotate these panels.
> 
> Signed-off-by: Andrew Wyatt <fewtarius@steamfork.org>
> Co-developed-by: John Edwards <uejji@uejji.net>
> Signed-off-by: John Edwards <uejji@uejji.net>
> Tested-by: Paco Avelar <pacoavelar@hotmail.com>
> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index f9c975338..c5acf2628 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -93,6 +93,12 @@ static const struct drm_dmi_panel_orientation_data onegx1_pro = {
>  	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
>  };
>  
> +static const struct drm_dmi_panel_orientation_data lcd640x960_leftside_up = {
> +	.width = 640,
> +	.height = 960,
> +	.orientation = DRM_MODE_PANEL_ORIENTATION_LEFT_UP,
> +};
> +
>  static const struct drm_dmi_panel_orientation_data lcd720x1280_rightside_up = {
>  	.width = 720,
>  	.height = 1280,
> @@ -202,6 +208,18 @@ static const struct dmi_system_id orientation_data[] = {
>  		  DMI_MATCH(DMI_PRODUCT_NAME, "AIR"),
>  		},
>  		.driver_data = (void *)&lcd1080x1920_leftside_up,
> +	}, {    /* AYA NEO Flip DS Bottom Screen */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "FLIP DS"),
> +	},

Since this '}' is closing the .matches initializer it should be indented 2 tabs,
note I think we can fix this up while merging things so no need for a v3
(assuming Thomas agrees).

> +		.driver_data = (void *)&lcd640x960_leftside_up,
> +	}, {    /* AYA NEO Flip KB/DS Top Screen */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
> +		  DMI_MATCH(DMI_PRODUCT_NAME, "FLIP"),
> +	},

Since this '}' is closing the .matches initializer it should be indented 2 tabs

> +		.driver_data = (void *)&lcd1080x1920_leftside_up,
>  	}, {	/* AYA NEO Founder */
>  		.matches = {
>  		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYA NEO"),

Regards,

Hans

Re: [PATCH v2 3/5] drm: panel-orientation-quirks: Add quirk for AYA NEO Slide

[Hans de Goede]

Hi,

On 24-Jan-25 9:46 PM, John Edwards wrote:
> From: Andrew Wyatt <fewtarius@steamfork.org>
> 
> The AYANEO Slide uses a 1080x1920 portrait LCD panel.  This is the same
> panel used on the AYANEO Air Plus, but the DMI data is too different to
> match both with one entry.
> 
> Add a DMI match to correctly rotate the panel on the AYANEO Slide.
> 
> This also covers the Antec Core HS, which is a rebranded AYANEO Slide with
> the exact same hardware and DMI strings.
> 
> Signed-off-by: Andrew Wyatt <fewtarius@steamfork.org>
> Signed-off-by: John Edwards <uejji@uejji.net>
> Tested-by: John Edwards <uejji@uejji.net>
> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index c5acf2628..9e6708cd1 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -244,6 +244,12 @@ static const struct dmi_system_id orientation_data[] = {
>  		  DMI_MATCH(DMI_BOARD_NAME, "KUN"),
>  		},
>  		.driver_data = (void *)&lcd1600x2560_rightside_up,
> +	}, {	/* AYA NEO SLIDE */
> +		 .matches = {
> +		   DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
> +		   DMI_MATCH(DMI_PRODUCT_NAME, "SLIDE"),
> +	},

Since this '}' is closing the .matches initializer it should be indented 2 tabs

> +		.driver_data = (void *)&lcd1080x1920_leftside_up,
>  	}, {    /* AYN Loki Max */
>  		.matches = {
>  			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ayn"),

Regards,

Hans

Re: [PATCH v2 0/5] Handheld gaming PC panel orientation quirks

[Hans de Goede]

Hi Thomas,

On 11-Feb-25 2:55 PM, Thomas Zimmermann wrote:
> Hi
> 
> Am 24.01.25 um 21:46 schrieb John Edwards:
>> Hello.
>>
>> I am submitting a small number of patches to add panel rotation quirks for
>> a few handheld gaming PCs.  These patches were created by the SteamFork
>> team and are in daily use by us and/or members of our community.
>>
>> The following devices are covered by these patches:
>> 1: AYANEO 2S
>> 2: AYANEO Flip DS, AYANEO Flip KB
>> 3: AYANEO Slide, Antec Core HS
>> 4: GPD Win 2 (with correct DMI strings)
>> 5: OneXPlayer Mini (Intel)
>>
>> Thank you for your consideration and for taking the time to review these
>> patches.
> 
> Did you ever receive any response to this series? If not, then
> 
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

I had the following remark for 3 new entries added in patches 2/5 + 3/5:

"Since this '}' is closing the .matches initializer it should be indented 2 tabs"

With that fixed, you can add my:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

to the entire series.

> for the series. Let me know if you need assistance for getting the patch files merged.

Normally I pickup/merge these panel orientation quirks, but I've been swamped
which is why these have just been sitting on the list.

Thomas, I would appreciate it if you can merge the set into drm-misc-fixes, with
the 3 minor indentation issues fixed.

Regards,

Hans




>> v2:
>> - Minor rewording of commit messages
>> - Include Tested-by tag for Paco Avelar in AYANEO Flip DS/KB patch
>> - Add OneXPlayer Mini (Intel) patch
>>
>> v1:
>> https://lore.kernel.org/dri-devel/20250116155049.39647-2-uejji@uejji.net/
>>
>> Andrew Wyatt (5):
>>    drm: panel-orientation-quirks: Add support for AYANEO 2S
>>    drm: panel-orientation-quirks: Add quirks for AYA NEO Flip DS and KB
>>    drm: panel-orientation-quirks: Add quirk for AYA NEO Slide
>>    drm: panel-orientation-quirks: Add new quirk for GPD Win 2
>>    drm: panel-orientation-quirks: Add quirk for OneXPlayer Mini (Intel)
>>
>>   .../gpu/drm/drm_panel_orientation_quirks.c    | 40 ++++++++++++++++++-
>>   1 file changed, 38 insertions(+), 2 deletions(-)
>>
> 

Re: [PATCH v2 0/5] Handheld gaming PC panel orientation quirks

[Thomas Zimmermann]

Hi

Am 12.02.25 um 11:51 schrieb Hans de Goede:
> Hi Thomas,
>
> On 11-Feb-25 2:55 PM, Thomas Zimmermann wrote:
>> Hi
>>
>> Am 24.01.25 um 21:46 schrieb John Edwards:
>>> Hello.
>>>
>>> I am submitting a small number of patches to add panel rotation quirks for
>>> a few handheld gaming PCs.  These patches were created by the SteamFork
>>> team and are in daily use by us and/or members of our community.
>>>
>>> The following devices are covered by these patches:
>>> 1: AYANEO 2S
>>> 2: AYANEO Flip DS, AYANEO Flip KB
>>> 3: AYANEO Slide, Antec Core HS
>>> 4: GPD Win 2 (with correct DMI strings)
>>> 5: OneXPlayer Mini (Intel)
>>>
>>> Thank you for your consideration and for taking the time to review these
>>> patches.
>> Did you ever receive any response to this series? If not, then
>>
>> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> I had the following remark for 3 new entries added in patches 2/5 + 3/5:
>
> "Since this '}' is closing the .matches initializer it should be indented 2 tabs"
>
> With that fixed, you can add my:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> to the entire series.
>
>> for the series. Let me know if you need assistance for getting the patch files merged.
> Normally I pickup/merge these panel orientation quirks, but I've been swamped
> which is why these have just been sitting on the list.
>
> Thomas, I would appreciate it if you can merge the set into drm-misc-fixes, with
> the 3 minor indentation issues fixed.

Sure, no problem. I'll wait for John to provide an update. Otherwise, 
I'll fix it myself while merging the series.

Best regards
Thomas

>
> Regards,
>
> Hans
>
>
>
>
>>> v2:
>>> - Minor rewording of commit messages
>>> - Include Tested-by tag for Paco Avelar in AYANEO Flip DS/KB patch
>>> - Add OneXPlayer Mini (Intel) patch
>>>
>>> v1:
>>> https://lore.kernel.org/dri-devel/20250116155049.39647-2-uejji@uejji.net/
>>>
>>> Andrew Wyatt (5):
>>>     drm: panel-orientation-quirks: Add support for AYANEO 2S
>>>     drm: panel-orientation-quirks: Add quirks for AYA NEO Flip DS and KB
>>>     drm: panel-orientation-quirks: Add quirk for AYA NEO Slide
>>>     drm: panel-orientation-quirks: Add new quirk for GPD Win 2
>>>     drm: panel-orientation-quirks: Add quirk for OneXPlayer Mini (Intel)
>>>
>>>    .../gpu/drm/drm_panel_orientation_quirks.c    | 40 ++++++++++++++++++-
>>>    1 file changed, 38 insertions(+), 2 deletions(-)
>>>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Re: [PATCH v2 0/5] Handheld gaming PC panel orientation quirks

[Hans de Goede]

Hi,

On 12-Feb-25 12:11 PM, Thomas Zimmermann wrote:
> Hi
> 
> Am 12.02.25 um 11:51 schrieb Hans de Goede:
>> Hi Thomas,
>>
>> On 11-Feb-25 2:55 PM, Thomas Zimmermann wrote:
>>> Hi
>>>
>>> Am 24.01.25 um 21:46 schrieb John Edwards:
>>>> Hello.
>>>>
>>>> I am submitting a small number of patches to add panel rotation quirks for
>>>> a few handheld gaming PCs.  These patches were created by the SteamFork
>>>> team and are in daily use by us and/or members of our community.
>>>>
>>>> The following devices are covered by these patches:
>>>> 1: AYANEO 2S
>>>> 2: AYANEO Flip DS, AYANEO Flip KB
>>>> 3: AYANEO Slide, Antec Core HS
>>>> 4: GPD Win 2 (with correct DMI strings)
>>>> 5: OneXPlayer Mini (Intel)
>>>>
>>>> Thank you for your consideration and for taking the time to review these
>>>> patches.
>>> Did you ever receive any response to this series? If not, then
>>>
>>> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>> I had the following remark for 3 new entries added in patches 2/5 + 3/5:
>>
>> "Since this '}' is closing the .matches initializer it should be indented 2 tabs"
>>
>> With that fixed, you can add my:
>>
>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>>
>> to the entire series.
>>
>>> for the series. Let me know if you need assistance for getting the patch files merged.
>> Normally I pickup/merge these panel orientation quirks, but I've been swamped
>> which is why these have just been sitting on the list.
>>
>> Thomas, I would appreciate it if you can merge the set into drm-misc-fixes, with
>> the 3 minor indentation issues fixed.
> 
> Sure, no problem. I'll wait for John to provide an update. Otherwise, I'll fix it myself while merging the series.

Great thank you.

Note in the review comments I said that we could likely fixup the indentation
issues while merging. If you prefer a new version from John that is fine too,
but we need to make clear to John what we want :)

Regards,

Hans




>>>> v2:
>>>> - Minor rewording of commit messages
>>>> - Include Tested-by tag for Paco Avelar in AYANEO Flip DS/KB patch
>>>> - Add OneXPlayer Mini (Intel) patch
>>>>
>>>> v1:
>>>> https://lore.kernel.org/dri-devel/20250116155049.39647-2-uejji@uejji.net/
>>>>
>>>> Andrew Wyatt (5):
>>>>     drm: panel-orientation-quirks: Add support for AYANEO 2S
>>>>     drm: panel-orientation-quirks: Add quirks for AYA NEO Flip DS and KB
>>>>     drm: panel-orientation-quirks: Add quirk for AYA NEO Slide
>>>>     drm: panel-orientation-quirks: Add new quirk for GPD Win 2
>>>>     drm: panel-orientation-quirks: Add quirk for OneXPlayer Mini (Intel)
>>>>
>>>>    .../gpu/drm/drm_panel_orientation_quirks.c    | 40 ++++++++++++++++++-
>>>>    1 file changed, 38 insertions(+), 2 deletions(-)
>>>>
> 

Re: [PATCH v2 0/5] Handheld gaming PC panel orientation quirks

[John Edwards]

Hello, Thomas and Hans.

On Wed, Feb 12, 2025 at 5:14 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 12-Feb-25 12:11 PM, Thomas Zimmermann wrote:
>> Hi
>>
>> Am 12.02.25 um 11:51 schrieb Hans de Goede:
>>> Hi Thomas,
>>>
>>> On 11-Feb-25 2:55 PM, Thomas Zimmermann wrote:
>>>> Hi
>>>>
>>>> Am 24.01.25 um 21:46 schrieb John Edwards:
>>>>> Hello.
>>>>>
>>>>> I am submitting a small number of patches to add panel rotation quirks for
>>>>> a few handheld gaming PCs.  These patches were created by the SteamFork
>>>>> team and are in daily use by us and/or members of our community.
>>>>>
>>>>> The following devices are covered by these patches:
>>>>> 1: AYANEO 2S
>>>>> 2: AYANEO Flip DS, AYANEO Flip KB
>>>>> 3: AYANEO Slide, Antec Core HS
>>>>> 4: GPD Win 2 (with correct DMI strings)
>>>>> 5: OneXPlayer Mini (Intel)
>>>>>
>>>>> Thank you for your consideration and for taking the time to review these
>>>>> patches.
>>>> Did you ever receive any response to this series? If not, then
>>>>
>>>> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>>> I had the following remark for 3 new entries added in patches 2/5 + 3/5:
>>>
>>> "Since this '}' is closing the .matches initializer it should be indented 2 tabs"
>>>
>>> With that fixed, you can add my:
>>>
>>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>>>
>>> to the entire series.
>>>
>>>> for the series. Let me know if you need assistance for getting the patch files merged.
>>> Normally I pickup/merge these panel orientation quirks, but I've been swamped
>>> which is why these have just been sitting on the list.
>>>
>>> Thomas, I would appreciate it if you can merge the set into drm-misc-fixes, with
>>> the 3 minor indentation issues fixed.
>>
>> Sure, no problem. I'll wait for John to provide an update. Otherwise, I'll fix it myself while merging the series.
>
> Great thank you.
>
> Note in the review comments I said that we could likely fixup the indentation
> issues while merging. If you prefer a new version from John that is fine too,
> but we need to make clear to John what we want :)

Thank you both for your comments and feedback.  I am more than happy to
provide a v3 with the noted changes if requested.

We have no other planned changes for this patch series, so if you wish to
implement the changes while merging that is also acceptable to us.

Thank you both again.

John Edwards



>>>>> v2:
>>>>> - Minor rewording of commit messages
>>>>> - Include Tested-by tag for Paco Avelar in AYANEO Flip DS/KB patch
>>>>> - Add OneXPlayer Mini (Intel) patch
>>>>>
>>>>> v1:
>>>>> https://lore.kernel.org/dri-devel/20250116155049.39647-2-uejji@uejji.net/
>>>>>
>>>>> Andrew Wyatt (5):
>>>>>     drm: panel-orientation-quirks: Add support for AYANEO 2S
>>>>>     drm: panel-orientation-quirks: Add quirks for AYA NEO Flip DS and KB
>>>>>     drm: panel-orientation-quirks: Add quirk for AYA NEO Slide
>>>>>     drm: panel-orientation-quirks: Add new quirk for GPD Win 2
>>>>>     drm: panel-orientation-quirks: Add quirk for OneXPlayer Mini (Intel)
>>>>>
>>>>>    .../gpu/drm/drm_panel_orientation_quirks.c    | 40 ++++++++++++++++++-
>>>>>    1 file changed, 38 insertions(+), 2 deletions(-)
>>>>>
>>
>

Re: [PATCH v2 0/5] Handheld gaming PC panel orientation quirks

[Thomas Zimmermann]

Hi

Am 12.02.25 um 20:59 schrieb John Edwards:
> Hello, Thomas and Hans.
>
> On Wed, Feb 12, 2025 at 5:14 AM Hans de Goede <hdegoede@redhat.com> wrote:
>> Hi,
>>
>> On 12-Feb-25 12:11 PM, Thomas Zimmermann wrote:
>>> Hi
>>>
>>> Am 12.02.25 um 11:51 schrieb Hans de Goede:
>>>> Hi Thomas,
>>>>
>>>> On 11-Feb-25 2:55 PM, Thomas Zimmermann wrote:
>>>>> Hi
>>>>>
>>>>> Am 24.01.25 um 21:46 schrieb John Edwards:
>>>>>> Hello.
>>>>>>
>>>>>> I am submitting a small number of patches to add panel rotation quirks for
>>>>>> a few handheld gaming PCs.  These patches were created by the SteamFork
>>>>>> team and are in daily use by us and/or members of our community.
>>>>>>
>>>>>> The following devices are covered by these patches:
>>>>>> 1: AYANEO 2S
>>>>>> 2: AYANEO Flip DS, AYANEO Flip KB
>>>>>> 3: AYANEO Slide, Antec Core HS
>>>>>> 4: GPD Win 2 (with correct DMI strings)
>>>>>> 5: OneXPlayer Mini (Intel)
>>>>>>
>>>>>> Thank you for your consideration and for taking the time to review these
>>>>>> patches.
>>>>> Did you ever receive any response to this series? If not, then
>>>>>
>>>>> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>>>> I had the following remark for 3 new entries added in patches 2/5 + 3/5:
>>>>
>>>> "Since this '}' is closing the .matches initializer it should be indented 2 tabs"
>>>>
>>>> With that fixed, you can add my:
>>>>
>>>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>>>>
>>>> to the entire series.
>>>>
>>>>> for the series. Let me know if you need assistance for getting the patch files merged.
>>>> Normally I pickup/merge these panel orientation quirks, but I've been swamped
>>>> which is why these have just been sitting on the list.
>>>>
>>>> Thomas, I would appreciate it if you can merge the set into drm-misc-fixes, with
>>>> the 3 minor indentation issues fixed.
>>> Sure, no problem. I'll wait for John to provide an update. Otherwise, I'll fix it myself while merging the series.
>> Great thank you.
>>
>> Note in the review comments I said that we could likely fixup the indentation
>> issues while merging. If you prefer a new version from John that is fine too,
>> but we need to make clear to John what we want :)
> Thank you both for your comments and feedback.  I am more than happy to
> provide a v3 with the noted changes if requested.
>
> We have no other planned changes for this patch series, so if you wish to
> implement the changes while merging that is also acceptable to us.

Please send an update.

Best regards
Thomas

>
> Thank you both again.
>
> John Edwards
>
>
>
>>>>>> v2:
>>>>>> - Minor rewording of commit messages
>>>>>> - Include Tested-by tag for Paco Avelar in AYANEO Flip DS/KB patch
>>>>>> - Add OneXPlayer Mini (Intel) patch
>>>>>>
>>>>>> v1:
>>>>>> https://lore.kernel.org/dri-devel/20250116155049.39647-2-uejji@uejji.net/
>>>>>>
>>>>>> Andrew Wyatt (5):
>>>>>>      drm: panel-orientation-quirks: Add support for AYANEO 2S
>>>>>>      drm: panel-orientation-quirks: Add quirks for AYA NEO Flip DS and KB
>>>>>>      drm: panel-orientation-quirks: Add quirk for AYA NEO Slide
>>>>>>      drm: panel-orientation-quirks: Add new quirk for GPD Win 2
>>>>>>      drm: panel-orientation-quirks: Add quirk for OneXPlayer Mini (Intel)
>>>>>>
>>>>>>     .../gpu/drm/drm_panel_orientation_quirks.c    | 40 ++++++++++++++++++-
>>>>>>     1 file changed, 38 insertions(+), 2 deletions(-)
>>>>>>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Re: [PATCH v2 0/5] Handheld gaming PC panel orientation quirks

[John Edwards]

Hello, Thomas.

On Thu, Feb 13, 2025 at 1:35 AM Thomas Zimmermann <tzimmermann@suse.de> wrote:
>
> Hi
>
>Am 12.02.25 um 20:59 schrieb John Edwards:
>> Hello, Thomas and Hans.
>>
>> On Wed, Feb 12, 2025 at 5:14 AM Hans de Goede <hdegoede@redhat.com> wrote:
>>> Hi,
>>>
>>> On 12-Feb-25 12:11 PM, Thomas Zimmermann wrote:
>>>> Hi
>>>>
>>>> Am 12.02.25 um 11:51 schrieb Hans de Goede:
>>>>> Hi Thomas,
>>>>>
>>>>> On 11-Feb-25 2:55 PM, Thomas Zimmermann wrote:
>>>>>> Hi
>>>>>>
>>>>>> Am 24.01.25 um 21:46 schrieb John Edwards:
>>>>>>> Hello.
>>>>>>>
>>>>>>> I am submitting a small number of patches to add panel rotation quirks for
>>>>>>> a few handheld gaming PCs.  These patches were created by the SteamFork
>>>>>>> team and are in daily use by us and/or members of our community.
>>>>>>>
>>>>>>> The following devices are covered by these patches:
>>>>>>> 1: AYANEO 2S
>>>>>>> 2: AYANEO Flip DS, AYANEO Flip KB
>>>>>>> 3: AYANEO Slide, Antec Core HS
>>>>>>> 4: GPD Win 2 (with correct DMI strings)
>>>>>>> 5: OneXPlayer Mini (Intel)
>>>>>>>
>>>>>>> Thank you for your consideration and for taking the time to review these
>>>>>>> patches.
>>>>>> Did you ever receive any response to this series? If not, then
>>>>>>
>>>>>> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>>>>> I had the following remark for 3 new entries added in patches 2/5 + 3/5:
>>>>>
>>>>> "Since this '}' is closing the .matches initializer it should be indented 2 tabs"
>>>>>
>>>>> With that fixed, you can add my:
>>>>>
>>>>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>>>>>
>>>>> to the entire series.
>>>>>
>>>>>> for the series. Let me know if you need assistance for getting the patch files merged.
>>>>> Normally I pickup/merge these panel orientation quirks, but I've been swamped
>>>>> which is why these have just been sitting on the list.
>>>>>
>>>>> Thomas, I would appreciate it if you can merge the set into drm-misc-fixes, with
>>>>> the 3 minor indentation issues fixed.
>>>> Sure, no problem. I'll wait for John to provide an update. Otherwise, I'll fix it myself while merging the series.
>>> Great thank you.
>>>
>>> Note in the review comments I said that we could likely fixup the indentation
>>> issues while merging. If you prefer a new version from John that is fine too,
>>> but we need to make clear to John what we want :)
>> Thank you both for your comments and feedback.  I am more than happy to
>> provide a v3 with the noted changes if requested.
>>
>> We have no other planned changes for this patch series, so if you wish to
>> implement the changes while merging that is also acceptable to us.
>
> Please send an update.

I have just submitted v3 with the requested changes.

Thank you.

John Edwards


>>>>>>> v2:
>>>>>>> - Minor rewording of commit messages
>>>>>>> - Include Tested-by tag for Paco Avelar in AYANEO Flip DS/KB patch
>>>>>>> - Add OneXPlayer Mini (Intel) patch
>>>>>>>
>>>>>>> v1:
>>>>>>> https://lore.kernel.org/dri-devel/20250116155049.39647-2-uejji@uejji.net/
>>>>>>>
>>>>>>> Andrew Wyatt (5):
>>>>>>>      drm: panel-orientation-quirks: Add support for AYANEO 2S
>>>>>>>      drm: panel-orientation-quirks: Add quirks for AYA NEO Flip DS and KB
>>>>>>>      drm: panel-orientation-quirks: Add quirk for AYA NEO Slide
>>>>>>>      drm: panel-orientation-quirks: Add new quirk for GPD Win 2
>>>>>>>      drm: panel-orientation-quirks: Add quirk for OneXPlayer Mini (Intel)
>>>>>>>
>>>>>>>     .../gpu/drm/drm_panel_orientation_quirks.c    | 40 ++++++++++++++++++-
>>>>>>>     1 file changed, 38 insertions(+), 2 deletions(-)
>>>>>>>