All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] Bluetooth: MGMT: Allow connection rate request as peripheral
@ 2026-10-12 15:28 Luiz Augusto von Dentz
  2026-10-12 17:42 ` [v1] " bluez.test.bot
  2026-10-13 14:20 ` [PATCH v1] " patchwork-bot+bluetooth
  0 siblings, 2 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2026-10-12 15:28 UTC (permalink / raw)
  To: linux-bluetooth

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

Load Connection Subrate only issues the LE Connection Rate Request when
connected as central, but either role can initiate the Connection Rate
Update procedure, e.g. a HID device, which is the peripheral, does it
once the HID host requests a HID SCI mode with the HID Control Point.

Issue it regardless of the role.

Fixes: 19129d7037be ("Bluetooth: Add MGMT Load Connection Subrate command")
Assisted-by: OpenCode:claude-opus-5.5
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---
 net/bluetooth/mgmt.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index 9f65863e7457..3b9c82bd2f02 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -8347,8 +8347,10 @@ static int load_conn_subrate(struct sock *sk, struct hci_dev *hdev, void *data,
 		hci_param->cont_num = cont_num;
 		hci_param->rate_supv_timeout = supv_timeout;
 
-		/* If the device is connected as central check if the
-		 * connection rate parameters need to be updated.
+		/* If the device is connected check if the connection rate
+		 * parameters need to be updated, either role can initiate the
+		 * Connection Rate Update procedure, e.g. a HID device acting
+		 * as peripheral once the HID host requests a HID SCI mode.
 		 */
 		if (!i && param_count == 1) {
 			struct hci_conn *conn;
@@ -8357,7 +8359,6 @@ static int load_conn_subrate(struct sock *sk, struct hci_dev *hdev, void *data,
 						       &hci_param->addr,
 						       addr_type);
 			if (conn && conn->state == BT_CONNECTED &&
-			    conn->role == HCI_ROLE_MASTER &&
 			    (conn->le_rate_interval < min ||
 			     conn->le_rate_interval > max ||
 			     conn->le_subrate < subrate_min ||
-- 
2.56.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [v1] Bluetooth: MGMT: Allow connection rate request as peripheral
  2026-10-12 15:28 [PATCH v1] Bluetooth: MGMT: Allow connection rate request as peripheral Luiz Augusto von Dentz
@ 2026-10-12 17:42 ` bluez.test.bot
  2026-10-13 14:20 ` [PATCH v1] " patchwork-bot+bluetooth
  1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2026-10-12 17:42 UTC (permalink / raw)
  To: linux-bluetooth, luiz.dentz

[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1184009/

---Test result---

Test Summary:
CheckPatch                    PASS      0.68 seconds
VerifyFixes                   PASS      0.07 seconds
VerifySignedoff               PASS      0.35 seconds
GitLint                       PASS      0.22 seconds
SubjectPrefix                 PASS      0.08 seconds
BuildKernel                   PASS      30.97 seconds
CheckAllWarning               PASS      35.09 seconds
CheckSparse                   PASS      36.93 seconds
BuildKernel32                 PASS      30.21 seconds
CheckKernelLLVM               PASS      34.55 seconds
TestRunnerSetup               PASS      816.63 seconds
TestRunner_mgmt-tester        PASS      61.31 seconds
TestRunner_mesh-tester        PASS      5.45 seconds
IncrementalBuild              PASS      29.04 seconds



https://github.com/bluez/bluetooth-next/pull/905

---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] Bluetooth: MGMT: Allow connection rate request as peripheral
  2026-10-12 15:28 [PATCH v1] Bluetooth: MGMT: Allow connection rate request as peripheral Luiz Augusto von Dentz
  2026-10-12 17:42 ` [v1] " bluez.test.bot
@ 2026-10-13 14:20 ` patchwork-bot+bluetooth
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+bluetooth @ 2026-10-13 14:20 UTC (permalink / raw)
  To: Luiz Augusto von Dentz; +Cc: linux-bluetooth

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 12 Oct 2026 11:28:03 -0400 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> Load Connection Subrate only issues the LE Connection Rate Request when
> connected as central, but either role can initiate the Connection Rate
> Update procedure, e.g. a HID device, which is the peripheral, does it
> once the HID host requests a HID SCI mode with the HID Control Point.
> 
> [...]

Here is the summary with links:
  - [v1] Bluetooth: MGMT: Allow connection rate request as peripheral
    https://git.kernel.org/bluetooth/bluetooth-next/c/fe921b758083

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-10-13 14:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-12 15:28 [PATCH v1] Bluetooth: MGMT: Allow connection rate request as peripheral Luiz Augusto von Dentz
2026-10-12 17:42 ` [v1] " bluez.test.bot
2026-10-13 14:20 ` [PATCH v1] " patchwork-bot+bluetooth

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.