* [PATCH BlueZ] client/telephony: Fix missing string.h include
@ 2026-10-30 9:09 Jacob Siverskog
2026-10-30 15:21 ` [BlueZ] " bluez.test.bot
0 siblings, 1 reply; 2+ messages in thread
From: Jacob Siverskog @ 2026-10-30 9:09 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Frédéric Danis, Jacob Siverskog
strcmp() is used without including string.h, which only builds because
some glib versions pull it in indirectly. With older glib:
client/telephony.c:641:2: warning: implicit declaration of function
'strcmp' [-Wimplicit-function-declaration]
Assisted-by: Claude:claude-opus-5-5
---
client/telephony.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/client/telephony.c b/client/telephony.c
index 858c02c0b..1d6885fa6 100644
--- a/client/telephony.c
+++ b/client/telephony.c
@@ -14,6 +14,7 @@
#define _GNU_SOURCE
#include <stdlib.h>
+#include <string.h>
#include <glib.h>
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [BlueZ] client/telephony: Fix missing string.h include
2026-10-30 9:09 [PATCH BlueZ] client/telephony: Fix missing string.h include Jacob Siverskog
@ 2026-10-30 15:21 ` bluez.test.bot
0 siblings, 0 replies; 2+ messages in thread
From: bluez.test.bot @ 2026-10-30 15:21 UTC (permalink / raw)
To: linux-bluetooth, jacob
[-- Attachment #1: Type: text/plain, Size: 3145 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1196995/
---Test result---
Test Summary:
CheckPatch PASS 0.45 seconds
GitLint PASS 0.32 seconds
BuildEll PASS 16.30 seconds
BluezMake PASS 230.88 seconds
CheckSmatch PASS 225.43 seconds
bluezmakeextell PASS 76.87 seconds
TestFunctional FAIL 991.72 seconds
IncrementalBuild PASS 231.05 seconds
ScanBuild PASS 829.73 seconds
Details
##############################
Test: TestFunctional - FAIL
Desc: Run test-functional
Output:
FAIL functional.test_bluetoothctl::test_bluetoothctl_pair_bredr[hosts15-vm2]: pytest_bluezenv.rpc.RemoteError: <pexpect.popen_spawn.PopenSpawn object at 0x7f7c16c4e510>
searcher: searcher_re:
0: re.compile(b'Changing pairable on succeeded')
<pexpect.popen_spawn.PopenSpawn object at 0x7f7c16c4e510>
searcher: searcher_re:
0: re.compile(b'Changing pairable on succeeded')
Remote traceback:
Traceback (most recent call last):
File "/usr/local/lib/python3.14/dist-packages/pytest_bluezenv/../pytest_bluezenv/rpc.py", line 102, in server_stream
result = method(*msg["a"], **msg["kw"])
File "/usr/local/lib/python3.14/dist-packages/pytest_bluezenv/../pytest_bluezenv/env.py", line 256, in call_plugin
return getattr(self.plugins[name], method)(*a, **kw)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^
File "/usr/local/lib/python3.14/dist-packages/pytest_bluezenv/../pytest_bluezenv/host_plugins.py", line 502, in expect
ret = self.ctl.expect(*a, **kw)
File "/usr/lib/python3/dist-packages/pexpect/spawnbase.py", line 354, in expect
return self.expect_list(compiled_pattern_list,
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
timeout, searchwindowsize, async_)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/pexpect/spawnbase.py", line 383, in expect_list
return exp.expect_loop(timeout)
~~~~~~~~~~~~~~~^^^^^^^^^
File "/usr/lib/python3/dist-packages/pexpect/expect.py", line 181, in expect_loop
return self.timeout(e)
~~~~~~~~~~~~^^^
File "/usr/lib/python3/dist-packages/pexpect/expect.py", line 144, in timeout
raise exc
pexpect.exceptions.TIMEOUT: <pexpect.popen_spawn.PopenSpawn object at 0x7f7c16c4e510>
searcher: searcher_re:
0: re.compile(b'Changing pairable on succeeded')
<pexpect.popen_spawn.PopenSpawn object at 0x7f7c16c4e510>
searcher: searcher_re:
0: re.compile(b'Changing pairable on succeeded')
https://github.com/bluez/bluez/pull/2737
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-30 15:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-30 9:09 [PATCH BlueZ] client/telephony: Fix missing string.h include Jacob Siverskog
2026-10-30 15:21 ` [BlueZ] " bluez.test.bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.