All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] soc: imx: imx93_lpm: return -EPROBE_DEFER when SE firmware not ready
@ 2026-09-02 10:43 Bratiranjan Acharya
  2026-09-11 18:58 ` Frank Li
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Bratiranjan Acharya @ 2026-09-02 10:43 UTC (permalink / raw)
  To: aisheng.dong, peng.fan; +Cc: pankaj.gupta, ping.bai, imx

imx_get_se_data_info() returns NULL during early boot because the
EdgeLock Enclave firmware takes ~900ms to register its services.
Returning -ENODEV here permanently drops the driver with no retry,
leaving DDR DVFS and lpm-cooling non-functional.

Return -EPROBE_DEFER so the driver retries once SE firmware is up.

Tested on i.MX93: probe defers once, succeeds on retry, lpm-cooling
and DDR frequency scaling both operational.

Fixes: 711990e353bb ("LF-13910: soc: imx93: lpm changes to update exported apis")
Signed-off-by: Bratiranjan Acharya <bacharya@enphaseenergy.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
---
v2: Add Reviewed-by from Peng Fan
 drivers/soc/imx/imx93_lpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/imx/imx93_lpm.c b/drivers/soc/imx/imx93_lpm.c
index bfa52ff8f..26d72e3e2 100644
--- a/drivers/soc/imx/imx93_lpm.c
+++ b/drivers/soc/imx/imx93_lpm.c
@@ -621,7 +621,7 @@ static int imx93_lpm_probe(struct platform_device *pdev)
 	se_data = imx_get_se_data_info(SOC_ID_OF_IMX93, 0);
 	if (!se_data) {
 		dev_err(&pdev->dev, "get se-fw2 failed\n");
-		return -ENODEV;
+		return -EPROBE_DEFER;
 	}
 
 	/*
-- 
2.34.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] soc: imx: imx93_lpm: return -EPROBE_DEFER when SE firmware not ready
  2026-09-02 10:43 [PATCH v2] soc: imx: imx93_lpm: return -EPROBE_DEFER when SE firmware not ready Bratiranjan Acharya
@ 2026-09-11 18:58 ` Frank Li
  2026-11-02  8:50 ` bratiranjan11
  2026-11-02  9:08 ` bratiranjan11
  2 siblings, 0 replies; 4+ messages in thread
From: Frank Li @ 2026-09-11 18:58 UTC (permalink / raw)
  To: Bratiranjan Acharya; +Cc: aisheng.dong, peng.fan, pankaj.gupta, ping.bai, imx

On Wed, Sep 02, 2026 at 03:43:16AM -0700, Bratiranjan Acharya wrote:
> imx_get_se_data_info() returns NULL during early boot because the
> EdgeLock Enclave firmware takes ~900ms to register its services.
> Returning -ENODEV here permanently drops the driver with no retry,
> leaving DDR DVFS and lpm-cooling non-functional.
>
> Return -EPROBE_DEFER so the driver retries once SE firmware is up.
>
> Tested on i.MX93: probe defers once, succeeds on retry, lpm-cooling
> and DDR frequency scaling both operational.
>
> Fixes: 711990e353bb ("LF-13910: soc: imx93: lpm changes to update exported apis")
> Signed-off-by: Bratiranjan Acharya <bacharya@enphaseenergy.com>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
> v2: Add Reviewed-by from Peng Fan
>  drivers/soc/imx/imx93_lpm.c | 2 +-

I have seen this file at upstream tree

https://elixir.bootlin.com/linux/v7.3-rc1/source/drivers/soc/imx

Frank
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/imx/imx93_lpm.c b/drivers/soc/imx/imx93_lpm.c
> index bfa52ff8f..26d72e3e2 100644
> --- a/drivers/soc/imx/imx93_lpm.c
> +++ b/drivers/soc/imx/imx93_lpm.c
> @@ -621,7 +621,7 @@ static int imx93_lpm_probe(struct platform_device *pdev)
>  	se_data = imx_get_se_data_info(SOC_ID_OF_IMX93, 0);
>  	if (!se_data) {
>  		dev_err(&pdev->dev, "get se-fw2 failed\n");
> -		return -ENODEV;
> +		return -EPROBE_DEFER;
>  	}
>
>  	/*
> --
> 2.34.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] soc: imx: imx93_lpm: return -EPROBE_DEFER when SE firmware not ready
  2026-09-02 10:43 [PATCH v2] soc: imx: imx93_lpm: return -EPROBE_DEFER when SE firmware not ready Bratiranjan Acharya
  2026-09-11 18:58 ` Frank Li
@ 2026-11-02  8:50 ` bratiranjan11
  2026-11-02  9:08 ` bratiranjan11
  2 siblings, 0 replies; 4+ messages in thread
From: bratiranjan11 @ 2026-11-02  8:50 UTC (permalink / raw)
  To: aisheng.dong; +Cc: peng.fan, imx

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

Hi Aisheng,

Gentle ping on this patch. It has a Reviewed-by from Peng Fan.
Is there anything blocking it, or anything more needed from my side?

Thanks,
Bratiranjan

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] soc: imx: imx93_lpm: return -EPROBE_DEFER when SE firmware not ready
  2026-09-02 10:43 [PATCH v2] soc: imx: imx93_lpm: return -EPROBE_DEFER when SE firmware not ready Bratiranjan Acharya
  2026-09-11 18:58 ` Frank Li
  2026-11-02  8:50 ` bratiranjan11
@ 2026-11-02  9:08 ` bratiranjan11
  2 siblings, 0 replies; 4+ messages in thread
From: bratiranjan11 @ 2026-11-02  9:08 UTC (permalink / raw)
  To: Frank.li; +Cc: aisheng.dong, peng.fan, pankaj.gupta, ping.bai, imx

Hi Frank,

Thanks for pointing this out, apologies for the delayed response.

I checked the upstream tree (torvalds/linux master). The file
drivers/soc/imx/imx93_lpm.c is not present in mainline yet --
only imx93-src.c, soc-imx.c, soc-imx8m.c and soc-imx9.c exist
under drivers/soc/imx/ in Linus's tree.

Are you referring to the NXP staging/arm-soc tree? If the file is
on its way upstream, I am happy to re-spin the patch against that
tree once it lands, or submit it separately upstream if that is
preferred.

Thanks,
Bratiranjan

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-02  9:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-02 10:43 [PATCH v2] soc: imx: imx93_lpm: return -EPROBE_DEFER when SE firmware not ready Bratiranjan Acharya
2026-09-11 18:58 ` Frank Li
2026-11-02  8:50 ` bratiranjan11
2026-11-02  9:08 ` bratiranjan11

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.