[meta-initramfs][PATCH] klibc.bbclass: Add spaces around assignment

[meta-initramfs][PATCH] klibc.bbclass: Add spaces around assignment

[Khem Raj]

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta-initramfs/classes/klibc.bbclass | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/meta-initramfs/classes/klibc.bbclass b/meta-initramfs/classes/klibc.bbclass
index ca50a3d431..935ee10c40 100644
--- a/meta-initramfs/classes/klibc.bbclass
+++ b/meta-initramfs/classes/klibc.bbclass
@@ -9,8 +9,13 @@ CC:append:armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE
 CC:append:armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}"
 
 # klcc uses own optimizations by default. See klcc(1) man file.
-export CFLAGS="${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}"
-export CPPFLAGS="${TUNE_CCARGS}"
-export LDFLAGS="${TUNE_CCARGS}"
+CFLAGS = "${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}"
+CFLAGS[export] = "1"
+
+CPPFLAGS = "${TUNE_CCARGS}"
+CPPFLAGS[export] = "1"
+
+LDFLAGS=" ${TUNE_CCARGS}"
+LDFLAGS[export] = "1"
 
 OVERRIDES =. "libc-klibc:"

Re: [oe] [meta-initramfs][PATCH] klibc.bbclass: Add spaces around assignment

[Gyorgy Sarvari]

On 4/18/25 03:41, Khem Raj via lists.openembedded.org wrote:
> +LDFLAGS=" ${TUNE_CCARGS}"
> +LDFLAGS[export] = "1"
That space is still off by one in the upper line.

Re: [oe] [meta-initramfs][PATCH] klibc.bbclass: Add spaces around assignment

[Martin Jansa]

On Fri, Apr 18, 2025 at 3:41 AM Khem Raj via lists.openembedded.org
<raj.khem=gmail.com@lists.openembedded.org> wrote:
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta-initramfs/classes/klibc.bbclass | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/meta-initramfs/classes/klibc.bbclass b/meta-initramfs/classes/klibc.bbclass
> index ca50a3d431..935ee10c40 100644
> --- a/meta-initramfs/classes/klibc.bbclass
> +++ b/meta-initramfs/classes/klibc.bbclass
> @@ -9,8 +9,13 @@ CC:append:armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE
>  CC:append:armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}"
>
>  # klcc uses own optimizations by default. See klcc(1) man file.
> -export CFLAGS="${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}"
> -export CPPFLAGS="${TUNE_CCARGS}"
> -export LDFLAGS="${TUNE_CCARGS}"
> +CFLAGS = "${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}"
> +CFLAGS[export] = "1"
> +
> +CPPFLAGS = "${TUNE_CCARGS}"
> +CPPFLAGS[export] = "1"
> +
> +LDFLAGS=" ${TUNE_CCARGS}"
> +LDFLAGS[export] = "1"

Why the change in export syntax, is the varflag preferred now?

Re: [oe] [meta-initramfs][PATCH] klibc.bbclass: Add spaces around assignment

[Gyorgy Sarvari]

On 4/18/25 13:30, Martin Jansa via lists.openembedded.org wrote:
> On Fri, Apr 18, 2025 at 3:41 AM Khem Raj via lists.openembedded.org
> <raj.khem=gmail.com@lists.openembedded.org> wrote:
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>  meta-initramfs/classes/klibc.bbclass | 11 ++++++++---
>>  1 file changed, 8 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta-initramfs/classes/klibc.bbclass b/meta-initramfs/classes/klibc.bbclass
>> index ca50a3d431..935ee10c40 100644
>> --- a/meta-initramfs/classes/klibc.bbclass
>> +++ b/meta-initramfs/classes/klibc.bbclass
>> @@ -9,8 +9,13 @@ CC:append:armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE
>>  CC:append:armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}"
>>
>>  # klcc uses own optimizations by default. See klcc(1) man file.
>> -export CFLAGS="${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}"
>> -export CPPFLAGS="${TUNE_CCARGS}"
>> -export LDFLAGS="${TUNE_CCARGS}"
>> +CFLAGS = "${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}"
>> +CFLAGS[export] = "1"
>> +
>> +CPPFLAGS = "${TUNE_CCARGS}"
>> +CPPFLAGS[export] = "1"
>> +
>> +LDFLAGS=" ${TUNE_CCARGS}"
>> +LDFLAGS[export] = "1"
> Why the change in export syntax, is the varflag preferred now?
Meta comment: maybe it should be preferred... It is at least a bit
confusing that bitbake's and shell's "export" look and work very very
similarly, but one of them complains about not having spaces, and the
other complains about having spaces.

Re: [oe] [meta-initramfs][PATCH] klibc.bbclass: Add spaces around assignment

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1828 bytes --]

On Fri, Apr 18, 2025 at 5:25 AM Gyorgy Sarvari <skandigraun@gmail.com>
wrote:

>
> On 4/18/25 13:30, Martin Jansa via lists.openembedded.org wrote:
> > On Fri, Apr 18, 2025 at 3:41 AM Khem Raj via lists.openembedded.org
> > <raj.khem=gmail.com@lists.openembedded.org> wrote:
> >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >> ---
> >>  meta-initramfs/classes/klibc.bbclass | 11 ++++++++---
> >>  1 file changed, 8 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/meta-initramfs/classes/klibc.bbclass
> b/meta-initramfs/classes/klibc.bbclass
> >> index ca50a3d431..935ee10c40 100644
> >> --- a/meta-initramfs/classes/klibc.bbclass
> >> +++ b/meta-initramfs/classes/klibc.bbclass
> >> @@ -9,8 +9,13 @@ CC:append:armv7ve = " ${@'
> -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE
> >>  CC:append:armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if
> (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}"
> >>
> >>  # klcc uses own optimizations by default. See klcc(1) man file.
> >> -export CFLAGS="${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}"
> >> -export CPPFLAGS="${TUNE_CCARGS}"
> >> -export LDFLAGS="${TUNE_CCARGS}"
> >> +CFLAGS = "${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}"
> >> +CFLAGS[export] = "1"
> >> +
> >> +CPPFLAGS = "${TUNE_CCARGS}"
> >> +CPPFLAGS[export] = "1"
> >> +
> >> +LDFLAGS=" ${TUNE_CCARGS}"
> >> +LDFLAGS[export] = "1"
> > Why the change in export syntax, is the varflag preferred now?


It’s fine either way. I preferred bitbakes way of doing it here for not
mixing shell syntax ourside of functions

>
> Meta comment: maybe it should be preferred... It is at least a bit
> confusing that bitbake's and shell's "export" look and work very very
> similarly, but one of them complains about not having spaces, and the
> other complains about having spaces.
>

[-- Attachment #2: Type: text/html, Size: 2951 bytes --]