* [syzbot] [ext4?] BUG: unable to handle kernel NULL pointer dereference in strrchr
@ 2026-11-20 12:49 syzbot
2026-11-20 13:07 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: syzbot @ 2026-11-20 12:49 UTC (permalink / raw)
To: jack, linux-ext4, linux-kernel, sandeen, syzkaller-bugs
Hello,
syzbot found the following issue on:
HEAD commit: 65e4fd942f72 Merge tag 'selinux-pr-20261119' of git://git...
git tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux
console output: https://syzkaller.appspot.com/x/log.txt?x=1102b185580000
kernel config: https://syzkaller.appspot.com/x/.config?x=3299dd89908ef903
dashboard link: https://syzkaller.appspot.com/bug?extid=1d23ad199a3bfd6f9149
compiler: arm-linux-gnueabi-gcc (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44
userspace arch: arm
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=165e3abd580000
The issue was bisected by AI to:
commit 98f18c76c2c3089183c35d2c33e468ad6c03d86b
Author: Eric Sandeen <sandeen@redhat.com>
Date: Sun Feb 23 19:57:41 2025 +0000
ext2: create ext2_msg_fc for use during parsing
AI reasoning: https://syzkaller.appspot.com/ai_job?id=f0a661eb-7c3b-44be-becd-54ce0bd776b2
AI-generated root cause summary:
In fs/ext2/super.c, ext2_msg_fc() formats log messages for filesystem context
operations. When fc->purpose != FS_CONTEXT_FOR_RECONFIGURE, it unconditionally
executes strrchr(fc->source, '/') without verifying that fc->source is non-NULL.
During filesystem configuration via the new mount API (e.g., fsopen() followed
by fsconfig()), fc->source starts as NULL and options can be parsed in any
order. Specifying an option that triggers ext2_msg_fc() (such as "dax", "nobh",
or "reservation") prior to supplying the "source" parameter passes a NULL
pointer to strrchr(), causing a kernel NULL pointer dereference.
full analysis: https://syzkaller.appspot.com/x/ai_root_cause?x=1d23ad199a3bfd6f9149
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+1d23ad199a3bfd6f9149@syzkaller.appspotmail.com
The cause commit was identified by AI and may be wrong.
If you agree with it, please also add:
Fixes: 98f18c76c2c3 ("ext2: create ext2_msg_fc for use during parsing")
8<--- cut here ---
Unable to handle kernel NULL pointer dereference at virtual address 00000000 when read
[00000000] *pgd=86b45003, *pmd=df702003
Internal error: Oops: 205 [#1] SMP ARM
Modules linked in:
CPU: 0 UID: 0 PID: 4221 Comm: syz-executor704 Not tainted syzkaller #0 PREEMPT
Hardware name: ARM-Versatile Express
PC is at strrchr+0x4/0x20 arch/arm/lib/strrchr.S:16
LR is at ext2_msg_fc+0x64/0xbc fs/ext2/super.c:94
pc : [<81be3be4>] lr : [<80207988>] psr: 80000013
sp : df969ed0 ip : 00000000 fp : df969efc
r10: 8665ce00 r9 : 86c5a600 r8 : 8665ce00
r7 : 00000000 r6 : 825897f0 r5 : 82533520 r4 : 00000000
r3 : 00000000 r2 : 00000000 r1 : 0000002f r0 : 00000000
Flags: Nzcv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user
Control: 30c5387d Table: 86801300 DAC: fffffffd
Register r0 information: NULL pointer
Register r1 information: non-paged memory
Register r2 information: NULL pointer
Register r3 information: NULL pointer
Register r4 information: NULL pointer
Register r5 information: non-slab/vmalloc memory
Register r6 information: non-slab/vmalloc memory
Register r7 information: NULL pointer
Register r8 information: slab filp start 8665ce00 pointer offset 0 size 128
Register r9 information: slab kmalloc-cg-128 start 86c5a600 pointer offset 0 size 128
Register r10 information: slab filp start 8665ce00 pointer offset 0 size 128
Register r11 information: 2-page vmalloc region starting at 0xdf968000 allocated at kernel_clone+0xc4/0x440 kernel/fork.c:2798
Register r12 information: NULL pointer
Process syz-executor704 (pid: 4221, stack limit = 0xdf968000)
Stack: (0xdf969ed0 to 0xdf96a000)
9ec0: 00000000 00000000 00000000 9b02fc30
9ee0: 86c7ab80 86c5a600 86c7ab80 fffffdf9 df969f34 df969f08 80791374 80207934
9f00: 825897f0 0000006a 00000000 00000000 00000001 00000000 fffffdf9 9b02fc30
9f20: 86c5a600 df969f60 df969f5c df969f38 80632b70 8079114c 80501748 805015b0
9f40: 00000000 00000000 00000000 86c5a604 df969fa4 df969f60 80634f3c 80632ab8
9f60: 86801c00 00000001 00000000 00000000 00000000 9b02fc30 00000000 00000000
9f80: 00000002 00000001 000001af 8020029c 84563300 000001af 00000000 df969fa8
9fa0: 80200060 80634c2c 00000000 00000002 00000003 00000000 000653e0 00000000
9fc0: 00000000 00000002 00000001 000001af 00000000 7eb39e0c 00000002 00000000
9fe0: 7eb39c90 7eb39c80 00010330 00027e10 60000010 00000003 00000000 00000000
Call trace:
[<80207924>] (ext2_msg_fc) from [<80791374>] (ext2_parse_param+0x234/0x2dc fs/ext2/super.c:598)
r3:0000006a r2:825897f0
r6:fffffdf9 r5:86c7ab80 r4:86c5a600
[<80791140>] (ext2_parse_param) from [<80632b70>] (vfs_parse_fs_param+0xc4/0x13c fs/fs_context.c:132)
r5:df969f60 r4:86c5a600
[<80632aac>] (vfs_parse_fs_param) from [<80634f3c>] (vfs_fsconfig_locked fs/fsopen.c:306 [inline])
[<80632aac>] (vfs_parse_fs_param) from [<80634f3c>] (__do_sys_fsconfig fs/fsopen.c:466 [inline])
[<80632aac>] (vfs_parse_fs_param) from [<80634f3c>] (sys_fsconfig+0x31c/0x514 fs/fsopen.c:353)
r6:86c5a604 r5:00000000 r4:00000000
[<80634c20>] (sys_fsconfig) from [<80200060>] (ret_fast_syscall+0x0/0x1c arch/arm/mm/proc-v7.S:67)
Exception stack(0xdf969fa8 to 0xdf969ff0)
9fa0: 00000000 00000002 00000003 00000000 000653e0 00000000
9fc0: 00000000 00000002 00000001 000001af 00000000 7eb39e0c 00000002 00000000
9fe0: 7eb39c90 7eb39c80 00010330 00027e10
r10:000001af r9:84563300 r8:8020029c r7:000001af r6:00000001 r5:00000002
r4:00000000
Code: 00000000 00000000 00000000 e3a03000 (e4d02001)
---[ end trace 0000000000000000 ]---
----------------
Code disassembly (best guess):
c: e3a03000 mov r3, #0
* 10: e4d02001 ldrb r2, [r0], #1 <-- trapping instruction
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
For information about AI bisection see: https://goo.gl/tpsmEJ#ai-bisection
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [syzbot] [ext4?] BUG: unable to handle kernel NULL pointer dereference in strrchr
2026-11-20 12:49 [syzbot] [ext4?] BUG: unable to handle kernel NULL pointer dereference in strrchr syzbot
@ 2026-11-20 13:07 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2026-11-20 13:07 UTC (permalink / raw)
To: syzbot; +Cc: jack, linux-ext4, linux-kernel, sandeen, syzkaller-bugs
[-- Attachment #1: Type: text/plain, Size: 1805 bytes --]
On Fri 20-11-26 04:49:43, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit: 65e4fd942f72 Merge tag 'selinux-pr-20261119' of git://git...
> git tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux
> console output: https://syzkaller.appspot.com/x/log.txt?x=1102b185580000
> kernel config: https://syzkaller.appspot.com/x/.config?x=3299dd89908ef903
> dashboard link: https://syzkaller.appspot.com/bug?extid=1d23ad199a3bfd6f9149
> compiler: arm-linux-gnueabi-gcc (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44
> userspace arch: arm
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=165e3abd580000
>
> The issue was bisected by AI to:
>
> commit 98f18c76c2c3089183c35d2c33e468ad6c03d86b
> Author: Eric Sandeen <sandeen@redhat.com>
> Date: Sun Feb 23 19:57:41 2025 +0000
>
> ext2: create ext2_msg_fc for use during parsing
>
> AI reasoning: https://syzkaller.appspot.com/ai_job?id=f0a661eb-7c3b-44be-becd-54ce0bd776b2
>
> AI-generated root cause summary:
> In fs/ext2/super.c, ext2_msg_fc() formats log messages for filesystem context
> operations. When fc->purpose != FS_CONTEXT_FOR_RECONFIGURE, it unconditionally
> executes strrchr(fc->source, '/') without verifying that fc->source is non-NULL.
> During filesystem configuration via the new mount API (e.g., fsopen() followed
> by fsconfig()), fc->source starts as NULL and options can be parsed in any
> order. Specifying an option that triggers ext2_msg_fc() (such as "dax", "nobh",
> or "reservation") prior to supplying the "source" parameter passes a NULL
> pointer to strrchr(), causing a kernel NULL pointer dereference.
Yeah, correct. I'm putting attached patch to my tree.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
[-- Attachment #2: 0001-ext2-Fix-NULL-ptr-dereference-in-ext2_msg_fc.patch --]
[-- Type: text/x-patch, Size: 1217 bytes --]
From bd31e164b532d064560868011167baa218fcb2f3 Mon Sep 17 00:00:00 2001
From: Jan Kara <jack@suse.cz>
Date: Fri, 20 Nov 2026 14:03:58 +0100
Subject: [PATCH] ext2: Fix NULL ptr dereference in ext2_msg_fc()
When mount parameters emitting messages are configured before
fc->source, we crash in ext2_msg_fc() when trying to create a fs
identifier for the filesystem from fc->source. Just use unknown in that
case.
Fixes: 98f18c76c2c3 ("ext2: create ext2_msg_fc for use during parsing")
Reported-by: syzbot+1d23ad199a3bfd6f9149@syzkaller.appspotmail.com
Signed-off-by: Jan Kara <jack@suse.cz>
---
fs/ext2/super.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 54a6c26d0388..63a3a212a0ec 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -89,13 +89,15 @@ static void ext2_msg_fc(struct fs_context *fc, const char *prefix,
if (fc->purpose == FS_CONTEXT_FOR_RECONFIGURE) {
s_id = fc->root->d_sb->s_id;
- } else {
+ } else if (fc->source) {
/* get last path component of source */
s_id = strrchr(fc->source, '/');
if (s_id)
s_id++;
else
s_id = fc->source;
+ } else {
+ s_id = "unknown";
}
va_start(args, fmt);
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-20 13:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 12:49 [syzbot] [ext4?] BUG: unable to handle kernel NULL pointer dereference in strrchr syzbot
2026-11-20 13:07 ` Jan Kara
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.