All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH bluez] tools/test-runner: Fix termination of the emulator
@ 2026-11-20 10:26 Zijun Hu
  2026-11-20 14:43 ` [bluez] " bluez.test.bot
  0 siblings, 1 reply; 2+ messages in thread
From: Zijun Hu @ 2026-11-20 10:26 UTC (permalink / raw)
  To: Linux Bluetooth; +Cc: Marcel Holtmann, Luiz Augusto von Dentz, Zijun Hu

run_command() intends to terminate the emulator, but wrongly sends
SIGTERM to the D-Bus system daemon instead.

Fix by sending SIGTERM to @emulator_pid instead of @dbus_pid.

Fixes: 850003734a74 ("test-runner: Add option to start emulator")
Assisted-by: Claude:claude-opus-5-5
---
 tools/test-runner.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/test-runner.c b/tools/test-runner.c
index 0bca31a46351..52b58df7618e 100644
--- a/tools/test-runner.c
+++ b/tools/test-runner.c
@@ -2064,17 +2064,17 @@ start_next:
 
 	if (dbus_pid > 0)
 		kill(dbus_pid, SIGTERM);
 
 	if (dbus_session_pid > 0)
 		kill(dbus_session_pid, SIGTERM);
 
 	if (emulator_pid > 0)
-		kill(dbus_pid, SIGTERM);
+		kill(emulator_pid, SIGTERM);
 
 	if (monitor_pid > 0)
 		kill(monitor_pid, SIGTERM);
 
 	if (serial_fd >= 0)
 		close(serial_fd);
 }
 

---
base-commit: 1adfe662efeff12997df9ddd0960dbd0de9c8ea7
change-id: 20261120-fix_kvm-99b4b868ae3d

Best regards,
--  
Zijun Hu <zijun.hu@oss.qualcomm.com>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [bluez] tools/test-runner: Fix termination of the emulator
  2026-11-20 10:26 [PATCH bluez] tools/test-runner: Fix termination of the emulator Zijun Hu
@ 2026-11-20 14:43 ` bluez.test.bot
  0 siblings, 0 replies; 2+ messages in thread
From: bluez.test.bot @ 2026-11-20 14:43 UTC (permalink / raw)
  To: linux-bluetooth, zijun.hu

[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1217178/

---Test result---

Test Summary:
CheckPatch                    PASS      0.45 seconds
GitLint                       FAIL      0.32 seconds
BuildEll                      PASS      16.16 seconds
BluezMake                     PASS      230.98 seconds
CheckSmatch                   PASS      235.70 seconds
bluezmakeextell               PASS      75.81 seconds
TestFunctional                PASS      1000.42 seconds
IncrementalBuild              PASS      232.51 seconds
ScanBuild                     PASS      848.13 seconds

Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[bluez] tools/test-runner: Fix termination of the emulator

19: B2 Line has trailing whitespace: "--  "


https://github.com/bluez/bluez/pull/2856

---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-20 14:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 10:26 [PATCH bluez] tools/test-runner: Fix termination of the emulator Zijun Hu
2026-11-20 14:43 ` [bluez] " bluez.test.bot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.