From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-gpio@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 1/9] pinctrl: Use seq_putc() in three functions
Date: Tue, 02 May 2017 09:21:55 +0000 [thread overview]
Message-ID: <6b51c0df-b48e-c49c-b7ae-ee0c8edfb581@users.sourceforge.net> (raw)
In-Reply-To: <d8cce619-5a37-2f8b-1c07-a4c45443fb50@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 1 May 2017 22:24:29 +0200
A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pinctrl/pinconf.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index a02dba35fcf3..1a3fbdf81ecb 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -232,7 +232,7 @@ static void pinconf_show_config(struct seq_file *s, struct pinctrl_dev *pctldev,
configs[i]);
else
seq_printf(s, "%08lx", configs[i]);
- seq_puts(s, "\n");
+ seq_putc(s, '\n');
}
}
@@ -325,8 +325,7 @@ static int pinconf_pins_show(struct seq_file *s, void *what)
seq_printf(s, "pin %d (%s): ", pin, desc->name);
pinconf_dump_pin(pctldev, s, pin);
-
- seq_printf(s, "\n");
+ seq_putc(s, '\n');
}
mutex_unlock(&pctldev->mutex);
@@ -361,8 +360,7 @@ static int pinconf_groups_show(struct seq_file *s, void *what)
seq_printf(s, "%u (%s): ", selector, gname);
pinconf_dump_group(pctldev, s, selector, gname);
- seq_printf(s, "\n");
-
+ seq_putc(s, '\n');
selector++;
}
--
2.12.2
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-gpio@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 1/9] pinctrl: Use seq_putc() in three functions
Date: Tue, 2 May 2017 11:21:55 +0200 [thread overview]
Message-ID: <6b51c0df-b48e-c49c-b7ae-ee0c8edfb581@users.sourceforge.net> (raw)
In-Reply-To: <d8cce619-5a37-2f8b-1c07-a4c45443fb50@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 1 May 2017 22:24:29 +0200
A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pinctrl/pinconf.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index a02dba35fcf3..1a3fbdf81ecb 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -232,7 +232,7 @@ static void pinconf_show_config(struct seq_file *s, struct pinctrl_dev *pctldev,
configs[i]);
else
seq_printf(s, "%08lx", configs[i]);
- seq_puts(s, "\n");
+ seq_putc(s, '\n');
}
}
@@ -325,8 +325,7 @@ static int pinconf_pins_show(struct seq_file *s, void *what)
seq_printf(s, "pin %d (%s): ", pin, desc->name);
pinconf_dump_pin(pctldev, s, pin);
-
- seq_printf(s, "\n");
+ seq_putc(s, '\n');
}
mutex_unlock(&pctldev->mutex);
@@ -361,8 +360,7 @@ static int pinconf_groups_show(struct seq_file *s, void *what)
seq_printf(s, "%u (%s): ", selector, gname);
pinconf_dump_group(pctldev, s, selector, gname);
- seq_printf(s, "\n");
-
+ seq_putc(s, '\n');
selector++;
}
--
2.12.2
next prev parent reply other threads:[~2017-05-02 9:21 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 9:20 [PATCH 0/9] pinctrl: Fine-tuning for some function implementations SF Markus Elfring
2017-05-02 9:20 ` SF Markus Elfring
2017-05-02 9:21 ` SF Markus Elfring [this message]
2017-05-02 9:21 ` [PATCH 1/9] pinctrl: Use seq_putc() in three functions SF Markus Elfring
2017-05-11 11:34 ` Linus Walleij
2017-05-11 11:34 ` Linus Walleij
2017-05-02 9:22 ` [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call in two functions SF Markus Elfring
2017-05-02 9:22 ` SF Markus Elfring
2017-05-03 17:47 ` Andy Shevchenko
2017-05-03 17:47 ` Andy Shevchenko
2017-05-02 9:23 ` [PATCH 3/9] pinctrl: Combine five seq_printf() calls into one call in pinconf_dbg_config_print() SF Markus Elfring
2017-05-02 9:23 ` SF Markus Elfring
2017-05-03 17:48 ` Andy Shevchenko
2017-05-03 17:48 ` Andy Shevchenko
2017-05-02 9:24 ` [PATCH 4/9] pinctrl: Replace two seq_printf() calls by seq_puts() in pinconf_show_map() SF Markus Elfring
2017-05-02 9:24 ` SF Markus Elfring
2017-05-11 13:24 ` Linus Walleij
2017-05-11 13:24 ` Linus Walleij
2017-05-02 9:25 ` [PATCH 5/9] pinctrl: Adjust five checks for null pointers SF Markus Elfring
2017-05-02 9:25 ` SF Markus Elfring
2017-05-11 13:25 ` Linus Walleij
2017-05-11 13:25 ` Linus Walleij
2017-05-02 9:26 ` [PATCH 6/9] pinctrl: Combine substrings for a message in pin_config_group_get() SF Markus Elfring
2017-05-02 9:26 ` SF Markus Elfring
2017-05-03 17:49 ` Andy Shevchenko
2017-05-03 17:49 ` Andy Shevchenko
2017-05-11 13:26 ` Linus Walleij
2017-05-11 13:26 ` Linus Walleij
2017-05-02 9:27 ` [PATCH 7/9] pinctrl: Add spaces for better code readability SF Markus Elfring
2017-05-02 9:27 ` SF Markus Elfring
2017-05-11 13:27 ` Linus Walleij
2017-05-11 13:27 ` Linus Walleij
2017-05-02 9:28 ` [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show() SF Markus Elfring
2017-05-02 9:28 ` SF Markus Elfring
2017-05-03 17:45 ` Andy Shevchenko
2017-05-03 17:45 ` Andy Shevchenko
2017-05-11 13:28 ` Linus Walleij
2017-05-11 13:28 ` Linus Walleij
2017-05-02 9:29 ` [PATCH 9/9] pinctrl: Adjust nine checks for null pointers SF Markus Elfring
2017-05-02 9:29 ` SF Markus Elfring
2017-05-11 13:29 ` Linus Walleij
2017-05-11 13:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b51c0df-b48e-c49c-b7ae-ee0c8edfb581@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.