From: David Lechner <dlechner@baylibre.com>
To: Anshul Dalal <anshuld@ti.com>, Tom Rini <trini@konsulko.com>,
Casey Connolly <casey.connolly@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Sumit Garg <sumit.garg@kernel.org>,
Nobuhiro Iwamatsu <iwamatsu@nigauri.org>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
Simon Glass <sjg@chromium.org>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Kever Yang <kever.yang@rock-chips.com>
Cc: Julien Stephan <jstephan@baylibre.com>,
u-boot@lists.denx.de, u-boot-qcom@groups.io
Subject: Re: [PATCH] phy: Kconfig: use bool instead of tristate
Date: Thu, 14 May 2026 08:17:28 -0500 [thread overview]
Message-ID: <6b8790b4-6180-4f10-8857-c2714cd2fdd4@baylibre.com> (raw)
In-Reply-To: <DII5FZA8ENCM.3KT0XC9C90X2D@ti.com>
On 5/14/26 12:27 AM, Anshul Dalal wrote:
> On Wed May 13, 2026 at 7:41 PM IST, David Lechner wrote:
>> Change all uses of tristate in the PHY Kconfigs to bool. U-Boot does
>> not support modules, so tristate does not make sense here.
>>
>> Signed-off-by: David Lechner <dlechner@baylibre.com>
>
> Thanks for the fix David, I see the same issue is repeated at other
> places outside of PHY:
>
> % find . -name Kconfig | xargs -I {} grep -HPn '^\ttristate' {} | wc -l
> 47
>
> Let me know if you would be interested in doing a treewide cleanup
> otherwise I can take this up.
>
I just did a few subsystems to start with to see what kind
of reaction it got. Feel free to pick this up. And I will
consider doing the rest later.
prev parent reply other threads:[~2026-05-14 13:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 14:11 [PATCH] phy: Kconfig: use bool instead of tristate David Lechner
2026-05-13 14:29 ` Tom Rini
2026-05-13 14:31 ` Quentin Schulz
2026-05-14 2:20 ` Macpaul Lin (林智斌)
2026-05-14 5:27 ` Anshul Dalal
2026-05-14 13:17 ` David Lechner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b8790b4-6180-4f10-8857-c2714cd2fdd4@baylibre.com \
--to=dlechner@baylibre.com \
--cc=anshuld@ti.com \
--cc=casey.connolly@linaro.org \
--cc=iwamatsu@nigauri.org \
--cc=jstephan@baylibre.com \
--cc=kever.yang@rock-chips.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=neil.armstrong@linaro.org \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=sumit.garg@kernel.org \
--cc=trini@konsulko.com \
--cc=u-boot-qcom@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.