Re: [PATCH] phy: Kconfig: use bool instead of tristate

["Macpaul Lin (林智斌)" <Macpaul.Lin@mediatek.com>]

On Wed, 2026-05-13 at 09:11 -0500, David Lechner wrote:
> Change all uses of tristate in the PHY Kconfigs to bool. U-Boot does
> not support modules, so tristate does not make sense here.
> 
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
>  drivers/phy/Kconfig          | 14 +++++++-------
>  drivers/phy/cadence/Kconfig  |  4 ++--
>  drivers/phy/qcom/Kconfig     | 16 ++++++++--------
>  drivers/phy/renesas/Kconfig  |  6 +++---
>  drivers/phy/rockchip/Kconfig |  2 +-
>  drivers/phy/ti/Kconfig       |  2 +-
>  6 files changed, 22 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 5c8ec2b146f..eafa82fe494 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -114,7 +114,7 @@ config BCM_SR_PCIE_PHY
>  	  If unsure, say N.
>  
>  config PHY_DA8XX_USB
> -	tristate "TI DA8xx USB PHY Driver"
> +	bool "TI DA8xx USB PHY Driver"
>  	depends on PHY && ARCH_DAVINCI
>  	help
>  	  Enable this to support the USB PHY on DA8xx SoCs.
> @@ -138,7 +138,7 @@ config SPL_PIPE3_PHY
>  	  and omap5
>  
>  config AM654_PHY
> -	tristate "TI AM654 SERDES support"
> +	bool "TI AM654 SERDES support"
>  	depends on PHY && ARCH_K3
>  	select REGMAP
>  	select SYSCON
> @@ -155,7 +155,7 @@ config STI_USB_PHY
>  	  STiH407 SoC families.
>  
>  config PHY_RCAR_GEN2
> -	tristate "Renesas R-Car Gen2 USB PHY"
> +	bool "Renesas R-Car Gen2 USB PHY"
>  	depends on PHY && RCAR_GEN2
>  	help
>  	  Support for the Renesas R-Car Gen2 USB PHY. This driver
> operates the
> @@ -163,7 +163,7 @@ config PHY_RCAR_GEN2
>  	  allows configuring the module multiplexing.
>  
>  config PHY_RCAR_GEN3
> -	tristate "Renesas R-Car Gen3 USB PHY"
> +	bool "Renesas R-Car Gen3 USB PHY"
>  	depends on PHY && CLK && DM_REGULATOR && (RCAR_GEN3 ||
> RZG2L)
>  	default y if (RCAR_GEN3 || RZG2L)
>  	help
> @@ -171,7 +171,7 @@ config PHY_RCAR_GEN3
>  	  PHY connected to EHCI USB module and controls USB OTG
> operation.
>  
>  config PHY_STM32_USBPHYC
> -	tristate "STMicroelectronics STM32 SoC USB HS PHY driver"
> +	bool "STMicroelectronics STM32 SoC USB HS PHY driver"
>  	depends on PHY && ARCH_STM32MP
>  	help
>  	  Enable this to support the High-Speed USB transceiver that
> is part of
> @@ -283,7 +283,7 @@ config PHY_MTK_TPHY
>  	  so you can easily distinguish them by banks layout.
>  
>  config PHY_MTK_UFS
> -	tristate "MediaTek UFS M-PHY driver"
> +	bool "MediaTek UFS M-PHY driver"
>  	depends on ARCH_MEDIATEK
>  	depends on PHY
>  	help
> @@ -337,7 +337,7 @@ config PHY_IMX8M_PCIE
>  	  This PHY is found on i.MX8M devices supporting PCIe.
>  
>  config PHY_XILINX_ZYNQMP
> -	tristate "Xilinx ZynqMP PHY driver"
> +	bool "Xilinx ZynqMP PHY driver"
>  	depends on PHY && ARCH_ZYNQMP
>  	help
>  	  Enable this to support ZynqMP High Speed Gigabit
> Transceiver
> diff --git a/drivers/phy/cadence/Kconfig
> b/drivers/phy/cadence/Kconfig
> index 8c0ab80fbbc..f5f096889fe 100644
> --- a/drivers/phy/cadence/Kconfig
> +++ b/drivers/phy/cadence/Kconfig
> @@ -1,11 +1,11 @@
>  config PHY_CADENCE_SIERRA
> -	tristate "Cadence Sierra PHY Driver"
> +	bool "Cadence Sierra PHY Driver"
>  	depends on DM_RESET
>  	help
>  	  Enable this to support the Cadence Sierra PHY driver
>  
>  config PHY_CADENCE_TORRENT
> -	tristate "Cadence Torrent PHY Driver"
> +	bool "Cadence Torrent PHY Driver"
>  	depends on DM_RESET
>  	help
>  	  Enable this to support the Cadence Torrent PHY driver
> diff --git a/drivers/phy/qcom/Kconfig b/drivers/phy/qcom/Kconfig
> index 49f830abf01..7094903d869 100644
> --- a/drivers/phy/qcom/Kconfig
> +++ b/drivers/phy/qcom/Kconfig
> @@ -7,7 +7,7 @@ config MSM8916_USB_PHY
>  	  This PHY is found on qualcomm dragonboard410c development
> board.
>  
>  config PHY_QCOM_IPQ4019_USB
> -	tristate "Qualcomm IPQ4019 USB PHY driver"
> +	bool "Qualcomm IPQ4019 USB PHY driver"
>  	depends on PHY && ARCH_IPQ40XX
>  	help
>  	  Support for the USB PHY-s on Qualcomm IPQ40xx SoC-s.
> @@ -21,26 +21,26 @@ config PHY_QCOM_QMP_COMBO
>  	  PHY (USB3 + DisplayPort). Currently only USB3 mode is
> supported.
>  
>  config PHY_QCOM_QMP_PCIE
> -	tristate "Qualcomm QMP PCIe PHY driver"
> +	bool "Qualcomm QMP PCIe PHY driver"
>  	depends on PHY && ARCH_SNAPDRAGON
>  	help
>  	  Enable this to support the PCIe QMP PHY on various
> Qualcomm chipsets.
>  
>  config PHY_QCOM_QMP_UFS
> -	tristate "Qualcomm QMP UFS PHY driver"
> +	bool "Qualcomm QMP UFS PHY driver"
>  	depends on PHY && ARCH_SNAPDRAGON
>  	help
>  	  Enable this to support the UFS QMP PHY on various Qualcomm
> chipsets.
>  
>  config PHY_QCOM_QUSB2
> -	tristate "Qualcomm USB QUSB2 PHY driver"
> +	bool "Qualcomm USB QUSB2 PHY driver"
>  	depends on PHY && ARCH_SNAPDRAGON
>  	help
>  	  Enable this to support the Super-Speed USB transceiver on
> various
>  	  Qualcomm chipsets.
>  
>  config PHY_QCOM_USB_SNPS_FEMTO_V2
> -	tristate "Qualcomm SNPS FEMTO USB HS PHY v2"
> +	bool "Qualcomm SNPS FEMTO USB HS PHY v2"
>  	depends on PHY && ARCH_SNAPDRAGON
>  	help
>  	  Enable this to support the Qualcomm Synopsys DesignWare
> Core 7nm
> @@ -48,7 +48,7 @@ config PHY_QCOM_USB_SNPS_FEMTO_V2
>  	  is usually paired with Synopsys DWC3 USB IPs on MSM SOCs.
>  
>  config PHY_QCOM_SNPS_EUSB2
> -	tristate "Qualcomm Synopsys eUSB2 High-Speed PHY"
> +	bool "Qualcomm Synopsys eUSB2 High-Speed PHY"
>  	depends on PHY && ARCH_SNAPDRAGON
>  	help
>  	  Enable this to support the Qualcomm Synopsys DesignWare
> eUSB2
> @@ -56,7 +56,7 @@ config PHY_QCOM_SNPS_EUSB2
>  	  is usually paired with Synopsys DWC3 USB IPs on MSM SOCs.
>  
>  config PHY_QCOM_USB_HS_28NM
> -	tristate "Qualcomm 28nm High-Speed PHY"
> +	bool "Qualcomm 28nm High-Speed PHY"
>  	depends on PHY && ARCH_SNAPDRAGON
>  	help
>  	  Enable this to support the Qualcomm Synopsys DesignWare
> Core 28nm
> @@ -65,7 +65,7 @@ config PHY_QCOM_USB_HS_28NM
>  	  IPs on MSM SOCs.
>  
>  config PHY_QCOM_USB_SS
> -	tristate "Qualcomm USB Super-Speed PHY driver"
> +	bool "Qualcomm USB Super-Speed PHY driver"
>  	depends on PHY && ARCH_SNAPDRAGON
>  	help
>  	  Enable this to support the Super-Speed USB transceiver on
> various
> diff --git a/drivers/phy/renesas/Kconfig
> b/drivers/phy/renesas/Kconfig
> index affbee0500c..3358d454e59 100644
> --- a/drivers/phy/renesas/Kconfig
> +++ b/drivers/phy/renesas/Kconfig
> @@ -3,19 +3,19 @@
>  # Phy drivers for Renesas platforms
>  
>  config PHY_R8A779F0_ETHERNET_SERDES
> -	tristate "Renesas R-Car S4-8 Ethernet SERDES driver"
> +	bool "Renesas R-Car S4-8 Ethernet SERDES driver"
>  	depends on RCAR_64 && PHY
>  	help
>  	  Support for Ethernet SERDES found on Renesas R-Car S4-8
> SoCs.
>  
>  config PHY_R8A78000_ETHERNET_PCS
> -	tristate "Renesas R-Car X5H Ethernet PCS driver"
> +	bool "Renesas R-Car X5H Ethernet PCS driver"
>  	depends on RCAR_64 && PHY
>  	help
>  	  Support for Ethernet PCS found on Renesas R-Car X5H SoCs.
>  
>  config PHY_R8A78000_MP_PHY
> -	tristate "Renesas R-Car X5H Multi-Protocol PHY driver"
> +	bool "Renesas R-Car X5H Multi-Protocol PHY driver"
>  	depends on RCAR_64 && PHY
>  	help
>  	  Support for Multi-Protocol PHY on Renesas R-Car X5H SoCs.
> diff --git a/drivers/phy/rockchip/Kconfig
> b/drivers/phy/rockchip/Kconfig
> index 80128335d52..6f3d7ebe29e 100644
> --- a/drivers/phy/rockchip/Kconfig
> +++ b/drivers/phy/rockchip/Kconfig
> @@ -49,7 +49,7 @@ config PHY_ROCKCHIP_SNPS_PCIE3
>  	  also be able splited into multiple combinations of lanes.
>  
>  config PHY_ROCKCHIP_USBDP
> -	tristate "Rockchip USBDP COMBO PHY Driver"
> +	bool "Rockchip USBDP COMBO PHY Driver"
>  	depends on ARCH_ROCKCHIP
>  	select PHY
>  	help
> diff --git a/drivers/phy/ti/Kconfig b/drivers/phy/ti/Kconfig
> index df750b26d66..fe96eb6806f 100644
> --- a/drivers/phy/ti/Kconfig
> +++ b/drivers/phy/ti/Kconfig
> @@ -1,5 +1,5 @@
>  config PHY_J721E_WIZ
> -	tristate "TI J721E WIZ (SERDES Wrapper) support"
> +	bool "TI J721E WIZ (SERDES Wrapper) support"
>  	depends on ARCH_K3
>  	help
>  	  This option enables support for WIZ module present in TI's
> J721E
> 
> ---
> base-commit: e3e651c480c46b332f16a7555b97c6c6fd640a40
> change-id: 20260513-phy-kconfig-no-tristate-61bc2d324149
> 
> Best regards,
> --  
> David Lechner <dlechner@baylibre.com>
> 

Reviewed-by: Macpaul Lin <macpaul.lin@mediatek.com>

Best regards,
Macpaul Lin