* [PATCH] phy: Kconfig: use bool instead of tristate
@ 2026-05-13 14:11 David Lechner
2026-05-13 14:29 ` Tom Rini
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: David Lechner @ 2026-05-13 14:11 UTC (permalink / raw)
To: Tom Rini, Casey Connolly, Neil Armstrong, Sumit Garg,
Nobuhiro Iwamatsu, Marek Vasut, Simon Glass, Philipp Tomsich,
Kever Yang
Cc: Julien Stephan, u-boot, u-boot-qcom, David Lechner
Change all uses of tristate in the PHY Kconfigs to bool. U-Boot does
not support modules, so tristate does not make sense here.
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
drivers/phy/Kconfig | 14 +++++++-------
drivers/phy/cadence/Kconfig | 4 ++--
drivers/phy/qcom/Kconfig | 16 ++++++++--------
drivers/phy/renesas/Kconfig | 6 +++---
drivers/phy/rockchip/Kconfig | 2 +-
drivers/phy/ti/Kconfig | 2 +-
6 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 5c8ec2b146f..eafa82fe494 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -114,7 +114,7 @@ config BCM_SR_PCIE_PHY
If unsure, say N.
config PHY_DA8XX_USB
- tristate "TI DA8xx USB PHY Driver"
+ bool "TI DA8xx USB PHY Driver"
depends on PHY && ARCH_DAVINCI
help
Enable this to support the USB PHY on DA8xx SoCs.
@@ -138,7 +138,7 @@ config SPL_PIPE3_PHY
and omap5
config AM654_PHY
- tristate "TI AM654 SERDES support"
+ bool "TI AM654 SERDES support"
depends on PHY && ARCH_K3
select REGMAP
select SYSCON
@@ -155,7 +155,7 @@ config STI_USB_PHY
STiH407 SoC families.
config PHY_RCAR_GEN2
- tristate "Renesas R-Car Gen2 USB PHY"
+ bool "Renesas R-Car Gen2 USB PHY"
depends on PHY && RCAR_GEN2
help
Support for the Renesas R-Car Gen2 USB PHY. This driver operates the
@@ -163,7 +163,7 @@ config PHY_RCAR_GEN2
allows configuring the module multiplexing.
config PHY_RCAR_GEN3
- tristate "Renesas R-Car Gen3 USB PHY"
+ bool "Renesas R-Car Gen3 USB PHY"
depends on PHY && CLK && DM_REGULATOR && (RCAR_GEN3 || RZG2L)
default y if (RCAR_GEN3 || RZG2L)
help
@@ -171,7 +171,7 @@ config PHY_RCAR_GEN3
PHY connected to EHCI USB module and controls USB OTG operation.
config PHY_STM32_USBPHYC
- tristate "STMicroelectronics STM32 SoC USB HS PHY driver"
+ bool "STMicroelectronics STM32 SoC USB HS PHY driver"
depends on PHY && ARCH_STM32MP
help
Enable this to support the High-Speed USB transceiver that is part of
@@ -283,7 +283,7 @@ config PHY_MTK_TPHY
so you can easily distinguish them by banks layout.
config PHY_MTK_UFS
- tristate "MediaTek UFS M-PHY driver"
+ bool "MediaTek UFS M-PHY driver"
depends on ARCH_MEDIATEK
depends on PHY
help
@@ -337,7 +337,7 @@ config PHY_IMX8M_PCIE
This PHY is found on i.MX8M devices supporting PCIe.
config PHY_XILINX_ZYNQMP
- tristate "Xilinx ZynqMP PHY driver"
+ bool "Xilinx ZynqMP PHY driver"
depends on PHY && ARCH_ZYNQMP
help
Enable this to support ZynqMP High Speed Gigabit Transceiver
diff --git a/drivers/phy/cadence/Kconfig b/drivers/phy/cadence/Kconfig
index 8c0ab80fbbc..f5f096889fe 100644
--- a/drivers/phy/cadence/Kconfig
+++ b/drivers/phy/cadence/Kconfig
@@ -1,11 +1,11 @@
config PHY_CADENCE_SIERRA
- tristate "Cadence Sierra PHY Driver"
+ bool "Cadence Sierra PHY Driver"
depends on DM_RESET
help
Enable this to support the Cadence Sierra PHY driver
config PHY_CADENCE_TORRENT
- tristate "Cadence Torrent PHY Driver"
+ bool "Cadence Torrent PHY Driver"
depends on DM_RESET
help
Enable this to support the Cadence Torrent PHY driver
diff --git a/drivers/phy/qcom/Kconfig b/drivers/phy/qcom/Kconfig
index 49f830abf01..7094903d869 100644
--- a/drivers/phy/qcom/Kconfig
+++ b/drivers/phy/qcom/Kconfig
@@ -7,7 +7,7 @@ config MSM8916_USB_PHY
This PHY is found on qualcomm dragonboard410c development board.
config PHY_QCOM_IPQ4019_USB
- tristate "Qualcomm IPQ4019 USB PHY driver"
+ bool "Qualcomm IPQ4019 USB PHY driver"
depends on PHY && ARCH_IPQ40XX
help
Support for the USB PHY-s on Qualcomm IPQ40xx SoC-s.
@@ -21,26 +21,26 @@ config PHY_QCOM_QMP_COMBO
PHY (USB3 + DisplayPort). Currently only USB3 mode is supported.
config PHY_QCOM_QMP_PCIE
- tristate "Qualcomm QMP PCIe PHY driver"
+ bool "Qualcomm QMP PCIe PHY driver"
depends on PHY && ARCH_SNAPDRAGON
help
Enable this to support the PCIe QMP PHY on various Qualcomm chipsets.
config PHY_QCOM_QMP_UFS
- tristate "Qualcomm QMP UFS PHY driver"
+ bool "Qualcomm QMP UFS PHY driver"
depends on PHY && ARCH_SNAPDRAGON
help
Enable this to support the UFS QMP PHY on various Qualcomm chipsets.
config PHY_QCOM_QUSB2
- tristate "Qualcomm USB QUSB2 PHY driver"
+ bool "Qualcomm USB QUSB2 PHY driver"
depends on PHY && ARCH_SNAPDRAGON
help
Enable this to support the Super-Speed USB transceiver on various
Qualcomm chipsets.
config PHY_QCOM_USB_SNPS_FEMTO_V2
- tristate "Qualcomm SNPS FEMTO USB HS PHY v2"
+ bool "Qualcomm SNPS FEMTO USB HS PHY v2"
depends on PHY && ARCH_SNAPDRAGON
help
Enable this to support the Qualcomm Synopsys DesignWare Core 7nm
@@ -48,7 +48,7 @@ config PHY_QCOM_USB_SNPS_FEMTO_V2
is usually paired with Synopsys DWC3 USB IPs on MSM SOCs.
config PHY_QCOM_SNPS_EUSB2
- tristate "Qualcomm Synopsys eUSB2 High-Speed PHY"
+ bool "Qualcomm Synopsys eUSB2 High-Speed PHY"
depends on PHY && ARCH_SNAPDRAGON
help
Enable this to support the Qualcomm Synopsys DesignWare eUSB2
@@ -56,7 +56,7 @@ config PHY_QCOM_SNPS_EUSB2
is usually paired with Synopsys DWC3 USB IPs on MSM SOCs.
config PHY_QCOM_USB_HS_28NM
- tristate "Qualcomm 28nm High-Speed PHY"
+ bool "Qualcomm 28nm High-Speed PHY"
depends on PHY && ARCH_SNAPDRAGON
help
Enable this to support the Qualcomm Synopsys DesignWare Core 28nm
@@ -65,7 +65,7 @@ config PHY_QCOM_USB_HS_28NM
IPs on MSM SOCs.
config PHY_QCOM_USB_SS
- tristate "Qualcomm USB Super-Speed PHY driver"
+ bool "Qualcomm USB Super-Speed PHY driver"
depends on PHY && ARCH_SNAPDRAGON
help
Enable this to support the Super-Speed USB transceiver on various
diff --git a/drivers/phy/renesas/Kconfig b/drivers/phy/renesas/Kconfig
index affbee0500c..3358d454e59 100644
--- a/drivers/phy/renesas/Kconfig
+++ b/drivers/phy/renesas/Kconfig
@@ -3,19 +3,19 @@
# Phy drivers for Renesas platforms
config PHY_R8A779F0_ETHERNET_SERDES
- tristate "Renesas R-Car S4-8 Ethernet SERDES driver"
+ bool "Renesas R-Car S4-8 Ethernet SERDES driver"
depends on RCAR_64 && PHY
help
Support for Ethernet SERDES found on Renesas R-Car S4-8 SoCs.
config PHY_R8A78000_ETHERNET_PCS
- tristate "Renesas R-Car X5H Ethernet PCS driver"
+ bool "Renesas R-Car X5H Ethernet PCS driver"
depends on RCAR_64 && PHY
help
Support for Ethernet PCS found on Renesas R-Car X5H SoCs.
config PHY_R8A78000_MP_PHY
- tristate "Renesas R-Car X5H Multi-Protocol PHY driver"
+ bool "Renesas R-Car X5H Multi-Protocol PHY driver"
depends on RCAR_64 && PHY
help
Support for Multi-Protocol PHY on Renesas R-Car X5H SoCs.
diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig
index 80128335d52..6f3d7ebe29e 100644
--- a/drivers/phy/rockchip/Kconfig
+++ b/drivers/phy/rockchip/Kconfig
@@ -49,7 +49,7 @@ config PHY_ROCKCHIP_SNPS_PCIE3
also be able splited into multiple combinations of lanes.
config PHY_ROCKCHIP_USBDP
- tristate "Rockchip USBDP COMBO PHY Driver"
+ bool "Rockchip USBDP COMBO PHY Driver"
depends on ARCH_ROCKCHIP
select PHY
help
diff --git a/drivers/phy/ti/Kconfig b/drivers/phy/ti/Kconfig
index df750b26d66..fe96eb6806f 100644
--- a/drivers/phy/ti/Kconfig
+++ b/drivers/phy/ti/Kconfig
@@ -1,5 +1,5 @@
config PHY_J721E_WIZ
- tristate "TI J721E WIZ (SERDES Wrapper) support"
+ bool "TI J721E WIZ (SERDES Wrapper) support"
depends on ARCH_K3
help
This option enables support for WIZ module present in TI's J721E
---
base-commit: e3e651c480c46b332f16a7555b97c6c6fd640a40
change-id: 20260513-phy-kconfig-no-tristate-61bc2d324149
Best regards,
--
David Lechner <dlechner@baylibre.com>
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] phy: Kconfig: use bool instead of tristate
2026-05-13 14:11 [PATCH] phy: Kconfig: use bool instead of tristate David Lechner
@ 2026-05-13 14:29 ` Tom Rini
2026-05-13 14:31 ` Quentin Schulz
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2026-05-13 14:29 UTC (permalink / raw)
To: David Lechner
Cc: Casey Connolly, Neil Armstrong, Sumit Garg, Nobuhiro Iwamatsu,
Marek Vasut, Simon Glass, Philipp Tomsich, Kever Yang,
Julien Stephan, u-boot, u-boot-qcom
[-- Attachment #1: Type: text/plain, Size: 345 bytes --]
On Wed, May 13, 2026 at 09:11:52AM -0500, David Lechner wrote:
> Change all uses of tristate in the PHY Kconfigs to bool. U-Boot does
> not support modules, so tristate does not make sense here.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
Thanks for the cleanup.
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] phy: Kconfig: use bool instead of tristate
2026-05-13 14:11 [PATCH] phy: Kconfig: use bool instead of tristate David Lechner
2026-05-13 14:29 ` Tom Rini
@ 2026-05-13 14:31 ` Quentin Schulz
2026-05-14 2:20 ` Macpaul Lin (林智斌)
2026-05-14 5:27 ` Anshul Dalal
3 siblings, 0 replies; 6+ messages in thread
From: Quentin Schulz @ 2026-05-13 14:31 UTC (permalink / raw)
To: David Lechner, Tom Rini, Casey Connolly, Neil Armstrong,
Sumit Garg, Nobuhiro Iwamatsu, Marek Vasut, Simon Glass,
Philipp Tomsich, Kever Yang
Cc: Julien Stephan, u-boot, u-boot-qcom
Hi David,
On 5/13/26 4:11 PM, David Lechner wrote:
> Change all uses of tristate in the PHY Kconfigs to bool. U-Boot does
> not support modules, so tristate does not make sense here.
>
Fixes: 25f142543196 ("phy: Add MediaTek UFS PHY Driver")
Fixes: 3d50dba3a3cc ("phy: renesas: Add Multi-Protocol PHY driver for
R-Car X5H")
Fixes: 152ff5696bcc ("phy: renesas: Add PCS driver for Renesas R-Car X5H
R8A78000")
Fixes: d22fe8f2aaf9 ("phy: qcom: add QMP PCIe PHY driver")
Fixes: 62130bc0cb7f ("phy: qcom: Add QMP UFS PHY driver")
Fixes: 6947939b629c ("phy: qcom: add Synopsys eUSB2 PHY driver")
Fixes: 968f512e6c9f ("phy: qcom: Add SNPS femto v2 USB HS phy")
Fixes: 8b133fc19c6e ("phy: qcom: add Qualcomm QUSB2 USB PHY driver")
Fixes: 7b57ca18f8a3 ("phy: rockchip: add usbdp combo phy driver")
Fixes: 08c561447673 ("phy: renesas: Add Renesas Ethernet SERDES driver
for R-Car S4-8")
Fixes: 0b746d287c6c ("phy: Add support for drivers to enable USB on
QCS404 SoC")
Fixes: 1d78d6834962 ("phy: zynqmp: Add serdes/psgtr driver")
Fixes: 1a83f9931e05 ("phy: ti: j721e-wiz: Add support for WIZ module
present in TI J721E SoC")
Fixes: 193c7351624c ("phy: cadence: Add driver for Torrent SERDES")
Fixes: 39b823381d9d ("phy: cadence: Add driver for Sierra PHY")
Fixes: dec042028e8a ("phy: add driver for Qualcomm IPQ40xx USB PHY")
Fixes: 888e1caeaec2 ("phy: add support for AM654x SERDES")
Fixes: fc58263d2e41 ("phy: Add support for phy-da8xx-usb")
Fixes: 6cfc3d664ed6 ("phy: rcar: Add R-Car Gen3 PHY driver")
Fixes: 664258887ded ("phy: rcar: Add R-Car Gen2 PHY driver")
Fixes: 3b2912167824 ("phy: add support for STM32 usb phy controller")
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Thanks!
Quentin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] phy: Kconfig: use bool instead of tristate
2026-05-13 14:11 [PATCH] phy: Kconfig: use bool instead of tristate David Lechner
2026-05-13 14:29 ` Tom Rini
2026-05-13 14:31 ` Quentin Schulz
@ 2026-05-14 2:20 ` Macpaul Lin (林智斌)
2026-05-14 5:27 ` Anshul Dalal
3 siblings, 0 replies; 6+ messages in thread
From: Macpaul Lin (林智斌) @ 2026-05-14 2:20 UTC (permalink / raw)
To: David Lechner, kever.yang@rock-chips.com,
neil.armstrong@linaro.org, trini@konsulko.com,
Bear Wang (萩原惟德),
sumit.garg@kernel.org, Biao Huang (黄彪),
iwamatsu@nigauri.org, casey.connolly@linaro.org,
Pablo Sun (孫毓翔), sjg@chromium.org,
marek.vasut+renesas@mailbox.org, philipp.tomsich@vrull.eu
Cc: Julien Stephan, u-boot@lists.denx.de, u-boot-qcom@groups.io
On Wed, 2026-05-13 at 09:11 -0500, David Lechner wrote:
> Change all uses of tristate in the PHY Kconfigs to bool. U-Boot does
> not support modules, so tristate does not make sense here.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
> drivers/phy/Kconfig | 14 +++++++-------
> drivers/phy/cadence/Kconfig | 4 ++--
> drivers/phy/qcom/Kconfig | 16 ++++++++--------
> drivers/phy/renesas/Kconfig | 6 +++---
> drivers/phy/rockchip/Kconfig | 2 +-
> drivers/phy/ti/Kconfig | 2 +-
> 6 files changed, 22 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 5c8ec2b146f..eafa82fe494 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -114,7 +114,7 @@ config BCM_SR_PCIE_PHY
> If unsure, say N.
>
> config PHY_DA8XX_USB
> - tristate "TI DA8xx USB PHY Driver"
> + bool "TI DA8xx USB PHY Driver"
> depends on PHY && ARCH_DAVINCI
> help
> Enable this to support the USB PHY on DA8xx SoCs.
> @@ -138,7 +138,7 @@ config SPL_PIPE3_PHY
> and omap5
>
> config AM654_PHY
> - tristate "TI AM654 SERDES support"
> + bool "TI AM654 SERDES support"
> depends on PHY && ARCH_K3
> select REGMAP
> select SYSCON
> @@ -155,7 +155,7 @@ config STI_USB_PHY
> STiH407 SoC families.
>
> config PHY_RCAR_GEN2
> - tristate "Renesas R-Car Gen2 USB PHY"
> + bool "Renesas R-Car Gen2 USB PHY"
> depends on PHY && RCAR_GEN2
> help
> Support for the Renesas R-Car Gen2 USB PHY. This driver
> operates the
> @@ -163,7 +163,7 @@ config PHY_RCAR_GEN2
> allows configuring the module multiplexing.
>
> config PHY_RCAR_GEN3
> - tristate "Renesas R-Car Gen3 USB PHY"
> + bool "Renesas R-Car Gen3 USB PHY"
> depends on PHY && CLK && DM_REGULATOR && (RCAR_GEN3 ||
> RZG2L)
> default y if (RCAR_GEN3 || RZG2L)
> help
> @@ -171,7 +171,7 @@ config PHY_RCAR_GEN3
> PHY connected to EHCI USB module and controls USB OTG
> operation.
>
> config PHY_STM32_USBPHYC
> - tristate "STMicroelectronics STM32 SoC USB HS PHY driver"
> + bool "STMicroelectronics STM32 SoC USB HS PHY driver"
> depends on PHY && ARCH_STM32MP
> help
> Enable this to support the High-Speed USB transceiver that
> is part of
> @@ -283,7 +283,7 @@ config PHY_MTK_TPHY
> so you can easily distinguish them by banks layout.
>
> config PHY_MTK_UFS
> - tristate "MediaTek UFS M-PHY driver"
> + bool "MediaTek UFS M-PHY driver"
> depends on ARCH_MEDIATEK
> depends on PHY
> help
> @@ -337,7 +337,7 @@ config PHY_IMX8M_PCIE
> This PHY is found on i.MX8M devices supporting PCIe.
>
> config PHY_XILINX_ZYNQMP
> - tristate "Xilinx ZynqMP PHY driver"
> + bool "Xilinx ZynqMP PHY driver"
> depends on PHY && ARCH_ZYNQMP
> help
> Enable this to support ZynqMP High Speed Gigabit
> Transceiver
> diff --git a/drivers/phy/cadence/Kconfig
> b/drivers/phy/cadence/Kconfig
> index 8c0ab80fbbc..f5f096889fe 100644
> --- a/drivers/phy/cadence/Kconfig
> +++ b/drivers/phy/cadence/Kconfig
> @@ -1,11 +1,11 @@
> config PHY_CADENCE_SIERRA
> - tristate "Cadence Sierra PHY Driver"
> + bool "Cadence Sierra PHY Driver"
> depends on DM_RESET
> help
> Enable this to support the Cadence Sierra PHY driver
>
> config PHY_CADENCE_TORRENT
> - tristate "Cadence Torrent PHY Driver"
> + bool "Cadence Torrent PHY Driver"
> depends on DM_RESET
> help
> Enable this to support the Cadence Torrent PHY driver
> diff --git a/drivers/phy/qcom/Kconfig b/drivers/phy/qcom/Kconfig
> index 49f830abf01..7094903d869 100644
> --- a/drivers/phy/qcom/Kconfig
> +++ b/drivers/phy/qcom/Kconfig
> @@ -7,7 +7,7 @@ config MSM8916_USB_PHY
> This PHY is found on qualcomm dragonboard410c development
> board.
>
> config PHY_QCOM_IPQ4019_USB
> - tristate "Qualcomm IPQ4019 USB PHY driver"
> + bool "Qualcomm IPQ4019 USB PHY driver"
> depends on PHY && ARCH_IPQ40XX
> help
> Support for the USB PHY-s on Qualcomm IPQ40xx SoC-s.
> @@ -21,26 +21,26 @@ config PHY_QCOM_QMP_COMBO
> PHY (USB3 + DisplayPort). Currently only USB3 mode is
> supported.
>
> config PHY_QCOM_QMP_PCIE
> - tristate "Qualcomm QMP PCIe PHY driver"
> + bool "Qualcomm QMP PCIe PHY driver"
> depends on PHY && ARCH_SNAPDRAGON
> help
> Enable this to support the PCIe QMP PHY on various
> Qualcomm chipsets.
>
> config PHY_QCOM_QMP_UFS
> - tristate "Qualcomm QMP UFS PHY driver"
> + bool "Qualcomm QMP UFS PHY driver"
> depends on PHY && ARCH_SNAPDRAGON
> help
> Enable this to support the UFS QMP PHY on various Qualcomm
> chipsets.
>
> config PHY_QCOM_QUSB2
> - tristate "Qualcomm USB QUSB2 PHY driver"
> + bool "Qualcomm USB QUSB2 PHY driver"
> depends on PHY && ARCH_SNAPDRAGON
> help
> Enable this to support the Super-Speed USB transceiver on
> various
> Qualcomm chipsets.
>
> config PHY_QCOM_USB_SNPS_FEMTO_V2
> - tristate "Qualcomm SNPS FEMTO USB HS PHY v2"
> + bool "Qualcomm SNPS FEMTO USB HS PHY v2"
> depends on PHY && ARCH_SNAPDRAGON
> help
> Enable this to support the Qualcomm Synopsys DesignWare
> Core 7nm
> @@ -48,7 +48,7 @@ config PHY_QCOM_USB_SNPS_FEMTO_V2
> is usually paired with Synopsys DWC3 USB IPs on MSM SOCs.
>
> config PHY_QCOM_SNPS_EUSB2
> - tristate "Qualcomm Synopsys eUSB2 High-Speed PHY"
> + bool "Qualcomm Synopsys eUSB2 High-Speed PHY"
> depends on PHY && ARCH_SNAPDRAGON
> help
> Enable this to support the Qualcomm Synopsys DesignWare
> eUSB2
> @@ -56,7 +56,7 @@ config PHY_QCOM_SNPS_EUSB2
> is usually paired with Synopsys DWC3 USB IPs on MSM SOCs.
>
> config PHY_QCOM_USB_HS_28NM
> - tristate "Qualcomm 28nm High-Speed PHY"
> + bool "Qualcomm 28nm High-Speed PHY"
> depends on PHY && ARCH_SNAPDRAGON
> help
> Enable this to support the Qualcomm Synopsys DesignWare
> Core 28nm
> @@ -65,7 +65,7 @@ config PHY_QCOM_USB_HS_28NM
> IPs on MSM SOCs.
>
> config PHY_QCOM_USB_SS
> - tristate "Qualcomm USB Super-Speed PHY driver"
> + bool "Qualcomm USB Super-Speed PHY driver"
> depends on PHY && ARCH_SNAPDRAGON
> help
> Enable this to support the Super-Speed USB transceiver on
> various
> diff --git a/drivers/phy/renesas/Kconfig
> b/drivers/phy/renesas/Kconfig
> index affbee0500c..3358d454e59 100644
> --- a/drivers/phy/renesas/Kconfig
> +++ b/drivers/phy/renesas/Kconfig
> @@ -3,19 +3,19 @@
> # Phy drivers for Renesas platforms
>
> config PHY_R8A779F0_ETHERNET_SERDES
> - tristate "Renesas R-Car S4-8 Ethernet SERDES driver"
> + bool "Renesas R-Car S4-8 Ethernet SERDES driver"
> depends on RCAR_64 && PHY
> help
> Support for Ethernet SERDES found on Renesas R-Car S4-8
> SoCs.
>
> config PHY_R8A78000_ETHERNET_PCS
> - tristate "Renesas R-Car X5H Ethernet PCS driver"
> + bool "Renesas R-Car X5H Ethernet PCS driver"
> depends on RCAR_64 && PHY
> help
> Support for Ethernet PCS found on Renesas R-Car X5H SoCs.
>
> config PHY_R8A78000_MP_PHY
> - tristate "Renesas R-Car X5H Multi-Protocol PHY driver"
> + bool "Renesas R-Car X5H Multi-Protocol PHY driver"
> depends on RCAR_64 && PHY
> help
> Support for Multi-Protocol PHY on Renesas R-Car X5H SoCs.
> diff --git a/drivers/phy/rockchip/Kconfig
> b/drivers/phy/rockchip/Kconfig
> index 80128335d52..6f3d7ebe29e 100644
> --- a/drivers/phy/rockchip/Kconfig
> +++ b/drivers/phy/rockchip/Kconfig
> @@ -49,7 +49,7 @@ config PHY_ROCKCHIP_SNPS_PCIE3
> also be able splited into multiple combinations of lanes.
>
> config PHY_ROCKCHIP_USBDP
> - tristate "Rockchip USBDP COMBO PHY Driver"
> + bool "Rockchip USBDP COMBO PHY Driver"
> depends on ARCH_ROCKCHIP
> select PHY
> help
> diff --git a/drivers/phy/ti/Kconfig b/drivers/phy/ti/Kconfig
> index df750b26d66..fe96eb6806f 100644
> --- a/drivers/phy/ti/Kconfig
> +++ b/drivers/phy/ti/Kconfig
> @@ -1,5 +1,5 @@
> config PHY_J721E_WIZ
> - tristate "TI J721E WIZ (SERDES Wrapper) support"
> + bool "TI J721E WIZ (SERDES Wrapper) support"
> depends on ARCH_K3
> help
> This option enables support for WIZ module present in TI's
> J721E
>
> ---
> base-commit: e3e651c480c46b332f16a7555b97c6c6fd640a40
> change-id: 20260513-phy-kconfig-no-tristate-61bc2d324149
>
> Best regards,
> --
> David Lechner <dlechner@baylibre.com>
>
Reviewed-by: Macpaul Lin <macpaul.lin@mediatek.com>
Best regards,
Macpaul Lin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] phy: Kconfig: use bool instead of tristate
2026-05-13 14:11 [PATCH] phy: Kconfig: use bool instead of tristate David Lechner
` (2 preceding siblings ...)
2026-05-14 2:20 ` Macpaul Lin (林智斌)
@ 2026-05-14 5:27 ` Anshul Dalal
2026-05-14 13:17 ` David Lechner
3 siblings, 1 reply; 6+ messages in thread
From: Anshul Dalal @ 2026-05-14 5:27 UTC (permalink / raw)
To: David Lechner, Tom Rini, Casey Connolly, Neil Armstrong,
Sumit Garg, Nobuhiro Iwamatsu, Marek Vasut, Simon Glass,
Philipp Tomsich, Kever Yang
Cc: Julien Stephan, u-boot, u-boot-qcom
On Wed May 13, 2026 at 7:41 PM IST, David Lechner wrote:
> Change all uses of tristate in the PHY Kconfigs to bool. U-Boot does
> not support modules, so tristate does not make sense here.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
Thanks for the fix David, I see the same issue is repeated at other
places outside of PHY:
% find . -name Kconfig | xargs -I {} grep -HPn '^\ttristate' {} | wc -l
47
Let me know if you would be interested in doing a treewide cleanup
otherwise I can take this up.
Reviewed-by: Anshul Dalal <anshuld@ti.com>
Thanks,
Anshul
> ---
> drivers/phy/Kconfig | 14 +++++++-------
> drivers/phy/cadence/Kconfig | 4 ++--
> drivers/phy/qcom/Kconfig | 16 ++++++++--------
> drivers/phy/renesas/Kconfig | 6 +++---
> drivers/phy/rockchip/Kconfig | 2 +-
> drivers/phy/ti/Kconfig | 2 +-
> 6 files changed, 22 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 5c8ec2b146f..eafa82fe494 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -114,7 +114,7 @@ config BCM_SR_PCIE_PHY
> If unsure, say N.
>
> config PHY_DA8XX_USB
> - tristate "TI DA8xx USB PHY Driver"
> + bool "TI DA8xx USB PHY Driver"
> depends on PHY && ARCH_DAVINCI
> help
> Enable this to support the USB PHY on DA8xx SoCs.
> @@ -138,7 +138,7 @@ config SPL_PIPE3_PHY
> and omap5
>
> config AM654_PHY
> - tristate "TI AM654 SERDES support"
> + bool "TI AM654 SERDES support"
> depends on PHY && ARCH_K3
> select REGMAP
> select SYSCON
> @@ -155,7 +155,7 @@ config STI_USB_PHY
> STiH407 SoC families.
>
> config PHY_RCAR_GEN2
> - tristate "Renesas R-Car Gen2 USB PHY"
> + bool "Renesas R-Car Gen2 USB PHY"
> depends on PHY && RCAR_GEN2
> help
> Support for the Renesas R-Car Gen2 USB PHY. This driver operates the
> @@ -163,7 +163,7 @@ config PHY_RCAR_GEN2
> allows configuring the module multiplexing.
>
> config PHY_RCAR_GEN3
> - tristate "Renesas R-Car Gen3 USB PHY"
> + bool "Renesas R-Car Gen3 USB PHY"
> depends on PHY && CLK && DM_REGULATOR && (RCAR_GEN3 || RZG2L)
> default y if (RCAR_GEN3 || RZG2L)
> help
> @@ -171,7 +171,7 @@ config PHY_RCAR_GEN3
> PHY connected to EHCI USB module and controls USB OTG operation.
>
> config PHY_STM32_USBPHYC
> - tristate "STMicroelectronics STM32 SoC USB HS PHY driver"
> + bool "STMicroelectronics STM32 SoC USB HS PHY driver"
> depends on PHY && ARCH_STM32MP
> help
> Enable this to support the High-Speed USB transceiver that is part of
> @@ -283,7 +283,7 @@ config PHY_MTK_TPHY
> so you can easily distinguish them by banks layout.
>
> config PHY_MTK_UFS
> - tristate "MediaTek UFS M-PHY driver"
> + bool "MediaTek UFS M-PHY driver"
> depends on ARCH_MEDIATEK
> depends on PHY
> help
> @@ -337,7 +337,7 @@ config PHY_IMX8M_PCIE
> This PHY is found on i.MX8M devices supporting PCIe.
>
> config PHY_XILINX_ZYNQMP
> - tristate "Xilinx ZynqMP PHY driver"
> + bool "Xilinx ZynqMP PHY driver"
> depends on PHY && ARCH_ZYNQMP
> help
> Enable this to support ZynqMP High Speed Gigabit Transceiver
> diff --git a/drivers/phy/cadence/Kconfig b/drivers/phy/cadence/Kconfig
> index 8c0ab80fbbc..f5f096889fe 100644
> --- a/drivers/phy/cadence/Kconfig
> +++ b/drivers/phy/cadence/Kconfig
> @@ -1,11 +1,11 @@
> config PHY_CADENCE_SIERRA
> - tristate "Cadence Sierra PHY Driver"
> + bool "Cadence Sierra PHY Driver"
> depends on DM_RESET
> help
> Enable this to support the Cadence Sierra PHY driver
>
> config PHY_CADENCE_TORRENT
> - tristate "Cadence Torrent PHY Driver"
> + bool "Cadence Torrent PHY Driver"
> depends on DM_RESET
> help
> Enable this to support the Cadence Torrent PHY driver
> diff --git a/drivers/phy/qcom/Kconfig b/drivers/phy/qcom/Kconfig
> index 49f830abf01..7094903d869 100644
> --- a/drivers/phy/qcom/Kconfig
> +++ b/drivers/phy/qcom/Kconfig
> @@ -7,7 +7,7 @@ config MSM8916_USB_PHY
> This PHY is found on qualcomm dragonboard410c development board.
>
> config PHY_QCOM_IPQ4019_USB
> - tristate "Qualcomm IPQ4019 USB PHY driver"
> + bool "Qualcomm IPQ4019 USB PHY driver"
> depends on PHY && ARCH_IPQ40XX
> help
> Support for the USB PHY-s on Qualcomm IPQ40xx SoC-s.
> @@ -21,26 +21,26 @@ config PHY_QCOM_QMP_COMBO
> PHY (USB3 + DisplayPort). Currently only USB3 mode is supported.
>
> config PHY_QCOM_QMP_PCIE
> - tristate "Qualcomm QMP PCIe PHY driver"
> + bool "Qualcomm QMP PCIe PHY driver"
> depends on PHY && ARCH_SNAPDRAGON
> help
> Enable this to support the PCIe QMP PHY on various Qualcomm chipsets.
>
> config PHY_QCOM_QMP_UFS
> - tristate "Qualcomm QMP UFS PHY driver"
> + bool "Qualcomm QMP UFS PHY driver"
> depends on PHY && ARCH_SNAPDRAGON
> help
> Enable this to support the UFS QMP PHY on various Qualcomm chipsets.
>
> config PHY_QCOM_QUSB2
> - tristate "Qualcomm USB QUSB2 PHY driver"
> + bool "Qualcomm USB QUSB2 PHY driver"
> depends on PHY && ARCH_SNAPDRAGON
> help
> Enable this to support the Super-Speed USB transceiver on various
> Qualcomm chipsets.
>
> config PHY_QCOM_USB_SNPS_FEMTO_V2
> - tristate "Qualcomm SNPS FEMTO USB HS PHY v2"
> + bool "Qualcomm SNPS FEMTO USB HS PHY v2"
> depends on PHY && ARCH_SNAPDRAGON
> help
> Enable this to support the Qualcomm Synopsys DesignWare Core 7nm
> @@ -48,7 +48,7 @@ config PHY_QCOM_USB_SNPS_FEMTO_V2
> is usually paired with Synopsys DWC3 USB IPs on MSM SOCs.
>
> config PHY_QCOM_SNPS_EUSB2
> - tristate "Qualcomm Synopsys eUSB2 High-Speed PHY"
> + bool "Qualcomm Synopsys eUSB2 High-Speed PHY"
> depends on PHY && ARCH_SNAPDRAGON
> help
> Enable this to support the Qualcomm Synopsys DesignWare eUSB2
> @@ -56,7 +56,7 @@ config PHY_QCOM_SNPS_EUSB2
> is usually paired with Synopsys DWC3 USB IPs on MSM SOCs.
>
> config PHY_QCOM_USB_HS_28NM
> - tristate "Qualcomm 28nm High-Speed PHY"
> + bool "Qualcomm 28nm High-Speed PHY"
> depends on PHY && ARCH_SNAPDRAGON
> help
> Enable this to support the Qualcomm Synopsys DesignWare Core 28nm
> @@ -65,7 +65,7 @@ config PHY_QCOM_USB_HS_28NM
> IPs on MSM SOCs.
>
> config PHY_QCOM_USB_SS
> - tristate "Qualcomm USB Super-Speed PHY driver"
> + bool "Qualcomm USB Super-Speed PHY driver"
> depends on PHY && ARCH_SNAPDRAGON
> help
> Enable this to support the Super-Speed USB transceiver on various
> diff --git a/drivers/phy/renesas/Kconfig b/drivers/phy/renesas/Kconfig
> index affbee0500c..3358d454e59 100644
> --- a/drivers/phy/renesas/Kconfig
> +++ b/drivers/phy/renesas/Kconfig
> @@ -3,19 +3,19 @@
> # Phy drivers for Renesas platforms
>
> config PHY_R8A779F0_ETHERNET_SERDES
> - tristate "Renesas R-Car S4-8 Ethernet SERDES driver"
> + bool "Renesas R-Car S4-8 Ethernet SERDES driver"
> depends on RCAR_64 && PHY
> help
> Support for Ethernet SERDES found on Renesas R-Car S4-8 SoCs.
>
> config PHY_R8A78000_ETHERNET_PCS
> - tristate "Renesas R-Car X5H Ethernet PCS driver"
> + bool "Renesas R-Car X5H Ethernet PCS driver"
> depends on RCAR_64 && PHY
> help
> Support for Ethernet PCS found on Renesas R-Car X5H SoCs.
>
> config PHY_R8A78000_MP_PHY
> - tristate "Renesas R-Car X5H Multi-Protocol PHY driver"
> + bool "Renesas R-Car X5H Multi-Protocol PHY driver"
> depends on RCAR_64 && PHY
> help
> Support for Multi-Protocol PHY on Renesas R-Car X5H SoCs.
> diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig
> index 80128335d52..6f3d7ebe29e 100644
> --- a/drivers/phy/rockchip/Kconfig
> +++ b/drivers/phy/rockchip/Kconfig
> @@ -49,7 +49,7 @@ config PHY_ROCKCHIP_SNPS_PCIE3
> also be able splited into multiple combinations of lanes.
>
> config PHY_ROCKCHIP_USBDP
> - tristate "Rockchip USBDP COMBO PHY Driver"
> + bool "Rockchip USBDP COMBO PHY Driver"
> depends on ARCH_ROCKCHIP
> select PHY
> help
> diff --git a/drivers/phy/ti/Kconfig b/drivers/phy/ti/Kconfig
> index df750b26d66..fe96eb6806f 100644
> --- a/drivers/phy/ti/Kconfig
> +++ b/drivers/phy/ti/Kconfig
> @@ -1,5 +1,5 @@
> config PHY_J721E_WIZ
> - tristate "TI J721E WIZ (SERDES Wrapper) support"
> + bool "TI J721E WIZ (SERDES Wrapper) support"
> depends on ARCH_K3
> help
> This option enables support for WIZ module present in TI's J721E
>
> ---
> base-commit: e3e651c480c46b332f16a7555b97c6c6fd640a40
> change-id: 20260513-phy-kconfig-no-tristate-61bc2d324149
>
> Best regards,
> --
> David Lechner <dlechner@baylibre.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] phy: Kconfig: use bool instead of tristate
2026-05-14 5:27 ` Anshul Dalal
@ 2026-05-14 13:17 ` David Lechner
0 siblings, 0 replies; 6+ messages in thread
From: David Lechner @ 2026-05-14 13:17 UTC (permalink / raw)
To: Anshul Dalal, Tom Rini, Casey Connolly, Neil Armstrong,
Sumit Garg, Nobuhiro Iwamatsu, Marek Vasut, Simon Glass,
Philipp Tomsich, Kever Yang
Cc: Julien Stephan, u-boot, u-boot-qcom
On 5/14/26 12:27 AM, Anshul Dalal wrote:
> On Wed May 13, 2026 at 7:41 PM IST, David Lechner wrote:
>> Change all uses of tristate in the PHY Kconfigs to bool. U-Boot does
>> not support modules, so tristate does not make sense here.
>>
>> Signed-off-by: David Lechner <dlechner@baylibre.com>
>
> Thanks for the fix David, I see the same issue is repeated at other
> places outside of PHY:
>
> % find . -name Kconfig | xargs -I {} grep -HPn '^\ttristate' {} | wc -l
> 47
>
> Let me know if you would be interested in doing a treewide cleanup
> otherwise I can take this up.
>
I just did a few subsystems to start with to see what kind
of reaction it got. Feel free to pick this up. And I will
consider doing the rest later.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-05-14 13:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-13 14:11 [PATCH] phy: Kconfig: use bool instead of tristate David Lechner
2026-05-13 14:29 ` Tom Rini
2026-05-13 14:31 ` Quentin Schulz
2026-05-14 2:20 ` Macpaul Lin (林智斌)
2026-05-14 5:27 ` Anshul Dalal
2026-05-14 13:17 ` David Lechner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.