All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mario Limonciello <superm1@kernel.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
	linux-usb@vger.kernel.org
Cc: Yehezkel Bernat <YehezkelShB@gmail.com>,
	Michael Jamet <michael.jamet@intel.com>,
	Lukas Wunner <lukas@wunner.de>,
	Andreas Noever <andreas.noever@gmail.com>,
	Raju Rangoju <Raju.Rangoju@amd.com>,
	Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] thunderbolt: Use Linux Foundation IDs for XDomain discovery
Date: Tue, 12 Aug 2025 07:19:10 -0500	[thread overview]
Message-ID: <6bb0aa82-31ff-4514-b76c-d2e45d759974@kernel.org> (raw)
In-Reply-To: <20250812054710.2910816-1-mika.westerberg@linux.intel.com>



On 8/12/25 12:47 AM, Mika Westerberg wrote:
> There are other vendors now that have their own USB4 host router
> hardware so using the Intel donated IDs may confuse users. For this
> reason switch to use USB IDs provided by the Linux Foundation for
> XDomain discovery.
> 
> Link: https://lore.kernel.org/linux-usb/20250722175026.1994846-1-Raju.Rangoju@amd.com/
> Cc: Raju Rangoju <Raju.Rangoju@amd.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>> ---
>   drivers/thunderbolt/xdomain.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/thunderbolt/xdomain.c b/drivers/thunderbolt/xdomain.c
> index b0630e6d9472..fffa28cc491d 100644
> --- a/drivers/thunderbolt/xdomain.c
> +++ b/drivers/thunderbolt/xdomain.c
> @@ -2562,10 +2562,9 @@ int tb_xdomain_init(void)
>   	 * Rest of the properties are filled dynamically based on these
>   	 * when the P2P connection is made.
>   	 */
> -	tb_property_add_immediate(xdomain_property_dir, "vendorid",
> -				  PCI_VENDOR_ID_INTEL);
> -	tb_property_add_text(xdomain_property_dir, "vendorid", "Intel Corp.");
> -	tb_property_add_immediate(xdomain_property_dir, "deviceid", 0x1);
> +	tb_property_add_immediate(xdomain_property_dir, "vendorid", 0x1d6b);
> +	tb_property_add_text(xdomain_property_dir, "vendorid", "Linux");
> +	tb_property_add_immediate(xdomain_property_dir, "deviceid", 0x0004);
>   	tb_property_add_immediate(xdomain_property_dir, "devicerv", 0x80000100);
>   
>   	xdomain_property_block_gen = get_random_u32();


  parent reply	other threads:[~2025-08-12 12:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-12  5:47 [PATCH] thunderbolt: Use Linux Foundation IDs for XDomain discovery Mika Westerberg
2025-08-12  6:27 ` Greg KH
2025-08-12 12:19 ` Mario Limonciello [this message]
2025-08-13  8:09 ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6bb0aa82-31ff-4514-b76c-d2e45d759974@kernel.org \
    --to=superm1@kernel.org \
    --cc=Raju.Rangoju@amd.com \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=michael.jamet@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.