* [PATCH] thunderbolt: Use Linux Foundation IDs for XDomain discovery
@ 2025-08-12 5:47 Mika Westerberg
2025-08-12 6:27 ` Greg KH
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Mika Westerberg @ 2025-08-12 5:47 UTC (permalink / raw)
To: linux-usb
Cc: Yehezkel Bernat, Michael Jamet, Lukas Wunner, Andreas Noever,
Raju Rangoju, Mario Limonciello, Greg KH, Mika Westerberg
There are other vendors now that have their own USB4 host router
hardware so using the Intel donated IDs may confuse users. For this
reason switch to use USB IDs provided by the Linux Foundation for
XDomain discovery.
Link: https://lore.kernel.org/linux-usb/20250722175026.1994846-1-Raju.Rangoju@amd.com/
Cc: Raju Rangoju <Raju.Rangoju@amd.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/thunderbolt/xdomain.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/thunderbolt/xdomain.c b/drivers/thunderbolt/xdomain.c
index b0630e6d9472..fffa28cc491d 100644
--- a/drivers/thunderbolt/xdomain.c
+++ b/drivers/thunderbolt/xdomain.c
@@ -2562,10 +2562,9 @@ int tb_xdomain_init(void)
* Rest of the properties are filled dynamically based on these
* when the P2P connection is made.
*/
- tb_property_add_immediate(xdomain_property_dir, "vendorid",
- PCI_VENDOR_ID_INTEL);
- tb_property_add_text(xdomain_property_dir, "vendorid", "Intel Corp.");
- tb_property_add_immediate(xdomain_property_dir, "deviceid", 0x1);
+ tb_property_add_immediate(xdomain_property_dir, "vendorid", 0x1d6b);
+ tb_property_add_text(xdomain_property_dir, "vendorid", "Linux");
+ tb_property_add_immediate(xdomain_property_dir, "deviceid", 0x0004);
tb_property_add_immediate(xdomain_property_dir, "devicerv", 0x80000100);
xdomain_property_block_gen = get_random_u32();
--
2.50.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] thunderbolt: Use Linux Foundation IDs for XDomain discovery
2025-08-12 5:47 [PATCH] thunderbolt: Use Linux Foundation IDs for XDomain discovery Mika Westerberg
@ 2025-08-12 6:27 ` Greg KH
2025-08-12 12:19 ` Mario Limonciello
2025-08-13 8:09 ` Mika Westerberg
2 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2025-08-12 6:27 UTC (permalink / raw)
To: Mika Westerberg
Cc: linux-usb, Yehezkel Bernat, Michael Jamet, Lukas Wunner,
Andreas Noever, Raju Rangoju, Mario Limonciello
On Tue, Aug 12, 2025 at 07:47:09AM +0200, Mika Westerberg wrote:
> There are other vendors now that have their own USB4 host router
> hardware so using the Intel donated IDs may confuse users. For this
> reason switch to use USB IDs provided by the Linux Foundation for
> XDomain discovery.
>
> Link: https://lore.kernel.org/linux-usb/20250722175026.1994846-1-Raju.Rangoju@amd.com/
> Cc: Raju Rangoju <Raju.Rangoju@amd.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> drivers/thunderbolt/xdomain.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] thunderbolt: Use Linux Foundation IDs for XDomain discovery
2025-08-12 5:47 [PATCH] thunderbolt: Use Linux Foundation IDs for XDomain discovery Mika Westerberg
2025-08-12 6:27 ` Greg KH
@ 2025-08-12 12:19 ` Mario Limonciello
2025-08-13 8:09 ` Mika Westerberg
2 siblings, 0 replies; 4+ messages in thread
From: Mario Limonciello @ 2025-08-12 12:19 UTC (permalink / raw)
To: Mika Westerberg, linux-usb
Cc: Yehezkel Bernat, Michael Jamet, Lukas Wunner, Andreas Noever,
Raju Rangoju, Greg KH
On 8/12/25 12:47 AM, Mika Westerberg wrote:
> There are other vendors now that have their own USB4 host router
> hardware so using the Intel donated IDs may confuse users. For this
> reason switch to use USB IDs provided by the Linux Foundation for
> XDomain discovery.
>
> Link: https://lore.kernel.org/linux-usb/20250722175026.1994846-1-Raju.Rangoju@amd.com/
> Cc: Raju Rangoju <Raju.Rangoju@amd.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>> ---
> drivers/thunderbolt/xdomain.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/thunderbolt/xdomain.c b/drivers/thunderbolt/xdomain.c
> index b0630e6d9472..fffa28cc491d 100644
> --- a/drivers/thunderbolt/xdomain.c
> +++ b/drivers/thunderbolt/xdomain.c
> @@ -2562,10 +2562,9 @@ int tb_xdomain_init(void)
> * Rest of the properties are filled dynamically based on these
> * when the P2P connection is made.
> */
> - tb_property_add_immediate(xdomain_property_dir, "vendorid",
> - PCI_VENDOR_ID_INTEL);
> - tb_property_add_text(xdomain_property_dir, "vendorid", "Intel Corp.");
> - tb_property_add_immediate(xdomain_property_dir, "deviceid", 0x1);
> + tb_property_add_immediate(xdomain_property_dir, "vendorid", 0x1d6b);
> + tb_property_add_text(xdomain_property_dir, "vendorid", "Linux");
> + tb_property_add_immediate(xdomain_property_dir, "deviceid", 0x0004);
> tb_property_add_immediate(xdomain_property_dir, "devicerv", 0x80000100);
>
> xdomain_property_block_gen = get_random_u32();
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] thunderbolt: Use Linux Foundation IDs for XDomain discovery
2025-08-12 5:47 [PATCH] thunderbolt: Use Linux Foundation IDs for XDomain discovery Mika Westerberg
2025-08-12 6:27 ` Greg KH
2025-08-12 12:19 ` Mario Limonciello
@ 2025-08-13 8:09 ` Mika Westerberg
2 siblings, 0 replies; 4+ messages in thread
From: Mika Westerberg @ 2025-08-13 8:09 UTC (permalink / raw)
To: linux-usb
Cc: Yehezkel Bernat, Michael Jamet, Lukas Wunner, Andreas Noever,
Raju Rangoju, Mario Limonciello, Greg KH
On Tue, Aug 12, 2025 at 07:47:09AM +0200, Mika Westerberg wrote:
> There are other vendors now that have their own USB4 host router
> hardware so using the Intel donated IDs may confuse users. For this
> reason switch to use USB IDs provided by the Linux Foundation for
> XDomain discovery.
>
> Link: https://lore.kernel.org/linux-usb/20250722175026.1994846-1-Raju.Rangoju@amd.com/
> Cc: Raju Rangoju <Raju.Rangoju@amd.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Applied to thunderbolt.git/next.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-08-13 8:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-12 5:47 [PATCH] thunderbolt: Use Linux Foundation IDs for XDomain discovery Mika Westerberg
2025-08-12 6:27 ` Greg KH
2025-08-12 12:19 ` Mario Limonciello
2025-08-13 8:09 ` Mika Westerberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.