Re: [PATCH] wifi: mac80211: Ensure links are cleaned up when driver fails.

[Ben Greear <greearb@candelatech.com>]

On 3/25/24 10:30, Johannes Berg wrote:
> On Mon, 2024-03-25 at 09:10 -0700, Ben Greear wrote:
>> On 11/10/23 16:10, greearb@candelatech.com wrote:
>>> From: Ben Greear <greearb@candelatech.com>
>>>
>>> On cleanup paths, links need to be deleted even if the driver fails
>>> to do so.  Add a flag to cause driver errors to be ignored in
>>> appropriate cases.
>>>
>>> This appears to fix some kernel warnings and crashes.
>>
>> Hello Johannes,
>>
>> Any interest in this patch?
> 
> Well, you threw a bunch of unrelated stuff into it, and didn't even
> really explain why it's needed ... so not really?

It is needed because if FW crashes while you are trying to remove links, then link
removal would fail, which causes mac80211 to not clean up its links.  In case where you
are trying to delete the station, this causes un-cleaned links which caused crashes
back when I was creating this patch.  My patch allows always cleaning up the links
regardless of driver errors in the teardown paths.

Always possible some intervening changes made this less of a problem, especially since
MLO is disabled for be200 in upstream code anyway now.

I can remove the extra logging if you are otherwise OK with the approach
but don't want the logs.

Thanks,
Ben

> 
> johannes
> 

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com