From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: mac80211: Ensure links are cleaned up when driver fails.
Date: Mon, 25 Mar 2024 18:43:32 +0100 [thread overview]
Message-ID: <973efc2cb87812f512fd33f354a91da17e3d8564.camel@sipsolutions.net> (raw)
In-Reply-To: <6bed94b3-4674-7fe9-ee82-bac7f9c7ffd6@candelatech.com>
On Mon, 2024-03-25 at 10:40 -0700, Ben Greear wrote:
> It is needed because if FW crashes while you are trying to remove links, then link
> removal would fail, which causes mac80211 to not clean up its links.
OK. It should get back to some legal state after recovery though?
> In case where you
> are trying to delete the station, this causes un-cleaned links which caused crashes
> back when I was creating this patch. My patch allows always cleaning up the links
> regardless of driver errors in the teardown paths.
Seems potentially more like driver errors. Or perhaps we should just
ignore driver errors entirely?
> Always possible some intervening changes made this less of a problem, especially since
> MLO is disabled for be200 in upstream code anyway now.
Well that's just temporary, but we've also done a lot of work on FW
error recovery, though likely unrelated to this particular issue.
> I can remove the extra logging if you are otherwise OK with the approach
> but don't want the logs.
Well it'd be nice to actually see what crashed, and maybe it should
really be driver fixes? I don't really understand why mac80211 would
crash on failure of link removal.
johannes
next prev parent reply other threads:[~2024-03-25 17:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 0:10 [PATCH] wifi: mac80211: Ensure links are cleaned up when driver fails greearb
2024-03-25 16:10 ` Ben Greear
2024-03-25 17:30 ` Johannes Berg
2024-03-25 17:40 ` Ben Greear
2024-03-25 17:43 ` Johannes Berg [this message]
2024-03-25 17:53 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=973efc2cb87812f512fd33f354a91da17e3d8564.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.