* [Intel-gfx] [PATCH 1/2] drm/i915: Double check bumping after the spinlock
@ 2020-02-20 12:36 Chris Wilson
2020-02-20 12:36 ` [Intel-gfx] [PATCH 2/2] drm/i915: Protect i915_request_await_start from early waits Chris Wilson
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Chris Wilson @ 2020-02-20 12:36 UTC (permalink / raw)
To: intel-gfx; +Cc: matthew.auld
In preparation for making GEM execbuf parallel, we need to be prepared
to handle very early declaration of dependencies -- even before our
signaler has itself been submitted.
References: a79ca656b648 ("drm/i915: Push the wakeref->count deferral to the backend")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i915_scheduler.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_scheduler.c b/drivers/gpu/drm/i915/i915_scheduler.c
index 59f70b674665..be770f2419b1 100644
--- a/drivers/gpu/drm/i915/i915_scheduler.c
+++ b/drivers/gpu/drm/i915/i915_scheduler.c
@@ -363,6 +363,9 @@ static void __bump_priority(struct i915_sched_node *node, unsigned int bump)
{
struct i915_sched_attr attr = node->attr;
+ if (attr.priority & bump)
+ return;
+
attr.priority |= bump;
__i915_schedule(node, &attr);
}
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Intel-gfx] [PATCH 2/2] drm/i915: Protect i915_request_await_start from early waits 2020-02-20 12:36 [Intel-gfx] [PATCH 1/2] drm/i915: Double check bumping after the spinlock Chris Wilson @ 2020-02-20 12:36 ` Chris Wilson 2020-02-20 13:02 ` [Intel-gfx] [PATCH 1/2] drm/i915: Double check bumping after the spinlock Matthew Auld ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: Chris Wilson @ 2020-02-20 12:36 UTC (permalink / raw) To: intel-gfx; +Cc: matthew.auld We need to be extremely careful inside i915_request_await_start() as it needs to walk the list of requests in the foreign timeline with very little protection. As we hold our own timeline mutex, we can not nest inside the signaler's timeline mutex, so all that remains is our RCU protection. However, to be safe we need to tell the compiler that we may be traversing the list only under RCU protection, and furthermore we need to start declaring requests as elements of the timeline from their construction. Fixes: 9ddc8ec027a3 ("drm/i915: Eliminate the trylock for awaiting an earlier request") Fixes: 6a79d848403d ("drm/i915: Lock signaler timeline while navigating") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/i915_request.c | 43 ++++++++++++++++++++--------- 1 file changed, 30 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index d53af93b919b..28f135ebeaa0 100644 --- a/drivers/gpu/drm/i915/i915_request.c +++ b/drivers/gpu/drm/i915/i915_request.c @@ -290,7 +290,7 @@ bool i915_request_retire(struct i915_request *rq) spin_unlock_irq(&rq->lock); remove_from_client(rq); - list_del(&rq->link); + list_del_rcu(&rq->link); intel_context_exit(rq->context); intel_context_unpin(rq->context); @@ -736,6 +736,8 @@ __i915_request_create(struct intel_context *ce, gfp_t gfp) rq->infix = rq->ring->emit; /* end of header; start of user payload */ intel_context_mark_active(ce); + list_add_tail_rcu(&rq->link, &tl->requests); + return rq; err_unwind: @@ -792,13 +794,21 @@ i915_request_await_start(struct i915_request *rq, struct i915_request *signal) GEM_BUG_ON(i915_request_timeline(rq) == rcu_access_pointer(signal->timeline)); + if (i915_request_started(signal)) + return 0; + fence = NULL; rcu_read_lock(); spin_lock_irq(&signal->lock); - if (!i915_request_started(signal) && - !list_is_first(&signal->link, - &rcu_dereference(signal->timeline)->requests)) { - struct i915_request *prev = list_prev_entry(signal, link); + do { + struct list_head *pos = READ_ONCE(signal->link.prev); + struct i915_request *prev; + + if (i915_request_started(signal)) + break; + + if (pos == &rcu_dereference(signal->timeline)->requests) + break; /* * Peek at the request before us in the timeline. That @@ -806,13 +816,22 @@ i915_request_await_start(struct i915_request *rq, struct i915_request *signal) * after acquiring a reference to it, confirm that it is * still part of the signaler's timeline. */ - if (i915_request_get_rcu(prev)) { - if (list_next_entry(prev, link) == signal) - fence = &prev->fence; - else - i915_request_put(prev); + prev = list_entry(pos, typeof(*prev), link); + if (!i915_request_get_rcu(prev)) + break; + + if (i915_request_completed(prev)) { + i915_request_put(prev); + break; } - } + + if (READ_ONCE(prev->link.next) != &signal->link) { + i915_request_put(prev); + break; + } + + fence = &prev->fence; + } while (0); spin_unlock_irq(&signal->lock); rcu_read_unlock(); if (!fence) @@ -1253,8 +1272,6 @@ __i915_request_add_to_timeline(struct i915_request *rq) 0); } - list_add_tail(&rq->link, &timeline->requests); - /* * Make sure that no request gazumped us - if it was allocated after * our i915_request_alloc() and called __i915_request_add() before -- 2.25.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Double check bumping after the spinlock 2020-02-20 12:36 [Intel-gfx] [PATCH 1/2] drm/i915: Double check bumping after the spinlock Chris Wilson 2020-02-20 12:36 ` [Intel-gfx] [PATCH 2/2] drm/i915: Protect i915_request_await_start from early waits Chris Wilson @ 2020-02-20 13:02 ` Matthew Auld 2020-02-20 16:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] " Patchwork ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: Matthew Auld @ 2020-02-20 13:02 UTC (permalink / raw) To: Chris Wilson, intel-gfx On 20/02/2020 12:36, Chris Wilson wrote: > In preparation for making GEM execbuf parallel, we need to be prepared > to handle very early declaration of dependencies -- even before our > signaler has itself been submitted. > > References: a79ca656b648 ("drm/i915: Push the wakeref->count deferral to the backend") > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Matthew Auld <matthew.auld@intel.com> _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Double check bumping after the spinlock 2020-02-20 12:36 [Intel-gfx] [PATCH 1/2] drm/i915: Double check bumping after the spinlock Chris Wilson 2020-02-20 12:36 ` [Intel-gfx] [PATCH 2/2] drm/i915: Protect i915_request_await_start from early waits Chris Wilson 2020-02-20 13:02 ` [Intel-gfx] [PATCH 1/2] drm/i915: Double check bumping after the spinlock Matthew Auld @ 2020-02-20 16:51 ` Patchwork 2020-02-20 17:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-02-22 22:43 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 4 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2020-02-20 16:51 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: series starting with [1/2] drm/i915: Double check bumping after the spinlock URL : https://patchwork.freedesktop.org/series/73707/ State : warning == Summary == $ dim checkpatch origin/drm-tip 00c160893898 drm/i915: Double check bumping after the spinlock -:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #10: References: a79ca656b648 ("drm/i915: Push the wakeref->count deferral to the backend") -:10: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit a79ca656b648 ("drm/i915: Push the wakeref->count deferral to the backend")' #10: References: a79ca656b648 ("drm/i915: Push the wakeref->count deferral to the backend") total: 1 errors, 1 warnings, 0 checks, 9 lines checked e5bc0f843da3 drm/i915: Protect i915_request_await_start from early waits _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Double check bumping after the spinlock 2020-02-20 12:36 [Intel-gfx] [PATCH 1/2] drm/i915: Double check bumping after the spinlock Chris Wilson ` (2 preceding siblings ...) 2020-02-20 16:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] " Patchwork @ 2020-02-20 17:18 ` Patchwork 2020-02-22 22:43 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 4 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2020-02-20 17:18 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: series starting with [1/2] drm/i915: Double check bumping after the spinlock URL : https://patchwork.freedesktop.org/series/73707/ State : success == Summary == CI Bug Log - changes from CI_DRM_7973 -> Patchwork_16645 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/index.html New tests --------- New tests have been introduced between CI_DRM_7973 and Patchwork_16645: ### New IGT tests (4) ### * igt@i915_pm_backlight@basic-brightness: - Statuses : 1 dmesg-warn(s) 13 pass(s) 22 skip(s) - Exec time: [0.0, 0.22] s * igt@i915_pm_rpm@basic-pci-d3-state: - Statuses : 1 dmesg-warn(s) 25 pass(s) 10 skip(s) - Exec time: [0.0, 6.74] s * igt@i915_pm_rpm@basic-rte: - Statuses : 1 dmesg-warn(s) 25 pass(s) 10 skip(s) - Exec time: [0.45, 17.72] s * igt@i915_pm_rps@basic-api: - Statuses : 31 pass(s) 5 skip(s) - Exec time: [0.0, 0.02] s Known issues ------------ Here are the changes found in Patchwork_16645 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live_gtt: - fi-hsw-4770r: [PASS][1] -> [TIMEOUT][2] ([fdo#112271]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/fi-hsw-4770r/igt@i915_selftest@live_gtt.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/fi-hsw-4770r/igt@i915_selftest@live_gtt.html * igt@prime_self_import@basic-llseek-size: - fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([CI#94] / [i915#402]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/fi-tgl-y/igt@prime_self_import@basic-llseek-size.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/fi-tgl-y/igt@prime_self_import@basic-llseek-size.html #### Possible fixes #### * igt@gem_exec_parallel@contexts: - fi-byt-n2820: [FAIL][5] ([i915#694]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/fi-byt-n2820/igt@gem_exec_parallel@contexts.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/fi-byt-n2820/igt@gem_exec_parallel@contexts.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-icl-u2: [FAIL][7] ([i915#217]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html * igt@prime_self_import@basic-llseek-bad: - fi-tgl-y: [DMESG-WARN][9] ([CI#94] / [i915#402]) -> [PASS][10] +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/fi-tgl-y/igt@prime_self_import@basic-llseek-bad.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/fi-tgl-y/igt@prime_self_import@basic-llseek-bad.html #### Warnings #### * igt@amdgpu/amd_prime@amd-to-i915: - fi-icl-u3: [SKIP][11] ([fdo#109315]) -> [SKIP][12] ([fdo#109315] / [i915#585]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/fi-icl-u3/igt@amdgpu/amd_prime@amd-to-i915.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/fi-icl-u3/igt@amdgpu/amd_prime@amd-to-i915.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [FAIL][13] ([fdo#111407]) -> [FAIL][14] ([fdo#111096] / [i915#323]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096 [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407 [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271 [i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217 [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#585]: https://gitlab.freedesktop.org/drm/intel/issues/585 [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694 Participating hosts (49 -> 39) ------------------------------ Additional (4): fi-kbl-soraka fi-skl-lmem fi-ivb-3770 fi-pnv-d510 Missing (14): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-skl-6770hq fi-hsw-peppy fi-glk-dsi fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-cfl-8109u fi-bsw-kefka fi-bdw-samus fi-bsw-nick fi-skl-6600u Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7973 -> Patchwork_16645 CI-20190529: 20190529 CI_DRM_7973: 07350317e4b2be54b1de7f1e73f77875df5e43f3 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5453: cae9a5881ed2c5be2c2518a255740b612a927f9a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16645: e5bc0f843da36cdc8a5b8fcdb5c692f14347dcb3 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == e5bc0f843da3 drm/i915: Protect i915_request_await_start from early waits 00c160893898 drm/i915: Double check bumping after the spinlock == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Double check bumping after the spinlock 2020-02-20 12:36 [Intel-gfx] [PATCH 1/2] drm/i915: Double check bumping after the spinlock Chris Wilson ` (3 preceding siblings ...) 2020-02-20 17:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2020-02-22 22:43 ` Patchwork 4 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2020-02-22 22:43 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: series starting with [1/2] drm/i915: Double check bumping after the spinlock URL : https://patchwork.freedesktop.org/series/73707/ State : success == Summary == CI Bug Log - changes from CI_DRM_7973_full -> Patchwork_16645_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_16645_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_isolation@rcs0-s3: - shard-kbl: [PASS][1] -> [DMESG-WARN][2] ([i915#180]) +7 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-kbl6/igt@gem_ctx_isolation@rcs0-s3.html * igt@gem_ctx_shared@exec-single-timeline-bsd1: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276]) +9 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-iclb4/igt@gem_ctx_shared@exec-single-timeline-bsd1.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-iclb8/igt@gem_ctx_shared@exec-single-timeline-bsd1.html * igt@gem_eio@kms: - shard-skl: [PASS][5] -> [INCOMPLETE][6] ([i915#198]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-skl8/igt@gem_eio@kms.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-skl3/igt@gem_eio@kms.html * igt@gem_exec_schedule@pi-common-bsd: - shard-iclb: [PASS][7] -> [SKIP][8] ([i915#677]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-iclb3/igt@gem_exec_schedule@pi-common-bsd.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-iclb2/igt@gem_exec_schedule@pi-common-bsd.html * igt@gem_exec_schedule@preempt-self-bsd: - shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) +2 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-iclb3/igt@gem_exec_schedule@preempt-self-bsd.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-iclb2/igt@gem_exec_schedule@preempt-self-bsd.html * igt@gen7_exec_parse@basic-offset: - shard-hsw: [PASS][11] -> [FAIL][12] ([i915#694]) +1 similar issue [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-hsw6/igt@gen7_exec_parse@basic-offset.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-hsw1/igt@gen7_exec_parse@basic-offset.html * igt@i915_pm_rps@waitboost: - shard-iclb: [PASS][13] -> [FAIL][14] ([i915#413]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-iclb7/igt@i915_pm_rps@waitboost.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-iclb7/igt@i915_pm_rps@waitboost.html * igt@i915_selftest@live_gtt: - shard-tglb: [PASS][15] -> [TIMEOUT][16] ([fdo#112126] / [fdo#112271]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-tglb2/igt@i915_selftest@live_gtt.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-tglb1/igt@i915_selftest@live_gtt.html * igt@kms_big_fb@x-tiled-64bpp-rotate-180: - shard-snb: [PASS][17] -> [SKIP][18] ([fdo#109271]) +1 similar issue [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-snb6/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-snb1/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html * igt@kms_cursor_crc@pipe-b-cursor-suspend: - shard-apl: [PASS][19] -> [DMESG-WARN][20] ([i915#180]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-apl4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-apl2/igt@kms_cursor_crc@pipe-b-cursor-suspend.html * igt@kms_flip@flip-vs-expired-vblank: - shard-skl: [PASS][21] -> [FAIL][22] ([i915#79]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-skl5/igt@kms_flip@flip-vs-expired-vblank.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-apl: [PASS][23] -> [FAIL][24] ([i915#79]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-apl3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-apl4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes: - shard-skl: [PASS][25] -> [INCOMPLETE][26] ([i915#69]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-skl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-skl9/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html * igt@kms_plane_lowres@pipe-a-tiling-x: - shard-glk: [PASS][27] -> [FAIL][28] ([i915#899]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-glk7/igt@kms_plane_lowres@pipe-a-tiling-x.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-glk2/igt@kms_plane_lowres@pipe-a-tiling-x.html * igt@kms_psr@psr2_cursor_plane_move: - shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +2 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-iclb4/igt@kms_psr@psr2_cursor_plane_move.html * igt@perf_pmu@busy-accuracy-2-vcs1: - shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#112080]) +9 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-iclb4/igt@perf_pmu@busy-accuracy-2-vcs1.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-iclb8/igt@perf_pmu@busy-accuracy-2-vcs1.html * igt@perf_pmu@cpu-hotplug: - shard-hsw: [PASS][33] -> [INCOMPLETE][34] ([i915#1176] / [i915#61]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-hsw1/igt@perf_pmu@cpu-hotplug.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-hsw5/igt@perf_pmu@cpu-hotplug.html #### Possible fixes #### * igt@gem_busy@busy-vcs1: - shard-iclb: [SKIP][35] ([fdo#112080]) -> [PASS][36] +5 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-iclb6/igt@gem_busy@busy-vcs1.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-iclb1/igt@gem_busy@busy-vcs1.html * {igt@gem_ctx_persistence@close-replace-race}: - shard-kbl: [INCOMPLETE][37] ([fdo#103665]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-kbl3/igt@gem_ctx_persistence@close-replace-race.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-kbl3/igt@gem_ctx_persistence@close-replace-race.html * igt@gem_exec_balancer@hang: - shard-iclb: [FAIL][39] ([i915#1277]) -> [PASS][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-iclb4/igt@gem_exec_balancer@hang.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-iclb4/igt@gem_exec_balancer@hang.html - shard-tglb: [FAIL][41] ([i915#1277]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-tglb8/igt@gem_exec_balancer@hang.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-tglb7/igt@gem_exec_balancer@hang.html * {igt@gem_exec_schedule@implicit-both-bsd2}: - shard-iclb: [SKIP][43] ([fdo#109276] / [i915#677]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-iclb5/igt@gem_exec_schedule@implicit-both-bsd2.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-iclb1/igt@gem_exec_schedule@implicit-both-bsd2.html * igt@gem_exec_schedule@pi-shared-iova-bsd: - shard-iclb: [SKIP][45] ([i915#677]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-iclb1/igt@gem_exec_schedule@pi-shared-iova-bsd.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-iclb7/igt@gem_exec_schedule@pi-shared-iova-bsd.html * igt@gem_exec_schedule@preempt-contexts-bsd2: - shard-iclb: [SKIP][47] ([fdo#109276]) -> [PASS][48] +12 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-iclb6/igt@gem_exec_schedule@preempt-contexts-bsd2.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-iclb1/igt@gem_exec_schedule@preempt-contexts-bsd2.html * igt@gem_exec_schedule@preemptive-hang-bsd: - shard-iclb: [SKIP][49] ([fdo#112146]) -> [PASS][50] +6 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-iclb7/igt@gem_exec_schedule@preemptive-hang-bsd.html * igt@gem_ppgtt@flink-and-close-vma-leak: - shard-apl: [FAIL][51] ([i915#644]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-apl7/igt@gem_ppgtt@flink-and-close-vma-leak.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-apl6/igt@gem_ppgtt@flink-and-close-vma-leak.html - shard-kbl: [FAIL][53] ([i915#644]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-kbl6/igt@gem_ppgtt@flink-and-close-vma-leak.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-kbl3/igt@gem_ppgtt@flink-and-close-vma-leak.html * igt@i915_pm_rpm@system-suspend-execbuf: - shard-glk: [FAIL][55] ([fdo#103375]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-glk6/igt@i915_pm_rpm@system-suspend-execbuf.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-glk1/igt@i915_pm_rpm@system-suspend-execbuf.html * igt@kms_color@pipe-a-gamma: - shard-skl: [FAIL][57] ([i915#71]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-skl1/igt@kms_color@pipe-a-gamma.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-skl7/igt@kms_color@pipe-a-gamma.html * igt@kms_flip@2x-flip-vs-suspend: - shard-hsw: [INCOMPLETE][59] ([i915#61]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-hsw5/igt@kms_flip@2x-flip-vs-suspend.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-hsw6/igt@kms_flip@2x-flip-vs-suspend.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: [FAIL][61] ([i915#79]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-skl: [INCOMPLETE][63] ([i915#221]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-skl2/igt@kms_flip@flip-vs-suspend-interruptible.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-skl3/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-apl: [DMESG-WARN][65] ([i915#180]) -> [PASS][66] +7 similar issues [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-apl6/igt@kms_frontbuffer_tracking@fbc-suspend.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-apl4/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_frontbuffer_tracking@fbcpsr-slowdraw: - shard-tglb: [SKIP][67] ([i915#668]) -> [PASS][68] +1 similar issue [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-slowdraw.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-slowdraw.html * {igt@kms_hdr@bpc-switch-suspend}: - shard-skl: [FAIL][69] ([i915#1188]) -> [PASS][70] +1 similar issue [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-skl10/igt@kms_hdr@bpc-switch-suspend.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-skl1/igt@kms_hdr@bpc-switch-suspend.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes: - shard-kbl: [DMESG-WARN][71] ([i915#180]) -> [PASS][72] [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-kbl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: - shard-skl: [FAIL][73] ([fdo#108145]) -> [PASS][74] [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [FAIL][75] ([fdo#108145] / [i915#265]) -> [PASS][76] [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_psr@psr2_primary_page_flip: - shard-iclb: [SKIP][77] ([fdo#109441]) -> [PASS][78] +2 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-iclb1/igt@kms_psr@psr2_primary_page_flip.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html * igt@perf_pmu@busy-idle-check-all-vcs0: - shard-glk: [FAIL][79] -> [PASS][80] +7 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-glk6/igt@perf_pmu@busy-idle-check-all-vcs0.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-glk1/igt@perf_pmu@busy-idle-check-all-vcs0.html * igt@perf_pmu@cpu-hotplug: - shard-glk: [TIMEOUT][81] ([fdo#111561] / [fdo#112271]) -> [PASS][82] [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-glk6/igt@perf_pmu@cpu-hotplug.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-glk1/igt@perf_pmu@cpu-hotplug.html #### Warnings #### * igt@gem_exec_reuse@baggage: - shard-skl: [TIMEOUT][83] ([fdo#112271]) -> [TIMEOUT][84] ([fdo#112271] / [i915#1084]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-skl2/igt@gem_exec_reuse@baggage.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-skl6/igt@gem_exec_reuse@baggage.html * igt@gem_tiled_blits@interruptible: - shard-hsw: [FAIL][85] ([i915#694]) -> [FAIL][86] ([i915#818]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-hsw6/igt@gem_tiled_blits@interruptible.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-hsw1/igt@gem_tiled_blits@interruptible.html * igt@i915_pm_rpm@pm-caching: - shard-snb: [INCOMPLETE][87] ([i915#82]) -> [SKIP][88] ([fdo#109271]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-snb5/igt@i915_pm_rpm@pm-caching.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-snb5/igt@i915_pm_rpm@pm-caching.html * igt@kms_content_protection@legacy: - shard-kbl: [TIMEOUT][89] ([fdo#112271]) -> [TIMEOUT][90] ([fdo#112271] / [i915#727]) [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-kbl2/igt@kms_content_protection@legacy.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-kbl7/igt@kms_content_protection@legacy.html * igt@runner@aborted: - shard-hsw: [FAIL][91] ([fdo#111012]) -> [FAIL][92] ([i915#1176]) [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7973/shard-hsw5/igt@runner@aborted.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/shard-hsw5/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#111012]: https://bugs.freedesktop.org/show_bug.cgi?id=111012 [fdo#111561]: https://bugs.freedesktop.org/show_bug.cgi?id=111561 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112126]: https://bugs.freedesktop.org/show_bug.cgi?id=112126 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271 [i915#1084]: https://gitlab.freedesktop.org/drm/intel/issues/1084 [i915#1176]: https://gitlab.freedesktop.org/drm/intel/issues/1176 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#1277]: https://gitlab.freedesktop.org/drm/intel/issues/1277 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198 [i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413 [i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61 [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644 [i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668 [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677 [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69 [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694 [i915#71]: https://gitlab.freedesktop.org/drm/intel/issues/71 [i915#727]: https://gitlab.freedesktop.org/drm/intel/issues/727 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#818]: https://gitlab.freedesktop.org/drm/intel/issues/818 [i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82 [i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7973 -> Patchwork_16645 CI-20190529: 20190529 CI_DRM_7973: 07350317e4b2be54b1de7f1e73f77875df5e43f3 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5453: cae9a5881ed2c5be2c2518a255740b612a927f9a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16645: e5bc0f843da36cdc8a5b8fcdb5c692f14347dcb3 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16645/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-22 22:43 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-02-20 12:36 [Intel-gfx] [PATCH 1/2] drm/i915: Double check bumping after the spinlock Chris Wilson 2020-02-20 12:36 ` [Intel-gfx] [PATCH 2/2] drm/i915: Protect i915_request_await_start from early waits Chris Wilson 2020-02-20 13:02 ` [Intel-gfx] [PATCH 1/2] drm/i915: Double check bumping after the spinlock Matthew Auld 2020-02-20 16:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] " Patchwork 2020-02-20 17:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-02-22 22:43 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.