All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	mturquette@baylibre.com
Cc: matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
	wenst@chromium.org, johnson.wang@mediatek.com,
	miles.chen@mediatek.com, chun-jie.chen@mediatek.com,
	daniel@makrotopia.org, fparent@baylibre.com, msp@baylibre.com,
	nfraprado@collabora.com, rex-bc.chen@mediatek.com,
	zhaojh329@gmail.com, sam.shih@mediatek.com,
	edward-jw.yang@mediatek.com, yangyingliang@huawei.com,
	granquet@baylibre.com, pablo.sun@mediatek.com,
	sean.wang@mediatek.com, chen.zhong@mediatek.com,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v6 00/54] MediaTek clocks: full module build and cleanups
Date: Mon, 13 Mar 2023 16:22:52 -0700	[thread overview]
Message-ID: <6c52bcda08b62593c541d52e269d3982.sboyd@kernel.org> (raw)
In-Reply-To: <20230306140543.1813621-1-angelogioacchino.delregno@collabora.com>

Quoting AngeloGioacchino Del Regno (2023-03-06 06:04:49)
> 
> This huge series adds more cleanups on top, reducing size and adding more
> commonization for clock drivers probe/remove, which also includes a new
> common probe mechanism for multimedia clock drivers that are usually
> probed by mtk-mmsys instead of a dt clock node: thanks to this, it was
> finally possible to convert almost all clock drivers to the common probe
> mechanism, which *finally again* makes us able to build all these drivers
> as modules!
> 
> Since this looked like being *the* way forward, I went on converting some
> more drivers away from OF_CLK_DECLARE_DRIVER to full platform_driver(s),
> allowing for more (actually, almost all!) drivers to be built as modules.
> 
> While at it, I also added some more consistency in macros usage by
> removing all of the duplicated full macro declaration for MediaTek gate
> clocks and replacing all of those with using the GATE_MTK macro instead,
> producing a nice reduction in amount of lines per file but, more
> importantly, improving readability and eventual future batch changes.
> 
> This amount of commonization will also, in my opinion, greatly improve
> the review process for new clock drivers, as they will be mostly just a
> list of clocks and won't contain much new code, as it's all going to be
> handled in the common places, which also reduces chances to see new clock
> driver related bugs emerging on one SoC or the other.
> 
> Since I don't own devices with all of the supported MediaTek SoCs, I
> could not test some of the conversions on real hardware... but I am
> confident that this will work as the drivers are *very* similar on a
> per-generation basis.
> 
> This series was build-tested for all (both module and built-in build)
> and was manually tested on MT6795, MT8173, MT8192, MT8195.
> 

Applied the whole series to clk-next.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	mturquette@baylibre.com
Cc: matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
	wenst@chromium.org, johnson.wang@mediatek.com,
	miles.chen@mediatek.com, chun-jie.chen@mediatek.com,
	daniel@makrotopia.org, fparent@baylibre.com, msp@baylibre.com,
	nfraprado@collabora.com, rex-bc.chen@mediatek.com,
	zhaojh329@gmail.com, sam.shih@mediatek.com,
	edward-jw.yang@mediatek.com, yangyingliang@huawei.com,
	granquet@baylibre.com, pablo.sun@mediatek.com,
	sean.wang@mediatek.com, chen.zhong@mediatek.com,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v6 00/54] MediaTek clocks: full module build and cleanups
Date: Mon, 13 Mar 2023 16:22:52 -0700	[thread overview]
Message-ID: <6c52bcda08b62593c541d52e269d3982.sboyd@kernel.org> (raw)
In-Reply-To: <20230306140543.1813621-1-angelogioacchino.delregno@collabora.com>

Quoting AngeloGioacchino Del Regno (2023-03-06 06:04:49)
> 
> This huge series adds more cleanups on top, reducing size and adding more
> commonization for clock drivers probe/remove, which also includes a new
> common probe mechanism for multimedia clock drivers that are usually
> probed by mtk-mmsys instead of a dt clock node: thanks to this, it was
> finally possible to convert almost all clock drivers to the common probe
> mechanism, which *finally again* makes us able to build all these drivers
> as modules!
> 
> Since this looked like being *the* way forward, I went on converting some
> more drivers away from OF_CLK_DECLARE_DRIVER to full platform_driver(s),
> allowing for more (actually, almost all!) drivers to be built as modules.
> 
> While at it, I also added some more consistency in macros usage by
> removing all of the duplicated full macro declaration for MediaTek gate
> clocks and replacing all of those with using the GATE_MTK macro instead,
> producing a nice reduction in amount of lines per file but, more
> importantly, improving readability and eventual future batch changes.
> 
> This amount of commonization will also, in my opinion, greatly improve
> the review process for new clock drivers, as they will be mostly just a
> list of clocks and won't contain much new code, as it's all going to be
> handled in the common places, which also reduces chances to see new clock
> driver related bugs emerging on one SoC or the other.
> 
> Since I don't own devices with all of the supported MediaTek SoCs, I
> could not test some of the conversions on real hardware... but I am
> confident that this will work as the drivers are *very* similar on a
> per-generation basis.
> 
> This series was build-tested for all (both module and built-in build)
> and was manually tested on MT6795, MT8173, MT8192, MT8195.
> 

Applied the whole series to clk-next.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-03-13 23:23 UTC|newest]

Thread overview: 120+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 14:04 [PATCH v6 00/54] MediaTek clocks: full module build and cleanups AngeloGioacchino Del Regno
2023-03-06 14:04 ` AngeloGioacchino Del Regno
2023-03-06 14:04 ` [PATCH v6 01/54] clk: mediatek: clk-mtk: Switch to device_get_match_data() AngeloGioacchino Del Regno
2023-03-06 14:04   ` AngeloGioacchino Del Regno
2023-03-06 14:04 ` [PATCH v6 02/54] clk: mediatek: clk-mtk: Introduce clk_mtk_pdev_{probe,remove}() AngeloGioacchino Del Regno
2023-03-06 14:04   ` AngeloGioacchino Del Regno
2023-03-06 14:04 ` [PATCH v6 03/54] clk: mediatek: Migrate to mtk_clk_pdev_probe() for multimedia clocks AngeloGioacchino Del Regno
2023-03-06 14:04   ` AngeloGioacchino Del Regno
2023-03-06 14:04 ` [PATCH v6 04/54] clk: mediatek: Add divider clocks to mtk_clk_simple_{probe,remove}() AngeloGioacchino Del Regno
2023-03-06 14:04   ` AngeloGioacchino Del Regno
2023-03-06 14:04 ` [PATCH v6 05/54] clk: mediatek: mt2712: Migrate topckgen/mcucfg to mtk_clk_simple_probe() AngeloGioacchino Del Regno
2023-03-06 14:04   ` AngeloGioacchino Del Regno
2023-03-06 14:04 ` [PATCH v6 06/54] clk: mediatek: mt2712: Compress clock arrays entries to 90 columns AngeloGioacchino Del Regno
2023-03-06 14:04   ` AngeloGioacchino Del Regno
2023-03-06 14:04 ` [PATCH v6 07/54] clk: mediatek: mt2712: Add error handling to clk_mt2712_apmixed_probe() AngeloGioacchino Del Regno
2023-03-06 14:04   ` AngeloGioacchino Del Regno
2023-03-06 14:04 ` [PATCH v6 08/54] clk: mediatek: mt2712: Move apmixedsys clock driver to its own file AngeloGioacchino Del Regno
2023-03-06 14:04   ` AngeloGioacchino Del Regno
2023-03-06 14:04 ` [PATCH v6 09/54] clk: mediatek: mt2712-apmixedsys: Add .remove() callback for module build AngeloGioacchino Del Regno
2023-03-06 14:04   ` AngeloGioacchino Del Regno
2023-03-06 14:04 ` [PATCH v6 10/54] clk: mediatek: mt2712: Change to use module_platform_driver macro AngeloGioacchino Del Regno
2023-03-06 14:04   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 11/54] clk: mediatek: mt8365: Move apmixedsys clock driver to its own file AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 12/54] clk: mediatek: mt8365: Convert simple_gate to mtk_gate clocks AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 13/54] clk: mediatek: mt8365: Join top_misc_mux_gates and top_misc_muxes arrays AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 14/54] clk: mediatek: mt8365: Convert to mtk_clk_simple_{probe,remove}() AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 15/54] clk: mediatek: mt8167: Compress GATE_TOPx macros AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 16/54] clk: mediatek: mt8167: Move apmixedsys as platform_driver in new file AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 17/54] clk: mediatek: mt8167: Remove __initconst annotation from arrays AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 18/54] clk: mediatek: mt8167: Convert to mtk_clk_simple_{probe,remove}() AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 19/54] clk: mediatek: mt8183: Move apmixedsys clock driver to its own file AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 20/54] clk: mediatek: mt8183: Compress clocks arrays entries where possible AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 21/54] clk: mediatek: mt8183: Convert all remaining clocks to common probe AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 22/54] clk: mediatek: Consistently use GATE_MTK() macro AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 23/54] clk: mediatek: mt7622: Properly use CLK_IS_CRITICAL flag AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 24/54] clk: mediatek: mt7622: Move apmixedsys clock driver to its own file AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 25/54] clk: mediatek: mt7622-apmixedsys: Add .remove() callback for module build AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 26/54] clk: mediatek: mt7622: Move infracfg to clk-mt7622-infracfg.c AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 27/54] clk: mediatek: mt7622: Convert to platform driver and simple probe AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 28/54] clk: mediatek: mt8516: Move apmixedsys clock driver to its own file AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 29/54] clk: mediatek: mt8516: Convert to platform driver and simple probe AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 30/54] clk: mediatek: mt8516: Allow building clock drivers as modules AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 31/54] clk: mediatek: Propagate struct device with mtk_clk_register_dividers() AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 32/54] clk: mediatek: mt7986-apmixed: Use PLL_AO flag to set critical clock AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 33/54] clk: mediatek: mt7986-infracfg: Migrate to common probe mechanism AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 34/54] clk: mediatek: mt7986-eth: " AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 35/54] clk: mediatek: mt8186-mcu: " AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 36/54] clk: mediatek: Switch to module_platform_driver() where possible AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 37/54] clk: mediatek: Add MODULE_LICENSE() where missing AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 38/54] clk: mediatek: mt2712: Change Kconfig options to allow module build AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 39/54] clk: mediatek: Split MT8195 clock drivers and " AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 40/54] clk: mediatek: Allow building MT8192 non-critical clocks as modules AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 41/54] clk: mediatek: Allow MT7622 clocks to be built " AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 42/54] clk: mediatek: Allow all MT8167 " AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 43/54] clk: mediatek: Allow all MT8183 " AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 44/54] clk: mediatek: Allow building most MT6765 clock drivers " AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 45/54] clk: mediatek: Allow building most MT6797 " AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 46/54] clk: mediatek: Split configuration options for MT8186 clock drivers AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 47/54] clk: mediatek: mt8192: Move apmixedsys clock driver to its own file AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 22:04   ` Daniel Golle
2023-03-06 22:04     ` Daniel Golle
2023-03-07  9:24     ` AngeloGioacchino Del Regno
2023-03-07  9:24       ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 48/54] clk: mediatek: Kconfig: Allow module build for core mt8192 clocks AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 49/54] clk: mediatek: Add MODULE_DEVICE_TABLE() where appropriate AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 50/54] clk: mediatek: mt8135: Move apmixedsys to its own file AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 51/54] clk: mediatek: mt8135: Properly use CLK_IS_CRITICAL flag AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 52/54] clk: mediatek: mt8135-apmixedsys: Convert to platform_driver and module AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 53/54] clk: mediatek: mt8135: Join root_clk_alias and top_divs arrays AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 14:05 ` [PATCH v6 54/54] clk: mediatek: mt8135: Convert to simple probe and enable module build AngeloGioacchino Del Regno
2023-03-06 14:05   ` AngeloGioacchino Del Regno
2023-03-06 20:35 ` [PATCH v6 00/54] MediaTek clocks: full module build and cleanups Stephen Boyd
2023-03-06 20:35   ` Stephen Boyd
2023-03-13 23:22 ` Stephen Boyd [this message]
2023-03-13 23:22   ` Stephen Boyd
2023-03-14  6:48   ` Chen-Yu Tsai
2023-03-14  6:48     ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c52bcda08b62593c541d52e269d3982.sboyd@kernel.org \
    --to=sboyd@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chen.zhong@mediatek.com \
    --cc=chun-jie.chen@mediatek.com \
    --cc=daniel@makrotopia.org \
    --cc=edward-jw.yang@mediatek.com \
    --cc=fparent@baylibre.com \
    --cc=granquet@baylibre.com \
    --cc=johnson.wang@mediatek.com \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=miles.chen@mediatek.com \
    --cc=msp@baylibre.com \
    --cc=mturquette@baylibre.com \
    --cc=nfraprado@collabora.com \
    --cc=pablo.sun@mediatek.com \
    --cc=rex-bc.chen@mediatek.com \
    --cc=sam.shih@mediatek.com \
    --cc=sean.wang@mediatek.com \
    --cc=wenst@chromium.org \
    --cc=yangyingliang@huawei.com \
    --cc=zhaojh329@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.