All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shashank Sharma <shashank.sharma@amd.com>
To: Arvind Yadav <Arvind.Yadav@amd.com>,
	Christian.Koenig@amd.com, alexander.deucher@amd.com,
	Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
	Felix.Kuehling@amd.com, amd-gfx@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 6/7] drm/amdgpu: switch workload context to/from compute
Date: Mon, 21 Aug 2023 15:47:35 +0200	[thread overview]
Message-ID: <6c7bb6f9-ccf4-a763-044f-b795877246aa@amd.com> (raw)
In-Reply-To: <20230821064759.94223-7-Arvind.Yadav@amd.com>


On 21/08/2023 08:47, Arvind Yadav wrote:
> This patch switches the GPU workload mode to/from
> compute mode, while submitting compute workload.
>
> Cc: Christian Koenig <christian.koenig@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Shashank Sharma <shashank.sharma@amd.com>
> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> index 0385f7f69278..1d6a41f8d24e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> @@ -713,9 +713,11 @@ void amdgpu_amdkfd_set_compute_idle(struct amdgpu_device *adev, bool idle)
>   		pr_debug("GFXOFF is %s\n", idle ? "enabled" : "disabled");
>   		amdgpu_gfx_off_ctrl(adev, idle);
>   	}
> -	amdgpu_dpm_switch_power_profile(adev,
> -					PP_SMC_POWER_PROFILE_COMPUTE,
> -					!idle);
> +
> +	if (idle)
> +		amdgpu_workload_profile_put(adev, AMDGPU_RING_TYPE_COMPUTE);
> +	else
> +		amdgpu_workload_profile_set(adev, AMDGPU_RING_TYPE_COMPUTE);
>   }
Please feel free to use:

Reviewed-by: Shashank Sharma <shashank.sharma@amd.com>

- Shashank

>   
>   bool amdgpu_amdkfd_is_kfd_vmid(struct amdgpu_device *adev, u32 vmid)

WARNING: multiple messages have this Message-ID (diff)
From: Shashank Sharma <shashank.sharma@amd.com>
To: Arvind Yadav <Arvind.Yadav@amd.com>,
	Christian.Koenig@amd.com, alexander.deucher@amd.com,
	Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
	Felix.Kuehling@amd.com, amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/7] drm/amdgpu: switch workload context to/from compute
Date: Mon, 21 Aug 2023 15:47:35 +0200	[thread overview]
Message-ID: <6c7bb6f9-ccf4-a763-044f-b795877246aa@amd.com> (raw)
In-Reply-To: <20230821064759.94223-7-Arvind.Yadav@amd.com>


On 21/08/2023 08:47, Arvind Yadav wrote:
> This patch switches the GPU workload mode to/from
> compute mode, while submitting compute workload.
>
> Cc: Christian Koenig <christian.koenig@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Shashank Sharma <shashank.sharma@amd.com>
> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> index 0385f7f69278..1d6a41f8d24e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> @@ -713,9 +713,11 @@ void amdgpu_amdkfd_set_compute_idle(struct amdgpu_device *adev, bool idle)
>   		pr_debug("GFXOFF is %s\n", idle ? "enabled" : "disabled");
>   		amdgpu_gfx_off_ctrl(adev, idle);
>   	}
> -	amdgpu_dpm_switch_power_profile(adev,
> -					PP_SMC_POWER_PROFILE_COMPUTE,
> -					!idle);
> +
> +	if (idle)
> +		amdgpu_workload_profile_put(adev, AMDGPU_RING_TYPE_COMPUTE);
> +	else
> +		amdgpu_workload_profile_set(adev, AMDGPU_RING_TYPE_COMPUTE);
>   }
Please feel free to use:

Reviewed-by: Shashank Sharma <shashank.sharma@amd.com>

- Shashank

>   
>   bool amdgpu_amdkfd_is_kfd_vmid(struct amdgpu_device *adev, u32 vmid)

  reply	other threads:[~2023-08-21 13:47 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-21  6:47 [PATCH v2 0/7] GPU workload hints for better performance Arvind Yadav
2023-08-21  6:47 ` Arvind Yadav
2023-08-21  6:47 ` [PATCH v2 1/7] drm/amdgpu: Added init/fini functions for workload Arvind Yadav
2023-08-21  6:47   ` Arvind Yadav
2023-08-21 13:06   ` Shashank Sharma
2023-08-21 13:06     ` Shashank Sharma
2023-08-21 13:35     ` Yadav, Arvind
2023-08-21 13:35       ` Yadav, Arvind
2023-08-21 13:54       ` Shashank Sharma
2023-08-21 13:54         ` Shashank Sharma
2023-08-21 14:12         ` Yadav, Arvind
2023-08-21 14:12           ` Yadav, Arvind
2023-08-21 14:27           ` Shashank Sharma
2023-08-21 14:27             ` Shashank Sharma
2023-08-21  6:47 ` [PATCH v2 2/7] drm/amdgpu: Add new function to set GPU power profile Arvind Yadav
2023-08-21  6:47   ` Arvind Yadav
2023-08-21 13:10   ` Shashank Sharma
2023-08-21 13:10     ` Shashank Sharma
2023-08-21 16:22   ` Alex Deucher
2023-08-21 16:22     ` Alex Deucher
2023-08-21 16:22     ` Alex Deucher
2023-08-21 17:53     ` Yadav, Arvind
2023-08-21 17:53       ` Yadav, Arvind
2023-08-21 17:53       ` Yadav, Arvind
2023-08-21 18:10       ` Alex Deucher
2023-08-21 18:10         ` Alex Deucher
2023-08-21 18:10         ` Alex Deucher
2023-08-22  6:13         ` Yadav, Arvind
2023-08-22  6:13           ` Yadav, Arvind
2023-08-22  6:13           ` Yadav, Arvind
2023-08-21 18:06   ` Alex Deucher
2023-08-21 18:06     ` Alex Deucher
2023-08-21 18:06     ` Alex Deucher
2023-08-21 18:08     ` Yadav, Arvind
2023-08-21 18:08       ` Yadav, Arvind
2023-08-21 18:08       ` Yadav, Arvind
2023-08-22  6:25   ` Lazar, Lijo
2023-08-22 12:40     ` Yadav, Arvind
2023-08-21  6:47 ` [PATCH v2 3/7] drm/amdgpu: Add new function to put " Arvind Yadav
2023-08-21  6:47   ` Arvind Yadav
2023-08-21 13:39   ` Shashank Sharma
2023-08-21 13:39     ` Shashank Sharma
2023-08-21 14:40     ` Yadav, Arvind
2023-08-21 14:40       ` Yadav, Arvind
2023-08-22  4:51   ` Lazar, Lijo
2023-08-22 12:11     ` Yadav, Arvind
2023-08-22 12:46       ` Lazar, Lijo
2023-08-25 11:18         ` Yadav, Arvind
2023-08-25 11:27           ` Lazar, Lijo
2023-08-21  6:47 ` [PATCH v2 4/7] drm/amdgpu: Add suspend function to clear the " Arvind Yadav
2023-08-21  6:47   ` Arvind Yadav
2023-08-21 13:43   ` Shashank Sharma
2023-08-21 13:43     ` Shashank Sharma
2023-08-21 13:52     ` Yadav, Arvind
2023-08-21 13:52       ` Yadav, Arvind
2023-08-22  6:31   ` Lazar, Lijo
2023-08-22 12:22     ` Yadav, Arvind
2023-08-22 12:54       ` Lazar, Lijo
2023-08-22 12:56         ` Yadav, Arvind
2023-08-21  6:47 ` [PATCH v2 5/7] drm/amdgpu: Switch on/off GPU workload profile Arvind Yadav
2023-08-21  6:47   ` Arvind Yadav
2023-08-21 13:46   ` Shashank Sharma
2023-08-21 13:46     ` Shashank Sharma
2023-08-21 13:53     ` Yadav, Arvind
2023-08-21 13:53       ` Yadav, Arvind
2023-08-21  6:47 ` [PATCH v2 6/7] drm/amdgpu: switch workload context to/from compute Arvind Yadav
2023-08-21  6:47   ` Arvind Yadav
2023-08-21 13:47   ` Shashank Sharma [this message]
2023-08-21 13:47     ` Shashank Sharma
2023-08-21  6:47 ` [PATCH v2 7/7] Revert "drm/amd/amdgpu: switch on/off vcn power profile mode" Arvind Yadav
2023-08-21  6:47   ` Arvind Yadav
2023-08-21 13:49   ` Shashank Sharma
2023-08-21 13:49     ` Shashank Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c7bb6f9-ccf4-a763-044f-b795877246aa@amd.com \
    --to=shashank.sharma@amd.com \
    --cc=Arvind.Yadav@amd.com \
    --cc=Christian.Koenig@amd.com \
    --cc=Felix.Kuehling@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.